Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2225311/?format=api
{ "id": 2225311, "url": "http://patchwork.ozlabs.org/api/patches/2225311/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-11-vsementsov@yandex-team.ru/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260420200339.708640-11-vsementsov@yandex-team.ru>", "list_archive_url": null, "date": "2026-04-20T20:03:25", "name": "[v6,10/22] vhost: vhost_virtqueue_start(): fix failure path", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d1eb065284d6a359027d5010afc0d24ab3507ae5", "submitter": { "id": 84116, "url": "http://patchwork.ozlabs.org/api/people/84116/?format=api", "name": "Vladimir Sementsov-Ogievskiy", "email": "vsementsov@yandex-team.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-11-vsementsov@yandex-team.ru/mbox/", "series": [ { "id": 500672, "url": "http://patchwork.ozlabs.org/api/series/500672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672", "date": "2026-04-20T20:03:18", "name": "vhost refactoring and fixes", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/500672/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225311/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225311/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=RgFUKMAw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxMm71rlz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 06:06:44 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEur2-0001lu-Ke; Mon, 20 Apr 2026 16:04:24 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqo-0001Mi-0I\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:11 -0400", "from forwardcorp1d.mail.yandex.net\n ([2a02:6b8:c41:1300:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqj-0001oZ-VD\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:08 -0400", "from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 3E5CE80795;\n Mon, 20 Apr 2026 23:04:04 +0300 (MSK)", "from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-IJFHQbSb; Mon, 20 Apr 2026 23:04:03 +0300" ], "Precedence": "bulk", "X-Yandex-Fwd": "1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715443;\n bh=34scPHp2ZdybOm2yZ0WL9aJaMm2nao2xuPbVsUANPc0=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=RgFUKMAwfAaoFaTDJl/pPEutgmAh4vjAg26XhDyCrc3eT+sX8p4hQfMEUaiRH+/6H\n 3L/oFWlAxcBB35saNHuI8+EsAMm1LZJ+490lT4cyE5wKaYpCf28AAL1OIoqOJhG90k\n 7SSXuo1Q0aan3PNX1rYdSnyrrjX0ppMA0luaJ7kE=", "From": "Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>", "To": "mst@redhat.com", "Cc": "sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz <raphael.s.norwitz@gmail.com>", "Subject": "[PATCH v6 10/22] vhost: vhost_virtqueue_start(): fix failure path", "Date": "Mon, 20 Apr 2026 23:03:25 +0300", "Message-ID": "<20260420200339.708640-11-vsementsov@yandex-team.ru>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260420200339.708640-1-vsementsov@yandex-team.ru>", "References": "<20260420200339.708640-1-vsementsov@yandex-team.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "We miss call to unmap in cases when vhost_memory_map() returns\nlenght less than requested (still we consider such cases as an\nerror). Let's fix it in vhost_memory_map().\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Raphael Norwitz <raphael.s.norwitz@gmail.com>\n---\n hw/virtio/vhost.c | 27 ++++++++++++++++++---------\n 1 file changed, 18 insertions(+), 9 deletions(-)", "diff": "diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex e39e0676e00..131a2fbf870 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -454,11 +454,20 @@ static inline void vhost_dev_log_resize(struct vhost_dev *dev, uint64_t size)\n }\n \n static void *vhost_memory_map(struct vhost_dev *dev, hwaddr addr,\n- hwaddr *plen, bool is_write)\n+ hwaddr len, bool is_write)\n {\n if (!vhost_dev_has_iommu(dev)) {\n- return address_space_map(dev->vdev->dma_as, addr, plen, is_write,\n- MEMTXATTRS_UNSPECIFIED);\n+ hwaddr mapped_len = len;\n+ void *res = address_space_map(dev->vdev->dma_as, addr, &mapped_len,\n+ is_write, MEMTXATTRS_UNSPECIFIED);\n+ if (!res) {\n+ return NULL;\n+ }\n+ if (len != mapped_len) {\n+ address_space_unmap(dev->vdev->dma_as, res, mapped_len, 0, 0);\n+ return NULL;\n+ }\n+ return res;\n } else {\n return (void *)(uintptr_t)addr;\n }\n@@ -1312,22 +1321,22 @@ int vhost_virtqueue_start(struct vhost_dev *dev,\n }\n \n l = vq->desc_size;\n- vq->desc = vhost_memory_map(dev, vq->desc_phys, &l, false);\n- if (!vq->desc || l != vq->desc_size) {\n+ vq->desc = vhost_memory_map(dev, vq->desc_phys, l, false);\n+ if (!vq->desc) {\n r = -ENOMEM;\n goto fail_alloc_desc;\n }\n \n l = vq->avail_size;\n- vq->avail = vhost_memory_map(dev, vq->avail_phys, &l, false);\n- if (!vq->avail || l != vq->avail_size) {\n+ vq->avail = vhost_memory_map(dev, vq->avail_phys, l, false);\n+ if (!vq->avail) {\n r = -ENOMEM;\n goto fail_alloc_avail;\n }\n \n l = vq->used_size;\n- vq->used = vhost_memory_map(dev, vq->used_phys, &l, true);\n- if (!vq->used || l != vq->used_size) {\n+ vq->used = vhost_memory_map(dev, vq->used_phys, l, true);\n+ if (!vq->used) {\n r = -ENOMEM;\n goto fail_alloc_used;\n }\n", "prefixes": [ "v6", "10/22" ] }