Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224942/?format=api
{ "id": 2224942, "url": "http://patchwork.ozlabs.org/api/patches/2224942/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/patch/20260419222355.5842-1-rand.sec96@gmail.com/", "project": { "id": 13, "url": "http://patchwork.ozlabs.org/api/projects/13/?format=api", "name": "Linux IDE development", "link_name": "linux-ide", "list_id": "linux-ide.vger.kernel.org", "list_email": "linux-ide@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260419222355.5842-1-rand.sec96@gmail.com>", "list_archive_url": null, "date": "2026-04-19T22:23:55", "name": "[5.10.y] ata: pata_sil680: fix result type of sil680_sel{dev|reg}()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "436ac8f9b4127b241e6929272e9b7be7babe3b11", "submitter": { "id": 87813, "url": "http://patchwork.ozlabs.org/api/people/87813/?format=api", "name": "Rand Deeb", "email": "rand.sec96@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ide/patch/20260419222355.5842-1-rand.sec96@gmail.com/mbox/", "series": [ { "id": 500530, "url": "http://patchwork.ozlabs.org/api/series/500530/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/list/?series=500530", "date": "2026-04-19T22:23:55", "name": "[5.10.y] ata: pata_sil680: fix result type of sil680_sel{dev|reg}()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500530/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224942/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224942/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-ide+bounces-5493-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ide@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ekiMwlWS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5493-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"ekiMwlWS\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.208.180", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzNTf0sWyz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 08:24:54 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 93FA33017C0C\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 22:24:47 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A786430F543;\n\tSun, 19 Apr 2026 22:24:46 +0000 (UTC)", "from mail-lj1-f180.google.com (mail-lj1-f180.google.com\n [209.85.208.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 36384AD24\n\tfor <linux-ide@vger.kernel.org>; Sun, 19 Apr 2026 22:24:44 +0000 (UTC)", "by mail-lj1-f180.google.com with SMTP id\n 38308e7fff4ca-38dd9f0fdc6so36405061fa.0\n for <linux-ide@vger.kernel.org>; Sun, 19 Apr 2026 15:24:43 -0700 (PDT)", "from localhost.localdomain ([85.143.146.122])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-5a4185ad0fdsm2554297e87.13.2026.04.19.15.24.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Apr 2026 15:24:41 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776637486; cv=none;\n b=XmJqzZmIg9Jku8VzoHj4cCGcpY8OsOjSlzF0DCxKpmYaRO7/FBv6kYSX1fCAxN9v7TiLG1KCxQvCFO9/lYDxb35lhU7jorxfD0OKM6BBvHIWMa4/82dCjDm8urGk9wFuq6JTdhJJ9edT3dUiJ362jnaoaYt3xQPkJ9uBCUXCl90=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776637486; c=relaxed/simple;\n\tbh=HokyC2nDUbRTJYDs3PhWlBf/ZTkZR5B5P0FWV4QeBLg=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=A6eI7l0rLi8nEkddNOQOEadytfeidZuX2nM8udO/ho4pVAXRI3nSfPHA5GJLyBK3ByXw2nSYMYVPrLfg0Bn4dKBQ4azSPnOgVJT9C/7Jw0xlc0IUqraaGLgI3aVVLoFr4zFnw7Op67bHEouK0Jq2ZZGdA925SbrmQspgAEMAsz8=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=ekiMwlWS; arc=none smtp.client-ip=209.85.208.180", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776637482; x=1777242282;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=HpNJcvd4vFonahhQxxRKSX+/5Qv/TqiQwoW9F6azc/c=;\n b=ekiMwlWSHWkdNYZO2uvYuT7Ef7GXktYnaT4gnlpbBPKXQPBbz2CMLsq4QTBO6JM7MM\n 9PR+jjofyRZqmScMVuTPy9ViueG/4LyG91jd6pjRmrNNZYQy05BLNXKe9+lfRMTe7+CK\n W2occPBGCeoumuRDhxV2JOo8+LSY58rWuK8T6IrvnSJyFwlp74C/yNDPzOsyv9kGFc5R\n lUmIOt4iAd3E4UZfu2rM2sPUXUUN+ENYjl0la8+WdafHlvqNVaSOuLEDMpawe4Z7+3+E\n EYPV4MqFVoS0XWwlPOaHiSyJXi6MlZJCrMKSDtUlrILnZ4kEL0EeazoDwl0sE43mnJ8B\n dXCg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776637482; x=1777242282;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=HpNJcvd4vFonahhQxxRKSX+/5Qv/TqiQwoW9F6azc/c=;\n b=qpItPiQCcgKu7MzAv/0RxaoNetnMPOKvW/g+zQJMzOiIohjUJrfTMxmi3jPtNgMviJ\n bfq74qItzWCfU+SolbazX4OXEcNQAKlGyiPllCV2jJaBWrMMBLoVEd05ScTpAAJ9nveF\n 7W21PFUc2e7EI+KTe8hz8//ioZ1BgI2MumCHELsV9rCrlSH8f7P2krMztsBn57KB5uOY\n V9pvs2tL8nIr49Kx14qwNTMIZRPWnkY3bgSELBdgcyip15g5zTg97uyGwf63JYrsEQoU\n +7QHwyZNdwuK7u/f/FgY7glDOVBJYFtckcvkOCpfi15lTtLzZW/SCBVmZxYOxPybc+fD\n kaDg==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+yorrz+GCxJdXju0uZ0pFFq3ijp/0mi5Na5uaJURQLhF0W855Pm57YCdsj3SiM2iChmBlAR0pCSgU=@vger.kernel.org", "X-Gm-Message-State": "AOJu0YzhPyNS1B5CGkqDGGGBqbrVPISB91XZuTqstWZSxmvmLm5Xe8+C\n\tzTN/tHFoQrptvrxiCGYyE4tfSWwbOtFi5eHKzSDHBoM93rc5TgyfvJ7MF7EOead/lCHiYA==", "X-Gm-Gg": "AeBDietbBVyDt+gklfI6+yX9y4jpKVc9Jx0KGiW5B2NOaYDX3hP5Db8uwmqIeFGUtC8\n\tDYa9VP8HLvNNVdxbEWk8XmUkIoL5wf4LpbbeJ/obpFYYskt6n1Rmow01hEGPHeosVgOpVSl4VSk\n\tg+ZL8oVZwP4xBnOamNmOhP7HJfv3kC79z1WaRseHNb0Rm7vqKji48A0nwr9aB9k3kVcSrUzUbPP\n\tfobrj9vyb8IO4z65+55qfASLCCgwR4HEFiITAFd6u+t1Rb+1FzqF3anXm7lCRO/DQ5S2UT90Sx4\n\trvctb+dkoRQYFpiwHq3G9O/T7kDSYbQ61an7Xs+ZAZoWOUJe2avrzy9g9k58KoxAVaCg15bDezH\n\tqJwD4/SDXVkqKz3MnwWHmeFBrT5SajqWIQWDEBHL3RehHOzvnnUtnLlLgyihd6pm+oeCQ55ZkhO\n\tHiGaAAbkVeSsdoGTf6Jq5ye5K/N0MBokjdJM7aRP6qbu543egSLMc9pLvFMT7ouA==", "X-Received": "by 2002:a05:6512:3502:b0:5a1:3d08:cfab with SMTP id\n 2adb3069b0e04-5a4172a9d81mr3298109e87.23.1776637481976;\n Sun, 19 Apr 2026 15:24:41 -0700 (PDT)", "From": "Rand Deeb <rand.sec96@gmail.com>", "To": "stable@vger.kernel.org", "Cc": "axboe@kernel.dk,\n\tlinux-ide@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tdeeb.rand@confident.ru,\n\tlvc-project@linuxtesting.org,\n\tkhoroshilov@ispras.ru,\n\tSergey Shtylyov <s.shtylyov@omp.ru>,\n\tDamien Le Moal <damien.lemoal@opensource.wdc.com>,\n\tRand Deeb <rand.sec96@gmail.com>", "Subject": "[PATCH 5.10.y] ata: pata_sil680: fix result type of\n sil680_sel{dev|reg}()", "Date": "Mon, 20 Apr 2026 01:23:55 +0300", "Message-ID": "<20260419222355.5842-1-rand.sec96@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "linux-ide@vger.kernel.org", "List-Id": "<linux-ide.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Sergey Shtylyov <s.shtylyov@omp.ru>\n\n[ Upstream commit dafbbf5c57dd6ae01d20b894bc2200e9d9834c4e ]\n\nsil680_sel{dev|reg}() return a PCI config space address but needlessly\nuse the *unsigned long* type for that, whereas the PCI config space\naccessors take *int* for the address parameter. Switch these functions\nto returning *int*, updating the local variables at their call sites.\nGet rid of the 'base' local variables in these functions, while at it...\n\nFound by Linux Verification Center (linuxtesting.org) with the SVACE static\nanalysis tool.\n\nSigned-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>\nSigned-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>\nSigned-off-by: Rand Deeb <rand.sec96@gmail.com>\n---\n drivers/ata/pata_sil680.c | 30 +++++++++++++-----------------\n 1 file changed, 13 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c\nindex 7ab9aea3b..fe60f884b 100644\n--- a/drivers/ata/pata_sil680.c\n+++ b/drivers/ata/pata_sil680.c\n@@ -47,11 +47,9 @@\n *\tcriticial.\n */\n \n-static unsigned long sil680_selreg(struct ata_port *ap, int r)\n+static int sil680_selreg(struct ata_port *ap, int r)\n {\n-\tunsigned long base = 0xA0 + r;\n-\tbase += (ap->port_no << 4);\n-\treturn base;\n+\treturn 0xA0 + (ap->port_no << 4) + r;\n }\n \n /**\n@@ -64,12 +62,9 @@ static unsigned long sil680_selreg(struct ata_port *ap, int r)\n *\tthe unit shift.\n */\n \n-static unsigned long sil680_seldev(struct ata_port *ap, struct ata_device *adev, int r)\n+static int sil680_seldev(struct ata_port *ap, struct ata_device *adev, int r)\n {\n-\tunsigned long base = 0xA0 + r;\n-\tbase += (ap->port_no << 4);\n-\tbase |= adev->devno ? 2 : 0;\n-\treturn base;\n+\treturn 0xA0 + (ap->port_no << 4) + r + (adev->devno << 1);\n }\n \n \n@@ -84,8 +79,9 @@ static unsigned long sil680_seldev(struct ata_port *ap, struct ata_device *adev,\n static int sil680_cable_detect(struct ata_port *ap)\n {\n \tstruct pci_dev *pdev = to_pci_dev(ap->host->dev);\n-\tunsigned long addr = sil680_selreg(ap, 0);\n+\tint addr = sil680_selreg(ap, 0);\n \tu8 ata66;\n+\n \tpci_read_config_byte(pdev, addr, &ata66);\n \tif (ata66 & 1)\n \t\treturn ATA_CBL_PATA80;\n@@ -112,9 +108,9 @@ static void sil680_set_piomode(struct ata_port *ap, struct ata_device *adev)\n \t\t0x328A, 0x2283, 0x1281, 0x10C3, 0x10C1\n \t};\n \n-\tunsigned long tfaddr = sil680_selreg(ap, 0x02);\n-\tunsigned long addr = sil680_seldev(ap, adev, 0x04);\n-\tunsigned long addr_mask = 0x80 + 4 * ap->port_no;\n+\tint tfaddr = sil680_selreg(ap, 0x02);\n+\tint addr = sil680_seldev(ap, adev, 0x04);\n+\tint addr_mask = 0x80 + 4 * ap->port_no;\n \tstruct pci_dev *pdev = to_pci_dev(ap->host->dev);\n \tint pio = adev->pio_mode - XFER_PIO_0;\n \tint lowest_pio = pio;\n@@ -164,9 +160,9 @@ static void sil680_set_dmamode(struct ata_port *ap, struct ata_device *adev)\n \tstatic const u16 dma_table[3] = { 0x2208, 0x10C2, 0x10C1 };\n \n \tstruct pci_dev *pdev = to_pci_dev(ap->host->dev);\n-\tunsigned long ma = sil680_seldev(ap, adev, 0x08);\n-\tunsigned long ua = sil680_seldev(ap, adev, 0x0C);\n-\tunsigned long addr_mask = 0x80 + 4 * ap->port_no;\n+\tint ma = sil680_seldev(ap, adev, 0x08);\n+\tint ua = sil680_seldev(ap, adev, 0x0C);\n+\tint addr_mask = 0x80 + 4 * ap->port_no;\n \tint port_shift = adev->devno * 4;\n \tu8 scsc, mode;\n \tu16 multi, ultra;\n@@ -219,7 +215,7 @@ static void sil680_sff_exec_command(struct ata_port *ap,\n static bool sil680_sff_irq_check(struct ata_port *ap)\n {\n \tstruct pci_dev *pdev\t= to_pci_dev(ap->host->dev);\n-\tunsigned long addr\t= sil680_selreg(ap, 1);\n+\tint addr\t\t= sil680_selreg(ap, 1);\n \tu8 val;\n \n \tpci_read_config_byte(pdev, addr, &val);\n", "prefixes": [ "5.10.y" ] }