Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224840/?format=api
{ "id": 2224840, "url": "http://patchwork.ozlabs.org/api/patches/2224840/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260418223320.51330-35-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260418223320.51330-35-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-04-18T22:33:16", "name": "[34/38] whpx: i386: don't increment eip on MSR access raising GPF", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c8e69434524cdbc152af214110d29b02b636f55d", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260418223320.51330-35-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 500475, "url": "http://patchwork.ozlabs.org/api/series/500475/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500475", "date": "2026-04-18T22:32:54", "name": "WHPX x86 updates for QEMU 11.1", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500475/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224840/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224840/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=HWWz826P;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fympF1JCVz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 08:37:09 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEEFG-0007Zo-Id; Sat, 18 Apr 2026 18:34:34 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEEFC-00077j-IN\n for qemu-devel@nongnu.org; Sat, 18 Apr 2026 18:34:30 -0400", "from p-east2-cluster1-host4-snip4-10.eps.apple.com ([57.103.76.23]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEEFA-0005Df-Vz\n for qemu-devel@nongnu.org; Sat, 18 Apr 2026 18:34:30 -0400", "from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n 8BCB418000E2; Sat, 18 Apr 2026 22:34:27 +0000 (UTC)", "from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n 89DF71800219; Sat, 18 Apr 2026 22:34:25 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776551668; x=1779143668;\n bh=kGhBK4LCPtYSYe6aojWD51bIwGxqBS+1pxUsdaVHLfk=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=HWWz826Phui9dviZ5wpRDaIsKTOPsi6eLmN/PAta3epWjFjdLUtUGx35YdAgYTIpuTDW+PE6WCWZauRsNVjGO3J1qBbFy50fDLF5//DjUu9vDXixFFg6o4AiVN997BO+nDTIOEcyOt8AuTpm02WgRbXulGPnDtwW3wNXrtasyvqv4MbLt3GeVVbU7IiJBRxeJ315cCa9hGvAhB6nUerm1U6EgWxXGdj4GxFLgQRCm2fc6CR7KZO042RA3OCGWJoziiRYzJsM6jMvlJ1uZiNCWEHm3FTjFr/DJ6LRsXOsby6wtlcSzXFAVaZQoGDgpFmXXRBtEWLuj68PmjzIc0zRmA==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Mohamed Mediouni <mohamed@unpredictable.fr>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>, Pedro Barbuda <pbarbuda@microsoft.com>,\n Roman Bolshakov <rbolshakov@ddn.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>", "Subject": "[PATCH 34/38] whpx: i386: don't increment eip on MSR access raising\n GPF", "Date": "Sun, 19 Apr 2026 00:33:16 +0200", "Message-ID": "<20260418223320.51330-35-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260418223320.51330-1-mohamed@unpredictable.fr>", "References": "<20260418223320.51330-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Info-Out": "v=2.4 cv=OoNCCi/t c=1 sm=1 tr=0 ts=69e406f4\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=N0YEvnU7VqbRQIRMxcMA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19", "X-Proofpoint-GUID": "GDJvuNSI7pJlzRThvRB8l-5JT5pKqFIe", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDE4MDIyOSBTYWx0ZWRfXxDg/Xy1RFHX0\n UIqif8DSy91Y8yqNykv0f5nAx3ixDpoUB24ozRp80wAge5tht174LiA0MS2POVLuy0CXr2VIF6R\n XGMmq4K/7YkbouBr1dw2hJO0Otbt27UAmln1DAPq9yeKu+8Cq4OvlO6kOFXwtebfNXlfy6U0jNt\n Ifx8JH9/LrKRXZFxJUuKpzkX/4HRxEbrAaEkR1IjSjPG32LEBfiRqAVpAgvOmVX9lGrdUBZ+T/A\n IvlYsDdIq24slYS5xSfwrq07Ayo30y6ZP6CUyTj9CH2gqwoUDc/TI+Rg3O0CLCMFV5w3anlu6GO\n I1llOrI+ykTb36tydkwZShmCxPaE08yme8d4qW9IUNOTfgfF2qX3orX1Lws+bE=", "X-Proofpoint-ORIG-GUID": "GDJvuNSI7pJlzRThvRB8l-5JT5pKqFIe", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-18_06,2026-04-17_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 bulkscore=0\n suspectscore=0 clxscore=1030 phishscore=0 mlxscore=0 lowpriorityscore=0\n spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=757 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604180229", "Received-SPF": "pass client-ip=57.103.76.23;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n target/i386/whpx/whpx-all.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 98b13676ba..de254e236b 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -2178,6 +2178,7 @@ int whpx_vcpu_run(CPUState *cpu)\n WHV_REGISTER_NAME reg_names[3];\n UINT32 reg_count;\n bool is_known_msr = 0; \n+ bool raises_gpf = false;\n uint64_t val;\n \n if (vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite) {\n@@ -2210,6 +2211,7 @@ int whpx_vcpu_run(CPUState *cpu)\n is_known_msr = 1;\n if (val & MSR_IA32_APICBASE_RESERVED) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n }\n if (!vcpu->exit_ctx.MsrAccess.AccessInfo.IsWrite) {\n /* Read path unreachable on Hyper-V */\n@@ -2219,6 +2221,7 @@ int whpx_vcpu_run(CPUState *cpu)\n int msr_ret = cpu_set_apic_base(X86_CPU(cpu)->apic_state, val);\n if (msr_ret < 0) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n } else {\n whpx_set_reg(cpu, WHvX64RegisterApicBase, reg);\n }\n@@ -2238,6 +2241,7 @@ int whpx_vcpu_run(CPUState *cpu)\n reg_values[1].Reg64 = val;\n if (msr_ret < 0) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n }\n } else {\n bql_lock();\n@@ -2245,6 +2249,7 @@ int whpx_vcpu_run(CPUState *cpu)\n bql_unlock();\n if (msr_ret < 0) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n }\n }\n }\n@@ -2294,6 +2299,13 @@ int whpx_vcpu_run(CPUState *cpu)\n \n if (!is_known_msr && !whpx->ignore_unknown_msr) {\n x86_emul_raise_exception(&X86_CPU(cpu)->env, EXCP0D_GPF, 0);\n+ raises_gpf = true;\n+ }\n+\n+ /* When a GPF is raised, do not change Rip. */\n+ if (raises_gpf) {\n+ reg_values[0].Reg64 =\n+ vcpu->exit_ctx.VpContext.Rip;\n }\n \n hr = whp_dispatch.WHvSetVirtualProcessorRegisters(\n", "prefixes": [ "34/38" ] }