Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224825/?format=api
{ "id": 2224825, "url": "http://patchwork.ozlabs.org/api/patches/2224825/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260418223320.51330-15-mohamed@unpredictable.fr/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260418223320.51330-15-mohamed@unpredictable.fr>", "list_archive_url": null, "date": "2026-04-18T22:32:56", "name": "[14/38] hw/intc: apic: disallow APIC reads when disabled", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4b530832baccd204d18491eb1e9bd1db2ee977a9", "submitter": { "id": 91318, "url": "http://patchwork.ozlabs.org/api/people/91318/?format=api", "name": "Mohamed Mediouni", "email": "mohamed@unpredictable.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260418223320.51330-15-mohamed@unpredictable.fr/mbox/", "series": [ { "id": 500475, "url": "http://patchwork.ozlabs.org/api/series/500475/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500475", "date": "2026-04-18T22:32:54", "name": "WHPX x86 updates for QEMU 11.1", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500475/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224825/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224825/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=CxF8QgQW;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fymlZ1tyYz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 08:34:50 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEEEd-0006Fe-VB; Sat, 18 Apr 2026 18:33:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEEEc-0006EX-BJ\n for qemu-devel@nongnu.org; Sat, 18 Apr 2026 18:33:54 -0400", "from p-east2-cluster3-host12-snip4-10.eps.apple.com ([57.103.77.191]\n helo=outbound.st.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <mohamed@unpredictable.fr>)\n id 1wEEEa-0004vR-WB\n for qemu-devel@nongnu.org; Sat, 18 Apr 2026 18:33:54 -0400", "from outbound.st.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPS id\n 1425418000B4; Sat, 18 Apr 2026 22:33:50 +0000 (UTC)", "from localhost.localdomain (unknown [17.42.251.67])\n by p00-icloudmta-asmtp-us-east-1a-100-percent-1 (Postfix) with ESMTPSA id\n E83E31800208; Sat, 18 Apr 2026 22:33:48 +0000 (UTC)" ], "Dkim-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776551632; x=1779143632;\n bh=ZKPoujWieITU4lFOoYMwoz+Ev2hRigYtFeWxrkrjtmk=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=CxF8QgQW+tStUw6ukGlpap0waEGdhTnrkGVxquGmIRODwfjuQbNVAZnf+vsvigXaO5keIf8Rnb3owTmtC3d/KHhQ/U+6u612iI8y/uclPePEP//6S96UC2LK5S5WQ9T7eAOfoO1vLTmcZqqxFnJFiFnodp+xOJKl4jUsfN/urvJPKKz9TuPOBbg7AZG0JOTlWRMeM1Fzy6NiF3eC9t4Ntd9rn7lhyj1ts2Y8jrFjnypivZxpRwT80RejQ8y74Y+/9T/TD9qa2zn/H1DxEpRUus2TUIO5FDfWGxEbpYao3uceR1mN5a6lWBWsUJh8g6adKR32uHESdvWhvPO9wVtO1w==", "mail-alias-created-date": "1752046281608", "From": "Mohamed Mediouni <mohamed@unpredictable.fr>", "To": "qemu-devel@nongnu.org", "Cc": "Mohamed Mediouni <mohamed@unpredictable.fr>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>, Pedro Barbuda <pbarbuda@microsoft.com>,\n Roman Bolshakov <rbolshakov@ddn.com>, qemu-arm@nongnu.org,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Peter Maydell <peter.maydell@linaro.org>, Wei Liu <wei.liu@kernel.org>,\n Phil Dennis-Jordan <phil@philjordan.eu>", "Subject": "[PATCH 14/38] hw/intc: apic: disallow APIC reads when disabled", "Date": "Sun, 19 Apr 2026 00:32:56 +0200", "Message-ID": "<20260418223320.51330-15-mohamed@unpredictable.fr>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20260418223320.51330-1-mohamed@unpredictable.fr>", "References": "<20260418223320.51330-1-mohamed@unpredictable.fr>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "CoVy3Xd7475ZqhG64IkpEEKn__iMH0xs", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDE4MDIyOCBTYWx0ZWRfX6mgpljENIahD\n Euh/ON6z/z1qWQxFeftQyAdhwC2GBqJHjV8aJQ+yesn19jvfiGgfiY960l1ribU+7CKehv5DzNy\n Mu4MLz12jtK3lKED5NLL9WCSD+ENNlRwW4kKAh6AaQa2w3PnPUSmPeK/AYR+MdYrcKP/qh+alys\n OQjNrB6RzAt2WuTziG0HyLw4T9JMXgMT39qYOxbIsUo+eBLs9hk+XYzWTCJoIQYG4oaRfwUh4Np\n nPidC/04MkcUVEZp7pXtaQFrYQVMyRi+IQSQLRVd7TisopapFK4iHDw2gFS1UVUJo0oEfFBGY2x\n F9Sk40PO+Qzy803AhdN9uAsPLxsxOywBUMklc87Gasow7c+WMRia0F8yvsqmJo=", "X-Proofpoint-ORIG-GUID": "CoVy3Xd7475ZqhG64IkpEEKn__iMH0xs", "X-Authority-Info-Out": "v=2.4 cv=T9mBjvKQ c=1 sm=1 tr=0 ts=69e406d0\n cx=c_apl:c_pps:t_out a=YrL12D//S6tul8v/L+6tKg==:117\n a=YrL12D//S6tul8v/L+6tKg==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=JYwUPf56aOQolOdNqfgA:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-18_06,2026-04-17_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0 spamscore=0\n bulkscore=0 mlxlogscore=821 clxscore=1030 lowpriorityscore=0 phishscore=0\n mlxscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604180228", "Received-SPF": "pass client-ip=57.103.77.191;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.st.icloud.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "!APICBASE_ENABLE + attempting to read xAPIC registers is not an allowed combination.\n\nAnd neither is x2APIC enabled + attempting to read xAPIC registers\n\nSigned-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>\n---\n hw/intc/apic.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/hw/intc/apic.c b/hw/intc/apic.c\nindex 8766ed00b9..e5ea831261 100644\n--- a/hw/intc/apic.c\n+++ b/hw/intc/apic.c\n@@ -875,6 +875,15 @@ static uint64_t apic_mem_read(void *opaque, hwaddr addr, unsigned size)\n return -1;\n }\n \n+ /* if the xAPIC is disabled, return early. */\n+ if (!(s->apicbase & MSR_IA32_APICBASE_ENABLE)) {\n+ return 0xffffffff;\n+ }\n+\n+ if (is_x2apic_mode(s)) {\n+ return 0xffffffff;\n+ }\n+\n index = (addr >> 4) & 0xff;\n apic_register_read(s, index, &val);\n \n", "prefixes": [ "14/38" ] }