Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224814/?format=api
{ "id": 2224814, "url": "http://patchwork.ozlabs.org/api/patches/2224814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260418221311.67583-5-ebiggers@kernel.org/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260418221311.67583-5-ebiggers@kernel.org>", "list_archive_url": null, "date": "2026-04-18T22:13:11", "name": "[v2,4/4] smb: client: Drop 'allocate_crypto' arg from smb*_calc_signature()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7a51cd7e6ea30fe262400a1ac3d7f5c63211a89d", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260418221311.67583-5-ebiggers@kernel.org/mbox/", "series": [ { "id": 500471, "url": "http://patchwork.ozlabs.org/api/series/500471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500471", "date": "2026-04-18T22:13:07", "name": "smb: client: Use AES-CMAC library", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500471/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224814/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224814/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10906-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Lry040TP;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10906-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Lry040TP\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fymHR5vFPz1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 19 Apr 2026 08:13:55 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id E5C8A3034EE1\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 22:13:42 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 79D18347532;\n\tSat, 18 Apr 2026 22:13:39 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 568EB34D38B;\n\tSat, 18 Apr 2026 22:13:39 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id CC561C2BCB4;\n\tSat, 18 Apr 2026 22:13:38 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776550419; cv=none;\n b=XQvqmY65rsPCyrjlkOa2WIsvoagAFSGctcpybqeIyR+7N5xM4K71lI90tEbqJZnRihsFqwt56D6sOMlFJEqL0jz424SYLU6r60Dg44cgxB38z70V3h6RBmxt3oViQvt3bsHQIzyH/fa+osJBsGJbk7xX2U1n9cBkEN1IXN53edY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776550419; c=relaxed/simple;\n\tbh=eTsIDIxopVM+5A5oT4iuxnfMSgbLRaGCewtHDCKsjCI=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=O7PewkhAoz1OIKcLAqstwSYQr/iiRA9V3bVTMpQE5eYXMS32ws02X2jT2XYrxBmarACIVvg9RcMfLKU6mMnEVJDFhaJTxRfXM+DInCgxzfqLlNUOMzhRyyjLwXHUtKR9WQD3yVtYV0nbXziFE7dLRtIx9NH1wb7dTFjPMi6HJwM=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Lry040TP; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776550419;\n\tbh=eTsIDIxopVM+5A5oT4iuxnfMSgbLRaGCewtHDCKsjCI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Lry040TP3pMbpX4EAV0kFVFUECdbwIjtTxYVh9s+nwRLkU97NPInG6w871CRgzhjr\n\t hLBoUDbX61RCXdvZWJ9UVKPAMOUIr0ynyFRs3EeAGfUbbXd8XTGL/2je92xapTFjhs\n\t nmxI+qYgPVfrzyublsVwTPVTM/sIn+WfTx/lx9PCIDxjxA9vD10nkl93B+mY4gvX6S\n\t 9Gv8p3ELObZOkAiURNWBCWFG+LbqkRAnsfI3l4rVAVERLQvxqZpgf6kfpLDtZM5zGV\n\t Hk18WYZHKQfNWoPUvTmQ1wJs5NjuNtdSVfgQeB7s7pUYuVVAyZz7tOnnvAv7bw9gn2\n\t oHp4t5z4dQC3w==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-cifs@vger.kernel.org,\n\tSteve French <sfrench@samba.org>", "Cc": "linux-crypto@vger.kernel.org,\n\tsamba-technical@lists.samba.org,\n\tlinux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tRonnie Sahlberg <ronniesahlberg@gmail.com>,\n\tShyam Prasad N <sprasad@microsoft.com>,\n\tTom Talpey <tom@talpey.com>,\n\tBharath SM <bharathsm@microsoft.com>,\n\tEric Biggers <ebiggers@kernel.org>,\n\tSteve French <stfrench@microsoft.com>", "Subject": "[PATCH v2 4/4] smb: client: Drop 'allocate_crypto' arg from\n smb*_calc_signature()", "Date": "Sat, 18 Apr 2026 15:13:11 -0700", "Message-ID": "<20260418221311.67583-5-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260418221311.67583-1-ebiggers@kernel.org>", "References": "<20260418221311.67583-1-ebiggers@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Since the crypto library API is now being used instead of crypto_shash,\nall structs for MAC computation are now just fixed-size structs\nallocated on the stack; no dynamic allocations are ever required.\nBesides being much more efficient, this also means that the\n'allocate_crypto' argument to smb2_calc_signature() and\nsmb3_calc_signature() is no longer used. Remove this unused argument.\n\nAcked-by: Steve French <stfrench@microsoft.com>\nReviewed-by: Ard Biesheuvel <ardb@kernel.org>\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n fs/smb/client/smb2transport.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c\nindex 0176185a1efcb..41009039b4cbe 100644\n--- a/fs/smb/client/smb2transport.c\n+++ b/fs/smb/client/smb2transport.c\n@@ -202,12 +202,11 @@ smb2_find_smb_tcon(struct TCP_Server_Info *server, __u64 ses_id, __u32 tid)\n \n \treturn tcon;\n }\n \n static int\n-smb2_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,\n-\t\t bool allocate_crypto)\n+smb2_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n {\n \tint rc;\n \tunsigned char smb2_signature[SMB2_HMACSHA256_SIZE];\n \tstruct kvec *iov = rqst->rq_iov;\n \tstruct smb2_hdr *shdr = (struct smb2_hdr *)iov[0].iov_base;\n@@ -438,12 +437,11 @@ generate_smb311signingkey(struct cifs_ses *ses,\n \n \treturn generate_smb3signingkey(ses, server, &triplet);\n }\n \n static int\n-smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,\n-\t\t bool allocate_crypto)\n+smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n {\n \tint rc;\n \tunsigned char smb3_signature[SMB2_CMACAES_SIZE];\n \tstruct kvec *iov = rqst->rq_iov;\n \tstruct smb2_hdr *shdr = (struct smb2_hdr *)iov[0].iov_base;\n@@ -451,11 +449,11 @@ smb3_calc_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server,\n \tstruct aes_cmac_ctx cmac_ctx;\n \tstruct smb_rqst drqst;\n \tu8 key[SMB3_SIGN_KEY_SIZE];\n \n \tif (server->vals->protocol_id <= SMB21_PROT_ID)\n-\t\treturn smb2_calc_signature(rqst, server, allocate_crypto);\n+\t\treturn smb2_calc_signature(rqst, server);\n \n \trc = smb3_get_sign_key(le64_to_cpu(shdr->SessionId), server, key);\n \tif (unlikely(rc)) {\n \t\tcifs_server_dbg(FYI, \"%s: Could not get signing key\\n\", __func__);\n \t\treturn rc;\n@@ -522,11 +520,11 @@ smb2_sign_rqst(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n \tif (!is_binding && !server->session_estab) {\n \t\tstrscpy(shdr->Signature, \"BSRSPYL\");\n \t\treturn 0;\n \t}\n \n-\treturn smb3_calc_signature(rqst, server, false);\n+\treturn smb3_calc_signature(rqst, server);\n }\n \n int\n smb2_verify_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n {\n@@ -558,11 +556,11 @@ smb2_verify_signature(struct smb_rqst *rqst, struct TCP_Server_Info *server)\n \t */\n \tmemcpy(server_response_sig, shdr->Signature, SMB2_SIGNATURE_SIZE);\n \n \tmemset(shdr->Signature, 0, SMB2_SIGNATURE_SIZE);\n \n-\trc = smb3_calc_signature(rqst, server, true);\n+\trc = smb3_calc_signature(rqst, server);\n \n \tif (rc)\n \t\treturn rc;\n \n \tif (crypto_memneq(server_response_sig, shdr->Signature,\n", "prefixes": [ "v2", "4/4" ] }