Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224224/?format=api
{ "id": 2224224, "url": "http://patchwork.ozlabs.org/api/patches/2224224/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417-virtio-fixups-v2-1-4a0d8636a628@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260417-virtio-fixups-v2-1-4a0d8636a628@linaro.org>", "list_archive_url": null, "date": "2026-04-17T05:10:09", "name": "[v2,1/2] virtio-snd: check rx buffer descriptor size", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dc63a3d6ab28d6a379568b65afaceefc6a2ce4c7", "submitter": { "id": 86526, "url": "http://patchwork.ozlabs.org/api/people/86526/?format=api", "name": "Manos Pitsidianakis", "email": "manos.pitsidianakis@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417-virtio-fixups-v2-1-4a0d8636a628@linaro.org/mbox/", "series": [ { "id": 500238, "url": "http://patchwork.ozlabs.org/api/series/500238/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500238", "date": "2026-04-17T05:10:09", "name": "More virtio-snd fortifications/coverity fixes", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/500238/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224224/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zjxpQP54;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxjdM6FwYz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 15:10:46 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDbTI-0006rk-Vj; Fri, 17 Apr 2026 01:10:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <manos.pitsidianakis@linaro.org>)\n id 1wDbTB-0006qO-Vm\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 01:10:22 -0400", "from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <manos.pitsidianakis@linaro.org>)\n id 1wDbT8-0002Ns-UN\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 01:10:21 -0400", "by mail-wr1-x42e.google.com with SMTP id\n ffacd0b85a97d-43d03db7f87so124835f8f.3\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 22:10:18 -0700 (PDT)", "from [127.0.1.1] (athedsl-4440559.home.otenet.gr. [79.129.177.223])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a18csm1749524f8f.20.2026.04.16.22.10.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 22:10:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776402617; x=1777007417; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=30dDtFtVzrZ0rFH7FQtblfDTpXIqR78+UUjDSh4LLvs=;\n b=zjxpQP54fyG+fqLFMc8ZEnjy4smYssAeAcXQBFnj/JAoF3lFA1FtT5okDkqGEvnozC\n XZFC5wzJc+hiFLo7khPEO33wJ0gQ1ZIfpY9HTJQUpFoJgTcYa3a4n2rBKnb3SDex5FYV\n o4WfAz+s7yBIUKeJ/k+DJAUaQSKn0mGjsjQcVFKSXphcHtJqsWjbRSGfqpoeI448Die2\n dhu7qU7jB5nc4n4/qnmFpN0W9jPzy6t7kNR8CU1iBUsp9qB0ALR42CDMADCcl7eEQeAA\n vCgx9lVdWQzRSSSBiB7I9Sl3P9gDCCIxih+YcvmafJ5MOSWhfNIJso5eeXN38Ubu+aat\n Hluw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776402617; x=1777007417;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=30dDtFtVzrZ0rFH7FQtblfDTpXIqR78+UUjDSh4LLvs=;\n b=GMx6ULIw7AvLv0pb8Vskj/zpkOhY6PZUW9PVVItTjKcyfPkbzS8XaAjfTDWTKFiE0U\n WdpkP6ZczOeWtH3XDfUv6uHoE/UvfRJW4GXjP7RrFrfqwKoC2W71AEL4Qkqm+ooFdKDa\n YdmnEtbQdUTypzXSNg5Uuadb+DnAXmiNQe3C6ODcOvoX6Zlmsdwk4IqyBv8u62YimXdm\n rnrrO2jeqOFpSMqQzttJo1IsPSFfJogat7dBRuDbYKjIJaYWNp1Qy6No28W44HebbXrC\n p4ixHz0lHqHlGaHi9igRM7FNdQR6q6K3Laai7jySIvXkxux8xEdQlHWrO+AMu87x4Jxl\n CUfg==", "X-Gm-Message-State": "AOJu0Yx+Zp3pm6geUF+56PT6oyk08Hs7asTRURr9EJdhEl53ECbIcX3W\n 5lk2ugQ5TE2Hr6nSDhRNZB9ivwHwUtylYJxM7hjAVRxS91qTmhOB0yy1mMfQQ11WdDH7/6W4Xuc\n P9xZEFcQ=", "X-Gm-Gg": "AeBDieuEWS2Z1ZYFFp8JBzRrrMcs6Yyn0gpYH6L+tGB+q1uBrbPJ1C43p6wfl/zyE6h\n FjQVcoDGn8IJmJ5mgqWg2Gwk7jZyTRw6GSfs6tvlizn9jw8pK2rUeHRAh2K632E0+KzZV1YbKSx\n S8tClGmomMsYfX3EIwgpGctnTLfbCMTViuG3A95thVgO7c/wxdpq1dQps7VRbDhcPAx5PYq0vdG\n 6VLA7BammuIltwFhGVwSmSnQbacEEObkIPdqRov2xL0aN2D1iQDNdnRCECkW9p2S8SqjFsw8dru\n rtDUXDNVoS4RUOgcB0U1Ui+qoNeYWnj+pky40wAOIXO4Tuy+6djefIAkUjidfKQxCSobQltWYUZ\n EZF83nV7y/ZryGKgPVw9L6bMNrqs2XEnFU+e/Ra8ZgLnrnDuWf/KCd+cixWfwUY6biEZQa70sa9\n T8gAq6a2sn3acJB+YnSU3k0QOy9lgMSQgIT2nVT0zdwqDlzr9kdV0BUjrqxZNEWILeCEtJNYS1+\n 8KMgj7X7pRLjUhG8nSLqzlCngDtcUvLa72jGYV8Mjp0V9tDS+E=", "X-Received": "by 2002:a05:6000:24c8:b0:43d:70b3:7edf with SMTP id\n ffacd0b85a97d-43fe3dc5386mr1776620f8f.12.1776402616764;\n Thu, 16 Apr 2026 22:10:16 -0700 (PDT)", "From": "Manos Pitsidianakis <manos.pitsidianakis@linaro.org>", "Date": "Fri, 17 Apr 2026 08:10:09 +0300", "Subject": "[PATCH v2 1/2] virtio-snd: check rx buffer descriptor size", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260417-virtio-fixups-v2-1-4a0d8636a628@linaro.org>", "References": "<20260417-virtio-fixups-v2-0-4a0d8636a628@linaro.org>", "In-Reply-To": "<20260417-virtio-fixups-v2-0-4a0d8636a628@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Gerd Hoffmann <kraxel@redhat.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, =?utf-8?q?Alex?=\n\t=?utf-8?q?_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>, qemu-stable@nongnu.org,\n Manos Pitsidianakis <manos.pitsidianakis@linaro.org>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1381;\n i=manos.pitsidianakis@linaro.org; h=from:subject:message-id;\n bh=e7CNu6bOPefkB4cYwLokIAQo8SEItIOzfhxsnDPZRv4=;\n b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FLQVhjcHgzQi9mZ\n 25RQWNzbVlnQnA0Y0MyUWpGM2pKNTNSNmdueVNhdnZXSTNhVzU0CkVpODhiRXo4Vi9VNnN6eVQ1\n NnFKQWpNRUFBRUtBQjBXSVFUTVhCdE9SS0JXODRkd0hSQjNLY2R3ZjM0SjBBVUMKYWVIQXRnQUt\n DUkIzS2Nkd2YzNEowQnh0RC85WFBuZVdQVEtKOGRPTUduRTlsNEFLWUllUTFVS2xYOHJxNDJxWQ\n pTKzVaaUFFNUgxNnJtZTUzT0tMc0NqMnhRRFB2R2VwY1FGSXBJazhZYXF4SmI2c043YTJmRFQrS\n VdHNXIzUEVUCmUrVUQ3QXExUmxQSWl6Q1cwbVZBaXF1QVB3SUthSmNSU2E1cVNTY0ZPRk9sb2Q4\n QTE4Z1dHb2hlckR2QjVuUzYKYmh4eXRWcjZ2eWFzTC8yUjVsK0Qzbjl6YUFOcU85NjdLcG5oOWh\n wNnlNU0NXVUJ4QU1TM2Y4WFM2T3FKQTZQRQpDazlFeFZjYnczV3dscW8wU2U0d3pWRFEyd3JkOW\n JEczRxM3h3cFJZRTE1dmdmcFZIUFZjc0x6VzVJU3gzbTU0CkR1SS9jZjBoQVZSNi9Dd1h3WUNTL\n 051MGE5R09oNFN2djFLeVdFNTQ2eVlSZHVvZnJ6Wms5WVJxM3pFSHhjNkcKTVVpd3psanZEdlN1\n NjhoVmUxNko2S0lJaG53bEpjZkI5NW56RlR3THYrQVp5TjJScE9KNGU5aFNYL0NCdzl5bApjM3p\n xa0w5VEJ2SC94SDIvUkFweG5rNHR1Q3MxeVVxS2dFV290cmdjRzZVUUlBS05NcmVnT0RJR3ZIMX\n RZZTFSCjBBSUtIWi9VZ0oyQUFNNzNoeWFxRGFoeXdxKzJFOE4yTWMvUHFwZjJVUnB1OVNWV2dLN\n 2ZuYXJHN2l1NytYdFoKT3lpZkJGQ09zY0RHVmpmalozS2cyZkM2U1RySHZEekQ1c2NvOHBBQzlD\n bWFZRDZmeXFGamk0Y0pGYkJCa0tqdApyVjlaL2tiUzcxRVNzWEF6V2pXQlNnSFJrS2JsMnl3Nm9\n 6WHlQNFdFU1JpMWl6d1U4b2xFMTZyKzJrSjBMQXlpCml6VkF3UT09Cj1yNkVaCi0tLS0tRU5EIF\n BHUCBNRVNTQUdFLS0tLS0K", "X-Developer-Key": "i=manos.pitsidianakis@linaro.org; a=openpgp;\n fpr=7C721DF9DB3CC7182311C0BF68BC211D47B421E1", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42e;\n envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wr1-x42e.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "It must be at least sizeof(virtio_snd_pcm_status).\n\nI haven't verified if it's possible to get an underflow, but coverity\npoints it out so add a check.\n\nSigned-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>\n---\n hw/audio/virtio-snd.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c\nindex fb5cff386606d03e5cfce88f79e404e510bbcde7..93fbcfb43f7fdcfd5c164b496015da743822f5eb 100644\n--- a/hw/audio/virtio-snd.c\n+++ b/hw/audio/virtio-snd.c\n@@ -970,12 +970,14 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)\n }\n \n stream = vsnd->pcm.streams[stream_id];\n- if (stream == NULL || stream->info.direction != VIRTIO_SND_D_INPUT) {\n+ size = iov_size(elem->in_sg, elem->in_num);\n+ if (stream == NULL\n+ || stream->info.direction != VIRTIO_SND_D_INPUT\n+ || size < sizeof(virtio_snd_pcm_status)) {\n goto rx_err;\n }\n+ size -= sizeof(virtio_snd_pcm_status);\n WITH_QEMU_LOCK_GUARD(&stream->queue_mutex) {\n- size = iov_size(elem->in_sg, elem->in_num) -\n- sizeof(virtio_snd_pcm_status);\n buffer = g_malloc0(sizeof(VirtIOSoundPCMBuffer) + size);\n buffer->elem = elem;\n buffer->vq = vq;\n", "prefixes": [ "v2", "1/2" ] }