Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2224056/?format=api
{ "id": 2224056, "url": "http://patchwork.ozlabs.org/api/patches/2224056/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260416180107.777065-6-kwilczynski@kernel.org/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260416180107.777065-6-kwilczynski@kernel.org>", "list_archive_url": null, "date": "2026-04-16T18:00:49", "name": "[v5,05/23] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c49e0a73cbc2101568fc3de0ec56b181777ddad3", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260416180107.777065-6-kwilczynski@kernel.org/mbox/", "series": [ { "id": 500193, "url": "http://patchwork.ozlabs.org/api/series/500193/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=500193", "date": "2026-04-16T18:00:44", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/500193/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2224056/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2224056/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-52629-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GNzaUOlO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52629-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"GNzaUOlO\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxQn94NRcz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 04:01:33 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id B57FF300567C\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 18:01:31 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 30F6A30DEA6;\n\tThu, 16 Apr 2026 18:01:30 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5772C21C7;\n\tThu, 16 Apr 2026 18:01:29 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 7A97AC2BCB5;\n\tThu, 16 Apr 2026 18:01:26 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776362490; cv=none;\n b=LeH+DeLFpLOS+bj/uEvdycd38uzB6WtoVKBVdAyXbcOc6FdzvLdoC4a5+wGym6VVzxv5x8RBF/rDu9RCb3CVOwBu0apw50HK5cu83JwqHhg4g68cJ+SIkCWNqGxNxstQcY3H00xtRmJYKZffN9GePNfUmgY0BAZ1AVd9o0vQPes=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776362490; c=relaxed/simple;\n\tbh=u/k9TMeqaPQPWgW7ILWQ8kth1orOPivoorazdGxMwic=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=uyAatg4wWzMAVaYJonEbC8qBAivFU5V1r43K0Zs15r2ftgIFTUhzqpcqKOLH/b509OVSfKaqY51I7v5x1KMXrjdVVjUwYAxkDY0EU/u5yeNYxy7Cr363rxzBDHixZ3ZhicsE/3Q1S2WgQqXwkJisrSljU+dO+Bf0/6Yy+7lxxf0=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=GNzaUOlO; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776362489;\n\tbh=u/k9TMeqaPQPWgW7ILWQ8kth1orOPivoorazdGxMwic=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GNzaUOlOxZWEgLbDs808/Oq3wDidFRb5nqJauRfHZ90l18YrYeKlEoChUM8QgraAz\n\t oreTnPAqoCd0iLRCrSAlVLLiNPzFq20CJoC/Iq+cmUxWe7h5z2T0rwGqLIpnXqtHdC\n\t xZJz7DYMXdM2amhZXAy5y9A/1f4FGDFl8j5nb0HPEZ+0xDa8/y+gX2M9fRfvDMiJfk\n\t lSQYfbpIAe2Iqhb1LnGqDvn579zIWLUWvhkp0LnB0sCbLuaI0zQ+BsHGFMW0UXgQXE\n\t di5s/47rwYqehx34VPcP3qlETFcKZ/54zFsaWGxzcD5uuRraX3FlZabm13M3jCdw/x\n\t Ph+agkyZNjW3A==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v5 05/23] PCI/sysfs: Add CAP_SYS_ADMIN check to\n __resource_resize_store()", "Date": "Thu, 16 Apr 2026 18:00:49 +0000", "Message-ID": "<20260416180107.777065-6-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260416180107.777065-1-kwilczynski@kernel.org>", "References": "<20260416180107.777065-1-kwilczynski@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit" }, "content": "Currently, the __resource_resize_store() allows writing to the\nresourceN_resize sysfs attribute to change a BAR's size without\nchecking for capabilities, currently relying only on the file\naccess check.\n\nResizing a BAR modifies PCI device configuration and can disrupt\nactive drivers. After the upcoming conversion to static attributes,\nit will also trigger resource file updates via sysfs_update_groups().\n\nThus, add a CAP_SYS_ADMIN check to prevent unprivileged users from\nperforming BAR resize operations.\n\nReviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/pci-sysfs.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 73a9ae9d289b..4f95b336cc34 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1619,6 +1619,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tint ret;\n \tu16 cmd;\n \n+\tif (!capable(CAP_SYS_ADMIN))\n+\t\treturn -EPERM;\n+\n \tif (kstrtoul(buf, 0, &size) < 0)\n \t\treturn -EINVAL;\n \n", "prefixes": [ "v5", "05/23" ] }