Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223978/?format=api
{ "id": 2223978, "url": "http://patchwork.ozlabs.org/api/patches/2223978/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-3-pablo@netfilter.org/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260416131453.308611-3-pablo@netfilter.org>", "list_archive_url": null, "date": "2026-04-16T13:14:44", "name": "[net,02/11] netfilter: nfnetlink_osf: fix divide-by-zero in OSF_WSS_MODULO", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e86eb5b7f50dfb83611738c26422db9076f63311", "submitter": { "id": 1315, "url": "http://patchwork.ozlabs.org/api/people/1315/?format=api", "name": "Pablo Neira Ayuso", "email": "pablo@netfilter.org" }, "delegate": { "id": 11902, "url": "http://patchwork.ozlabs.org/api/users/11902/?format=api", "username": "strlen", "first_name": "Florian", "last_name": "Westphal", "email": "fw@strlen.de" }, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260416131453.308611-3-pablo@netfilter.org/mbox/", "series": [ { "id": 500161, "url": "http://patchwork.ozlabs.org/api/series/500161/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500161", "date": "2026-04-16T13:14:48", "name": "[net,01/11] netfilter: arp_tables: fix IEEE1394 ARP payload parsing in arp_packet_match()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500161/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223978/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11970-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=q/tY4Ymt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11970-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"q/tY4Ymt\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxJTX27Fkz1yG9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 23:17:36 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 7D4CF3046FC7\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 13:15:24 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 655703C4544;\n\tThu, 16 Apr 2026 13:15:07 +0000 (UTC)", "from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EC7DF3BED27;\n\tThu, 16 Apr 2026 13:15:04 +0000 (UTC)", "from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id E8F7160254;\n\tThu, 16 Apr 2026 15:15:02 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776345306; cv=none;\n b=V7Vry5o8yUyMU70YQRL+Oku90ZLwB1ApwKBUcrlO9EveA9Uv169j0xsO3qfWCVi0luD1DQ2MGfQXYAcQLEqI9hxDK5SsgBcYU8zJm1CvM8j57UzRffwCx8IM/XKlRE9+xmgghiO8MkQ/sf77mo3ANdVzJuoS05h59AvAzNuMv0Y=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776345306; c=relaxed/simple;\n\tbh=PawOKsjU/i0MTF68zbUb+VsSAv0gXGWmxITDx7vkR6k=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Paqk+g05La910l4NFaLs1aFTSEcYzyvo1VKU61Vx8Wa7NhCSZf1OR4pJ/37uiGDMr5lasO3/BF0aVa/Oh9p2Gk7Fcls8gxs/v9va5cssl9yvlQ741MkkdpUZQJLBQwXeTRm5ktEh9J7g58TJabmg1UN5inBZOEWjUw3h9IEzSY8=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=q/tY4Ymt; arc=none smtp.client-ip=217.70.190.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776345303;\n\tbh=0HS0505hGdVF8P/vAEeHwqgAoOpv+wYp7KMbrpsv3RI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=q/tY4YmtWtu3tiAWQgARW4zma2O51HrPHWZ9vjqqRcI6pRX+fI7jC4HmxDRpwnfLv\n\t adcgNZZ3MDl+VElE/AjXf1DBPfvpaF5toZofiSrlzdQUNMlXGJBCk30ASXAtAz4MDD\n\t SrPvIU83124MQR+gMp0VBKAG10ZKzFABTOSLVOtWpzNhfsP3+hPZLVh/RUCW9j8d1Y\n\t w8UkvAbhnWbcAh+v7dW81m+GZluelAt9qL6CtRrpXhVZr6Mr9QtBSZUItZLXLXJf9n\n\t adGBngCO+KVrsdASBYC7jfgg6aebxQJwbnk54+NSjglRPBlDupDVnQG9y4D2ChpwiQ\n\t VKu36l1yd7Sww==", "From": "Pablo Neira Ayuso <pablo@netfilter.org>", "To": "netfilter-devel@vger.kernel.org", "Cc": "davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org", "Subject": "[PATCH net 02/11] netfilter: nfnetlink_osf: fix divide-by-zero in\n OSF_WSS_MODULO", "Date": "Thu, 16 Apr 2026 15:14:44 +0200", "Message-ID": "<20260416131453.308611-3-pablo@netfilter.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260416131453.308611-1-pablo@netfilter.org>", "References": "<20260416131453.308611-1-pablo@netfilter.org>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Xiang Mei <xmei5@asu.edu>\n\nnf_osf_match_one() computes ctx->window % f->wss.val in the\nOSF_WSS_MODULO branch with no guard for f->wss.val == 0. A\nCAP_NET_ADMIN user can add such a fingerprint via nfnetlink; a\nsubsequent matching TCP SYN divides by zero and panics the kernel.\n\nReject the bogus fingerprint in nfnl_osf_add_callback() above the\nper-option for-loop. f->wss is per-fingerprint, not per-option, so\nthe check must run regardless of f->opt_num (including 0). Also\nreject wss.wc >= OSF_WSS_MAX; nf_osf_match_one() already treats that\nas \"should not happen\".\n\nCrash:\n Oops: divide error: 0000 [#1] SMP KASAN NOPTI\n RIP: 0010:nf_osf_match_one (net/netfilter/nfnetlink_osf.c:98)\n Call Trace:\n <IRQ>\n nf_osf_match (net/netfilter/nfnetlink_osf.c:220)\n xt_osf_match_packet (net/netfilter/xt_osf.c:32)\n ipt_do_table (net/ipv4/netfilter/ip_tables.c:348)\n nf_hook_slow (net/netfilter/core.c:622)\n ip_local_deliver (net/ipv4/ip_input.c:265)\n ip_rcv (include/linux/skbuff.h:1162)\n __netif_receive_skb_one_core (net/core/dev.c:6181)\n process_backlog (net/core/dev.c:6642)\n __napi_poll (net/core/dev.c:7710)\n net_rx_action (net/core/dev.c:7945)\n handle_softirqs (kernel/softirq.c:622)\n\nFixes: 11eeef41d5f6 (\"netfilter: passive OS fingerprint xtables match\")\nReported-by: Weiming Shi <bestswngs@gmail.com>\nSuggested-by: Florian Westphal <fw@strlen.de>\nSuggested-by: Pablo Neira Ayuso <pablo@netfilter.org>\nSigned-off-by: Xiang Mei <xmei5@asu.edu>\nReviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\n net/netfilter/nfnetlink_osf.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/net/netfilter/nfnetlink_osf.c b/net/netfilter/nfnetlink_osf.c\nindex 45d9ad231a92..70172ca07858 100644\n--- a/net/netfilter/nfnetlink_osf.c\n+++ b/net/netfilter/nfnetlink_osf.c\n@@ -320,6 +320,10 @@ static int nfnl_osf_add_callback(struct sk_buff *skb,\n \tif (f->opt_num > ARRAY_SIZE(f->opt))\n \t\treturn -EINVAL;\n \n+\tif (f->wss.wc >= OSF_WSS_MAX ||\n+\t (f->wss.wc == OSF_WSS_MODULO && f->wss.val == 0))\n+\t\treturn -EINVAL;\n+\n \tfor (i = 0; i < f->opt_num; i++) {\n \t\tif (!f->opt[i].length || f->opt[i].length > MAX_IPOPTLEN)\n \t\t\treturn -EINVAL;\n", "prefixes": [ "net", "02/11" ] }