Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223914/?format=api
{ "id": 2223914, "url": "http://patchwork.ozlabs.org/api/patches/2223914/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1bdc772e4a795ecd9f5bf2b7e7143cc4b297318c.1776339451.git.matheus.bernardino@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1bdc772e4a795ecd9f5bf2b7e7143cc4b297318c.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-04-16T11:38:54", "name": "[v5,05/16] hexagon: print info on \"-d in_asm\" for disabled IEEE FP instructions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5d1a65b97b7ce65a23dd36a106807392b7908d3e", "submitter": { "id": 90606, "url": "http://patchwork.ozlabs.org/api/people/90606/?format=api", "name": "Matheus Tavares Bernardino", "email": "matheus.bernardino@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1bdc772e4a795ecd9f5bf2b7e7143cc4b297318c.1776339451.git.matheus.bernardino@oss.qualcomm.com/mbox/", "series": [ { "id": 500137, "url": "http://patchwork.ozlabs.org/api/series/500137/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500137", "date": "2026-04-16T11:38:50", "name": "hexagon: add missing HVX float instructions", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/500137/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223914/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Byr7ot8i;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=h6ZEQbX/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxGL92BDNz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 21:41:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDL4Q-0005EX-D8; Thu, 16 Apr 2026 07:39:43 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <matheus.bernardino@oss.qualcomm.com>)\n id 1wDL45-00056T-OT\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 07:39:21 -0400", "from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <matheus.bernardino@oss.qualcomm.com>)\n id 1wDL43-0003AF-Rz\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 07:39:21 -0400", "from pps.filterd (m0279867.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63G8Mhjk3733617\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 11:39:15 GMT", "from mail-dy1-f200.google.com (mail-dy1-f200.google.com\n [74.125.82.200])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djcqwktwg-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 11:39:14 +0000 (GMT)", "by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2c0ba59a830so10020963eec.0\n for <qemu-devel@nongnu.org>; Thu, 16 Apr 2026 04:39:14 -0700 (PDT)", "from hu-mathbern-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2de8c10a65asm6845391eec.6.2026.04.16.04.39.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 04:39:12 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=qcppdkim1; bh=ybwCHZLfhny\n CfuN9WWdAhCLFmoos/vVMcKHV+YU2Zd4=; b=Byr7ot8ieGuX1N5ri82I7lmiSfV\n aCBL49jm6QfNYZ51/0cceMu7jAKUQK8jVro6F+fH9s+BXL6bLHF+BO25oHdf3C7r\n KLZeSxQ5NrU7qz8XYzvv+nCyK1hlCO81h/fODpi9Cc2gmnb1F9F6SQjkACkRtNPn\n nPDwxzp66hJTZoB9ZJAU5a/98s2/IB6yNyacVuNs/c3cEdNK9aTHMX5SjFSqUPm4\n LXwGeMEuyuPbRTBujxifs3Oirs5RMKZ/r/F3T8oyf7EqaS2GomGrlSgF5+7yJDld\n f0wNUTLBYcQh2n03/i4CoQh5oximnozeqyybgM9hw34Bkq40xc1W00Mh9mw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776339554; x=1776944354; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ybwCHZLfhnyCfuN9WWdAhCLFmoos/vVMcKHV+YU2Zd4=;\n b=h6ZEQbX/QjrX7HbI6dQUmbZ+IomVEpJrxNxhpQdHEUgk/UZhompraI4/ytELkj4zL1\n 4LSez+RrcOagJg0poBGGhYO2tX+SNkdBzmN8YVuuOa5awYxL5rgBbf8xHGnah22yIcyx\n xfHgcMMb70dcywNAmjgm8Pr6glWI8X8pdPaidf/yhHgViNCAQRWfw6MHeFi4LsV5p0Ro\n /iCh3oe1lmKJ8U7hRg4/r0KOKuIobWTvCHhmSz3q57bxceK3D3AslzLDpcnBH7LAbq0e\n udUAasU5g57xJ5AtClhbIPNWaVDB+EffjX6EvyD/QcgDSuRIp92+2/8q0HcJs9MIERGk\n 3/pg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776339554; x=1776944354;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ybwCHZLfhnyCfuN9WWdAhCLFmoos/vVMcKHV+YU2Zd4=;\n b=h5tb476SqSdXI3pT+Y+ETuurb8dSDaL8ZTjV1S9YGIuRS5LicxsUk2OTv6QxatIMYk\n /JK2j4N7d0cnhj545lI3HhlAT6Q0UcP4HALZ1f01+xBX1CYxR2kDiIGKwPBMOBVpMpvt\n 36dAOmzsrfYElGJAam/094PxmQf+cuEAbSDOT+E9eW7TwRZtpRsdbxv0c7efBBqz3Lo6\n BlU+ArMVJ/0uljzRUH2L/+lcupXdHy4hgcjbxaBwaBmkN3tVirrxc1Q1mOUh+Suh+4Uh\n UtDPsdO/ufRUhs7ACBgkl8/YqBOf64OynBpwlOJPGD4akg2D1dIUFe+38Nb4Ean3gnnz\n Npng==", "X-Gm-Message-State": "AOJu0YwM57GniJN5dYCEECvPYq13SzvQrBh1axg30BBpFwN6q/xa7qtP\n qskut1TlsZKPkOa16QxSqSYrXtbT3o+r2ZQ4U85kpujwT1XN5e+aW9RyHLcB8Z7MDiRDFedGTwW\n j/Lh5UskxbLecxqsqUc5LroN9Wk9jy8k4d/oztPPsN35cZxD6+wRjBBt38Pf66cVVRE9d", "X-Gm-Gg": "AeBDieurG4OIl0RSLZdFbEVejjzHsxKDrVlZc1Pg2vQuV7sSjab25CcYTDtUgY5LdY/\n 1ItnbOdxZW1G8KqGfTl2Djhs1rzTpPs/ZsDa/ScJWOV5INAdfG+6/vhs0rj4WnJJpB8k/uji2sM\n ZRXOGOa8C/9PHiyXW+SOw5bB1WmGWqzHjzF03pu3JNYTnbQFRywcjBiZejdSTYnp8Y6hlPJtEm6\n QUV9Jfvf57ydye4Ucc5c4VK3Qx6XvYQFXL7oToqFaKBckjZBl8ZCXbWev4MmWkrcwPG21i2WcSg\n kTwZhCMMMNSl4zMw4PYZJoofMwISTqdWVfgpYaA4YTc0ku7chIAqsxgvkSKpCvtUHB2hip+7y4G\n eJJszl8GqSKLSKgfpwjvBxkPexLYbLwlWpka14VXLzBKPX68jloOjpMkHoTb5BklmfjBW/Fg1r+\n jDnMDCTYtntqaPkk+yqGs=", "X-Received": [ "by 2002:a05:7300:a287:b0:2c1:3f85:747 with SMTP id\n 5a478bee46e88-2d5894628demr13808502eec.21.1776339553495;\n Thu, 16 Apr 2026 04:39:13 -0700 (PDT)", "by 2002:a05:7300:a287:b0:2c1:3f85:747 with SMTP id\n 5a478bee46e88-2d5894628demr13808475eec.21.1776339552863;\n Thu, 16 Apr 2026 04:39:12 -0700 (PDT)" ], "From": "Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "richard.henderson@linaro.org, ale@rev.ng, anjo@rev.ng,\n brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com,\n marco.liebel@oss.qualcomm.com, philmd@linaro.org,\n quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com", "Subject": "[PATCH v5 05/16] hexagon: print info on \"-d in_asm\" for disabled IEEE\n FP instructions", "Date": "Thu, 16 Apr 2026 04:38:54 -0700", "Message-Id": "\n <1bdc772e4a795ecd9f5bf2b7e7143cc4b297318c.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<cover.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "References": "<cover.1776339451.git.matheus.bernardino@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-ORIG-GUID": "fsy5q0_QbfNxr2g5Zma8Vfsm1J0CRdw-", "X-Proofpoint-GUID": "fsy5q0_QbfNxr2g5Zma8Vfsm1J0CRdw-", "X-Authority-Analysis": "v=2.4 cv=XOIAjwhE c=1 sm=1 tr=0 ts=69e0ca62 cx=c_pps\n a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=pGLkceISAAAA:8\n a=EUspDBNiAAAA:8 a=uwSgyZDXI7pCxt1u4dUA:9 a=6Ab_bkdmUrQuMsNx7PHu:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDE2MDExMCBTYWx0ZWRfX+G+q7TCNfhC9\n Rhs2Nk3qjKe+YfteQaz/mfrPLvivhieLpq57qipwe3mN0K0Gjj1YyMuW2lUSYBBF3sd/PKOv/FA\n JIZSkffZu20XYGtbGvtUrx0YnTVopG0ysOJrrj3gPff3xWdfEjA/RVbslVedJHdAkaWPjfPsmEy\n yGA43JbCw4kS4J0zvmGvvjJhnu3DC3BodquUU44HZlDB+vZBEvy8bycgKWWzar6+k6RAhpTFpcc\n 5Smvj1tigrm5N3YrxH4XbuthqR0lSkvU7UvrEObm5DbtORjxXQtjPxLQV6G0aT+N/vMnSX496mh\n zvDF37hkrfCaLDIXjlZ1+KJqv2own9IvC/P6XBb5Jeee7m5XbtwkXdnq0ytdhZynAqNDhZ+s4BO\n eVwLb+ZWLquqD5uhoIyKeBOeKVvAM2CTU3Fw66Mkys+MVymC5HsdEsfNK7DMm8Lffov1Ur+h4dH\n OQ2YnJjlFQG5oxmhVGw==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-16_03,2026-04-13_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0\n bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160110", "Received-SPF": "pass client-ip=205.220.168.131;\n envelope-from=matheus.bernardino@oss.qualcomm.com;\n helo=mx0a-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When cpu->cfg.ieee_fp_extension is off, IEEE FP instructions don't get\nexecuted. Let's print that info on the \"-d in_asm\" output to help users.\nThis will generate an output like the following:\n\n0x00020e30: 0x1f82e1c0 { V0.sf = vadd(V1.sf,V2.sf) (disabled: no ieee_fp) }\n\nReviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>\nSigned-off-by: Matheus Tavares Bernardino <matheus.bernardino@oss.qualcomm.com>\n---\n target/hexagon/cpu_bits.h | 3 ++-\n target/hexagon/printinsn.h | 2 +-\n disas/hexagon.c | 3 ++-\n target/hexagon/cpu.c | 2 ++\n target/hexagon/decode.c | 4 ++--\n target/hexagon/printinsn.c | 7 ++++++-\n 6 files changed, 15 insertions(+), 6 deletions(-)", "diff": "diff --git a/target/hexagon/cpu_bits.h b/target/hexagon/cpu_bits.h\nindex 83d13de569..1f9e617d72 100644\n--- a/target/hexagon/cpu_bits.h\n+++ b/target/hexagon/cpu_bits.h\n@@ -72,6 +72,7 @@ static inline bool is_packet_end(uint32_t endocing)\n return ((bits == 0x3) || (bits == 0x0));\n }\n \n-int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc, GString *buf);\n+int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc,\n+ GString *buf, const HexagonCPUConfig *cfg);\n \n #endif\ndiff --git a/target/hexagon/printinsn.h b/target/hexagon/printinsn.h\nindex 2ecd1731d0..6a45ec571f 100644\n--- a/target/hexagon/printinsn.h\n+++ b/target/hexagon/printinsn.h\n@@ -21,7 +21,7 @@\n #include \"insn.h\"\n \n void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,\n- target_ulong pc);\n+ target_ulong pc, const HexagonCPUConfig *cfg);\n void snprint_a_pkt_debug(GString *buf, Packet *pkt);\n \n #endif\ndiff --git a/disas/hexagon.c b/disas/hexagon.c\nindex c1a4ffc5f6..e2d3804606 100644\n--- a/disas/hexagon.c\n+++ b/disas/hexagon.c\n@@ -57,8 +57,9 @@ int print_insn_hexagon(bfd_vma memaddr, struct disassemble_info *info)\n return PACKET_WORDS_MAX * sizeof(uint32_t);\n }\n \n+ const HexagonCPUConfig *cfg = info->target_info;\n buf = g_string_sized_new(PACKET_BUFFER_LEN);\n- len = disassemble_hexagon(words, i, memaddr, buf);\n+ len = disassemble_hexagon(words, i, memaddr, buf, cfg);\n (*info->fprintf_func)(info->stream, \"%s\", buf->str);\n g_string_free(buf, true);\n \ndiff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c\nindex 5470d9c7ce..d7f4df5f96 100644\n--- a/target/hexagon/cpu.c\n+++ b/target/hexagon/cpu.c\n@@ -307,6 +307,8 @@ static void hexagon_cpu_disas_set_info(const CPUState *cs,\n {\n info->print_insn = print_insn_hexagon;\n info->endian = BFD_ENDIAN_LITTLE;\n+ HexagonCPU *cpu = HEXAGON_CPU(cs);\n+ info->target_info = &cpu->cfg;\n }\n \n static void hexagon_cpu_realize(DeviceState *dev, Error **errp)\ndiff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex dbc9c630e8..d7ce8c8e1b 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -801,7 +801,7 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n \n /* Used for \"-d in_asm\" logging */\n int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc,\n- GString *buf)\n+ GString *buf, const HexagonCPUConfig *cfg)\n {\n DisasContext ctx;\n Packet pkt;\n@@ -810,7 +810,7 @@ int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc,\n ctx.pkt = &pkt;\n \n if (decode_packet(&ctx, nwords, words, &pkt, true) > 0) {\n- snprint_a_pkt_disas(buf, &pkt, words, pc);\n+ snprint_a_pkt_disas(buf, &pkt, words, pc, cfg);\n return pkt.encod_pkt_size_in_bytes;\n } else {\n g_string_assign(buf, \"<invalid>\");\ndiff --git a/target/hexagon/printinsn.c b/target/hexagon/printinsn.c\nindex 4865cdd133..85527f56e2 100644\n--- a/target/hexagon/printinsn.c\n+++ b/target/hexagon/printinsn.c\n@@ -51,7 +51,7 @@ static void snprintinsn(GString *buf, Insn *insn)\n }\n \n void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,\n- target_ulong pc)\n+ target_ulong pc, const HexagonCPUConfig *cfg)\n {\n bool has_endloop0 = false;\n bool has_endloop1 = false;\n@@ -85,6 +85,11 @@ void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,\n g_string_append(buf, \"\\t\");\n snprintinsn(buf, &(pkt->insn[i]));\n \n+ if (!cfg->ieee_fp_extension &&\n+ GET_ATTRIB(pkt->insn[i].opcode, A_HVX_IEEE_FP)) {\n+ g_string_append(buf, \" (disabled: no ieee_fp)\");\n+ }\n+\n if (i < pkt->num_insns - 1) {\n /*\n * Subinstructions are two instructions encoded\n", "prefixes": [ "v5", "05/16" ] }