Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223875/?format=api
{ "id": 2223875, "url": "http://patchwork.ozlabs.org/api/patches/2223875/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260416093927.602613-5-daniel@thingy.jp/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260416093927.602613-5-daniel@thingy.jp>", "list_archive_url": null, "date": "2026-04-16T09:39:23", "name": "[v5,4/8] m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5117c14e91c3aea0f794a1c0247b339c70afc45d", "submitter": { "id": 85408, "url": "http://patchwork.ozlabs.org/api/people/85408/?format=api", "name": "Daniel Palmer", "email": "daniel@thingy.jp" }, "delegate": { "id": 14103, "url": "http://patchwork.ozlabs.org/api/users/14103/?format=api", "username": "spectrum", "first_name": "Angelo", "last_name": "Dureghello", "email": "sysamfw@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260416093927.602613-5-daniel@thingy.jp/mbox/", "series": [ { "id": 500127, "url": "http://patchwork.ozlabs.org/api/series/500127/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=500127", "date": "2026-04-16T09:39:20", "name": "Add virtio-mmio support to m68k virt machine", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/500127/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223875/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223875/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=dUg+wul4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"dUg+wul4\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp", "phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxCgQ002qz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 19:40:49 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0183884105;\n\tThu, 16 Apr 2026 11:40:14 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 736F484285; Thu, 16 Apr 2026 11:40:10 +0200 (CEST)", "from mail-pg1-x532.google.com (mail-pg1-x532.google.com\n [IPv6:2607:f8b0:4864:20::532])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0C0FE84214\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 11:40:08 +0200 (CEST)", "by mail-pg1-x532.google.com with SMTP id\n 41be03b00d2f7-c796163fac5so810345a12.1\n for <u-boot@lists.denx.de>; Thu, 16 Apr 2026 02:40:07 -0700 (PDT)", "from kinako.work.home.arpa\n (p1329195-ipxg00a01sizuokaden.shizuoka.ocn.ne.jp. [114.145.5.195])\n by smtp.googlemail.com with ESMTPSA id\n 41be03b00d2f7-c79581a2fc2sm4423568a12.21.2026.04.16.02.40.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 Apr 2026 02:40:06 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1776332406; x=1776937206; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=goaQ4vSx4LpV53K9vUM2VBZDCzM4dwgQch9SJiUEP2c=;\n b=dUg+wul4+iP0hIpObYK8uIdnRwZfqBP+hsTZ5gwVaZ7ceJ0l2Wq+yAouAmue93qkT5\n ecGSQeiyXaUkJXO3U2kDoHT6jbMn0u5P6ByNoGNnrjRKkJYrVIjUYsWUcxUQeQyx/Pdi\n eo90ZBcWcAOhXAFjl8OV5aLIZKQZkQ3F3WIfw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776332406; x=1776937206;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=goaQ4vSx4LpV53K9vUM2VBZDCzM4dwgQch9SJiUEP2c=;\n b=TmudyYjDNf3H+kz31qbR5RNHSmydkiQPcL//9r/eAzun019ZaDmhTe1Wg2loOICTHk\n lGAmWpgotsdq8AhQyTxpuxoVQ+Sl5JAMR9EnnDJw58DE2Kw+VFED6ervy2DWc7tF0whn\n mDMgT3L+B4fsAgafKguJp9/wOj9oYQvysuKH4v2hUmUzWnz/a+oDuy87iQxxkbLPv0fZ\n mvigVuITE44EYBHEuQ2tsQR4ZwjhWNzUUrqgZnOKfKvaYHyPZSeLoHTXWTrpTKJNbvsS\n dEp3CsiQRBkD9gmX80VDbaZ+Tw4WNGHxz5GwqcFdMIRX9Gj00hb7q9uJUjUs9NdjDtYc\n vYkg==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ9Q1R+2D59TJNUuRnUk1x/P6s/veu8JTxzVWxLq0MvpS/a2yXYHqQyyG18btRwfVtR0mEwUWeA=@lists.denx.de", "X-Gm-Message-State": "AOJu0YzdIyksUJXnQN7S6ghOCJPd+DyKNhRKYkQwB5dgIE/k+vEqEqDs\n ZBQEQkM7fQJUlV0lufMiY/3JsgqHvAdeDQYP8b4tWc8yVa9CePH1gRCeMkmxIlkzsho=", "X-Gm-Gg": "AeBDietz+VPqo11uLf0XySws2445c6+v7j6RGHKxBIuCa8D6a9WepbfcfcVqXHGlMbm\n 02UWqxyPJsKkduzj/wOhlAxdB/uP+Bq/S+upW3BX/a3GCnNvf7Kel4zomWZEqdGBgVDIwHn2tON\n CaGENvs2YVhMErX1zxbepSe7kF3vh9p/g11972/ZgGqu0Xf6xsSj9CenLPr6cqi5mjYFul4dsPu\n sG8630SIxESH5UqF5b8NQYoXQVDmcwPmBO2ysi43hv9FGVBS9SPunpOWkg1NWW1TOrnX7luJK+r\n /obmF/xEmekyaqi85LtEyl1998+MQym74xTUpSfJxADMThmgaiIv5CM2uwEqfXs5I3FqEYTyk8d\n bNcsp5p6gmgc+q492IFlYGyDtbAVvo0BPZpQArVQZSBdlMalnoTqk5bQ2gM3ngxBF4W7zuXTpay\n 7QpQQWy4y7jh3KcQqqPjy272EAV0VZHZDE9x7bYrNkgxw+8GFxymTXHjYfbAxCnE9IuTGAqKHmb\n aJYyk753OWf6A==", "X-Received": "by 2002:a05:6300:7102:b0:39f:a42:9247 with SMTP id\n adf61e73a8af0-39fe3f5bf14mr20519408637.37.1776332406406;\n Thu, 16 Apr 2026 02:40:06 -0700 (PDT)", "From": "Daniel Palmer <daniel@thingy.jp>", "To": "visitorckw@gmail.com,\n\tangelo@kernel-space.org,\n\tbmeng.cn@gmail.com", "Cc": "sjg@chromium.org, u-boot@lists.denx.de, Daniel Palmer <daniel@thingy.jp>", "Subject": "[PATCH v5 4/8] m68k: Fix writew(), writel(), readw(),\n readl() endianness for classic m68k", "Date": "Thu, 16 Apr 2026 18:39:23 +0900", "Message-ID": "<20260416093927.602613-5-daniel@thingy.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260416093927.602613-1-daniel@thingy.jp>", "References": "<20260416093927.602613-1-daniel@thingy.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In Linux these are meant to read a little-endian value and swap\nto the CPU endian.\n\nIn u-boot for m68k this is currently broken and prevents\nvirtio-mmio from functioning.\n\nThis change is only for classic m68k. Coldfire has read big-endian,\nno swap for these in u-boot and Linux and existing drivers probably\ndepend on this.\n\nTested-by: Angelo Dureghello <angelo@kernel-space.org>\nReviewed-by: Simon Glass <sjg@chromium.org>\nAcked-by: Kuan-Wei Chiu <visitorckw@gmail.com>\nAcked-by: Angelo Dureghello <angelo@kernel-space.org>\nSigned-off-by: Daniel Palmer <daniel@thingy.jp>\n---\n arch/m68k/include/asm/io.h | 31 ++++++++++++++++++++-----------\n 1 file changed, 20 insertions(+), 11 deletions(-)", "diff": "diff --git a/arch/m68k/include/asm/io.h b/arch/m68k/include/asm/io.h\nindex 35ad4a1c0444..2577081d8363 100644\n--- a/arch/m68k/include/asm/io.h\n+++ b/arch/m68k/include/asm/io.h\n@@ -23,18 +23,27 @@\n #define __raw_writew(w,addr) ((*(volatile u16 *) (addr)) = (w))\n #define __raw_writel(l,addr) ((*(volatile u32 *) (addr)) = (l))\n \n-#define readb(addr)\t\tin_8((volatile u8 *)(addr))\n-#define writeb(b,addr)\t\tout_8((volatile u8 *)(addr), (b))\n-#if !defined(__BIG_ENDIAN)\n-#define readw(addr)\t\t(*(volatile u16 *) (addr))\n-#define readl(addr)\t\t(*(volatile u32 *) (addr))\n-#define writew(b,addr)\t\t((*(volatile u16 *) (addr)) = (b))\n-#define writel(b,addr)\t\t((*(volatile u32 *) (addr)) = (b))\n+#define readb(addr)\tin_8((volatile u8 *)(addr))\n+#define writeb(b, addr)\tout_8((volatile u8 *)(addr), (b))\n+#ifdef CONFIG_M680x0\n+/*\n+ * For classic m68k these work the same way as Linux:\n+ * Read a little endian value, swap to the CPU endian.\n+ */\n+#define readw(addr)\tin_le16((volatile u16 *)(addr))\n+#define readl(addr)\tin_le32((volatile u32 *)(addr))\n+#define writew(b, addr)\tout_le16((volatile u16 *)(addr), (b))\n+#define writel(b, addr)\tout_le32((volatile u32 *)(addr), (b))\n #else\n-#define readw(addr)\t\tin_be16((volatile u16 *)(addr))\n-#define readl(addr)\t\tin_be32((volatile u32 *)(addr))\n-#define writew(b,addr)\t\tout_be16((volatile u16 *)(addr),(b))\n-#define writel(b,addr)\t\tout_be32((volatile u32 *)(addr),(b))\n+/*\n+ * For coldfire these read a big endian value and use it\n+ * as-is. This means that for little endian devices on the\n+ * bus like PCI device these won't work as expected currently.\n+ */\n+#define readw(addr)\tin_be16((volatile u16 *)(addr))\n+#define readl(addr)\tin_be32((volatile u32 *)(addr))\n+#define writew(b, addr)\tout_be16((volatile u16 *)(addr), (b))\n+#define writel(b, addr)\tout_be32((volatile u32 *)(addr), (b))\n #endif\n \n /*\n", "prefixes": [ "v5", "4/8" ] }