Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223539/?format=api
{ "id": 2223539, "url": "http://patchwork.ozlabs.org/api/patches/2223539/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-7-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260415142841.3222399-7-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-04-15T14:28:41", "name": "[iwl-net,v3,6/6] ixgbe: fix integer overflow and wrong bit position in ixgbe_validate_rtr()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "0043c5c0c2387ac6b67c07ae48adbf208e6a7bd5", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Aleksandr Loktionov", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-7-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499995, "url": "http://patchwork.ozlabs.org/api/series/499995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499995", "date": "2026-04-15T14:28:35", "name": "ixgbe: six bug fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499995/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223539/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223539/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=0jZvNNfC;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwk6L0TB8z1yHc\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 00:28:58 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 841DB6F74D;\n\tWed, 15 Apr 2026 14:28:56 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hBoTrrce-4SJ; Wed, 15 Apr 2026 14:28:55 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 04BA66F753;\n\tWed, 15 Apr 2026 14:28:55 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 5F570375\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 4E82685476\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:54 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id yuVAl-ppuZ-B for <intel-wired-lan@lists.osuosl.org>;\n Wed, 15 Apr 2026 14:28:53 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 75BF585479\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:53 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 07:28:53 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa003.jf.intel.com with ESMTP; 15 Apr 2026 07:28:52 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 04BA66F753", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 75BF585479" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776263335;\n\tbh=it6igKY4qrJSpTkvyk0lUrw+wOK84Nrlw0QVHK9iASU=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=0jZvNNfCLhkpU+R1jvDBhCFSkDzFYuNHSY16I5+2T34YcSacUmDRfN1iyhApTFLXw\n\t 3wJUGiBU8Ipph/IYRsCFGBLqZMAI2wha7Y0krjXnqdEAtKEaPlCgLac4Dc+ypOih5Q\n\t syg8+Cv7M4abmAw3Q9xuh8XqawPpFix9PqT47PlaV0z+2VlLzjutV+78f9ncVkchsq\n\t 0Jv8PGpjdI44JRBLMwyE98/O39nPXwnz/8QEWys4MKuGLAWV7u1lJ9x3vIFzkiXsbc\n\t NrTbm+ZkEu6yjXlcwAK6s0N5DC5Sh8Z4Y6QH71xVvGHSvJte8uj7zJE9HCzxiWxOov\n\t pWodpeeVK/mTQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 75BF585479", "X-CSE-ConnectionGUID": [ "xkO6mPoqQZWE+juOq0ESXw==", "kgdYO5kKSESFmxxGDfIxZA==" ], "X-CSE-MsgGUID": [ "0tdYNp1/QneG/Ov1v7YKxw==", "jS2xfbJPRre/Vr72p4wZYA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11760\"; a=\"77423750\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77423750\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"234467899\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tSimon Horman <horms@kernel.org>", "Date": "Wed, 15 Apr 2026 16:28:41 +0200", "Message-ID": "<20260415142841.3222399-7-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260415142841.3222399-1-aleksandr.loktionov@intel.com>", "References": "<20260415142841.3222399-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776263333; x=1807799333;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=G7MmTf1h+5LioLTjjvjCKQN7jxTwWDeJLS/XSkZaGHM=;\n b=fl5Hybet6jl4TUbG1pG4jkV6NzpjT/xeaO+qumu8kvaoguxHnjwZntpU\n D5gXhWbG6HqoCljXjKy5f8yisKDoWYBANRfysjLeIILehSM0MngDmeJ0v\n LaLtFdEZ4+FuzggDtmy+hS7240DZvjphwEQTqBNSpZv9NqzAVrxpxXN7y\n lHEr1wKnB1m+8H7bqGcvk6K6rbLXmeMjOfq6NpizcmcwJafr9IBUXrORE\n D3VwIaE8Qk0wL5LI4/QpxyRHp0o4YCQHCZKbNt8IxVKhMMoirIi+sbEqA\n 0l5Y5xCVjEIUWyeF5444CDQTnkv0z3ovE2gdppMlfHqnj7ZpmkYgE7u2r\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=fl5Hybet" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v3 6/6] ixgbe: fix integer\n overflow and wrong bit position in ixgbe_validate_rtr()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Two bugs in the same loop in ixgbe_validate_rtr():\n\n1. The 3-bit traffic-class field was extracted by shifting a u32 and\n assigning the result directly to a u8. For user priority 0 this is\n harmless; for UP[5..7] the shift leaves bits [15..21] in the u32\n which are then silently truncated when stored in u8. Mask with\n IXGBE_RTRUP2TC_UP_MASK before the assignment so only the intended\n 3 bits are kept.\n\n2. When clearing an out-of-bounds entry the mask was always shifted by\n the fixed constant IXGBE_RTRUP2TC_UP_SHIFT (== 3), regardless of\n which loop iteration was being processed. This means only UP1 (bit\n position 3) was ever cleared; UP0,2..7 (positions 0, 6, 9, ..., 21)\n were left unreset, so invalid TC mappings persisted in hardware and\n could mis-steer received packets to the wrong traffic class.\n Use i * IXGBE_RTRUP2TC_UP_SHIFT to target the correct 3-bit field\n for each iteration.\n\nSwap the operand order in the mask expression to place the constant\non the right per kernel coding style (noted by David Laight).\n\nFixes: 8b1c0b24d9af (\"ixgbe: configure minimal packet buffers to support TC\")\nCc: stable@vger.kernel.org\nReviewed-by: Simon Horman <horms@kernel.org>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nv2 -> v3:\n - Correct Fixes: tag to 8b1c0b24d9af (\"ixgbe: configure minimal packet\n buffers to support TC\") -- the previously used e7589eab9291 predates\n the buggy code path (Simon Horman); add Reviewed-by: Simon Horman.\n\nv1 -> v2:\n - Add Fixes: tag; reroute to iwl-net (wrong bit positions cause packet\n mis-steering); swap to (reg >> ...) & MASK operand order per David\n Laight.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 210c7b9..c9e4f12 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9772,11 +9772,12 @@ static void ixgbe_validate_rtr(struct ixgbe_adapter *adapter, u8 tc)\n \trsave = reg;\n \n \tfor (i = 0; i < MAX_TRAFFIC_CLASS; i++) {\n-\t\tu8 up2tc = reg >> (i * IXGBE_RTRUP2TC_UP_SHIFT);\n+\t\tu8 up2tc = (reg >> (i * IXGBE_RTRUP2TC_UP_SHIFT)) &\n+\t\t\t IXGBE_RTRUP2TC_UP_MASK;\n \n \t\t/* If up2tc is out of bounds default to zero */\n \t\tif (up2tc > tc)\n-\t\t\treg &= ~(0x7 << IXGBE_RTRUP2TC_UP_SHIFT);\n+\t\t\treg &= ~(IXGBE_RTRUP2TC_UP_MASK << (i * IXGBE_RTRUP2TC_UP_SHIFT));\n \t}\n \n \tif (reg != rsave)\n", "prefixes": [ "iwl-net", "v3", "6/6" ] }