Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223538/?format=api
{ "id": 2223538, "url": "http://patchwork.ozlabs.org/api/patches/2223538/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-5-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260415142841.3222399-5-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-04-15T14:28:39", "name": "[iwl-net,v3,4/6] ixgbe: fix cls_u32 nexthdr path returning success when no entry installed", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "c94bb66d093edeca1618ff0bfb024ffb34db1719", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Aleksandr Loktionov", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-5-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499995, "url": "http://patchwork.ozlabs.org/api/series/499995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499995", "date": "2026-04-15T14:28:35", "name": "ixgbe: six bug fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499995/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223538/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=8wC3Wexd;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwk6K0MbVz1yHc\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 00:28:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id CE8884B08F;\n\tWed, 15 Apr 2026 14:28:53 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id a_0oq9ZBiD80; Wed, 15 Apr 2026 14:28:53 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 561214B2D7;\n\tWed, 15 Apr 2026 14:28:53 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 3BA3E283\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 21E5E825C3\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:52 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tP4tzEwKOlYw for <intel-wired-lan@lists.osuosl.org>;\n Wed, 15 Apr 2026 14:28:51 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 119B085475\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:50 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 07:28:50 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa003.jf.intel.com with ESMTP; 15 Apr 2026 07:28:48 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 561214B2D7", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 119B085475" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776263333;\n\tbh=/m6WWzlcLK2jIquH1fBIuBKUUcfgnJ5EDwGzGSrPaig=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=8wC3WexdmcGdM8UBu0AzNEgGWej//QJI+9aJHh6V2rIzpugCt4QkEqYDm76TlDgP+\n\t ueeqty94dCqJMvpfLDPSn3ao0du2i2ymyN81n51BIQDPB45JaKSTQungVx7ikEF+6r\n\t RnaYkb+0EWepCYF2pKH3Eo9YddJI+/gMJpGemWpADTMrB1aYE374sq97A6825NgWNX\n\t fTutWtoCEz7ZbM74OEIXCO6OXqSt/kJrhv+zBqhxjyGZ2IikwooFLf/zUn7P1o1JwN\n\t 4sA0jd7BPE8xXs+RogyqQE3kCN2ov/+97sF3k05R2u1/rXY3sjcOF7mJ6Y5juj3kkp\n\t BotxYEIVfnJXQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 119B085475", "X-CSE-ConnectionGUID": [ "SypIIIEiRY+OSNJJnm860Q==", "y/EfwaZqQfWVh46NKVJarA==" ], "X-CSE-MsgGUID": [ "45EdJcHMRNWpOJRfb0gOPQ==", "qp8XxpSnSuGFks2ZaAeTHA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11760\"; a=\"77423743\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77423743\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"234467873\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,\n Marcin Szycik <marcin.szycik@linux.intel.com>", "Date": "Wed, 15 Apr 2026 16:28:39 +0200", "Message-ID": "<20260415142841.3222399-5-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260415142841.3222399-1-aleksandr.loktionov@intel.com>", "References": "<20260415142841.3222399-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776263331; x=1807799331;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=UPq6I5ywuqsWlMV/CExGXVtW7/DyZKY/nvZFhIfzgBM=;\n b=iHlQJ3lpk+Soo9uJBQhPyL6f+MAGM7HvHd5F3g82p0wQROFseT1Ft9JG\n Uy6ihuCG4QKux3YwHxN7LOPYNZ1LV6FX1ImfdqXUBoRxTDBXjpq5evQHS\n 4ZRzckHrKlyI+yO25WuqBdQU0Ui4zKjw35ZsjgYDOEZPw+1pvvB2KinZs\n IZOPKqNmehaTA8RoATXnEHJGWmCvnvCdzapdEhOzg2HkUgVUSHyUshQwO\n i0HmW7R5enEPsPTPh8zNylj2lmTGYTB6MxfoMtngurbmWMxIhZJ84Qbgj\n 6H6uZc2vtlDJJijZtxHy1DwaNt6W+rfqYF6a/pGf6tUI3iU6Z8iuQvg4f\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=iHlQJ3lp" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v3 4/6] ixgbe: fix cls_u32 nexthdr\n path returning success when no entry installed", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ixgbe_configure_clsu32() returns 0 (success) after the nexthdr loop\neven when ixgbe_clsu32_build_input() fails for every candidate entry\nand no jump-table slot is actually programmed. Callers that test the\nreturn value would then falsely believe the filter was installed.\n\nThe variable 'err' already tracks the last ixgbe_clsu32_build_input()\nreturn value; if the loop completes with a successful break, err is 0.\nIf all attempts failed, err holds the last failure code. Change the\nunconditional 'return 0' to 'return err' so errors are propagated\ncorrectly.\n\nFixes: 1cdaaf5405ba (\"ixgbe: Match on multiple headers for cls_u32 offloads\")\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nCc: stable@vger.kernel.org\nReviewed-by: Simon Horman <horms@kernel.org>\nReviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>\n---\nv2 -> v3:\n - Add Reviewed-by: Simon Horman; no code change.\n\nv1 -> v2:\n - Add Fixes: tag; reroute from iwl-next to iwl-net (false-success\n return is a user-visible correctness bug, not a cleanup).\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 210c7b9..6e7f8a9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -10311,7 +10311,7 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter,\n \t\t\t\tkfree(jump);\n \t\t\t}\n \t\t}\n-\t\treturn 0;\n+\t\treturn err;\n \t}\n \n \tinput = kzalloc_obj(*input);\n", "prefixes": [ "iwl-net", "v3", "4/6" ] }