Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223537/?format=api
{ "id": 2223537, "url": "http://patchwork.ozlabs.org/api/patches/2223537/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-4-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260415142841.3222399-4-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-04-15T14:28:38", "name": "[iwl-net,v3,3/6] ixgbe: call ixgbe_setup_fc() before fc_enable() after NVM update", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "2fd536a889023d4e167ae81c8790f64ceaf8532d", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Aleksandr Loktionov", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260415142841.3222399-4-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 499995, "url": "http://patchwork.ozlabs.org/api/series/499995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499995", "date": "2026-04-15T14:28:35", "name": "ixgbe: six bug fixes", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499995/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223537/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223537/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Pe8RNwIT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwk6H4tgFz1yHc\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 16 Apr 2026 00:28:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 81E738547A;\n\tWed, 15 Apr 2026 14:28:53 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2E2N68K3N7Rb; Wed, 15 Apr 2026 14:28:52 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id BED6885475;\n\tWed, 15 Apr 2026 14:28:52 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 111AE375\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id F303285475\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:49 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id lSK_9kYaxotX for <intel-wired-lan@lists.osuosl.org>;\n Wed, 15 Apr 2026 14:28:49 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 00A7085476\n for <intel-wired-lan@lists.osuosl.org>; Wed, 15 Apr 2026 14:28:48 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Apr 2026 07:28:48 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa003.jf.intel.com with ESMTP; 15 Apr 2026 07:28:47 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org BED6885475", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 00A7085476" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776263332;\n\tbh=pxj7Qwt60KGAtfFfKHYnQEoASeCXoLziv0VtzU/+0sc=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Pe8RNwITcjLMlj1TDDPLMF5bDL05NwI7r967pAEBlquV5SSvE8p57Jcvf2aPpZULH\n\t MEFBe+ZliQXaNF2CE4AH9Iu3cQaq/c50Nw/0OCsBFtNMtcaaqx21xODgs+5WVrBkb9\n\t GciPWBczm78fMZmDLtEtwkB64IG5rYpzfEVLdZdhAJ6yyMwVXSPRJsUHTam6MQgcWy\n\t kmDg+xS/hdDruVQBADlvF7i4rQabzxCMI9+L3157Oig8sotVXifGwuYjTX9GACg3k3\n\t VZfaFbydJ3hBqCmqSTJckrgVab0xoQH5zmyqN+znIGHz8tlOFTC1T4lG740Q0w5EA/\n\t pj92YU/P1Xfig==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 00A7085476", "X-CSE-ConnectionGUID": [ "uFR6w5AiSY+JU3IxZ20FSQ==", "hEZbVS5VQyS9lDfZNZSLpQ==" ], "X-CSE-MsgGUID": [ "tM5Md4u1QMqGm+ua/YjVCA==", "DCC3lyWYQqqoOGpiW8fkbQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11760\"; a=\"77423739\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77423739\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"234467859\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org", "Date": "Wed, 15 Apr 2026 16:28:38 +0200", "Message-ID": "<20260415142841.3222399-4-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260415142841.3222399-1-aleksandr.loktionov@intel.com>", "References": "<20260415142841.3222399-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776263329; x=1807799329;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=TGdgV50bxeF5VneOtp3k0+KNHoKWBcOE5NH18XEnokc=;\n b=CO4VJZbolJy7MxG9ZEF7JVdtMMn2HwA5kpUKXE8t7zUai+b3hFHaSn9E\n 4kAc2k3lP09wysux5p6tb51WjlQdGTG6PS0aqB7ICYd+532HsOc8LaPtR\n jnr0AVOT4jb0wKdySIVsjy15cXV4vin/72jMXZ/AsfzYN0Zp4FRbIkmnD\n VHhWJWgR3M8DEw8eP+ZEepfiiHaVNqnGls/51RAF+N5DOyr5rCURhzixb\n vp7HqGb0oBsRXj9N+Lt/922YVXQVb/0ZY0kgiN8Ay5x4IUl1QwpKBFhOf\n OIFVxuT9SC05gkC+PMmoH0uK3vk4MBd/Ik/VX2sc55ejZ9KJu/BJGlflo\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=CO4VJZbo" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v3 3/6] ixgbe: call\n ixgbe_setup_fc() before fc_enable() after NVM update", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "During an NVM update the PHY reset clears the Technology Ability Field\n(IEEE 802.3 clause 37 register 7.10) back to hardware defaults. When\nthe driver subsequently calls only hw->mac.ops.fc_enable() the SRRCTL\nregister is recalculated from stale autonegotiated capability bits,\nwhich the MDD (Malicious Driver Detect) logic treats as an invalid\nchange and halts traffic on the PF.\n\nFix by calling ixgbe_setup_fc() immediately before fc_enable() in\nixgbe_watchdog_update_link() so that flow-control autoneg and the PHY\nregisters are re-programmed in the correct order after any reset.\n\nSkip setup_fc() on backplane links: on 82599 backplane interfaces\nsetup_fc() resolves to prot_autoc_write() ->\nixgbe_reset_pipeline_82599() which toggles IXGBE_AUTOC_AN_RESTART.\nCalling it unconditionally on link-up creates an infinite link-flap\nloop because each AN-restart triggers another link-up event. Guard\nwith a get_media_type() check and skip setup_fc() when the media type\nis ixgbe_media_type_backplane; fc_enable() is still called.\n\nAlso handle the failure path: if setup_fc() returns an error its output\nis invalid and calling fc_enable() on the unchanged hardware state would\nrepeat the exact MDD-triggering condition the fix is meant to prevent.\nSkip fc_enable() in that case while still calling\nixgbe_set_rx_drop_en() which configures the independent RX-drop\nbehaviour.\n\nFixes: 93c52dd0033b (\"ixgbe: Merge watchdog functionality into service task\")\nSuggested-by: Radoslaw Tyl <radoslawx.tyl@intel.com>\nCc: stable@vger.kernel.org\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nv2 -> v3:\n - Skip setup_fc() for ixgbe_media_type_backplane: unconditional call on\n 82599 backplane links triggers prot_autoc_write() ->\n ixgbe_reset_pipeline_82599() -> IXGBE_AUTOC_AN_RESTART, causing an\n infinite link-flap loop (Simon Horman).\n\nv1 -> v2:\n - Add Fixes: tag; reroute to iwl-net; handle setup_fc() failure by\n skipping fc_enable() so stale FC state is never committed to hardware.\n\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 210c7b9..fc3bae9 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8029,6 +8029,18 @@ static void ixgbe_watchdog_update_link(struct ixgbe_adapter *adapter)\n \t\tpfc_en |= !!(adapter->ixgbe_ieee_pfc->pfc_en);\n \n \tif (link_up && !((adapter->flags & IXGBE_FLAG_DCB_ENABLED) && pfc_en)) {\n-\t\thw->mac.ops.fc_enable(hw);\n+\t\t/* Skip setup_fc() on backplane links: it resolves to\n+\t\t * prot_autoc_write() -> ixgbe_reset_pipeline_82599() and\n+\t\t * toggles IXGBE_AUTOC_AN_RESTART, causing infinite link-flap\n+\t\t * on 82599 backplane interfaces.\n+\t\t * If setup_fc() fails its output is invalid; skip fc_enable()\n+\t\t * to avoid committing stale capability bits that trigger MDD.\n+\t\t */\n+\t\tif (hw->mac.ops.setup_fc &&\n+\t\t hw->mac.ops.get_media_type(hw) != ixgbe_media_type_backplane &&\n+\t\t hw->mac.ops.setup_fc(hw))\n+\t\t\te_warn(drv, \"setup_fc failed, skipping fc_enable\\n\");\n+\t\telse\n+\t\t\thw->mac.ops.fc_enable(hw);\n \t\tixgbe_set_rx_drop_en(adapter);\n \t}\n", "prefixes": [ "iwl-net", "v3", "3/6" ] }