Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223144/?format=api
{ "id": 2223144, "url": "http://patchwork.ozlabs.org/api/patches/2223144/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260414141514.1341429-5-den@valinux.co.jp/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260414141514.1341429-5-den@valinux.co.jp>", "list_archive_url": null, "date": "2026-04-14T14:15:11", "name": "[v14,4/7] PCI: endpoint: pci-ep-msi: Refactor doorbell allocation for new backends", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1b9fd919eca1cdbf6ee4a0f7bf0bda69d536a286", "submitter": { "id": 91573, "url": "http://patchwork.ozlabs.org/api/people/91573/?format=api", "name": "Koichiro Den", "email": "den@valinux.co.jp" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260414141514.1341429-5-den@valinux.co.jp/mbox/", "series": [ { "id": 499855, "url": "http://patchwork.ozlabs.org/api/series/499855/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=499855", "date": "2026-04-14T14:15:08", "name": "PCI: endpoint: pci-ep-msi: Add embedded doorbell fallback", "version": 14, "mbox": "http://patchwork.ozlabs.org/series/499855/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223144/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-52497-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.a=rsa-sha256 header.s=selector1 header.b=AFGZHpdl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52497-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.b=\"AFGZHpdl\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.228.133", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=valinux.co.jp", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=valinux.co.jp", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=valinux.co.jp;" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw5wq0Yvvz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 00:18:35 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 5C41D301BD98\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 14:16:57 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5415F3E8C6F;\n\tTue, 14 Apr 2026 14:16:36 +0000 (UTC)", "from OS0P286CU011.outbound.protection.outlook.com\n (mail-japanwestazon11020133.outbound.protection.outlook.com [52.101.228.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B6A373E8C4B;\n\tTue, 14 Apr 2026 14:16:34 +0000 (UTC)", "from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10)\n by TY3P286MB2529.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:222::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 14:16:25 +0000", "from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 14:16:25 +0000" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776176196; cv=fail;\n b=pfwbLWDk6MqeOR60vO6rKAPzIrrjOdspv6ajmJ30KUpzlDxgXrRxCJ+8sK29h8DOry7PO4I1CSLueuAgPT38MCWD+pwzvzkw18esJseR59Qt6Ah+gwXqdS1HI5XGwtBCKDZUzBgU6IKElLqBmNrUtEE6OdMbEq5UECklJ/jZPwM=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=dgUHGYF8qN6gcRG3ulI3xRUepHbt4x8KQKRobTL/bEtivvD0UhlytCJFPvUsFJBzziP2iFN2LjgP0eMk0HlYN5qMSPw8BZ04NeXkac9VZtFrjShQQP6iutr0T8ulghhoCrjNZ7gSbKgkUy+WLU2H6QvK19RzL/z6AK4b86LI04MUclXlpYc/xxyE7J7SnyHTBFdyOCD8eaVq+aLRm18KtzZNjEfLD1SkQJlQ/UVOV0evcgpuDXcZWEq+t9NQW4wvJECYAn26pqUkmEG2sQSxUeKZc3E9Jbrr5c9s6bDdPkcbZismWh1V1nH8H2wgbb5y72T5VcsA7nlt6j6Jquclew==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776176196; c=relaxed/simple;\n\tbh=24CtTktMCrTYnhJKM0CPxo89ofgYKr4aiWJjFoL6RkY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=EFE565v+hhW8Ht1kp40TGI20ODcA/eXWxpCsRq4Tk6lWfYCfGP8m6dx3v9T3Q6zEvMb5dmE67VkBFUxrM+wGAWLETfT2lrLx4PDa5B7nIHhOqDI5apaq31bDhFvAZUpOHjkkAII9gjFlmFON2vCu4dbyt/ITtHlqEnbxMvY8oL4=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=r7RiGuw4rdIqME4X0uRgpKq66eSKksk/+mPslKC5zL4=;\n b=iBwnFBLjmHQ+mo8+LWa6LKcfGREZj93tyj8JtHDQN3JaHPrbY6C79OI++U9mTxSeNQJc2UW/JU7U41fLOGY2z9W3vjWdwERT468dMWuTKbBk+j7KSC3vZ+QOrouz2JMz9FlkKM8HxByhgmCsVz9z3oLP8VHfbCmVcSFRKjH7Usz6F5XAXWkYhaJiRUPKXGpG4NJPsXWhbaGQ47IWbayMJCsBHcJtAt1RDNcxx9IXkKU0lz7fx2W5vXj8j4zPIN0lA4/vJgAAKV1UPqm5FJyeMDhokYp8BpnQvdYMgNAXDMnpDJibVcW9F2fF1cEc78K0qZjaIkj3vLdC3YXlhPlAeQ==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=valinux.co.jp;\n spf=pass smtp.mailfrom=valinux.co.jp;\n dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.b=AFGZHpdl; arc=fail smtp.client-ip=52.101.228.133", "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=valinux.co.jp; dmarc=pass action=none\n header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=r7RiGuw4rdIqME4X0uRgpKq66eSKksk/+mPslKC5zL4=;\n b=AFGZHpdlGVMNlSnsqrc1SRA6Y/K3JNqJf/tfK9C9+Ubl0VLzxNXjq6Umc9zZazTt7bJZy/2Rmcj1SIjoflDVkS8PanB65qARjdZEfOHWo/bd2sd7mZH2YJsUFKxL2B3/mAtwAe6An6FwuuNBvYj7VYmingnS8WvRu1SVOrA4VMM=", "From": "Koichiro Den <den@valinux.co.jp>", "To": "Jingoo Han <jingoohan1@gmail.com>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kwilczynski@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>,\n Kishon Vijay Abraham I <kishon@kernel.org>, Jon Mason <jdmason@kudzu.us>,\n Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,\n Niklas Cassel <cassel@kernel.org>, Frank Li <Frank.Li@nxp.com>,\n Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,\n Manikanta Maddireddy <mmaddireddy@nvidia.com>", "Cc": "linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tntb@lists.linux.dev", "Subject": "[PATCH v14 4/7] PCI: endpoint: pci-ep-msi: Refactor doorbell\n allocation for new backends", "Date": "Tue, 14 Apr 2026 23:15:11 +0900", "Message-ID": "<20260414141514.1341429-5-den@valinux.co.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260414141514.1341429-1-den@valinux.co.jp>", "References": "<20260414141514.1341429-1-den@valinux.co.jp>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "TYCP286CA0172.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:400:3c6::10) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:38f::10)", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "TY7P286MB7722:EE_|TY3P286MB2529:EE_", "X-MS-Office365-Filtering-Correlation-Id": "2005e12d-93c3-4da2-38ce-08de9a3069c4", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|10070799003|7416014|376014|366016|1800799024|921020|56012099003|22082099003|18002099003;", "X-Microsoft-Antispam-Message-Info": "\n\tiobLWUgKiN2k4CKxymf5vM9RdUBXB6RClTeLMD+oYdLHihSoEdHHg+8e6eX583xM4qBKLZUZidUGhE4aahu0ojtTiRFytN6Ys6E7tSqCDawVmXICdOdP9vyUXlvIBhECH09HQcQLcP+aQpdKrj3Jnl0XAVVTFgRdjiGshCkPLsiYef6POT+Qah7UKqRD0TVpf35LRvEF/Xp83PZjlzjscjMgNKRmgHuaI4Hgwg/iYZkDhr3moAB62kHq8NFK3NhN6GS6ofexTi1Xx/hH1SbBnBOZyGqBm/R25ogPeU/ZpWYfZk9k1XXcdfLhFLeXZMMrtfg15vVsahgbQvNl7uP9kFmcmxUoiZ8yHbgn3UUexvh4CCs7xBrq9mAwbwxwM8vx0S5kiF62tIeR3BNNq/L0SkpygqkqiNwmjhnZhKd6B7i11apAcoauMaWgyudfpmu0L+iqNNEai3N/F0XErF7lvzu21al1LcVaYd3qtk1R6laI20wNsRRsDmtnYKn6BhEjqRukGTkH4MrYNNpbHUbsbAvrXDaInY74/kx/9kcZul7ae5Ya9pQ4Vy1vtQcP9LqCcZq+Vl1NfvD+0Z/Mnl/HDamY3jOzmOITJbMDjQCASKgJR+ZN3gQUvjR92zmaic7KM1GjciAccr+U7/NeLH9KxolMNz8PaTx+e4A6x4M3kgHf0MyfZ/Fvdz5eB1b4G3AFMezchBYYyhQ83uu6N3MFylLtlEnF/vbeOXdipO0A1Q8zDR9MqhgKax5RqG70lMAM1K7yk7E40c3EseetMu46ag==", "X-Forefront-Antispam-Report": "\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(7416014)(376014)(366016)(1800799024)(921020)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n yn0G7TPTOH55WqEXVlZNT3HtCk+x9EgmfPrihYPWFF7G0HokN9RFr7Nodye8L56g6ArqNHaoM41zdHGYQ6I0L1BlNct84/SXz6GX4MgmX/4kJqS6lG0EZn66se8DuJZMYDMzoHAOurnBHo4SU1CsV3zUpegjJZTb2C+i7Gnd1XW684EpSyL8/UrCemI2rfu0YqirFiPbt+y+vc3ziuQYFSCUjXOrkOLhr9avUTdNJ3DareLXoZZEs71BrR90YXwMFUjhx0iFBAoKxrFy0+cGEwyct+sjWXE4UG7K1F6+wv3ej2JqhKNaLqe2x0DZeNHSVSA+SuksClz2bOGySA64nBQUJMWMlZPwb+zohyz3ElQKzrZSSYvspBqrT3kMa1Z0auGJztT15dKOpKrqMcdx78NHuDInxO6pX02R5TCtVNUN6ua4l2h7lD2sFP1GsHZk9S2UEeesfnunt8aN0MsVMHqpY5EcT0tFdeO0zq57uh0Xp+3jYT0uoWEmMax2gLe8C77KOsFJWjpwQ4fvDUu9r/OK/Y93xwW/dlcVRswq9IzSmyzvhdR9qbKmyc2a/8mSIz7ZFVFWKzwVvTEM5GqGGkLdFZdl7cWic6nYN2ZjmQwCa4Ro9mFoBER/3zGCC1lfdYt1/Esg85zCZBStsUi0yj6tbEMWQ6ACo1aQ3B2NnHWtuohCuf021wPFw/pmIDOHTPn4OCe/KshoVPnMyet1vqKtF2aPYB39ZBwR02dU1qFTqiHpmmzPF9OLS3IyTD5MhFcyTcz3c+LzDdWl3SdslcrStBox6wUK2M5HPClUMJH+FCRAJJeJvc6dG1IzeSCED51afR8pmDWFMKYJ/SCvVtSF3/npWrJAZj9Nkg0jDMWzItXaBg5cRkzVlvSbDtG5/ZnjoJ1tFzIiTbMSLpmINhAUcns0tOaWBuo2a0eWNoHrf40KKEFc5NfxdqJrxrMDsW1bDtMTHLoArFKC9dtnJup14g1G5mfW8IJ58Fs+4Ecyk+gqIhfcdAGHvBdcgpQvYcvOT1gpDudLsBigkpxsssw6VbXRoA/WrFTBHo9BxnrFzwd/JORGwSisYFlPclVH0JlgdcdokLhT+Q6Pjejxn1G/zq84OVzOaoFjk0Qfa0GsHyNIf7E8k+zHy/OZcFYfWoucO5M9XfOf7KWqUXihiQDOrsCGWEA5OpR/uB9FBly528Qu+LX4k0Xx3EjhdpKezwfO8SebaBCvcbNu8ZUkO8ZnIDfM0GlvX6zMz/H0jekWY1Gu7+FnxB61z2/ZUfTmWRC+TI9D0PENFGap8M8Qjvn2T99EoyLZMpQGZ6tUZaVKEpYgZVJrZlWNG84RpRnXbJ5q+HnQZTCe7nTcYajg1c1KrYZvD23uJiFh6Pkqait3VE3/NhJSOvYJ3+eicF4/9aI/J3dQ7sVGAQdCTXbgUsc8LMK/MnFcGhuXWRCBC3WMIBiajrWqj5Vkw50y7nU2Lw+TMWFquoZ+DsC7tBbpdiFsTjNbdjgTCndYEb9lGUAUexpPzlc6dzkYzasxQyj9zD56iYDeCqIEYW197XsoS9zTdjMm7W78jn2PVZnbzQ+u1jTrXfful8u1FzjTjo2ap9/WBCBibnVR+ku/jyReI6W7CzA4AES8FhSyB8G2azGIZx3O2cd2Sedj7HSZVJkV9S5ofQcA2TO0YZrAOlEAY0Vf6By9XoDjPzg+CEcL8FzE+9wV/PFP1PRa4WQjJrwu3AplTaq0R1CpU/CKfDu1d3n69XseydEHcZYSBNWx0AfwPBWnBAJ4jZxoYaLcIN16", "X-OriginatorOrg": "valinux.co.jp", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2005e12d-93c3-4da2-38ce-08de9a3069c4", "X-MS-Exchange-CrossTenant-AuthSource": "TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "14 Apr 2026 14:16:25.7142\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "7a57bee8-f73d-4c5f-a4f7-d72c91c8c111", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n DAm6afpjMwkxr+UpZdzRGeZgp67LvFeGSUtLjkYxIOixHTi+yFqB5S6crBPBGmw4MtZo/GYg7d6aXVQnLGHPUw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "TY3P286MB2529" }, "content": "Prepare pci-ep-msi for non-MSI doorbell backends.\n\nFactor MSI doorbell allocation into a helper and extend struct\npci_epf_doorbell_msg with:\n\n - irq_flags: required IRQ request flags (e.g. IRQF_SHARED for some\n backends)\n - type: doorbell backend type\n - bar/offset: pre-exposed doorbell target location, if any\n\nInitialize these fields for the existing MSI-backed doorbell\nimplementation.\n\nAlso add PCI_EPF_DOORBELL_EMBEDDED type, which is to be implemented in a\nfollow-up patch.\n\nNo functional changes.\n\nReviewed-by: Frank Li <Frank.Li@nxp.com>\nTested-by: Niklas Cassel <cassel@kernel.org>\nSigned-off-by: Koichiro Den <den@valinux.co.jp>\n---\n drivers/pci/endpoint/pci-ep-msi.c | 54 ++++++++++++++++++++++---------\n include/linux/pci-epf.h | 23 +++++++++++--\n 2 files changed, 60 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c\nindex 1395919571f8..85fe46103220 100644\n--- a/drivers/pci/endpoint/pci-ep-msi.c\n+++ b/drivers/pci/endpoint/pci-ep-msi.c\n@@ -8,6 +8,7 @@\n \n #include <linux/device.h>\n #include <linux/export.h>\n+#include <linux/interrupt.h>\n #include <linux/irqdomain.h>\n #include <linux/module.h>\n #include <linux/msi.h>\n@@ -35,23 +36,13 @@ static void pci_epf_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)\n \tpci_epc_put(epc);\n }\n \n-int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n+static int pci_epf_alloc_doorbell_msi(struct pci_epf *epf, u16 num_db)\n {\n-\tstruct pci_epc *epc = epf->epc;\n+\tstruct pci_epf_doorbell_msg *msg;\n \tstruct device *dev = &epf->dev;\n+\tstruct pci_epc *epc = epf->epc;\n \tstruct irq_domain *domain;\n-\tvoid *msg;\n-\tint ret;\n-\tint i;\n-\n-\t/* TODO: Multi-EPF support */\n-\tif (list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list) != epf) {\n-\t\tdev_err(dev, \"MSI doorbell doesn't support multiple EPF\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (epf->db_msg)\n-\t\treturn -EBUSY;\n+\tint ret, i;\n \n \tdomain = of_msi_map_get_device_domain(epc->dev.parent, 0,\n \t\t\t\t\t DOMAIN_BUS_PLATFORM_MSI);\n@@ -74,6 +65,12 @@ int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n \tif (!msg)\n \t\treturn -ENOMEM;\n \n+\tfor (i = 0; i < num_db; i++)\n+\t\tmsg[i] = (struct pci_epf_doorbell_msg) {\n+\t\t\t.type = PCI_EPF_DOORBELL_MSI,\n+\t\t\t.bar = NO_BAR,\n+\t\t};\n+\n \tepf->num_db = num_db;\n \tepf->db_msg = msg;\n \n@@ -90,13 +87,40 @@ int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n \tfor (i = 0; i < num_db; i++)\n \t\tepf->db_msg[i].virq = msi_get_virq(epc->dev.parent, i);\n \n+\treturn 0;\n+}\n+\n+int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n+{\n+\tstruct pci_epc *epc = epf->epc;\n+\tstruct device *dev = &epf->dev;\n+\tint ret;\n+\n+\t/* TODO: Multi-EPF support */\n+\tif (list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list) != epf) {\n+\t\tdev_err(dev, \"Doorbell doesn't support multiple EPF\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (epf->db_msg)\n+\t\treturn -EBUSY;\n+\n+\tret = pci_epf_alloc_doorbell_msi(epf, num_db);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tdev_err(dev, \"Failed to allocate doorbell: %d\\n\", ret);\n \treturn ret;\n }\n EXPORT_SYMBOL_GPL(pci_epf_alloc_doorbell);\n \n void pci_epf_free_doorbell(struct pci_epf *epf)\n {\n-\tplatform_device_msi_free_irqs_all(epf->epc->dev.parent);\n+\tif (!epf->db_msg)\n+\t\treturn;\n+\n+\tif (epf->db_msg[0].type == PCI_EPF_DOORBELL_MSI)\n+\t\tplatform_device_msi_free_irqs_all(epf->epc->dev.parent);\n \n \tkfree(epf->db_msg);\n \tepf->db_msg = NULL;\ndiff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h\nindex 7737a7c03260..cd747447a1ea 100644\n--- a/include/linux/pci-epf.h\n+++ b/include/linux/pci-epf.h\n@@ -152,14 +152,33 @@ struct pci_epf_bar {\n \tstruct pci_epf_bar_submap\t*submap;\n };\n \n+enum pci_epf_doorbell_type {\n+\tPCI_EPF_DOORBELL_MSI = 0,\n+\tPCI_EPF_DOORBELL_EMBEDDED,\n+};\n+\n /**\n * struct pci_epf_doorbell_msg - represents doorbell message\n- * @msg: MSI message\n- * @virq: IRQ number of this doorbell MSI message\n+ * @msg: Doorbell address/data pair to be mapped into BAR space.\n+ * For MSI-backed doorbells this is the MSI message, while for\n+ * \"embedded\" doorbells this represents an MMIO write that asserts\n+ * an interrupt on the EP side.\n+ * @virq: IRQ number of this doorbell message\n+ * @irq_flags: Required flags for request_irq()/request_threaded_irq().\n+ * Callers may OR-in additional flags (e.g. IRQF_ONESHOT).\n+ * @type: Doorbell type.\n+ * @bar: BAR number where the doorbell target is already exposed to the RC\n+ * (NO_BAR if not)\n+ * @offset: offset within @bar for the doorbell target (valid iff\n+ * @bar != NO_BAR)\n */\n struct pci_epf_doorbell_msg {\n \tstruct msi_msg msg;\n \tint virq;\n+\tunsigned long irq_flags;\n+\tenum pci_epf_doorbell_type type;\n+\tenum pci_barno bar;\n+\tresource_size_t offset;\n };\n \n /**\n", "prefixes": [ "v14", "4/7" ] }