Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223116/?format=api
{ "id": 2223116, "url": "http://patchwork.ozlabs.org/api/patches/2223116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414213523.1125859-2-junjie.cao@intel.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260414213523.1125859-2-junjie.cao@intel.com>", "list_archive_url": null, "date": "2026-04-14T21:35:23", "name": "[v2,2/2] ati-vga: mask out lock bit from CUR_OFFSET in cursor offset calculation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "083c16d3ae22e1a3db991289c314996f684c56ad", "submitter": { "id": 91537, "url": "http://patchwork.ozlabs.org/api/people/91537/?format=api", "name": "Junjie Cao", "email": "junjie.cao@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414213523.1125859-2-junjie.cao@intel.com/mbox/", "series": [ { "id": 499846, "url": "http://patchwork.ozlabs.org/api/series/499846/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499846", "date": "2026-04-14T21:35:22", "name": "[v2,1/2] ati-vga: fix unsigned integer overflow in cursor bounds checks", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499846/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223116/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=SD89Gb1J;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw4wd3dLTz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 23:33:21 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCdsw-0006MV-CC; Tue, 14 Apr 2026 09:32:58 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <junjie.cao@intel.com>)\n id 1wCdst-0006Ln-Ev; Tue, 14 Apr 2026 09:32:55 -0400", "from mgamail.intel.com ([192.198.163.14])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <junjie.cao@intel.com>)\n id 1wCdsr-0004dq-Tv; Tue, 14 Apr 2026 09:32:55 -0400", "from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Apr 2026 06:32:52 -0700", "from junjie-optiplex-micro-plus-7010.bj.intel.com ([10.238.152.98])\n by fmviesa008-auth.fm.intel.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2026 06:32:50 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776173574; x=1807709574;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ol2Im+QdI5af/C0v0OW53VBVcDkWA8XbSwTicgQ7LLk=;\n b=SD89Gb1JGdOe1Te3lgCpP40DwtJ12BNDkSXdGax82kYZzjd+JBV0c7m0\n Y5/vNutGdRrzUgU1OKXOGtcGyUxBw69q98M/FTGZYDO8e2E9Qm4bq0Gd2\n 97o+FvdAWGWWyVGRZ5zVthvrCc+FXhtGopA3awNl/7nhxr9doLiIsi+R1\n abOJHJ/MXwJndYDqL9Es1TVY/cirLm0tKHaCXTYk3T1e5e9ox/GxAkRBJ\n INS+nkLhWDTJUD7C3h8ASMZZCmhLwzxLt87NM5JfmmJdaxs+egtEJSVcY\n hL4Q+9DMNnLsVNqkJoHmpVBsH3WxucKOtiXSTuBqxJuJdOjGdUM5kYkUg g==;", "X-CSE-ConnectionGUID": [ "f9vv/CHWSGKOEHTIm9W3nA==", "Oq6X1b+eQqSVijzdWNGFtA==" ], "X-CSE-MsgGUID": [ "8I6bM1esT3+ritE41HzPyw==", "gW91qacwROSGWN6ZWun+og==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11759\"; a=\"77201467\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"77201467\"", "E=Sophos;i=\"6.23,179,1770624000\"; d=\"scan'208\";a=\"227448001\"" ], "X-ExtLoop1": "1", "From": "Junjie Cao <junjie.cao@intel.com>", "To": "qemu-devel@nongnu.org", "Cc": "BALATON Zoltan <balaton@eik.bme.hu>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Chad Jablonski <chad@jablonski.xyz>,\n qemu-stable@nongnu.org, junjie.cao@intel.com", "Subject": "[PATCH v2 2/2] ati-vga: mask out lock bit from CUR_OFFSET in cursor\n offset calculation", "Date": "Wed, 15 Apr 2026 05:35:23 +0800", "Message-ID": "<20260414213523.1125859-2-junjie.cao@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260414213523.1125859-1-junjie.cao@intel.com>", "References": "<20260414213523.1125859-1-junjie.cao@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=192.198.163.14;\n envelope-from=junjie.cao@intel.com;\n helo=mgamail.intel.com", "X-Spam_score_int": "-29", "X-Spam_score": "-3.0", "X-Spam_bar": "---", "X-Spam_report": "(-3.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947,\n DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\n DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Bit 31 of CUR_OFFSET is the cursor lock bit, not part of the actual\ncursor address (bits 26:4). Although the callers already check for the\nlock bit and return early, mask it out with 0x07fffff0 when computing\nthe cursor source offset so the calculation only uses the address bits.\n\nSuggested-by: BALATON Zoltan <balaton@eik.bme.hu>\nSigned-off-by: Junjie Cao <junjie.cao@intel.com>\n---\n hw/display/ati.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/hw/display/ati.c b/hw/display/ati.c\nindex 0489995d00..3a7d45a882 100644\n--- a/hw/display/ati.c\n+++ b/hw/display/ati.c\n@@ -147,7 +147,7 @@ static void ati_cursor_define(ATIVGAState *s)\n return; /* Do not update cursor if locked or rendered by guest */\n }\n /* FIXME handle cur_hv_offs correctly */\n- srcoff = s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n+ srcoff = (s->regs.cur_offset & 0x07fffff0) - (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16;\n if (srcoff > s->vga.vram_size - 64 * 16) {\n return;\n@@ -176,13 +176,15 @@ static void ati_cursor_invalidate(VGACommonState *vga)\n if (s->cursor_size != size ||\n vga->hw_cursor_x != s->regs.cur_hv_pos >> 16 ||\n vga->hw_cursor_y != (s->regs.cur_hv_pos & 0xffff) ||\n- s->cursor_offset != s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n+ s->cursor_offset != (s->regs.cur_offset & 0x07fffff0) -\n+ (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16) {\n /* Remove old cursor then update and show new one if needed */\n vga_invalidate_scanlines(vga, vga->hw_cursor_y, vga->hw_cursor_y + 63);\n vga->hw_cursor_x = s->regs.cur_hv_pos >> 16;\n vga->hw_cursor_y = s->regs.cur_hv_pos & 0xffff;\n- s->cursor_offset = s->regs.cur_offset - (s->regs.cur_hv_offs >> 16) -\n+ s->cursor_offset = (s->regs.cur_offset & 0x07fffff0) -\n+ (s->regs.cur_hv_offs >> 16) -\n (s->regs.cur_hv_offs & 0xffff) * 16;\n s->cursor_size = size;\n if (size) {\n", "prefixes": [ "v2", "2/2" ] }