Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223030/?format=api
{ "id": 2223030, "url": "http://patchwork.ozlabs.org/api/patches/2223030/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260414082004.3756080-6-dhowells@redhat.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260414082004.3756080-6-dhowells@redhat.com>", "list_archive_url": null, "date": "2026-04-14T08:20:01", "name": "[v2,5/7] netfs: Fix read-gaps to remove netfs_folio from filled folio", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bcaf1055326d69ec4349b522949d0545221b6397", "submitter": { "id": 59, "url": "http://patchwork.ozlabs.org/api/people/59/?format=api", "name": "David Howells", "email": "dhowells@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260414082004.3756080-6-dhowells@redhat.com/mbox/", "series": [ { "id": 499799, "url": "http://patchwork.ozlabs.org/api/series/499799/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=499799", "date": "2026-04-14T08:19:56", "name": "netfs: Miscellaneous fixes", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499799/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223030/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223030/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10798-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Q+5hglrN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10798-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"Q+5hglrN\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvy6M6Zh3z1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 18:26:19 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 92CBC303C12C\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 08:21:36 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A6EFF3A0E8A;\n\tTue, 14 Apr 2026 08:20:51 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 920793A9014\n\tfor <linux-cifs@vger.kernel.org>; Tue, 14 Apr 2026 08:20:47 +0000 (UTC)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-k6pWIlGfPJmkgN3ZqgaENg-1; Tue,\n 14 Apr 2026 04:20:40 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B8F3E180062A;\n\tTue, 14 Apr 2026 08:20:38 +0000 (UTC)", "from warthog.procyon.org.com (unknown [10.44.34.160])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6CB7319560AB;\n\tTue, 14 Apr 2026 08:20:34 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776154851; cv=none;\n b=UMY3yBUyelYKASrZMujdew2bTxuKg6mTfQWLItEgnmuHWCg0rtL/k3mD0wCKelq6WOIYSVAIHdEyTpT/IJk9BGxP0AwIGXmL+WMy9qWVtfXgPhOKjTXASDR9fVk1tWZnjNgtCoFhgwyKpvIGVcyxHaMG1IKdqc60z6HZ+ENty7E=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776154851; c=relaxed/simple;\n\tbh=oxUJyI76bnZ8tUbdxJRXOf7ol4SScdQ1t5WAkfI+fBY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Th4VATayR7a8hxt8qEGuQJBulPq38XHEWnwiCbIru0I2vS4WDxJYN3mcgeCZ/elJ3CVNfx+m7f/Z2Sn4OO63nd9V7Pf/6DT8q0P0E1duSapiWEPepteC/Kiz78voQ69GLdWX+4ggAuoUh3trUSVB5NOl7tcgXPacbCmmmGwubTU=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=Q+5hglrN; arc=none smtp.client-ip=170.10.129.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1776154845;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=qgyREwUHigIG1FgNOwg6GfmZf+SBiBENiuOGu7YKJR8=;\n\tb=Q+5hglrNp6aJGxODPhgoj8dS7qi8PFnDHnDKxhUuLAaDqQLxdCw5NpjlnXMFp1Ak6dw3ZI\n\t16in/TDcs4zNDGTWEEMxrzR5ISQ3qrRa2zq1uAQ03g9AsoFqO/mhzjtFyyVEEpM594iiXk\n\t+Bp3PmvSjidkuYUB448sDZzV8kY88QE=", "X-MC-Unique": "k6pWIlGfPJmkgN3ZqgaENg-1", "X-Mimecast-MFC-AGG-ID": "k6pWIlGfPJmkgN3ZqgaENg_1776154838", "From": "David Howells <dhowells@redhat.com>", "To": "Christian Brauner <christian@brauner.io>", "Cc": "David Howells <dhowells@redhat.com>,\n\tPaulo Alcantara <pc@manguebit.com>,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tMatthew Wilcox <willy@infradead.org>", "Subject": "[PATCH v2 5/7] netfs: Fix read-gaps to remove netfs_folio from filled\n folio", "Date": "Tue, 14 Apr 2026 09:20:01 +0100", "Message-ID": "<20260414082004.3756080-6-dhowells@redhat.com>", "In-Reply-To": "<20260414082004.3756080-1-dhowells@redhat.com>", "References": "<20260414082004.3756080-1-dhowells@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12" }, "content": "Fix netfs_read_gaps() to remove the netfs_folio record from the folio\nrecord before marking the folio uptodate if it successfully fills the gaps\naround the dirty data in a streaming write folio (dirty, but not uptodate).\n\nFound with:\n\n fsx -q -N 1000000 -p 10000 -o 128000 -l 600000 \\\n /xfstest.test/junk --replay-ops=junk.fsxops\n\nusing the following as junk.fsxops:\n\n truncate 0x0 0x138b1 0x8b15d *\n write 0x507ee 0x10df7 0x927c0\n write 0x19993 0x10e04 0x927c0 *\n mapwrite 0x66214 0x1a253 0x927c0\n copy_range 0xb704 0x89b9 0x24429 0x79380\n write 0x2402b 0x144a2 0x90660 *\n mapwrite 0x204d5 0x140a0 0x927c0 *\n copy_range 0x1f72c 0x137d0 0x7a906 0x927c0 *\n read 0 0x9157c 0x9157c\n\non cifs with the default cache option.\n\nIt shows folio 0x24 misbehaving if the FMODE_READ check is commented out in\nnetfs_perform_write():\n\n if (//(file->f_mode & FMODE_READ) ||\n netfs_is_cache_enabled(ctx)) {\n\nand no fscache. This was initially found with the generic/522 xfstest.\n\nSigned-off-by: David Howells <dhowells@redhat.com>\ncc: Paulo Alcantara <pc@manguebit.org>\ncc: Matthew Wilcox <willy@infradead.org>\ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex a8c0d86118c5..c23173a061e8 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -397,6 +397,7 @@ static int netfs_read_gaps(struct file *file, struct folio *folio)\n {\n \tstruct netfs_io_request *rreq;\n \tstruct address_space *mapping = folio->mapping;\n+\tstruct netfs_group *group = netfs_folio_group(folio);\n \tstruct netfs_folio *finfo = netfs_folio_info(folio);\n \tstruct netfs_inode *ctx = netfs_inode(mapping->host);\n \tstruct folio *sink = NULL;\n@@ -463,6 +464,10 @@ static int netfs_read_gaps(struct file *file, struct folio *folio)\n \n \tret = netfs_wait_for_read(rreq);\n \tif (ret >= 0) {\n+\t\tfolio_detach_private(folio);\n+\t\tnetfs_put_group(group);\n+\t\tkfree(finfo);\n+\t\ttrace_netfs_folio(folio, netfs_folio_trace_filled_gaps);\n \t\tflush_dcache_folio(folio);\n \t\tfolio_mark_uptodate(folio);\n \t}\n@@ -498,10 +503,8 @@ int netfs_read_folio(struct file *file, struct folio *folio)\n \tstruct netfs_inode *ctx = netfs_inode(mapping->host);\n \tint ret;\n \n-\tif (folio_test_dirty(folio)) {\n-\t\ttrace_netfs_folio(folio, netfs_folio_trace_read_gaps);\n+\tif (folio_test_dirty(folio))\n \t\treturn netfs_read_gaps(file, folio);\n-\t}\n \n \t_enter(\"%lx\", folio->index);\n \n", "prefixes": [ "v2", "5/7" ] }