Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2223006/?format=api
{ "id": 2223006, "url": "http://patchwork.ozlabs.org/api/patches/2223006/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-6-jamin_lin@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260414080025.3005916-6-jamin_lin@aspeedtech.com>", "list_archive_url": null, "date": "2026-04-14T08:00:32", "name": "[v2,05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with trace events", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9b76643968f0cc9912afe985d74fbebfb3fc9f54", "submitter": { "id": 81768, "url": "http://patchwork.ozlabs.org/api/people/81768/?format=api", "name": "Jamin Lin", "email": "jamin_lin@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-6-jamin_lin@aspeedtech.com/mbox/", "series": [ { "id": 499795, "url": "http://patchwork.ozlabs.org/api/series/499795/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499795", "date": "2026-04-14T08:00:26", "name": "hw/usb/ehci: Add 64-bit descriptor addressing support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499795/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2223006/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2223006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=BLGdGc/w;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxdJ195sz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 18:04:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCYhc-0003co-4E; Tue, 14 Apr 2026 04:00:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wCYhZ-0003aA-2T; Tue, 14 Apr 2026 04:00:53 -0400", "from mail-koreacentralazlp170130006.outbound.protection.outlook.com\n ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wCYhW-0005mG-Vw; Tue, 14 Apr 2026 04:00:52 -0400", "from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 08:00:32 +0000", "from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 08:00:32 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=TevAsJ4Cmw8Ib8xR6XKE7rjmv0AKVI9ovGfNmmnsk9DbuKU6mJf4DoAQBYlPN/lATYnxtCcqEC1QH+MYb0IPpIzytb3K+/i++MzBxAKRTZRsoGVx6g+jz854ykeXLbEoWe+beOnP7523eEZCAV+NloARCmdgtOElLlKWl41XgOZOa47YpJCK6CnF0FYoAlHOun4g2l2L6CVs3eBp/ENYaOtVxeo0RjZWp+CPWx6YYoyTLBjxQlrwHHlAGpu8FVkFC6qK4sn0pqN3kSME2OjDnaHWrbz2zxfAvfSTnBAXq5ED1ElXA7WzfprPTSVxS83c7TLGpS0h/lkrOL4NxFSNBg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=;\n b=J4a+s2ci5/+BV3fehzGkfo5859lqHCXQzB3YqozBaVR2B8Y9V+oBXJ6NKzBEKU2Dws/l0Gt2cGQe9MtM61bomuN/P5wPWNK5Mby/LW7NETk8tqji/sHuugH2WynOHi0U6BIUhuqC9l5ZCq1E+zsD//W7TxDX5z9jxjBg1AjNsWDIm4GQsW701UoWpJHHPU0dVG9Tik3QQiO/lH/8gTqd+lHn1hWsyvKyVwE2/RcLK9/+Vt+aJfRidchuQtN3LurHFONVxMMNytrOvNFHEseuhdUC36AvgU9LNi2Xih3LX2+679rswP8tRGtC3t/ZflfGX3mdi8LgIrKcRlGxlBojmw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=H6usZ5mXShBCQUWpF5kXm4oFlG2iJBMpiedjEUoqbNs=;\n b=BLGdGc/wjNGdGiThDkjw93+DlKapxRrT29y/XVuml+iCEJx8ytme2woiC/fnpH/kJ9LMWugxDY8DUdqu//ZPKMj6LvS2nBzdSb+O3fCUiaRI0wY0ymiAcbA6JIGfrTXB9x2/x9sIZh1TJNcpdLNKd//J5Jieq5OaOuTwJIs76WbQr7ijqpQANEYSNocB57qB007dbRaJoWSq7Jl1vzF+ii1g6WnZn12m+7FNJUizVqQPkTlI69RZT8m+EMtbYiScQj86P8/lrRZEjdH9z7hV3Auwafq2e2HhuduveY0lTn2+BP2RIWa8LZ3QwZ+PZLdberovgPsCeyM0GslGhvqxJg==", "From": "Jamin Lin <jamin_lin@aspeedtech.com>", "To": "=?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n \"flwu@google.com\" <flwu@google.com>, \"nabihestefan@google.com\"\n <nabihestefan@google.com>", "Subject": "[PATCH v2 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs with\n trace events", "Thread-Topic": "[PATCH v2 05/17] hw/usb/hcd-ehci: Replace DPRINTF debug logs\n with trace events", "Thread-Index": "AQHcy+TE5hvsGeJpgkGHytOuSshyKA==", "Date": "Tue, 14 Apr 2026 08:00:32 +0000", "Message-ID": "<20260414080025.3005916-6-jamin_lin@aspeedtech.com>", "References": "<20260414080025.3005916-1-jamin_lin@aspeedtech.com>", "In-Reply-To": "<20260414080025.3005916-1-jamin_lin@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=BLGdGc/w;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "TYPPR06MB8206:EE_|TYZPR06MB6745:EE_", "x-ms-office365-filtering-correlation-id": "cf982349-d447-4955-227a-08de99fbe6dd", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003;", "x-microsoft-antispam-message-info": "\n lHuwosqcuehK1AJrmnocPphK3GHzszDHlGSLbWPDeyjiI7csRi4ec7zgu+QLGPVjK+82tj5in6U5yQBS/Y16caM/T846ZRzEZoZQGRgfnPW/wknvXWuwhAYw2m5xP8pGET+T3XwjVxTrQttH4TUutjEjLadSKTNNWgHZlWB6zgDPUetGoWzM14HMd0U1Z/AslbAxi7RTawgg1xAByq1DD0onkQLI69Mb8y55iWrdQwdTl/Gp7EsdRtKPqpeefYfumWgonlxC74599mwWFY9hbAjrHIRNvyjYUG3ksKj7/j57CHVyyhpYjOrtNFo8VqSYhEwR4E/t72nWh8+oWE76jNEMfYGdQ2VlC6J/JXMf7erD2O0BJndKeItp1nqW1GiCY4t0AyrUSTEMmZYxJy9kKySRR4juGyi3IEPEzUnkOIgMwmdnQ3bJZ45ZmRXrpWbnMt5vvafLZYVrlGBtFCiu3q3s8MC86qX62Plx74DXNpa1UkfqYu7vC9q6KRNR0he2YCi6OEAnKzrlrFf+ymPXmgmgChfdkaPPfe2GEH697QBzw3pDjbSGedX8Bcb06S6jvH2y60uYMRGFcHSD1bLL52u3MLyLAkUE77J6iGfKIsHtlP9q/VLHx6+t51y+GfUx2yOJg/1M5JURNje+kITAmNsnxHzjTMraSyXJOUW6cquiEK5SZknfH+TtHAxQGkddkA7InmtI5o311bWkDa6F4/6C1a8wfGg5OKJX4xuaV4qjxc5y2BYjYhvdfxxeapeh6Vmwp0rOCRvs4sE8cfP6JKVVa3BVD0/ZM048QkOmWjQ=", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?u8F3U8lsV9S/WYjao8vu+7B?=\n\t=?iso-8859-1?q?+ek+2Mget0CCAPyLqRVMIPu1gMjugS9qWPwLprz1s/Yqo51GrCtidUqDulFF?=\n\t=?iso-8859-1?q?unMmaWUz5Du4+aQGnlCLarQYDzBQfgCd7ySlX4MSkKXKTUTY5kuLyL9RV6IS?=\n\t=?iso-8859-1?q?aACx0Tnc2TezOg39Kc91iNY6kH2DxWQjvX24qZlc9ronElPKUNRPEuLMzGuM?=\n\t=?iso-8859-1?q?m9/+ewaNJk6Ta9uKp2xmm/TGT4ZNS9OpkaTjGb49GHTTVENFuaA3rrJP/zMR?=\n\t=?iso-8859-1?q?nFvPTPRerODJ9+nqI7ytFxSfYet7hSgz/MiCZi2pFzhCYRUlFSFJy8UJEqlR?=\n\t=?iso-8859-1?q?M2OPQLToAKhC+HXlkfzWADo4BSFnk8jyqPM3vqQr8cdnXRtUjp6lW/1XLVLM?=\n\t=?iso-8859-1?q?2i9hXoGYL7K1yYWC4wacGy+MprZdjDMS6h+o61AuScSKd+/G6be8e1JMSUSE?=\n\t=?iso-8859-1?q?fPEmPXG1XNKS7TJTTxe1CoKbLGUAgYEWKxEwoNJ1Rdy9T8mIN60A1t8kaXkL?=\n\t=?iso-8859-1?q?dTu+ZQguDSSpLUBqPUlZBFC9q5KTWckx9go7rt6ed2S4zqwZ6NrE0Sec92+H?=\n\t=?iso-8859-1?q?4VzoEo0i6jzPKAnrk2IpnIZ4Vags8Abdb8aE6VX+JQ97zXOI68XioZ8AeZU6?=\n\t=?iso-8859-1?q?zaklgxqOfNRcbe85M2UFOldSg8l8lUS+pKfwH6RcXNKSLJYj2tIM7t3hxsMc?=\n\t=?iso-8859-1?q?psBuzTm/7Dqq2oJzpZtaojJnZDM8iLIGK33qBUgmpX+4YeG6wg02seCZfaZG?=\n\t=?iso-8859-1?q?n6Gy7wQItrI43MF0eHNHXvGXNUik5+cceeAH8qYuhQSBwFBxXAf3dcqUpNl0?=\n\t=?iso-8859-1?q?wDFgWKx2Qk6kb4qnvidE/B9Z2AMDy8ELkd9TSQKdBBYmgtQ1/V1uCIgxOnwy?=\n\t=?iso-8859-1?q?FAnNAjUB434VJ2kOuz/UWEdil3i4Y4HgJsPaGv1tc7NhVJxg5HF56Nz4jz/2?=\n\t=?iso-8859-1?q?nir+O7SKt6GfeMdMlqMFwG4Xn6dmlzGqwFX0nJ9ioMi86GPNJwqdoYi96XsY?=\n\t=?iso-8859-1?q?E4ym+Q3p6F8Hd9mj2xYMzvMGDxwzHmhOzUfUTMSwjKs4TpoAUdSfdh61A1n/?=\n\t=?iso-8859-1?q?HxaAQoMUvnMTOuZn3NYXEvy42Mre1ElHTUaSAUmPwNYeGh13MayCQNc8t6R/?=\n\t=?iso-8859-1?q?PKjNdRCYcB9pbW78dZ3VRkPuW9M1A1hTjvOp9pjCPwGUH3DuRCuF94oAoRC3?=\n\t=?iso-8859-1?q?XwZTNbXfaZnYGQ/ymOiOSSpmDp/6lBfVFfx2+WaS/2fjT8xByB7pA9D5TBjv?=\n\t=?iso-8859-1?q?z8rzWEPN7OUEhKUX+6GO4rmPkLD/qAS1eB78vA8XtbzZqxV14xsyDusNqt1z?=\n\t=?iso-8859-1?q?tnFZ+ZH9G1/dxMfsDBnhSh0anF7SfTUaGs712gDUtdWfDaNg0/b510QIPJ1M?=\n\t=?iso-8859-1?q?vtAtMOW4TuuxAlqXaevca6xuKVaPdShHdaMomdWVwbHpMRwtJeNfKfgs1TVc?=\n\t=?iso-8859-1?q?AyAvblugIhpEu1gGIppnsRqi3KVCvB6rPrI0UDnwvehEVDY/E/V1aqNhd3nm?=\n\t=?iso-8859-1?q?r+qAQHSuvGf/iXyRUZGLZCm90hWm2CI/yzyYxMDK+Wysi6kU35/mGjKIt8Lm?=\n\t=?iso-8859-1?q?tpLss2hJpILDhoe2W2JREoKyTswKC3xtYBKDdCyJgnc2kTWuHRLnfnYI2Doh?=\n\t=?iso-8859-1?q?vvvyYuZXaiej5AkcNtKM9GHd7v3aKz7bZaXF7pOa4Kdk4EYCRvLkaFoGbrGl?=\n\t=?iso-8859-1?q?/3uXhFP9z+6m70sErWLDoHMAcdi3jDoQG4Hi0m4Hlb4jhYy09r8vxkyPWC8s?=\n\t=?iso-8859-1?q?xabi31ulhfqOCSqAPKGJCNXDzL6oZtrvtco/Zm2R10IHoKw=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n wAt0LZtmTK4WBjNYgluYSVRtDPKiuauCfHyy/4YAgGXlvP/nYSJFLyBn5Hoe1lUEs779HaDina/JnhXauMDcl+Fid1pqDkPlBBeW9Wj5TrEMRKSjbISfkOVMaos96/WNt73DB6xTsChFgVdwIZPFhbgDR81W+xtE/xmJE5G2/xoMjrsShCa1pmCSX62PT+9o+tdqwgc86D6+JGtv/lQT7XfI5KRXSlIw9A5wfxuRnwJnGmKyFOkeIMq6cqk3Z1XCUngy/6TLqgRXU7cSbLebHtMBijmgdJZXQd4Txxsazisr0EIDtzTN+/4L8jxDmwM3KuYkJVkNrNOg3guCIzBGwA==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "TYPPR06MB8206.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n cf982349-d447-4955-227a-08de99fbe6dd", "X-MS-Exchange-CrossTenant-originalarrivaltime": "14 Apr 2026 08:00:32.2014 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n aMF2q4+TkrevANoClYuBvrLpKLeGn99DvahqoOFOhhaPwEJ9GWYvXvBepcVg7YK9MVv1dPR4Cl+6hjemrHK6tzdmRCWQF5tndo1+eNjdw+A=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "TYZPR06MB6745", "Received-SPF": "pass client-ip=2a01:111:f403:c40f::6;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=SEYPR02CU001.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace legacy DPRINTF() debug logging in the EHCI host controller\nimplementation with QEMU trace events.\n\nThe EHCI_DEBUG macro and associated DPRINTF() definitions are\nremoved as they are no longer needed.\n\nTrace events are added for:\n- packet submission and completion\n- queue head execution state\n- periodic schedule advancement\n- ITD error conditions\n- port state handling\n- skipped microframes\n\nNo functional change.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\n---\n hw/usb/hcd-ehci.h | 10 ---------\n hw/usb/hcd-ehci.c | 49 +++++++++++++++++++--------------------------\n hw/usb/trace-events | 9 +++++++++\n 3 files changed, 30 insertions(+), 38 deletions(-)", "diff": "diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h\nindex 736407fd52..4234591cb4 100644\n--- a/hw/usb/hcd-ehci.h\n+++ b/hw/usb/hcd-ehci.h\n@@ -24,16 +24,6 @@\n #include \"hw/pci/pci_device.h\"\n #include \"hw/core/sysbus.h\"\n \n-#ifndef EHCI_DEBUG\n-#define EHCI_DEBUG 0\n-#endif\n-\n-#if EHCI_DEBUG\n-#define DPRINTF printf\n-#else\n-#define DPRINTF(...)\n-#endif\n-\n #define MMIO_SIZE 0x1000\n #define CAPA_SIZE 0x10\n \ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex bebd137f94..d0ea4949f9 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -839,7 +839,7 @@ static USBDevice *ehci_find_device(EHCIState *ehci, uint8_t addr)\n for (i = 0; i < EHCI_PORTS; i++) {\n port = &ehci->ports[i];\n if (!(ehci->portsc[i] & PORTSC_PED)) {\n- DPRINTF(\"Port %d not enabled\\n\", i);\n+ trace_usb_ehci_port_disable(i);\n continue;\n }\n dev = usb_find_device(port, addr);\n@@ -1281,10 +1281,8 @@ static void ehci_execute_complete(EHCIQueue *q)\n assert(p->async == EHCI_ASYNC_INITIALIZED ||\n p->async == EHCI_ASYNC_FINISHED);\n \n- DPRINTF(\"execute_complete: qhaddr 0x%x, next 0x%x, qtdaddr 0x%x, \"\n- \"status %d, actual_length %d\\n\",\n- q->qhaddr, q->qh.next, q->qtdaddr,\n- p->packet.status, p->packet.actual_length);\n+ trace_usb_ehci_execute_complete(q->qhaddr, q->qh.next, q->qtdaddr,\n+ p->packet.status, p->packet.actual_length);\n \n switch (p->packet.status) {\n case USB_RET_SUCCESS:\n@@ -1327,7 +1325,7 @@ static void ehci_execute_complete(EHCIQueue *q)\n } else {\n tbytes = 0;\n }\n- DPRINTF(\"updating tbytes to %d\\n\", tbytes);\n+ trace_usb_ehci_qh_tbytes(tbytes);\n set_field(&q->qh.token, tbytes, QTD_TOKEN_TBYTES);\n \n ehci_finish_transfer(q, p->packet.actual_length);\n@@ -1392,10 +1390,9 @@ static int ehci_execute(EHCIPacket *p, const char *action)\n \n trace_usb_ehci_packet_action(p->queue, p, action);\n usb_handle_packet(p->queue->dev, &p->packet);\n- DPRINTF(\"submit: qh 0x%x next 0x%x qtd 0x%x pid 0x%x len %zd endp 0x%x \"\n- \"status %d actual_length %d\\n\", p->queue->qhaddr, p->qtd.next,\n- p->qtdaddr, p->pid, p->packet.iov.size, endp, p->packet.status,\n- p->packet.actual_length);\n+ trace_usb_ehci_packet_submit(p->queue->qhaddr, p->qtd.next, p->qtdaddr,\n+ p->pid, p->packet.iov.size, endp,\n+ p->packet.status, p->packet.actual_length);\n \n if (p->packet.actual_length > BUFF_SIZE) {\n qemu_log_mask(LOG_GUEST_ERROR,\n@@ -1472,7 +1469,8 @@ static int ehci_process_itd(EHCIState *ehci,\n usb_handle_packet(dev, &ehci->ipacket);\n usb_packet_unmap(&ehci->ipacket, &ehci->isgl);\n } else {\n- DPRINTF(\"ISOCH: attempt to address non-iso endpoint\\n\");\n+ trace_usb_ehci_log(\"ISOCH: \"\n+ \"attempt to address non-iso endpoint\");\n ehci->ipacket.status = USB_RET_NAK;\n ehci->ipacket.actual_length = 0;\n }\n@@ -1675,24 +1673,22 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async)\n if (ehci->usbsts & USBSTS_REC) {\n ehci_clear_usbsts(ehci, USBSTS_REC);\n } else {\n- DPRINTF(\"FETCHQH: QH 0x%08x. H-bit set, reclamation status reset\"\n- \" - done processing\\n\", q->qhaddr);\n+ trace_usb_ehci_fetchqh_reclaim_done(q->qhaddr);\n ehci_set_state(ehci, async, EST_ACTIVE);\n q = NULL;\n goto out;\n }\n }\n \n-#if EHCI_DEBUG\n- if (q->qhaddr != q->qh.next) {\n- DPRINTF(\"FETCHQH: QH 0x%08x (h %x halt %x active %x) next 0x%08x\\n\",\n- q->qhaddr,\n- q->qh.epchar & QH_EPCHAR_H,\n- q->qh.token & QTD_TOKEN_HALT,\n- q->qh.token & QTD_TOKEN_ACTIVE,\n- q->qh.next);\n+ if (trace_event_get_state_backends(TRACE_USB_EHCI_FETCHQH_DBG)) {\n+ if (q->qhaddr != q->qh.next) {\n+ trace_usb_ehci_fetchqh_dbg(q->qhaddr,\n+ q->qh.epchar & QH_EPCHAR_H,\n+ q->qh.token & QTD_TOKEN_HALT,\n+ q->qh.token & QTD_TOKEN_ACTIVE,\n+ q->qh.next);\n+ }\n }\n-#endif\n \n if (q->qh.token & QTD_TOKEN_HALT) {\n ehci_set_state(ehci, async, EST_HORIZONTALQH);\n@@ -2154,7 +2150,7 @@ static void ehci_advance_async_state(EHCIState *ehci)\n /* make sure guest has acknowledged the doorbell interrupt */\n /* TO-DO: is this really needed? */\n if (ehci->usbsts & USBSTS_IAA) {\n- DPRINTF(\"IAA status bit still set.\\n\");\n+ trace_usb_ehci_log(\"IAA status bit still set.\");\n break;\n }\n \n@@ -2221,9 +2217,7 @@ static void ehci_advance_periodic_state(EHCIState *ehci)\n if (get_dwords(ehci, list, &entry, 1) < 0) {\n break;\n }\n-\n- DPRINTF(\"PERIODIC state adv fr=%d. [%08X] -> %08X\\n\",\n- ehci->frindex / 8, list, entry);\n+ trace_usb_ehci_periodic_state_advance(ehci->frindex / 8, list, entry);\n ehci_set_fetch_addr(ehci, async, entry);\n ehci_set_state(ehci, async, EST_FETCHENTRY);\n ehci_advance_state(ehci, async);\n@@ -2291,8 +2285,7 @@ static void ehci_work_bh(void *opaque)\n ehci_update_frindex(ehci, skipped_uframes);\n ehci->last_run_ns += UFRAME_TIMER_NS * skipped_uframes;\n uframes -= skipped_uframes;\n- DPRINTF(\"WARNING - EHCI skipped %\"PRIu64\" uframes\\n\",\n- skipped_uframes);\n+ trace_usb_ehci_skipped_uframes(skipped_uframes);\n }\n \n for (i = 0; i < uframes; i++) {\ndiff --git a/hw/usb/trace-events b/hw/usb/trace-events\nindex dd04f14add..0d4318dcf1 100644\n--- a/hw/usb/trace-events\n+++ b/hw/usb/trace-events\n@@ -89,6 +89,7 @@ usb_ehci_state(const char *schedule, const char *state) \"%s schedule %s\"\n usb_ehci_qh_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t c_qtd, uint32_t n_qtd, uint32_t a_qtd) \"q %p - QH @ 0x%08x: next 0x%08x qtds 0x%08x,0x%08x,0x%08x\"\n usb_ehci_qh_fields(uint32_t addr, int rl, int mplen, int eps, int ep, int devaddr) \"QH @ 0x%08x - rl %d, mplen %d, eps %d, ep %d, dev %d\"\n usb_ehci_qh_bits(uint32_t addr, int c, int h, int dtc, int i) \"QH @ 0x%08x - c %d, h %d, dtc %d, i %d\"\n+usb_ehci_qh_tbytes(uint32_t tbytes) \"updating tbytes to %d\"\n usb_ehci_qtd_ptrs(void *q, uint32_t addr, uint32_t nxt, uint32_t altnext) \"q %p - QTD @ 0x%08x: next 0x%08x altnext 0x%08x\"\n usb_ehci_qtd_fields(uint32_t addr, int tbytes, int cpage, int cerr, int pid) \"QTD @ 0x%08x - tbytes %d, cpage %d, cerr %d, pid %d\"\n usb_ehci_qtd_bits(uint32_t addr, int ioc, int active, int halt, int babble, int xacterr) \"QTD @ 0x%08x - ioc %d, active %d, halt %d, babble %d, xacterr %d\"\n@@ -100,13 +101,21 @@ usb_ehci_port_reset(uint32_t port, int enable) \"reset port #%d - %d\"\n usb_ehci_port_suspend(uint32_t port) \"port #%d\"\n usb_ehci_port_wakeup(uint32_t port) \"port #%d\"\n usb_ehci_port_resume(uint32_t port) \"port #%d\"\n+usb_ehci_port_disable(uint32_t port) \"port #%d\"\n usb_ehci_queue_action(void *q, const char *action) \"q %p: %s\"\n usb_ehci_packet_action(void *q, void *p, const char *action) \"q %p p %p: %s\"\n+usb_ehci_packet_submit(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr, int pid, size_t len, int endp, int status, int actual_length) \"qh=0x%x, next=0x%x, qtd=0x%x, pid=0x%x, len=%zd, endp=0x%x, status=%d, actual_length=%d\"\n usb_ehci_irq(uint32_t level, uint32_t frindex, uint32_t sts, uint32_t mask) \"level %d, frindex 0x%04x, sts 0x%x, mask 0x%x\"\n usb_ehci_guest_bug(const char *reason) \"%s\"\n usb_ehci_doorbell_ring(void) \"\"\n usb_ehci_doorbell_ack(void) \"\"\n usb_ehci_dma_error(void) \"\"\n+usb_ehci_execute_complete(uint32_t qhaddr, uint32_t next, uint32_t qtdaddr, int status, int actual_length) \"qhaddr=0x%x, next=0x%x, qtdaddr=0x%x, status=%d, actual_length=%d\"\n+usb_ehci_fetchqh_reclaim_done(uint32_t qhaddr) \"QH 0x%08x H-bit set, reclamation status reset - done processing\"\n+usb_ehci_fetchqh_dbg(uint32_t qhaddr, uint32_t h, uint32_t halt, uint32_t active, uint32_t next) \"QH 0x%08x (h 0x%x halt 0x%x active 0x%x) next 0x%08x\"\n+usb_ehci_periodic_state_advance(uint32_t frame, uint32_t list, uint32_t entry) \"frame=%d, list=0x%x, entry=0x%x\"\n+usb_ehci_skipped_uframes(uint64_t skipped_uframes) \"skipped %\" PRIu64 \" uframes\"\n+usb_ehci_log(const char *msg) \"%s\"\n \n # hcd-uhci.c\n usb_uhci_reset(void) \"=== RESET ===\"\n", "prefixes": [ "v2", "05/17" ] }