Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2222995/?format=api
{ "id": 2222995, "url": "http://patchwork.ozlabs.org/api/patches/2222995/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-5-jamin_lin@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260414080025.3005916-5-jamin_lin@aspeedtech.com>", "list_archive_url": null, "date": "2026-04-14T08:00:31", "name": "[v2,04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with qemu_log_mask(LOG_GUEST_ERROR)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "14e07fc5c2c1b423a9a893b2776fd7853a6291e0", "submitter": { "id": 81768, "url": "http://patchwork.ozlabs.org/api/people/81768/?format=api", "name": "Jamin Lin", "email": "jamin_lin@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414080025.3005916-5-jamin_lin@aspeedtech.com/mbox/", "series": [ { "id": 499795, "url": "http://patchwork.ozlabs.org/api/series/499795/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499795", "date": "2026-04-14T08:00:26", "name": "hw/usb/ehci: Add 64-bit descriptor addressing support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499795/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222995/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=JKLD+RZ0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvxbt50bcz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 18:03:22 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wCYha-0003bP-UT; Tue, 14 Apr 2026 04:00:54 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wCYhX-0003Yd-P3; Tue, 14 Apr 2026 04:00:51 -0400", "from mail-koreacentralazlp170130006.outbound.protection.outlook.com\n ([2a01:111:f403:c40f::6] helo=SEYPR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jamin_lin@aspeedtech.com>)\n id 1wCYhT-0005oL-OR; Tue, 14 Apr 2026 04:00:51 -0400", "from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19)\n by TYZPR06MB6745.apcprd06.prod.outlook.com (2603:1096:400:45a::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr\n 2026 08:00:31 +0000", "from TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com\n ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9769.046; Tue, 14 Apr 2026\n 08:00:31 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=o7g+Z3inz6QzgxRht09uHgjFx6bBEPYUXc8/YT1EmhDdDyIsoUo4/e9axwyY+RilMbrxtskuaLtkldJM1SfdO/ozpnqnEGP7L5dLPSXTYWhxKole2ZlN7YvDaeT0FMbca113Lu56Nl4QeMKAsevEZSzHa/csc/AsHxOp9KxIcVxIhZ64dsqEA6w40vzDJecnSH3shM0sCCGSObh0Mkz6UsGhj6QLQsChX3J2wxCgRVkyUkXGE9P/2RW850BA3nDgFx/HfseCkdQ5u3jUQZDRSCJEvqoKlb2Ja+Kn+cLCKin6qFN6WhwF43gUDJ15kl6kri8Hz5QSqzJC2KszrcWpHw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=;\n b=g0/+gJiPdZh2YUkk3w4ip/ssVO8nV+CWn/hh1c+rDidVj3BAKNY0P2LAPXPXXAXx5IVq+5J35NFWaY4Iqw0rggxKy30iTHyqVwWHPu/Y+e3lZRdcSwO38jFX4qB1taTazSPkvFNxnwnRInF6NSItBYFBm07qzzpvXqfSFbZUWoieM1ktgEj+oOuQdoZ7PrB4zXzqoX4Ovpcva9NNfRJQuOIIobnmF/c2KHJdUdafO1J4q1zcM3Dx0h8N9igw6pgGzpiNIC264o/gWZQFBqeKVWiTIZSfki5VZhANomdmoHsq3uMYd+GoD+1JbEdi0oX8nofM9JWn4TxcaU+xWLLjKw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DPUuYGkfIR6j1AbiEpDRbnOQ1Z8Qp5SXYAhDVwcsM6k=;\n b=JKLD+RZ04GFuqLVXVkpyaN+hDWn4DfcCYyNXi9w7TaJ7mR91t5m/xsyu3Sp1efTzbI9yRJqPCD9Fu6tl5unhXu5THiFw+rUon4Jh9SD5Fq//lqfIFZFA4LCQcI7CaqtUriGPJ3zVTKdMYyMnp43URnuhZ/n6b6TBZiW6X37MnROHj2y1q4dmqDtKXxS/OA9tnysEZsRVghUnyN2s1bh9sTlI9jXt8HazBXiD15CzdBpj0x6WPtg3VNN2kNftXQgsQBoK94BRHjo/hlLsZ5KLUpVYLCMc7qtn+eapJxJjiIMsReIbKCODEtYzBnsA5R8EbZoy6T19FryfnUAO8JE2Sg==", "From": "Jamin Lin <jamin_lin@aspeedtech.com>", "To": "=?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>,\n \"flwu@google.com\" <flwu@google.com>, \"nabihestefan@google.com\"\n <nabihestefan@google.com>", "Subject": "[PATCH v2 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...) with\n qemu_log_mask(LOG_GUEST_ERROR)", "Thread-Topic": "[PATCH v2 04/17] hw/usb/hcd-ehci.c: Replace fprintf(stderr, ...)\n with qemu_log_mask(LOG_GUEST_ERROR)", "Thread-Index": "AQHcy+TDZKmGzP6rPU6jtNcClXZIGg==", "Date": "Tue, 14 Apr 2026 08:00:31 +0000", "Message-ID": "<20260414080025.3005916-5-jamin_lin@aspeedtech.com>", "References": "<20260414080025.3005916-1-jamin_lin@aspeedtech.com>", "In-Reply-To": "<20260414080025.3005916-1-jamin_lin@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=JKLD+RZ0;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "TYPPR06MB8206:EE_|TYZPR06MB6745:EE_", "x-ms-office365-filtering-correlation-id": "fdbfc5b8-6845-41ce-1399-08de99fbe630", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|376014|366016|1800799024|38070700021|22082099003|56012099003|18002099003;", "x-microsoft-antispam-message-info": "\n FCMEUqbkZJQopC+Z3SHbNcjYlC4KvgrjGYlloTCxDqdLtU3LKIG957xjrDxdj2LBJZ7LYGs6Y0NdFfUQR1JPW0NTMo+tam8GlWmK0CBo96iLF2mrORtt8Q/FsDUfEKKNYgu7N1LB9jWAtd8wH2AShCIJJoJ+aeUPhB6ud/bnfz1KMDgRAqmBb9qYmf94lofj32sKhUYpq1O7gxDFcRj7i5yC7y2TrqVmaORFmq9IhydimGM0cSPvnj6H/1FgvwOY7SbPlwhNw+UGAkt65j82akVtm54RcYYjRmDMlZFdTdOnKj1/23AimvUrU4w6ZdNJ7U625WXkb9J1vBJ4XKwn+st5CsC4sQYGA3y9ujZUy5CJ9bzDsicFlQxR8mxhA6i1k+0wZQrXP/HbQxXxif9cyjCAh0VJI4C/xih5ztKhAS98gR2zoUCz1rTGSubNniiQoU9ltO5rNId22YLtDGtyrALGh5DHQOOCVgUWf49kVwhYVnsN7JYd9uEyNgoytic1SpMxz7iLosy6dk1xkRvEz4AuutGyI651zk5Q6263jc4wXxzcK1wvR+Kx5pVv6AyyAXEG0OsvqIGnEqbKumQnn+H5VKqetWKFwHFpsLpSnhcQ4yB948/aV3vfms95cmIYIC/HLSoZEw9OPW4bE7POC/LgISbim6TRlIPqqwWPjZVi+oCv0zafEFyb3OMxiC2RtXRvZGQu2c391++QJpuNIk4wgFnuPBwu/GyiLVwz1gaYR8uxP/JaAaPWjwzB5GTz6fgVE/Y2SVM/d30AxsJlcR5Fo7sZuEbOO5U+XXXaHys=", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?IGNC8zogezfWFKSUmMvPwV+?=\n\t=?iso-8859-1?q?0tyIUUGhrA+EkcPG21XFukP6A6u8WZusevmReury8erif56lNpwOAxWoBrv3?=\n\t=?iso-8859-1?q?WW5yhiPAc4kD7fMDs62Hq9m7nR/+/DX2Z7GytBbrU90KUyt2U62+cs5AH8Ni?=\n\t=?iso-8859-1?q?tP8W/hgjk18//w4Zs9O8te8rCWVPsCExlzzSNFl1zdt8Uxql30KbDIvmsm8U?=\n\t=?iso-8859-1?q?mgOgwt6l7ykBazPZl1k9J8qban+8puMze3sWly1PnO5tdxEYIKJLFiMfuhl0?=\n\t=?iso-8859-1?q?qb/vwYqMxpnkCjUTbJho80WLVfOOzLQIdJ8ytRH9RXW7eqWJQyKShMA2ug6I?=\n\t=?iso-8859-1?q?EycQZqzdnlB69HctwdaWxLwrtJhmO5f3WYc9VLA8QwbvEMU5LhPq7qTiiPMt?=\n\t=?iso-8859-1?q?OOYczMX2kWYufLbUC6HpfPmCB6cpKIotENLwNifGhWqfXi7MtPAYU1wkSgqZ?=\n\t=?iso-8859-1?q?lPnjL+4Nddw4dupmV7BnpjvVDI/OxxuwqJcOgJqG8jrHOnrlGudPtL2nH9M9?=\n\t=?iso-8859-1?q?cIHuaBllZ4MOyJh1tF5gFP27nmQEdf7p+scz55KCnAbu2kUNh4utu94wZ7zy?=\n\t=?iso-8859-1?q?91E2SwFKX1s+rgMzAw3FJgTT5uYbr11T3EQKayHC1hy1PZGq2ePnQ/xhaf24?=\n\t=?iso-8859-1?q?ixlMzsnStWDntJHJ8XRWLeVMpJ+1ONkQXZ1HJJniuzkjrNqmTfHS7LHCBgkl?=\n\t=?iso-8859-1?q?tV6Qxs/4uL0msdVd2MThVS6/rsmmegmLTKEpnBeVaWpdSquTWEFZT+o/6orH?=\n\t=?iso-8859-1?q?Wd5u6lgPqib0HCxULvXgHJOROA7WZY6rtZhRVjXOFpah2+70fF9fP+5gSSbS?=\n\t=?iso-8859-1?q?Yy46gaHL7LNxog1J6fo3gLFd6DKQUzKn6j3WLNSTP6q61Rsm0lJYoIDjGajN?=\n\t=?iso-8859-1?q?732UPuv76Ocel91D+CpMAeybpO5KBHmuVfiDBrzIYI1pH9zkGrG86yk0BC6v?=\n\t=?iso-8859-1?q?ibjD8QUvhQG3z6b25HdiiS2Szpsgwo6DRfhiiUM9PzZ6dsqZbfJ2X+MllX2+?=\n\t=?iso-8859-1?q?Hh0ITzn4W+wGMs9uG22EC2RTIRN8c1ltpoWBp4xZIKKlY6q1JC6Qp2p42hvh?=\n\t=?iso-8859-1?q?gq6qDYwYmI0nm3IM/vIdDW7K2idUtaCR3VlTcnG2GTf+3JGZfK1IBPdWZiGU?=\n\t=?iso-8859-1?q?AJaK29LcyScaVqrsb1lmWfEBsJfITIZGwSDUAR7GCQHi5dftbxCsxzD6Exzl?=\n\t=?iso-8859-1?q?VaNu5tmUdO8MHwlaDLnuBpvoPvgcH0SSkAiKGfnJrV9z74FMkGIjY0EerNf8?=\n\t=?iso-8859-1?q?AXtlLfzfSqVQCNT2f2jUhEoDTd76AYQ3A6LErVotm/vWrAlNPxc7D0Z6B4QR?=\n\t=?iso-8859-1?q?q7nPNelCTWhuRdX4oyTvm2ZALHj2wqzPJwRg2KV3+glGzsyNgzY4It9Cj8wg?=\n\t=?iso-8859-1?q?gy1cWDpKoO6vTNVUG+KC3Kb4TpZrNAfSoshNA1BO7AqPTzvdr2nColzgJZ40?=\n\t=?iso-8859-1?q?uW+LacKpez22PmZgaYBL3uRG8HTVYj+HDBG7JVuwc21+770s6//KA9moE9Xn?=\n\t=?iso-8859-1?q?cv0Mi8dDma+z4lsYgcCq4Hiy2jGXVftNMtgsPxKBOxScHp6O9NI+/hr3z6To?=\n\t=?iso-8859-1?q?yW/t/Hpxf6Hb12UQxL2vDdppZLZ9VOaq76wMXgn9GNHVfzqF8yYKmMLuJMB0?=\n\t=?iso-8859-1?q?bNInPQTj4XqvNSjobPLvAn4z1/Z5IGWeiJ6wQNKSr+q5kEmDcDbpT1bhshM7?=\n\t=?iso-8859-1?q?Um3Sv+O8S389bsEw92qHhJF2+bvJm1k7qlg2PWNtX0O8ZLxwbMexYpr9PicX?=\n\t=?iso-8859-1?q?UTXANFKCvcSBqnyWOH7MAXpndmrU9wSdOWi4SeYjGadbYgg=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n ct+FEKADV+dqXqlD9N+H4xNHJtGkEbF+Aw8C7SNyx/4DtYIdOCdeaGlY9Q+vykL4ytHXhQzryJsM+pzEwDCQkt7n12WsJljK38arKi4eaD2MNl6SBvOd4BD95bb/EhQ9ObWXuJ2VO9KGIDrkBiuW9O+IrVXsegmwPaUMaZ0WX0X0f9zZNkOSP3VXldBxkuX9OldN5eqguM40YK8Qbf1zAUBf7uIv8ssmiT6sxQKcJzJsenQJom+lGhpDEt1aTvnmcHnrb5cJ1blwFJquJ5nwgHinFw6uzNOltTLF9btTy7NBBy3SxTh0byGACTH1tqsoGeZ4f1ts8ISySCXbea3sFg==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "TYPPR06MB8206.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fdbfc5b8-6845-41ce-1399-08de99fbe630", "X-MS-Exchange-CrossTenant-originalarrivaltime": "14 Apr 2026 08:00:31.0485 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n EllFd4w8eATkRgTeXzrWOBeazI+JbVSiNg45zUZzTDbwUdkTepJdsKE9OQte/xrLWzMLRveORZ+gKTCC9ztrjnisRhrv5gm7/jx+RShd1j8=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "TYZPR06MB6745", "Received-SPF": "pass client-ip=2a01:111:f403:c40f::6;\n envelope-from=jamin_lin@aspeedtech.com;\n helo=SEYPR02CU001.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Replace direct fprintf(stderr, ...) calls with qemu_log_mask()\nusing LOG_GUEST_ERROR in the EHCI controller implementation.\n\nDirect writes to stderr are discouraged in QEMU as they bypass\nthe logging framework and cannot be filtered or controlled at\nruntime. Using qemu_log_mask() ensures that guest-visible errors\nare properly categorized and can be managed via QEMU logging\noptions.\n\nAll affected messages correspond to guest-triggerable error\nconditions, so LOG_GUEST_ERROR is used consistently.\n\nThis change improves integration with QEMU's logging infrastructure\nand aligns with upstream coding guidelines.\n\nSigned-off-by: Jamin Lin <jamin_lin@aspeedtech.com>\n---\n hw/usb/hcd-ehci.c | 43 +++++++++++++++++++++++++------------------\n 1 file changed, 25 insertions(+), 18 deletions(-)", "diff": "diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 9b92384bac..bebd137f94 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -36,6 +36,7 @@\n #include \"qemu/error-report.h\"\n #include \"qemu/main-loop.h\"\n #include \"system/runstate.h\"\n+#include \"qemu/log.h\"\n \n #define FRAME_TIMER_FREQ 1000\n #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ)\n@@ -425,7 +426,7 @@ static int ehci_get_pid(EHCIqtd *qtd)\n case 2:\n return USB_TOKEN_SETUP;\n default:\n- fprintf(stderr, \"bad token\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR, \"bad token\\n\");\n return 0;\n }\n }\n@@ -532,7 +533,7 @@ static void ehci_free_packet(EHCIPacket *p)\n }\n if (p->async == EHCI_ASYNC_FINISHED &&\n p->packet.status == USB_RET_SUCCESS) {\n- fprintf(stderr,\n+ qemu_log_mask(LOG_GUEST_ERROR,\n \"EHCI: Dropping completed packet from halted %s ep %02X\\n\",\n (p->pid == USB_TOKEN_IN) ? \"in\" : \"out\",\n get_field(p->queue->qh.epchar, QH_EPCHAR_EP));\n@@ -1042,8 +1043,9 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \n /* not supporting dynamic frame list size at the moment */\n if ((val & USBCMD_FLS) && !(s->usbcmd & USBCMD_FLS)) {\n- fprintf(stderr, \"attempt to set frame list size -- value %d\\n\",\n- (int)val & USBCMD_FLS);\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"attempt to set frame list size -- value %d\\n\",\n+ (int)val & USBCMD_FLS);\n val &= ~USBCMD_FLS;\n }\n \n@@ -1101,7 +1103,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \n case PERIODICLISTBASE:\n if (ehci_periodic_enabled(s)) {\n- fprintf(stderr,\n+ qemu_log_mask(LOG_GUEST_ERROR,\n \"ehci: PERIODIC list base register set while periodic schedule\\n\"\n \" is enabled and HC is enabled\\n\");\n }\n@@ -1109,7 +1111,7 @@ static void ehci_opreg_write(void *ptr, hwaddr addr,\n \n case ASYNCLISTADDR:\n if (ehci_async_enabled(s)) {\n- fprintf(stderr,\n+ qemu_log_mask(LOG_GUEST_ERROR,\n \"ehci: ASYNC list address register set while async schedule\\n\"\n \" is enabled and HC is enabled\\n\");\n }\n@@ -1200,7 +1202,7 @@ static int ehci_init_transfer(EHCIPacket *p)\n \n while (bytes > 0) {\n if (cpage > 4) {\n- fprintf(stderr, \"cpage out of range (%u)\\n\", cpage);\n+ qemu_log_mask(LOG_GUEST_ERROR, \"cpage out of range (%u)\\n\", cpage);\n qemu_sglist_destroy(&p->sgl);\n return -1;\n }\n@@ -1306,7 +1308,8 @@ static void ehci_execute_complete(EHCIQueue *q)\n break;\n default:\n /* should not be triggerable */\n- fprintf(stderr, \"USB invalid response %d\\n\", p->packet.status);\n+ qemu_log_mask(LOG_GUEST_ERROR, \"USB invalid response %d\\n\",\n+ p->packet.status);\n g_assert_not_reached();\n }\n \n@@ -1354,7 +1357,7 @@ static int ehci_execute(EHCIPacket *p, const char *action)\n p->async == EHCI_ASYNC_INITIALIZED);\n \n if (!(p->qtd.token & QTD_TOKEN_ACTIVE)) {\n- fprintf(stderr, \"Attempting to execute inactive qtd\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR, \"Attempting to execute inactive qtd\\n\");\n return -1;\n }\n \n@@ -1395,7 +1398,8 @@ static int ehci_execute(EHCIPacket *p, const char *action)\n p->packet.actual_length);\n \n if (p->packet.actual_length > BUFF_SIZE) {\n- fprintf(stderr, \"ret from usb_handle_packet > BUFF_SIZE\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"ret from usb_handle_packet > BUFF_SIZE\\n\");\n return -1;\n }\n \n@@ -1479,8 +1483,9 @@ static int ehci_process_itd(EHCIState *ehci,\n case USB_RET_SUCCESS:\n break;\n default:\n- fprintf(stderr, \"Unexpected iso usb result: %d\\n\",\n- ehci->ipacket.status);\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"Unexpected iso usb result: %d\\n\",\n+ ehci->ipacket.status);\n /* Fall through */\n case USB_RET_IOERROR:\n case USB_RET_NODEV:\n@@ -1584,7 +1589,8 @@ static int ehci_state_fetchentry(EHCIState *ehci, int async)\n \n /* section 4.8, only QH in async schedule */\n if (async && (NLPTR_TYPE_GET(entry) != NLPTR_TYPE_QH)) {\n- fprintf(stderr, \"non queue head request in async schedule\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"non queue head request in async schedule\\n\");\n return -1;\n }\n \n@@ -1606,7 +1612,7 @@ static int ehci_state_fetchentry(EHCIState *ehci, int async)\n \n default:\n /* TODO: handle FSTN type */\n- fprintf(stderr, \"FETCHENTRY: entry at %X is of type %u \"\n+ qemu_log_mask(LOG_GUEST_ERROR, \"FETCHENTRY: entry at %X is of type %u \"\n \"which is not supported yet\\n\", entry, NLPTR_TYPE_GET(entry));\n return -1;\n }\n@@ -2112,13 +2118,14 @@ static void ehci_advance_state(EHCIState *ehci, int async)\n break;\n \n default:\n- fprintf(stderr, \"Bad state!\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR, \"Bad state!\\n\");\n g_assert_not_reached();\n }\n \n if (again < 0 || itd_count > 16) {\n /* TODO: notify guest (raise HSE irq?) */\n- fprintf(stderr, \"processing error - resetting ehci HC\\n\");\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"processing error - resetting ehci HC\\n\");\n ehci_reset(ehci);\n again = 0;\n }\n@@ -2175,7 +2182,7 @@ static void ehci_advance_async_state(EHCIState *ehci)\n \n default:\n /* this should only be due to a developer mistake */\n- fprintf(stderr, \"ehci: Bad asynchronous state %d. \"\n+ qemu_log_mask(LOG_GUEST_ERROR, \"ehci: Bad asynchronous state %d. \"\n \"Resetting to active\\n\", ehci->astate);\n g_assert_not_reached();\n }\n@@ -2225,7 +2232,7 @@ static void ehci_advance_periodic_state(EHCIState *ehci)\n \n default:\n /* this should only be due to a developer mistake */\n- fprintf(stderr, \"ehci: Bad periodic state %d. \"\n+ qemu_log_mask(LOG_GUEST_ERROR, \"ehci: Bad periodic state %d. \"\n \"Resetting to active\\n\", ehci->pstate);\n g_assert_not_reached();\n }\n", "prefixes": [ "v2", "04/17" ] }