Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2222446/?format=api
{ "id": 2222446, "url": "http://patchwork.ozlabs.org/api/patches/2222446/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260411211313.1597912-1-fw@strlen.de/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260411211313.1597912-1-fw@strlen.de>", "list_archive_url": null, "date": "2026-04-11T21:13:08", "name": "[nf-next,v2] netfilter: nft_set_rbtree: remove dead conditional", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f2e83e6383afc9bd407f0a2efdbea46c32e58d5f", "submitter": { "id": 1025, "url": "http://patchwork.ozlabs.org/api/people/1025/?format=api", "name": "Florian Westphal", "email": "fw@strlen.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260411211313.1597912-1-fw@strlen.de/mbox/", "series": [ { "id": 499575, "url": "http://patchwork.ozlabs.org/api/series/499575/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499575", "date": "2026-04-11T21:13:08", "name": "[nf-next,v2] netfilter: nft_set_rbtree: remove dead conditional", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/499575/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222446/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222446/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11825-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11825-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftRGw2G2gz1yGg\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 07:13:28 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 18E703008D57\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 21:13:25 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CD0C73115A2;\n\tSat, 11 Apr 2026 21:13:23 +0000 (UTC)", "from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C554248880\n\tfor <netfilter-devel@vger.kernel.org>; Sat, 11 Apr 2026 21:13:22 +0000 (UTC)", "by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 6BADE60344; Sat, 11 Apr 2026 23:13:20 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775942003; cv=none;\n b=T4r6KY7nTZRl6x3gQFnLG42aRVP8MdPiYUfksGHfGmSOVruxkBvl2SnAVpcFHFbthQpz85GpswOILEnHv/s8wf0ehRiS6t15QRU9ABM1zZsvUT2rz2QduVK6gxNNwen9dbN3SpiReRCM+zwuSWTLIfJWl+kgtOlRZ8SNXNLbOsA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775942003; c=relaxed/simple;\n\tbh=YY9wQ/wmEerCIGpGyAyPo+RV8dgCsMqlPJ6sTDFtMBw=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=knAx/Y0iUfE1Ab3t8VpAWVgzOAl8MrxVTVnkwOkAqMwW8qIjbWdAv5TLrVztw84OYgbIpbFf0LXRXvV0WFIHiILlmyYI58aGsp+Z0toE9FEEIQWNT3Mmxa8d49WCUCzgVU/BzUCPyl0t4WEOVoNVIp/hzGVCvNAld4S4JpNJ8os=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30", "From": "Florian Westphal <fw@strlen.de>", "To": "<netfilter-devel@vger.kernel.org>", "Cc": "Florian Westphal <fw@strlen.de>,\n\tDan Carpenter <error27@gmail.com>", "Subject": "[PATCH nf-next v2] netfilter: nft_set_rbtree: remove dead conditional", "Date": "Sat, 11 Apr 2026 23:13:08 +0200", "Message-ID": "<20260411211313.1597912-1-fw@strlen.de>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "net/netfilter/nft_set_rbtree.c:399 __nft_rbtree_insert()\n warn: 'removed_end' is not an error pointer\n\nSince commit : 087388278e0f (\"netfilter: nf_tables: nft_set_rbtree: fix\nspurious insertion failure\") __nft_rbtree_insert() can no longer fail\nand this condition is always false. Remove it.\n\nReported-by: Dan Carpenter <error27@gmail.com>\nCloses: https://lore.kernel.org/netfilter-devel/adjSaolTji0mPgqx@stanley.mountain/\nSigned-off-by: Florian Westphal <fw@strlen.de>\n---\n v2: re-target to nf-next & fix commit message.\n There is no bug, the condition is never true anymore.\n\n net/netfilter/nft_set_rbtree.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c\nindex 737c339decd0..3407109d6a5c 100644\n--- a/net/netfilter/nft_set_rbtree.c\n+++ b/net/netfilter/nft_set_rbtree.c\n@@ -396,9 +396,6 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set,\n \t\t\tconst struct nft_rbtree_elem *removed_end;\n \n \t\t\tremoved_end = nft_rbtree_gc_elem(set, priv, rbe);\n-\t\t\tif (IS_ERR(removed_end))\n-\t\t\t\treturn PTR_ERR(removed_end);\n-\n \t\t\tif (removed_end == rbe_le || removed_end == rbe_ge)\n \t\t\t\treturn -EAGAIN;\n \n", "prefixes": [ "nf-next", "v2" ] }