Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2222428/?format=api
{ "id": 2222428, "url": "http://patchwork.ozlabs.org/api/patches/2222428/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20260411163705.948426-1-tiwei.btw@antgroup.com/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260411163705.948426-1-tiwei.btw@antgroup.com>", "list_archive_url": null, "date": "2026-04-11T16:37:05", "name": "um: vector: Remove unnecessary NULL check in destroy_queue()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b3fabbd8c6ff83da3de3a1ff653b062a144e150b", "submitter": { "id": 87896, "url": "http://patchwork.ozlabs.org/api/people/87896/?format=api", "name": "Tiwei Bie", "email": "tiwei.btw@antgroup.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20260411163705.948426-1-tiwei.btw@antgroup.com/mbox/", "series": [ { "id": 499565, "url": "http://patchwork.ozlabs.org/api/series/499565/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=499565", "date": "2026-04-11T16:37:05", "name": "um: vector: Remove unnecessary NULL check in destroy_queue()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499565/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2222428/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2222428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vjfM8cHT;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=antgroup.com header.i=@antgroup.com header.a=rsa-sha256\n header.s=default header.b=qqdU0W9Y;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftK9T2HDMz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 02:38:12 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBbLQ-0000000Ddkk-1mqS;\n\tSat, 11 Apr 2026 16:38:04 +0000", "from out28-3.mail.aliyun.com ([115.124.28.3])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wBbLM-0000000Ddjh-2Pfe\n\tfor linux-um@lists.infradead.org;\n\tSat, 11 Apr 2026 16:38:03 +0000", "from ubuntu..(mailfrom:tiwei.btw@antgroup.com\n fp:SMTPD_---.h9ur6et_1775925445 cluster:ay29)\n by smtp.aliyun-inc.com;\n Sun, 12 Apr 2026 00:37:46 +0800" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tMIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner;\n\tbh=32XDPxTh3hyuGD6AcGpPtFLd0DUI1/fNrBqBJNZoPuw=; b=vjfM8cHTG54oHbHnP4SE5dT2Po\n\tZmIKtmyd87M3Lv6lox3a7dwTFbd+3lTtvFveVzDdgKOyNn/0Ho9vkgTOrF7gfqlTaFhGusu1cJCWe\n\tofdP+eJ9ChRpUSWhov4yemcAoawGtGwIsvhPQdvaH8buxAod8UUS2pHIsJ05f+OQuSKDow5vsWWWW\n\t6c6ggKtoPr2iUXSb42geFDts/FXiAiOGHi2cYMNNkfcvRDszM/yuLlcg5dLKjLewAVxCzTU7nsWq1\n\tUBYk9xc6nPdtS6RPej+Xzt1AxyEfGMR8vcyNvANckvS5zVnSCLpux0oo7oV3evCmEU/kCNLtAqe7L\n\t+SAVX4EQ==;", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=antgroup.com; s=default;\n\tt=1775925471; h=From:To:Subject:Date:Message-Id:MIME-Version;\n\tbh=32XDPxTh3hyuGD6AcGpPtFLd0DUI1/fNrBqBJNZoPuw=;\n\tb=qqdU0W9YBaDy2syl7wLI8z7/PcB+mk/X0kw9rVGVSXMheXmuZ9Kz8i3Rk7REAlQJkCvm3mLdlfqzcZWXNUivO7NreBgUxPdcTKdWd1TzriIZndJFtZ+5nla9J4P0EQg2w2loIHabuTNSc/Vl/poRo/AcK4iZaaVC1kOD5aDv5FE=" ], "X-Alimail-AntiSpam": "\n AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037031241;MF=tiwei.btw@antgroup.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---.h9ur6et_1775925445;", "From": "Tiwei Bie <tiwei.btw@antgroup.com>", "To": "richard@nod.at,\n\tanton.ivanov@cambridgegreys.com,\n\tjohannes@sipsolutions.net", "Cc": "linux-um@lists.infradead.org,\n\tTiwei Bie <tiwei.btw@antgroup.com>,\n\tkernel test robot <lkp@intel.com>,\n\tDan Carpenter <error27@gmail.com>", "Subject": "[PATCH] um: vector: Remove unnecessary NULL check in destroy_queue()", "Date": "Sun, 12 Apr 2026 00:37:05 +0800", "Message-Id": "<20260411163705.948426-1-tiwei.btw@antgroup.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260411_093801_189008_E859CC39 ", "X-CRM114-Status": "UNSURE ( 7.32 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: All callers of destroy_queue() already perform a NULL\n check,\n so a NULL qi will never be passed in. Inside destroy_queue(),\n we dereference\n qi immediately, and the subsequent NULL check on qi is unneces [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no\n trust\n [115.124.28.3 listed in list.dnswl.org]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [115.124.28.3 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [115.124.28.3 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [115.124.28.3 listed in bl.score.senderscore.com]\n 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)\n [115.124.28.3 listed in wl.mailspike.net]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "All callers of destroy_queue() already perform a NULL check, so\na NULL qi will never be passed in. Inside destroy_queue(), we\ndereference qi immediately, and the subsequent NULL check on qi\nis unnecessary and confusing. Remove it to address the smatch\nwarning.\n\nReported-by: kernel test robot <lkp@intel.com>\nReported-by: Dan Carpenter <error27@gmail.com>\nCloses: https://lore.kernel.org/r/202604110937.MLUL70Lx-lkp@intel.com/\nSigned-off-by: Tiwei Bie <tiwei.btw@antgroup.com>\n---\n arch/um/drivers/vector_kern.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c\nindex 2cc90055499a..755d936e5b43 100644\n--- a/arch/um/drivers/vector_kern.c\n+++ b/arch/um/drivers/vector_kern.c\n@@ -471,8 +471,6 @@ static void destroy_queue(struct vector_queue *qi)\n \tstruct vector_private *vp = netdev_priv(qi->dev);\n \tstruct mmsghdr *mmsg_vector;\n \n-\tif (qi == NULL)\n-\t\treturn;\n \t/* deallocate any skbuffs - we rely on any unused to be\n \t * set to NULL.\n \t */\n", "prefixes": [] }