Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2221941/?format=api
{ "id": 2221941, "url": "http://patchwork.ozlabs.org/api/patches/2221941/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260410125105.39340-2-wsa+renesas@sang-engineering.com/", "project": { "id": 21, "url": "http://patchwork.ozlabs.org/api/projects/21/?format=api", "name": "Linux Tegra Development", "link_name": "linux-tegra", "list_id": "linux-tegra.vger.kernel.org", "list_email": "linux-tegra@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260410125105.39340-2-wsa+renesas@sang-engineering.com>", "list_archive_url": null, "date": "2026-04-10T12:49:12", "name": "mailbox: prefix new constants with MBOX_", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0bd9afe8dcb894d8b521d3a9202c3407c0071226", "submitter": { "id": 69646, "url": "http://patchwork.ozlabs.org/api/people/69646/?format=api", "name": "Wolfram Sang", "email": "wsa+renesas@sang-engineering.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-tegra/patch/20260410125105.39340-2-wsa+renesas@sang-engineering.com/mbox/", "series": [ { "id": 499459, "url": "http://patchwork.ozlabs.org/api/series/499459/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-tegra/list/?series=499459", "date": "2026-04-10T12:49:12", "name": "mailbox: prefix new constants with MBOX_", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499459/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221941/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221941/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-tegra+bounces-13691-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-tegra@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=sang-engineering.com header.i=@sang-engineering.com\n header.a=rsa-sha256 header.s=k1 header.b=PT9XZv14;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13691-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=sang-engineering.com\n header.i=@sang-engineering.com header.b=\"PT9XZv14\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=194.117.254.33", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=sang-engineering.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=sang-engineering.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fscbh6Vf1z1yGS\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 23:10:08 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 91E0830015B1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 12:58:41 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1196A299959;\n\tFri, 10 Apr 2026 12:58:40 +0000 (UTC)", "from mail.zeus03.de (zeus03.de [194.117.254.33])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F2D348453\n\tfor <linux-tegra@vger.kernel.org>; Fri, 10 Apr 2026 12:58:37 +0000 (UTC)", "(qmail 1249670 invoked from network); 10 Apr 2026 14:51:13 +0200", "by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted,\n authenticated); 10 Apr 2026 14:51:13 +0200" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775825919; cv=none;\n b=OmFDWQ7kqZEH/WgoWxGBfTzkqWXWJu8MwRjAJhldgTPyDGKMFYOJIjZtS3Qx4WycmR9+NocN9WYiFjfCwA8oHFoH8rqRp7GhCaPfB9MB++Yu8s8EK9gT/dHqWnidpjYX/ugLzzjWMpel4rqlQx+8S/L4CB0CPnGZyQsPQr8qx04=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775825919; c=relaxed/simple;\n\tbh=ZqoHXRcVfvsBna1aRNXakyPiZ+0rwW24Qd/Ju/et5BA=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=KZWNUAJ0YyPiMmGD4tHqeSCpp2M/1WzxJDAffnw8zTR+7YmCpiTlXcuzvDe25irFd8LDEluFm1aTBQuKeJalpt8gbor3lJJefgdyVFkWekiEEMlLcptPgDi0MXuidZC8bseVZ7hl1WlZxGZEOCRfR8X6TNV7GnKAmb3T9DqRVM8=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=sang-engineering.com;\n spf=pass smtp.mailfrom=sang-engineering.com;\n dkim=pass (2048-bit key) header.d=sang-engineering.com\n header.i=@sang-engineering.com header.b=PT9XZv14;\n arc=none smtp.client-ip=194.117.254.33", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tsang-engineering.com; h=from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding; s=k1; bh=hZ69bOR3/6zlmi\n\tUsLzPVxv31mozYAaVG3lW9J1qZUxI=; b=PT9XZv14TZKyIZjpRDMZJR1GC/7nt6\n\titsg24VEoIYNOGnXun4s5/H4GQGToC3SeshINnvbY183bBqOsOhePB+Evwg631S9\n\tKmyOgPpt+Cb/MKTH9Zm2bqAYtzf+4d7WNi1B8C1POUALGRAPB99XCrlZpR/URL77\n\tCx2GcWQAYTKJFlU5pDstn8eobP4FuUfrXWgdqEEVD+VAeIHWBjMVB8urgNGBXW2y\n\tJLWRn287bZxDsHggwgTknq010sAzJoinV4kngM3S0Ly3mMWSuWdrCzTo5a1QUg8E\n\tpjxDcfdrEY4wbZepST3vrAAZM3HLsra9iaKkXRjbFmfbJWLaBQ47RKbQ==", "X-UD-Smtp-Session": "l3s3148p1@QqiHlhpPpI9UszZ9", "From": "Wolfram Sang <wsa+renesas@sang-engineering.com>", "To": "linux-renesas-soc@vger.kernel.org,\n\tJassi Brar <jassisinghbrar@gmail.com>", "Cc": "Wolfram Sang <wsa+renesas@sang-engineering.com>,\n\tPeter Chen <peter.chen@cixtech.com>,\n\tFugang Duan <fugang.duan@cixtech.com>,\n\tCIX Linux Kernel Upstream Group <cix-kernel-upstream@cixtech.com>,\n\tFrank Li <Frank.Li@nxp.com>,\n\tSascha Hauer <s.hauer@pengutronix.de>,\n\tPengutronix Kernel Team <kernel@pengutronix.de>,\n\tFabio Estevam <festevam@gmail.com>,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,\n\tThierry Reding <thierry.reding@kernel.org>,\n\tJonathan Hunter <jonathanh@nvidia.com>,\n\tlinux-arm-kernel@lists.infradead.org,\n\timx@lists.linux.dev,\n\tlinux-mediatek@lists.infradead.org,\n\tlinux-tegra@vger.kernel.org", "Subject": "[PATCH] mailbox: prefix new constants with MBOX_", "Date": "Fri, 10 Apr 2026 14:49:12 +0200", "Message-ID": "<20260410125105.39340-2-wsa+renesas@sang-engineering.com>", "X-Mailer": "git-send-email 2.51.0", "Precedence": "bulk", "X-Mailing-List": "linux-tegra@vger.kernel.org", "List-Id": "<linux-tegra.vger.kernel.org>", "List-Subscribe": "<mailto:linux-tegra+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-tegra+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Commit 89e5d7d61600 (\"mailbox: remove superfluous internal header\")\nmoved some constants to a public header but forgot to add a mailbox\nspecific prefix. Add this now to prevent future collisions on a too\ngeneric naming.\n\nLink: https://sashiko.dev/#/patchset/20260327151112.5202-2-wsa%2Brenesas%40sang-engineering.com\nSigned-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>\n---\n\nThis patch improves the above mentioned commit which already sits in\n-next. It is not really a fix but it probably is still a good idea to\napply it before rc1 to avoid confusion.\n\n drivers/mailbox/cix-mailbox.c | 2 +-\n drivers/mailbox/imx-mailbox.c | 2 +-\n drivers/mailbox/mailbox.c | 22 +++++++++++-----------\n drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-\n drivers/mailbox/omap-mailbox.c | 2 +-\n drivers/mailbox/tegra-hsp.c | 2 +-\n include/linux/mailbox_controller.h | 6 +++---\n 7 files changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/mailbox/cix-mailbox.c b/drivers/mailbox/cix-mailbox.c\nindex 8cfaa91b75bd..43c76cdab24a 100644\n--- a/drivers/mailbox/cix-mailbox.c\n+++ b/drivers/mailbox/cix-mailbox.c\n@@ -413,7 +413,7 @@ static int cix_mbox_startup(struct mbox_chan *chan)\n \tswitch (cp->type) {\n \tcase CIX_MBOX_TYPE_DB:\n \t\t/* Overwrite txdone_method for DB channel */\n-\t\tchan->txdone_method = TXDONE_BY_ACK;\n+\t\tchan->txdone_method = MBOX_TXDONE_BY_ACK;\n \t\tfallthrough;\n \tcase CIX_MBOX_TYPE_REG:\n \t\tif (priv->dir == CIX_MBOX_TX) {\ndiff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c\nindex 22331b579489..246a9a9e3952 100644\n--- a/drivers/mailbox/imx-mailbox.c\n+++ b/drivers/mailbox/imx-mailbox.c\n@@ -732,7 +732,7 @@ static struct mbox_chan * imx_mu_xlate(struct mbox_controller *mbox,\n \tp_chan = &mbox->chans[chan];\n \n \tif (type == IMX_MU_TYPE_TXDB_V2)\n-\t\tp_chan->txdone_method = TXDONE_BY_ACK;\n+\t\tp_chan->txdone_method = MBOX_TXDONE_BY_ACK;\n \n \treturn p_chan;\n }\ndiff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c\nindex 138ffbcd4fde..30eafdf3a91e 100644\n--- a/drivers/mailbox/mailbox.c\n+++ b/drivers/mailbox/mailbox.c\n@@ -72,7 +72,7 @@ static void msg_submit(struct mbox_chan *chan)\n \t\t}\n \t}\n \n-\tif (!err && (chan->txdone_method & TXDONE_BY_POLL)) {\n+\tif (!err && (chan->txdone_method & MBOX_TXDONE_BY_POLL)) {\n \t\t/* kick start the timer immediately to avoid delays */\n \t\tscoped_guard(spinlock_irqsave, &chan->mbox->poll_hrt_lock)\n \t\t\thrtimer_start(&chan->mbox->poll_hrt, 0, HRTIMER_MODE_REL);\n@@ -162,7 +162,7 @@ EXPORT_SYMBOL_GPL(mbox_chan_received_data);\n */\n void mbox_chan_txdone(struct mbox_chan *chan, int r)\n {\n-\tif (unlikely(!(chan->txdone_method & TXDONE_BY_IRQ))) {\n+\tif (unlikely(!(chan->txdone_method & MBOX_TXDONE_BY_IRQ))) {\n \t\tdev_err(chan->mbox->dev,\n \t\t \"Controller can't run the TX ticker\\n\");\n \t\treturn;\n@@ -183,7 +183,7 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone);\n */\n void mbox_client_txdone(struct mbox_chan *chan, int r)\n {\n-\tif (unlikely(!(chan->txdone_method & TXDONE_BY_ACK))) {\n+\tif (unlikely(!(chan->txdone_method & MBOX_TXDONE_BY_ACK))) {\n \t\tdev_err(chan->mbox->dev, \"Client can't run the TX ticker\\n\");\n \t\treturn;\n \t}\n@@ -344,8 +344,8 @@ static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl)\n \t\tchan->cl = cl;\n \t\tinit_completion(&chan->tx_complete);\n \n-\t\tif (chan->txdone_method\t== TXDONE_BY_POLL && cl->knows_txdone)\n-\t\t\tchan->txdone_method = TXDONE_BY_ACK;\n+\t\tif (chan->txdone_method\t== MBOX_TXDONE_BY_POLL && cl->knows_txdone)\n+\t\t\tchan->txdone_method = MBOX_TXDONE_BY_ACK;\n \t}\n \n \tif (chan->mbox->ops->startup) {\n@@ -499,8 +499,8 @@ void mbox_free_channel(struct mbox_chan *chan)\n \tscoped_guard(spinlock_irqsave, &chan->lock) {\n \t\tchan->cl = NULL;\n \t\tchan->active_req = MBOX_NO_MSG;\n-\t\tif (chan->txdone_method == TXDONE_BY_ACK)\n-\t\t\tchan->txdone_method = TXDONE_BY_POLL;\n+\t\tif (chan->txdone_method == MBOX_TXDONE_BY_ACK)\n+\t\t\tchan->txdone_method = MBOX_TXDONE_BY_POLL;\n \t}\n \n \tmodule_put(chan->mbox->dev->driver->owner);\n@@ -531,13 +531,13 @@ int mbox_controller_register(struct mbox_controller *mbox)\n \t\treturn -EINVAL;\n \n \tif (mbox->txdone_irq)\n-\t\ttxdone = TXDONE_BY_IRQ;\n+\t\ttxdone = MBOX_TXDONE_BY_IRQ;\n \telse if (mbox->txdone_poll)\n-\t\ttxdone = TXDONE_BY_POLL;\n+\t\ttxdone = MBOX_TXDONE_BY_POLL;\n \telse /* It has to be ACK then */\n-\t\ttxdone = TXDONE_BY_ACK;\n+\t\ttxdone = MBOX_TXDONE_BY_ACK;\n \n-\tif (txdone == TXDONE_BY_POLL) {\n+\tif (txdone == MBOX_TXDONE_BY_POLL) {\n \n \t\tif (!mbox->ops->last_tx_done) {\n \t\t\tdev_err(mbox->dev, \"last_tx_done method is absent\\n\");\ndiff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c\nindex 547a10a8fad3..e523c84b4808 100644\n--- a/drivers/mailbox/mtk-cmdq-mailbox.c\n+++ b/drivers/mailbox/mtk-cmdq-mailbox.c\n@@ -728,7 +728,7 @@ static int cmdq_probe(struct platform_device *pdev)\n \tcmdq->mbox.ops = &cmdq_mbox_chan_ops;\n \tcmdq->mbox.of_xlate = cmdq_xlate;\n \n-\t/* make use of TXDONE_BY_ACK */\n+\t/* make use of MBOX_TXDONE_BY_ACK */\n \tcmdq->mbox.txdone_irq = false;\n \tcmdq->mbox.txdone_poll = false;\n \ndiff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c\nindex 5772c6b9886a..535ca8020877 100644\n--- a/drivers/mailbox/omap-mailbox.c\n+++ b/drivers/mailbox/omap-mailbox.c\n@@ -238,7 +238,7 @@ static int omap_mbox_startup(struct omap_mbox *mbox)\n \t}\n \n \tif (mbox->send_no_irq)\n-\t\tmbox->chan->txdone_method = TXDONE_BY_ACK;\n+\t\tmbox->chan->txdone_method = MBOX_TXDONE_BY_ACK;\n \n \tomap_mbox_enable_irq(mbox, IRQ_RX);\n \ndiff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c\nindex 7b1e1b83ea29..500fa77c7d53 100644\n--- a/drivers/mailbox/tegra-hsp.c\n+++ b/drivers/mailbox/tegra-hsp.c\n@@ -514,7 +514,7 @@ static int tegra_hsp_mailbox_startup(struct mbox_chan *chan)\n \tstruct tegra_hsp *hsp = mb->channel.hsp;\n \tunsigned long flags;\n \n-\tchan->txdone_method = TXDONE_BY_IRQ;\n+\tchan->txdone_method = MBOX_TXDONE_BY_IRQ;\n \n \t/*\n \t * Shared mailboxes start out as consumers by default. FULL and EMPTY\ndiff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h\nindex e3896b08f22e..a49ee687d4cf 100644\n--- a/include/linux/mailbox_controller.h\n+++ b/include/linux/mailbox_controller.h\n@@ -15,9 +15,9 @@ struct mbox_chan;\n /* Sentinel value distinguishing \"no active request\" from \"NULL message data\" */\n #define MBOX_NO_MSG\t((void *)-1)\n \n-#define TXDONE_BY_IRQ\tBIT(0) /* controller has remote RTR irq */\n-#define TXDONE_BY_POLL\tBIT(1) /* controller can read status of last TX */\n-#define TXDONE_BY_ACK\tBIT(2) /* S/W ACK received by Client ticks the TX */\n+#define MBOX_TXDONE_BY_IRQ\tBIT(0) /* controller has remote RTR irq */\n+#define MBOX_TXDONE_BY_POLL\tBIT(1) /* controller can read status of last TX */\n+#define MBOX_TXDONE_BY_ACK\tBIT(2) /* S/W ACK received by Client ticks the TX */\n \n /**\n * struct mbox_chan_ops - methods to control mailbox channels\n", "prefixes": [] }