Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2221689/?format=api
{ "id": 2221689, "url": "http://patchwork.ozlabs.org/api/patches/2221689/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-write_booster-v5-3-d44e1a0e191c@samsung.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260410-write_booster-v5-3-d44e1a0e191c@samsung.com>", "list_archive_url": null, "date": "2026-04-10T05:57:16", "name": "[v5,3/5] hw/ufs: Add idle operation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c47d1c4a2fc5524cabd1ab5c9e550237722ad690", "submitter": { "id": 93039, "url": "http://patchwork.ozlabs.org/api/people/93039/?format=api", "name": "Jaemyung Lee", "email": "ldc.jml@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-write_booster-v5-3-d44e1a0e191c@samsung.com/mbox/", "series": [ { "id": 499400, "url": "http://patchwork.ozlabs.org/api/series/499400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499400", "date": "2026-04-10T05:57:14", "name": "hw/ufs: Add Write Booster Support on UFS", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/499400/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221689/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221689/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=nVwzyxZl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsR1m4lvTz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 15:58:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wB4s7-0004rk-MC; Fri, 10 Apr 2026 01:57:39 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <ldc.jml@gmail.com>) id 1wB4s6-0004r5-9y\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 01:57:38 -0400", "from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <ldc.jml@gmail.com>) id 1wB4s4-0007yJ-Qw\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 01:57:38 -0400", "by mail-pg1-x52b.google.com with SMTP id\n 41be03b00d2f7-c736261ee8dso686710a12.1\n for <qemu-devel@nongnu.org>; Thu, 09 Apr 2026 22:57:36 -0700 (PDT)", "from [172.17.0.5] ([168.126.243.22])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c79218fc8d9sm1225965a12.12.2026.04.09.22.57.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 22:57:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775800655; x=1776405455; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=s7rduMfdSHBv6Dm+D3nhuA8gVs+ENlu+IzPYpxEzuEI=;\n b=nVwzyxZlQvwRIVA+kgibucTsoo9px2EivKfE8/IcKP4EHjcswWyVjRzYvyzviU0X7d\n GqTDlhHVBokOCCPOiLwS644uYowWyCC+AkeeEPpI9Kh3+NX0IjNn05cgNJ08ldcrNnjP\n +fDuO5RYid/hqrfSD+Ey3C1uuQiEsYqOMWWXNUnVjGUtrpDCHFpHVyetbmpx9i5eeQri\n Y++d8zgwADlFrfy8vnx/tOVliJ2UsMDjnumi3ZBb/EqUQuWkZy3XKjeCGfFk+KJgqRq9\n uupNJgOaAIbnWYWx1/WcE5DE7Qu5K0aGFmv9Oim81Fn6c2xE/Pq+lFpVoaqIYQ2EfJU8\n 8Kdw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775800655; x=1776405455;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=s7rduMfdSHBv6Dm+D3nhuA8gVs+ENlu+IzPYpxEzuEI=;\n b=Coc5BvSEYZB4waKr30OzAOw1ObAI+BEtY8TikOny0tVQCSDah5vDq5L2nV4FZ2SgML\n nH3BWdtVUGijmjw3Q1xwwcCuzq2b5kE7ly1DR0gKelj3Ps3xqi8nMNbiZS52pw6MKU/t\n NJyLOIKqzj5K41SbiLYA4e5KWS7vWm6D3ORoybeqEqZeSFKU4iVlwyxUhNnN311CTEiR\n 5c8U+khOG8m3CCwXqMmfESEFuBgywUp436Xa0YCDN9P0tJzSv+vPX4sQoNtAuMotGCf6\n WfE1aENT4f/RhwLIRR9EymeLytNwfqiR4kODRdxNPBecBTGfLCZ9T3C8hcbtrKRpEToj\n C1vQ==", "X-Gm-Message-State": "AOJu0YxCu6lwC0Wf7xwOJz5VATMyiDNAEFDBh+HFkzMd2upoZkO4V/PO\n cgPNfJ+vwTkyWIRV6oGkV01i0tCMPkMwxdWITvdex50xPM0XcQcVfSZr", "X-Gm-Gg": "AeBDiesn2doynK3oZCWyhAFTIF5p75yGy9WeVnEKtZU4N2WLSmd1poJbmNe/BSzpb+7\n NKLmMA4EDP24+Ql2fVua1VKhMVTrvdGZh7aswvMk4UAI1fA1pBB63P2DX3qTVZDwqQ0MiCUHmB7\n MHVdfHtaytEheV/PBHGlDyzQAL5tETnZCt27daodvhn2UvjPoVuuxGzorYEKtkWcof5mH1SRfb2\n VCLPqCUAlRN+SUIMPK5F1hBxftwHL92u6OcPVmyMLDtbQ/KRRoNcO/VXuRU0b7/0dN/DgLURq+3\n Kxtk56giw4V7NvkOj4FIsh34PpB8h4DcTw9DSBqW7O62mgYA7ZIWZWBW1l9yHe9XwflWvI91utG\n w72wAODRV7SgxOmQMjdw4/nOpqUZ2oHgq3mUZkCGM+Yeqeb5d9LZLrPaytkI1YRtXLCAtwY/GfB\n FvPMHCxWgQcia8xCQ8Ik/j1iCT2dfRTQ==", "X-Received": "by 2002:a05:6a20:729b:b0:39c:4c23:a175 with SMTP id\n adf61e73a8af0-39fe40026a7mr2115115637.45.1775800655436;\n Thu, 09 Apr 2026 22:57:35 -0700 (PDT)", "From": "Jaemyung Lee <ldc.jml@gmail.com>", "X-Google-Original-From": "Jaemyung Lee <jaemyung.lee@samsung.com>", "Date": "Fri, 10 Apr 2026 14:57:16 +0900", "Subject": "[PATCH v5 3/5] hw/ufs: Add idle operation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260410-write_booster-v5-3-d44e1a0e191c@samsung.com>", "References": "<20260410-write_booster-v5-0-d44e1a0e191c@samsung.com>", "In-Reply-To": "<20260410-write_booster-v5-0-d44e1a0e191c@samsung.com>", "To": "qemu-devel@nongnu.org", "Cc": "Jeuk Kim <jeuk20.kim@samsung.com>, Kevin Wolf <kwolf@redhat.com>,\n Hanna Reitz <hreitz@redhat.com>, qemu-block@nongnu.org,\n Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Jaemyung Lee <jaemyung.lee@samsung.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1775800645; l=3493;\n i=jaemyung.lee@samsung.com; s=20260402; h=from:subject:message-id;\n bh=U1I7iR9KAXBx24tNL1R8hKu0trzHrSPwvB+dS7OpoRs=;\n b=W8jthARYna/2LYMfh5ouMy3fTqaKr56qNjQpI3MDkq1KG6PHSxqLrTCuE0fmO3kCcnNe1/YO4\n 0oMMu/eNkKyAHrd4Zr8acIECW6J0C+VXIx1CHVPc9fI1kssWX7ULzxr", "X-Developer-Key": "i=jaemyung.lee@samsung.com; a=ed25519;\n pk=bZPd7A/kteUO62FfUM6IrI1LuBPe5QrcqfvsitM1ZjE=", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::52b;\n envelope-from=ldc.jml@gmail.com; helo=mail-pg1-x52b.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When no I/O occurs, the UFS Device performs various internal operations.\nTo emulate this, adds a timer that periodically checks the current I/O\nstatus of the device and call the ufs_process_idle() function when idle.\n\nSigned-off-by: Jaemyung Lee <jaemyung.lee@samsung.com>\n---\n hw/ufs/ufs.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n hw/ufs/ufs.h | 2 ++\n 2 files changed, 73 insertions(+)", "diff": "diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c\nindex 69f82ab462d135fe6cda479891f9d8f26d19be9a..c504a0d7e3fb89eb5558cfd9c410cda9396bc3b4 100644\n--- a/hw/ufs/ufs.c\n+++ b/hw/ufs/ufs.c\n@@ -1801,6 +1801,71 @@ static void ufs_sendback_req(void *opaque)\n ufs_irq_check(u);\n }\n \n+static void ufs_process_idle(UfsHc *u)\n+{\n+ /* Currently do nothing */\n+ return;\n+}\n+\n+static inline bool ufs_check_idle(UfsHc *u)\n+{\n+ return !u->reg.utrldbr;\n+}\n+\n+static inline bool ufs_mcq_check_idle(UfsHc *u)\n+{\n+ if (!u->params.mcq) {\n+ return true;\n+ }\n+\n+ for (int qid = 0; qid < ARRAY_SIZE(u->sq); qid++) {\n+ if (!u->sq[qid]) {\n+ continue;\n+ }\n+\n+ if (!ufs_mcq_sq_empty(u, qid)) {\n+ return false;\n+ }\n+\n+ /* internal ongoing MCQ request check */\n+ UfsSq *sq = u->sq[qid];\n+ for (int i = 0; i < sq->size; i++) {\n+ if (sq->req[i].state != UFS_REQUEST_IDLE) {\n+ return false;\n+ }\n+ }\n+ }\n+\n+ for (int qid = 0; qid < ARRAY_SIZE(u->cq); qid++) {\n+ if (!u->cq[qid]) {\n+ continue;\n+ }\n+\n+ if (!ufs_mcq_cq_empty(u, qid)) {\n+ return false;\n+ }\n+\n+ if (!QTAILQ_EMPTY(&u->cq[qid]->req_list)) {\n+ return false;\n+ }\n+ }\n+\n+ return true;\n+}\n+\n+#define UFS_IDLE_TIMER_TICK 100 /* 0.1s */\n+static void ufs_idle_timer_cb(void *opaque)\n+{\n+ UfsHc *u = opaque;\n+ int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT);\n+\n+ if (ufs_check_idle(u) && ufs_mcq_check_idle(u)) {\n+ ufs_process_idle(u);\n+ }\n+\n+ timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n+}\n+\n static bool ufs_check_constraints(UfsHc *u, Error **errp)\n {\n if (u->params.nutrs > UFS_MAX_NUTRS) {\n@@ -1863,6 +1928,7 @@ static void ufs_init_hc(UfsHc *u)\n uint32_t cap = 0;\n uint32_t mcqconfig = 0;\n uint32_t mcqcap = 0;\n+ int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT);\n \n u->reg_size = pow2ceil(ufs_reg_size(u));\n \n@@ -1959,6 +2025,9 @@ static void ufs_init_hc(UfsHc *u)\n * dynamically\n */\n u->temperature = UFS_TEMPERATURE;\n+\n+ timer_init_ms(&u->idle_timer, QEMU_CLOCK_VIRTUAL_RT, ufs_idle_timer_cb, u);\n+ timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n }\n \n static void ufs_realize(PCIDevice *pci_dev, Error **errp)\n@@ -1986,6 +2055,8 @@ static void ufs_exit(PCIDevice *pci_dev)\n {\n UfsHc *u = UFS(pci_dev);\n \n+ timer_del(&u->idle_timer);\n+\n qemu_free_irq(u->irq);\n \n qemu_bh_delete(u->doorbell_bh);\ndiff --git a/hw/ufs/ufs.h b/hw/ufs/ufs.h\nindex 13d964c5ae5ec430a98b2ef71987cb9279e9a317..b5f040302129f4d02732ddd20ef82eb33c41922a 100644\n--- a/hw/ufs/ufs.h\n+++ b/hw/ufs/ufs.h\n@@ -148,6 +148,8 @@ typedef struct UfsHc {\n UfsCq *cq[UFS_MAX_MCQ_QNUM];\n \n uint8_t temperature;\n+\n+ QEMUTimer idle_timer;\n } UfsHc;\n \n static inline uint32_t ufs_mcq_sq_tail(UfsHc *u, uint32_t qid)\n", "prefixes": [ "v5", "3/5" ] }