Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2221670/?format=api
{ "id": 2221670, "url": "http://patchwork.ozlabs.org/api/patches/2221670/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-12-kwilczynski@kernel.org/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260410055040.39233-12-kwilczynski@kernel.org>", "list_archive_url": null, "date": "2026-04-10T05:50:31", "name": "[11/20] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a717314bbb1a1bba10fc022c71f5910d4caf6cda", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260410055040.39233-12-kwilczynski@kernel.org/mbox/", "series": [ { "id": 499398, "url": "http://patchwork.ozlabs.org/api/series/499398/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=499398", "date": "2026-04-10T05:50:21", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/499398/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2221670/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2221670/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-52273-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fhcFm+T1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52273-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"fhcFm+T1\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsQsX2408z1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 15:51:28 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id E85DF300C032\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 05:51:25 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DAC8D322B9F;\n\tFri, 10 Apr 2026 05:51:24 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B72B130F52A;\n\tFri, 10 Apr 2026 05:51:24 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 22D21C2BCAF;\n\tFri, 10 Apr 2026 05:51:21 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775800284; cv=none;\n b=XG2dCJDqM8xne98IOzM/5E5hVf1QEEEswIYcV7J+z81Cv4qMoNPW+7zTh/lO9Cg/KDwr3bYc7Q+3abACOYtfF6dKCVh3sZ3ufkej1XSD5PCzfH4skjrTHr0mqKxiY+sxkoBQRcyD8ma8CTivG6XGsb9++f+JNSKb/aOGs50HgwI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775800284; c=relaxed/simple;\n\tbh=4+W1kd8ovvTGg2a+x1mXoEZZdmh6JcYJxVFeZ3Yu0xQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=I/SDcrqIYo0uEM4iyVtvA4MkLhESQx7vyfFT7rNac9atDfYEk3M0JX4BiT8WqBGbBa0UX/fl6dci/1pHF2eSOtaFV6mobmoZuQbaHOaUorsb3ozaRZZq7W0l0QKsya8E5vbrNjmDH5vC+Pd4P8vdFjOzCxWfqqGOEObvxU3+IGM=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=fhcFm+T1; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775800284;\n\tbh=4+W1kd8ovvTGg2a+x1mXoEZZdmh6JcYJxVFeZ3Yu0xQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fhcFm+T12KNVqPEsauDmvNs2LgfnB15yjv07PjZoD5L2qgLCuSm8jS2fqKePwfwyl\n\t hUr7/un8ohQP2ZqR45z2sokFDVsaSUbSep87bcyWUnDxZHhSLTGP+q+Nty/zI7NEK+\n\t i4ss+3NC2srWor8vOMhDUWRTO9EbgSmHxOIc4gIl5C7rb2u9ttihS4qC3G6lEIkqqZ\n\t Pu6GtV96b1n3g3IeugY30bB6IJ8PYeXYTvADqUCjuaw0APrUOgMkGPJU7lE+ELXzhx\n\t O3DjB98247UHP3RjJNj9CLtkTNsRqiQXVuowSaLVR1XfNIFPlZ2ZLY5JMac9O3gxMs\n\t JIwZVi+YpY0Ag==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH 11/20] alpha/PCI: Use BAR index in sysfs attr->private instead\n of resource pointer", "Date": "Fri, 10 Apr 2026 05:50:31 +0000", "Message-ID": "<20260410055040.39233-12-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260410055040.39233-1-kwilczynski@kernel.org>", "References": "<20260410055040.39233-1-kwilczynski@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit" }, "content": "Currently, Alpha's pci_create_one_attr() stores a resource pointer in\nattr->private, and pci_mmap_resource() loops through all BARs to find\nthe matching index.\n\nThus, store the BAR index directly in attr->private and retrieve the\nresource via pci_resource_n(). This eliminates the loop and aligns\nwith the convention used by the generic PCI sysfs code.\n\nWhile at it, add parentheses around the bitwise flag test in\npci_mmap_resource() to make the precedence explicit, and to\nmatch the preferred style.\n\nThe PCI core change was first added in the commit dca40b186b75 (\"PCI:\nUse BAR index in sysfs attr->private instead of resource pointer\").\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n arch/alpha/kernel/pci-sysfs.c | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)", "diff": "diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2324720c3e83..c84867ce31f5 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -69,25 +69,20 @@ static int pci_mmap_resource(struct kobject *kobj,\n \t\t\t struct vm_area_struct *vma, int sparse)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n-\tstruct resource *res = attr->private;\n+\tint barno = (unsigned long)attr->private;\n+\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n-\tint i, ret;\n+\tint ret;\n \n \tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n \tif (ret)\n \t\treturn ret;\n \n-\tfor (i = 0; i < PCI_STD_NUM_BARS; i++)\n-\t\tif (res == &pdev->resource[i])\n-\t\t\tbreak;\n-\tif (i >= PCI_STD_NUM_BARS)\n-\t\treturn -ENODEV;\n-\n-\tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n+\tif ((res->flags & IORESOURCE_MEM) && iomem_is_exclusive(res->start))\n \t\treturn -EINVAL;\n \n-\tif (!__pci_mmap_fits(pdev, i, vma, sparse))\n+\tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n \tpcibios_resource_to_bus(pdev->bus, &bar, res);\n@@ -170,7 +165,7 @@ static int pci_create_one_attr(struct pci_dev *pdev, int num, char *name,\n \tres_attr->attr.name = name;\n \tres_attr->attr.mode = S_IRUSR | S_IWUSR;\n \tres_attr->size = sparse ? size << 5 : size;\n-\tres_attr->private = &pdev->resource[num];\n+\tres_attr->private = (void *)(unsigned long)num;\n \treturn sysfs_create_bin_file(&pdev->dev.kobj, res_attr);\n }\n \n", "prefixes": [ "11/20" ] }