Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220214/?format=api
{ "id": 2220214, "url": "http://patchwork.ozlabs.org/api/patches/2220214/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260406155717.880246-7-den@valinux.co.jp/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260406155717.880246-7-den@valinux.co.jp>", "list_archive_url": null, "date": "2026-04-06T15:57:16", "name": "[v13,6/7] PCI: endpoint: pci-epf-test: Reuse pre-exposed doorbell targets", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "83c22ef77e4fcbda54bb577520358b6dc3449903", "submitter": { "id": 91573, "url": "http://patchwork.ozlabs.org/api/people/91573/?format=api", "name": "Koichiro Den", "email": "den@valinux.co.jp" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260406155717.880246-7-den@valinux.co.jp/mbox/", "series": [ { "id": 498879, "url": "http://patchwork.ozlabs.org/api/series/498879/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498879", "date": "2026-04-06T15:57:10", "name": "PCI: endpoint: pci-ep-msi: Add embedded doorbell fallback", "version": 13, "mbox": "http://patchwork.ozlabs.org/series/498879/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220214/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220214/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51961-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.a=rsa-sha256 header.s=selector1 header.b=HMb1IXKb;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51961-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.b=\"HMb1IXKb\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.229.111", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=valinux.co.jp", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=valinux.co.jp", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=valinux.co.jp;" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqDbR2yKVz1yFt\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 02:01:39 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9761D305B291\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 6 Apr 2026 15:57:39 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 69EDB325701;\n\tMon, 6 Apr 2026 15:57:37 +0000 (UTC)", "from TY3P286CU002.outbound.protection.outlook.com\n (mail-japaneastazon11020111.outbound.protection.outlook.com [52.101.229.111])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B97338936;\n\tMon, 6 Apr 2026 15:57:32 +0000 (UTC)", "from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10)\n by TYYP286MB4187.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:10b::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Mon, 6 Apr\n 2026 15:57:26 +0000", "from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026\n 15:57:26 +0000" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775491057; cv=fail;\n b=BXNTQSXsYtFwFMN/UegCcgy4TdhW2KVLrJpDpHJbBrQ3x5HMMoEXEtLIR7koEGnmzaNK4uvnkFnXihssOBkVeHZG23+qNEDzZaxBECo3QvDYBriGUQ127bqkQalNnS8J5iOZMUHbhU/kgzK7kcNUDdPnBKDRBQz/w2vJgOrBzSQ=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=zVVunOv4DnKJD9rrdsUBMoDuEb2aQGmMJ7dgOeQLEeRVDeUkhytSJIfTE5c8BLlVQGPQkeokzP/QmaHEhWcIHCjpFJxrIlkcV6nlh5HY7vE0YmzdG+1nUwpcBcwAMh9hHU+FrM45rXpmhUkQMqrE5JLRtuf9fT1oByS+ZJgypxmBFXM1xLML+7/Os6NbCLCnY5AhZdG293UKUYAW/KyoQ2yNaElCdSVMLYkZLcGmp+9vvWOCUqOzxfZHvBBqXID6Q0cynHbt7WyMiaGAMw9eRetpFnvOJNxtAAcbjVT+2OBMRiAGDww7SWaAtZkm43RtlPuoH7ovqRvMpP7WSNDk2g==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775491057; c=relaxed/simple;\n\tbh=dlVnbhX8PxGnedfMNDpDYZosmRi6VsKB2pbJC0JUfqo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=sjZHB+tIrbkpTEmSLbi728BfZ3a463bqthCy8LRp7L2XN12nmPtvTLsPJPtKKNurlx1FlEDB2UzgG1KZFUuh4OoTPiDUtZkK0mlNJ/9FjlP1PBO3Oi6ZG2np9F35ckw0v6wEKQrNbQY7voMgBKPAln5lXjELKOj8mLF8jZhFIeY=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Zdv0PXxOcHbw+RGn7yNzlRw8lKljXPhJ7YMgz3q8sHU=;\n b=LxdKXVkjNaDXlsEjrc5rABLjGsNghB9Wy7GRxLn/r+KnAP/VA67eL1ZzBddq7sDWh3u0WX5g/rx/HXCGowbNjkLiyxjavo75pHoPwLZsVT97N5vW9RYeLGG2kyQdfT2MLPl9oSHfMFofgfPgiFu8U4zn9Wm1v6eGDLE0mfCSnqlGUbSPAlDF7AY6yq8u1f2eHjCRqsXBq3/BdI6we6r+NJS7I4UcO7Fv/m/HgyY2WeF7/rH7kA/A9ORrSDlidUtPvYR+PeFi6/bf6kDK7SbMZEUrJDQnhP2NumKSOs+snvo2aWBZv3yD7vdxd2132HJN2JCdsIvAuLrrnmi9wDt2Hg==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=valinux.co.jp;\n spf=pass smtp.mailfrom=valinux.co.jp;\n dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.b=HMb1IXKb; arc=fail smtp.client-ip=52.101.229.111", "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=valinux.co.jp; dmarc=pass action=none\n header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Zdv0PXxOcHbw+RGn7yNzlRw8lKljXPhJ7YMgz3q8sHU=;\n b=HMb1IXKbKGPfYZfc8uyskIp0iD1l8avGItwwXlvT2UYuSHDR9CnAevjRdwUWcxOKl962umS5A72l/mQKjIxMnYM73f4SjrtNq+JR57i/7Tx03iY8wmZ3VK12aso/2wGgo3XI1iBGkXyAEV9X4UrX4eL3ON9F0Nb1rqPA7NC/ulo=", "From": "Koichiro Den <den@valinux.co.jp>", "To": "Jingoo Han <jingoohan1@gmail.com>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kwilczynski@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>,\n Kishon Vijay Abraham I <kishon@kernel.org>, Jon Mason <jdmason@kudzu.us>,\n Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,\n Niklas Cassel <cassel@kernel.org>, Frank Li <Frank.Li@nxp.com>,\n Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,\n Manikanta Maddireddy <mmaddireddy@nvidia.com>", "Cc": "linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tntb@lists.linux.dev", "Subject": "[PATCH v13 6/7] PCI: endpoint: pci-epf-test: Reuse pre-exposed\n doorbell targets", "Date": "Tue, 7 Apr 2026 00:57:16 +0900", "Message-ID": "<20260406155717.880246-7-den@valinux.co.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260406155717.880246-1-den@valinux.co.jp>", "References": "<20260406155717.880246-1-den@valinux.co.jp>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "TY4P286CA0065.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:371::7) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:38f::10)", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "TY7P286MB7722:EE_|TYYP286MB4187:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f085b6c2-a810-4804-87df-08de93f53305", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7416014|56012099003|22082099003|18002099003|921020;", "X-Microsoft-Antispam-Message-Info": "\n\t/aZnCGKYWg9w7+S8iQmeywok2+ONGH5jC1+MavrD/w33SLy99+nss9yUDnjcX8bNoVOW95L11UxXLf19A7tLnoUkVNv0LYJvjX5mPUcJlqWmBJoKHTR6j8jsnZ1Bf+bveplRZf6lIgdZAJZkhHLoxmLF8AlTXY+WreRk+QdYUB3Q4CL6+lUZ12X3XA1QjSDdhWzlhyKWli7PvqW/BYoZWdB5WrMReX/JnD8mUAo6BR1p+rP//FQbciCkgbo+E6VOmMToLZQkMIMaAFo7SfI8UZpbzNHCClCLSIFOETbENE48cKDm+qA/Quhp2tA1CV5/m+IK1toMnC/6I4zCGtNonXRbYYThpFOt6xuwCsKCFs4UlfGhqtqyOmCgEqWe7sX4ZucNDPba72dpJKA93+i9HaiwePqjgPAtyF/EIEoQhJzzlUq1jD/ZSN2klaV/k9Mw1ma32wZ9v1nTiDbRXNLznXnnVOFMvyekHClJ3HCPt9rZterlX7zPV2rmAWsi8XA9hLqpbQ/fVFDqxarF0bf1LqzIckrmDZYyh/FcfL/B1+ozsy8l5MyHPQpVPRT3IG9Q7UtHft8Sy4kJjXgH4dTkD7i+J7HCYSaNq0V3XM/B5OiDNFbirrURj8AOwo6OfOyNUtsGZKhos4zTGJ3hbFKJR/GzclKGZs5eGIfkZi2GLdTlXf2PJLSAtLHGFWze4iGa2MY8G++XkqEtjIBD0oW7W9dLmZdbwGtl0iPXe2vCg0nGuyM6A5MpeIBZ4zidz5NDxCVjmX0FLaD15QbOSvKUvw==", "X-Forefront-Antispam-Report": "\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7416014)(56012099003)(22082099003)(18002099003)(921020);DIR:OUT;SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n xMVTisX8nHFtptXKwASx+3b6fOMgL8aeMZ6egPmd5nEKkAXZBdMnQmF3FrKjTcxNnt5sQJZX2xUBk7zuUs45Fv4tJq64IY4Zt5Cb9XsROZu05Cewudr5/EBvy3N7Qrazbe+uTdTqpaprgguhBvsHgoWd5zRqGOGgFRpnka8nMyN1Wbei89ZEE0TratiniUKgFKJEEQZKh6q0twTdZsWBuLjVUSaBXse66rTXQ9qGM6WjvkL+Haj9YTwdK7g6YAGRtb0g4mLEcP6baIeZnf0jzVRvYoygQ9oF6fx4ZcOw0tdc9soFmwF/yveOrGTpAkyjVTUjXDDPP2qINJTTSARDZdf3rGrNyDEpkzzBEINkMlBQtALV2dMkI4453ICEgLHnI6aS6bi1rATRIDUF5BeVUkEt+gORdtNhwSd3uFsEGVJS6kPbN7jJ3Xr45ZRFohyWLdmoMGVwIDJkIEVqTliQLfkE7CN0VDTcY1ydjiLiZu6QJpqPog/+p27vp4ASLMJ9G466YHEp9BZDohuiLsq1PbQncOzjaObV85KUG8AFUiKZPI0OypDwd5kkI/bWtvJau7NAebsOosw6ArpgsmFypDPd6gv/nVfd9p5y1SDUBceT1KIPgAjHLshxplyRaovG8402siOzGkJ78+35RC7edbHICL283LcMnEHcU2XHEU7nkg7GTMe8SDfEWBT0p57CeshnkThqbqsucnFJrQoPtT9xzdut5kXSG4QFZrBhoqS68XJIN7S1B4DpOGlidzZbMBC4XxvQLuPW6a//s2zj2un4w7uzCNsDMqk3bP9CtcArkB2wod6q2tttuVJMc63eomFCSxkXVGLnEYkPLSY1opymKz4vtB5i99A3gEUCZDCunlLx9Yj4fmF0nYASKjDawQm0SQOBWGWfTcPLiCqjJi2X07pQZC/hD+qKu4VBSbVZ16Psq9QXSsJ8hs9MgCuKNHb76dxEDQkMDp2/GQ9w1OB7eD6WA5g9yA1vU8zrJFwTiRanqpiyst1ohVhT+r7V5wNmxQq7oPIT52IHxt+Q6mIp2vcDyJvjM4Dd7mU7efXfk/a6otYZ2hSgWfMuwis0fL9b1JhLqZMKeli8d/C5ItKFW1osMw+7SrWORg2LFtqUfpNPbkngsPKDIZ3DxtaW+6So8ZqrycPwOhpDoKOTmLRDrG5sJw76chJD00tEXtwhBF//g7t4qcwYn3OFl6C4/9t/Gt4lNZxR1j271DF+vnNhi2SGq0SOh2TzYlgxAeEtFvCwEN5vcw6VYH7DmADYe8xIgpqdIVQUcs1EJcYQ4INsdmGSQ6MbRPKhGZlI/Brw4XAq8uNPytzni8tG8HyonWLvJ3Ki/p8SXSeNSjxG6nV9P4Fu5UzEmasq8d6dIJ8FShAnv3dfYiT9P5616kn6jeOgsShEKuruR4YPBXknCV7hoc0/28z7rHxV1QT578fCtQ3Tc1FtiUKABKmb/x1GRYrRgpYUd7zjp83AZFbmyss28wwqeq31TtdOihWt4stoG+mL+KvyO03SZgN3SBEr+F73IzlKsS3vhZznMzL9Mv59VXfXMaO38/2EpjBXw9R8A2uIci7M2AnJZMHyWyuwsebUNs1t5SgbB9UFD5A8JBQw6MFy01v0X/cWgxL5zExzxmd37H6G2hg/3fS3osfyYfGUDVVIKdKTSFtNnagUva//s8T+cWaP347vyII8ZOhaV1Gnfs4PquaXBUcQgNjj1FLP7wyUjx9Ms9e1G6oyu99scw1WEP8rzlQjfH1J46aIQoDY05JJp0eWI9RRIaCs", "X-OriginatorOrg": "valinux.co.jp", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f085b6c2-a810-4804-87df-08de93f53305", "X-MS-Exchange-CrossTenant-AuthSource": "TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Apr 2026 15:57:26.6015\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "7a57bee8-f73d-4c5f-a4f7-d72c91c8c111", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n wuV8HGyY1Qe56hM8/FjLKAaeHkIFGZ0iQWu3FUWope27fVBzxDBt1AOFWXV25wXV8NqIGtV2rKzh1ZGU5cIyTQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "TYYP286MB4187" }, "content": "pci-epf-test advertises the doorbell target to the RC as a BAR number\nand an offset, and the RC rings the doorbell with a single DWORD MMIO\nwrite.\n\nSome doorbell backends may report that the doorbell target is already\nexposed via a platform-owned fixed BAR (db_msg[0].bar/offset). In that\ncase, reuse the pre-exposed window and do not reprogram the BAR with\npci_epc_set_bar().\n\nAlso honor db_msg[0].irq_flags when requesting the doorbell IRQ, and\nonly restore the original BAR mapping on disable if pci-epf-test\nprogrammed it.\n\nTested-by: Niklas Cassel <cassel@kernel.org>\nReviewed-by: Frank Li <Frank.Li@nxp.com>\nSigned-off-by: Koichiro Den <den@valinux.co.jp>\n---\n drivers/pci/endpoint/functions/pci-epf-test.c | 84 +++++++++++++------\n 1 file changed, 57 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c\nindex 14e61ebe1f11..b6c865b0883d 100644\n--- a/drivers/pci/endpoint/functions/pci-epf-test.c\n+++ b/drivers/pci/endpoint/functions/pci-epf-test.c\n@@ -93,6 +93,7 @@ struct pci_epf_test {\n \tbool\t\t\tdma_private;\n \tconst struct pci_epc_features *epc_features;\n \tstruct pci_epf_bar\tdb_bar;\n+\tbool\t\t\tdb_bar_programmed;\n \tsize_t\t\t\tbar_size[PCI_STD_NUM_BARS];\n };\n \n@@ -732,7 +733,9 @@ static void pci_epf_test_enable_doorbell(struct pci_epf_test *epf_test,\n {\n \tu32 status = le32_to_cpu(reg->status);\n \tstruct pci_epf *epf = epf_test->epf;\n+\tstruct pci_epf_doorbell_msg *db;\n \tstruct pci_epc *epc = epf->epc;\n+\tunsigned long irq_flags;\n \tstruct msi_msg *msg;\n \tenum pci_barno bar;\n \tsize_t offset;\n@@ -742,13 +745,28 @@ static void pci_epf_test_enable_doorbell(struct pci_epf_test *epf_test,\n \tif (ret)\n \t\tgoto set_status_err;\n \n-\tmsg = &epf->db_msg[0].msg;\n-\tbar = pci_epc_get_next_free_bar(epf_test->epc_features, epf_test->test_reg_bar + 1);\n-\tif (bar < BAR_0)\n-\t\tgoto err_doorbell_cleanup;\n+\tdb = &epf->db_msg[0];\n+\tmsg = &db->msg;\n+\tepf_test->db_bar_programmed = false;\n+\n+\tif (db->bar != NO_BAR) {\n+\t\t/*\n+\t\t * The doorbell target is already exposed via a platform-owned\n+\t\t * fixed BAR\n+\t\t */\n+\t\tbar = db->bar;\n+\t\toffset = db->offset;\n+\t} else {\n+\t\tbar = pci_epc_get_next_free_bar(epf_test->epc_features,\n+\t\t\t\t\t\tepf_test->test_reg_bar + 1);\n+\t\tif (bar < BAR_0)\n+\t\t\tgoto err_doorbell_cleanup;\n+\t}\n+\n+\tirq_flags = epf->db_msg[0].irq_flags | IRQF_ONESHOT;\n \n \tret = request_threaded_irq(epf->db_msg[0].virq, NULL,\n-\t\t\t\t pci_epf_test_doorbell_handler, IRQF_ONESHOT,\n+\t\t\t\t pci_epf_test_doorbell_handler, irq_flags,\n \t\t\t\t \"pci-ep-test-doorbell\", epf_test);\n \tif (ret) {\n \t\tdev_err(&epf->dev,\n@@ -760,22 +778,30 @@ static void pci_epf_test_enable_doorbell(struct pci_epf_test *epf_test,\n \treg->doorbell_data = cpu_to_le32(msg->data);\n \treg->doorbell_bar = cpu_to_le32(bar);\n \n-\tmsg = &epf->db_msg[0].msg;\n-\tret = pci_epf_align_inbound_addr(epf, bar, ((u64)msg->address_hi << 32) | msg->address_lo,\n-\t\t\t\t\t &epf_test->db_bar.phys_addr, &offset);\n+\tif (db->bar == NO_BAR) {\n+\t\tret = pci_epf_align_inbound_addr(epf, bar,\n+\t\t\t\t\t\t ((u64)msg->address_hi << 32) |\n+\t\t\t\t\t\t msg->address_lo,\n+\t\t\t\t\t\t &epf_test->db_bar.phys_addr,\n+\t\t\t\t\t\t &offset);\n \n-\tif (ret)\n-\t\tgoto err_free_irq;\n+\t\tif (ret)\n+\t\t\tgoto err_free_irq;\n+\t}\n \n \treg->doorbell_offset = cpu_to_le32(offset);\n \n-\tepf_test->db_bar.barno = bar;\n-\tepf_test->db_bar.size = epf->bar[bar].size;\n-\tepf_test->db_bar.flags = epf->bar[bar].flags;\n+\tif (db->bar == NO_BAR) {\n+\t\tepf_test->db_bar.barno = bar;\n+\t\tepf_test->db_bar.size = epf->bar[bar].size;\n+\t\tepf_test->db_bar.flags = epf->bar[bar].flags;\n \n-\tret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, &epf_test->db_bar);\n-\tif (ret)\n-\t\tgoto err_free_irq;\n+\t\tret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, &epf_test->db_bar);\n+\t\tif (ret)\n+\t\t\tgoto err_free_irq;\n+\n+\t\tepf_test->db_bar_programmed = true;\n+\t}\n \n \tstatus |= STATUS_DOORBELL_ENABLE_SUCCESS;\n \treg->status = cpu_to_le32(status);\n@@ -805,17 +831,21 @@ static void pci_epf_test_disable_doorbell(struct pci_epf_test *epf_test,\n \tfree_irq(epf->db_msg[0].virq, epf_test);\n \tpci_epf_test_doorbell_cleanup(epf_test);\n \n-\t/*\n-\t * The doorbell feature temporarily overrides the inbound translation\n-\t * to point to the address stored in epf_test->db_bar.phys_addr, i.e.,\n-\t * it calls set_bar() twice without ever calling clear_bar(), as\n-\t * calling clear_bar() would clear the BAR's PCI address assigned by\n-\t * the host. Thus, when disabling the doorbell, restore the inbound\n-\t * translation to point to the memory allocated for the BAR.\n-\t */\n-\tret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, &epf->bar[bar]);\n-\tif (ret)\n-\t\tgoto set_status_err;\n+\tif (epf_test->db_bar_programmed) {\n+\t\t/*\n+\t\t * The doorbell feature temporarily overrides the inbound translation\n+\t\t * to point to the address stored in epf_test->db_bar.phys_addr, i.e.,\n+\t\t * it calls set_bar() twice without ever calling clear_bar(), as\n+\t\t * calling clear_bar() would clear the BAR's PCI address assigned by\n+\t\t * the host. Thus, when disabling the doorbell, restore the inbound\n+\t\t * translation to point to the memory allocated for the BAR.\n+\t\t */\n+\t\tret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, &epf->bar[bar]);\n+\t\tif (ret)\n+\t\t\tgoto set_status_err;\n+\n+\t\tepf_test->db_bar_programmed = false;\n+\t}\n \n \tstatus |= STATUS_DOORBELL_DISABLE_SUCCESS;\n \treg->status = cpu_to_le32(status);\n", "prefixes": [ "v13", "6/7" ] }