Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220209/?format=api
{ "id": 2220209, "url": "http://patchwork.ozlabs.org/api/patches/2220209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260406155717.880246-5-den@valinux.co.jp/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260406155717.880246-5-den@valinux.co.jp>", "list_archive_url": null, "date": "2026-04-06T15:57:14", "name": "[v13,4/7] PCI: endpoint: pci-ep-msi: Refactor doorbell allocation for new backends", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1b9fd919eca1cdbf6ee4a0f7bf0bda69d536a286", "submitter": { "id": 91573, "url": "http://patchwork.ozlabs.org/api/people/91573/?format=api", "name": "Koichiro Den", "email": "den@valinux.co.jp" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260406155717.880246-5-den@valinux.co.jp/mbox/", "series": [ { "id": 498879, "url": "http://patchwork.ozlabs.org/api/series/498879/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498879", "date": "2026-04-06T15:57:10", "name": "PCI: endpoint: pci-ep-msi: Add embedded doorbell fallback", "version": 13, "mbox": "http://patchwork.ozlabs.org/series/498879/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220209/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51959-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.a=rsa-sha256 header.s=selector1 header.b=uFCCTb9G;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-51959-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.b=\"uFCCTb9G\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.228.114", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=valinux.co.jp", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=valinux.co.jp", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=valinux.co.jp;" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqDW23QH9z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 01:57:50 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 51024301A51A\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 6 Apr 2026 15:57:33 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 03B6B329C6D;\n\tMon, 6 Apr 2026 15:57:32 +0000 (UTC)", "from OS0P286CU011.outbound.protection.outlook.com\n (mail-japanwestazon11020114.outbound.protection.outlook.com [52.101.228.114])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C454325701;\n\tMon, 6 Apr 2026 15:57:29 +0000 (UTC)", "from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:38f::10)\n by TYYP286MB4187.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:10b::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Mon, 6 Apr\n 2026 15:57:25 +0000", "from TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n ([fe80::2305:327c:28ec:9b32]) by TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n ([fe80::2305:327c:28ec:9b32%5]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026\n 15:57:24 +0000" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775491051; cv=fail;\n b=U+cbkxlSMOogIe/pdmxYed61redk879Y529TRhfcMEPtg5XiYca/rSzMpdj60xZVr3Z6MflJpaoaC2CHqof/3vT8NUyT+LB3sqgR0mObisSuy+AkahNEpXuGpI0sKK04gOlu1VxDK43DccMGKbfedFDOak0Da27HDiLK5W9S36U=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=JLQaHMU7tnLFYX0fzkiREpL8c0ULnvJJphGti1yZaG143kXfBB3vRIfCck2kTjPNvcnLRFK2up3xtfulECG6u041VCKgb01Htmz+z9l+gE7qwUjZyh5fYltHWlJHKZ9MQEVyth/YdFK3M+UeFFwzSM7bQ7OPL2zP0Vhew/Oq+yOADtoTZAZSF/RS+yycJ0lo39Jf4H5fFiKnRofx3rQatrzshDF3+Pp/Wt4OCWUYxFjgy+VLUQyJgPUcXTid+DWPX0U8OU7xDbjTKq/XC78+wi2oSjRvqd4loy+DhipD/CH0pA67kfCMQ8hDt3bhFSMh0ip7Rb1N8OT69LdhB3cp1A==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775491051; c=relaxed/simple;\n\tbh=24CtTktMCrTYnhJKM0CPxo89ofgYKr4aiWJjFoL6RkY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=qBZbtB71+3zu6lfasIRa4GCqes4rCeV22psMkHCdAsKEpq6Z4/uB4tbv448PAlPY7Wg/fPrRASScYVFTfxHyWq6wbhGmENlSVXDCilZDdp/5Qp4KxDW2K9/KrNZ4osEjoudcmEG18gYrDdp7t3dyQHni7dxWWWu2GEsVgFmqQgQ=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=r7RiGuw4rdIqME4X0uRgpKq66eSKksk/+mPslKC5zL4=;\n b=RjDPUTw3bz11IbpcDZApJrgA4oES+wZe5+lDnwrR6uu89Eefumz+bvNY7KSGD8usEnR1WKpwsbEH2ypCMzThi0JsKzl0jIiryLRwjd5zKLiyxJsNItLTY0MWrs4sivyA4aU5ZwB696owTehiBjZVU9jGWUMdlc7MKNycTTD+9zpVxQBxTZ2/tniiu4hJcclYNmd+6MojWDr3GpM2KK6O75qZzRhMmpHfD+PAx+M4dO2S26DEbrAx2HM96a5D4Cnq7kZHTagpVnbdH+R67NIW+wzdHAjCruj5U93L3ixV5A3uHfZsD9FOf73YyEtfGaGBA9HIAb29cOp+Q7LsZgYnTQ==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=valinux.co.jp;\n spf=pass smtp.mailfrom=valinux.co.jp;\n dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp\n header.b=uFCCTb9G; arc=fail smtp.client-ip=52.101.228.114", "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=valinux.co.jp; dmarc=pass action=none\n header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=r7RiGuw4rdIqME4X0uRgpKq66eSKksk/+mPslKC5zL4=;\n b=uFCCTb9GauZrdoAq+dabFwkBSGF2Tl5x7tRIdxDJO97gOSS0GO1lT/3q3h40YQWZght9Sg8ZWaOAK1LKzpdgeUTJNgIY4IDTICpt7B7nzYqT6oWGl46f+HYJnRim/LC14ABVs4CWG+MqGqKvSEhYEDzjNgYQsNFSG1IqAAnuK48=", "From": "Koichiro Den <den@valinux.co.jp>", "To": "Jingoo Han <jingoohan1@gmail.com>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kwilczynski@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>,\n Kishon Vijay Abraham I <kishon@kernel.org>, Jon Mason <jdmason@kudzu.us>,\n Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,\n Niklas Cassel <cassel@kernel.org>, Frank Li <Frank.Li@nxp.com>,\n Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>,\n Marco Crivellari <marco.crivellari@suse.com>,\n Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,\n Manikanta Maddireddy <mmaddireddy@nvidia.com>", "Cc": "linux-pci@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tntb@lists.linux.dev", "Subject": "[PATCH v13 4/7] PCI: endpoint: pci-ep-msi: Refactor doorbell\n allocation for new backends", "Date": "Tue, 7 Apr 2026 00:57:14 +0900", "Message-ID": "<20260406155717.880246-5-den@valinux.co.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260406155717.880246-1-den@valinux.co.jp>", "References": "<20260406155717.880246-1-den@valinux.co.jp>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "TYCP286CA0043.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:400:29d::14) To TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:38f::10)", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "TY7P286MB7722:EE_|TYYP286MB4187:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e4d2aa31-0dae-4c22-bfa1-08de93f53203", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7416014|56012099003|22082099003|18002099003|921020;", "X-Microsoft-Antispam-Message-Info": "\n\t0VWuc4K868ZEIfrLzRs8hDSwlJH296OZdSFyMwU3wX73jxmKdPWLVEN3SVY2HmnOVnQ5YL/QlV+yI1jHTiDhv4hVvbs0EibxT8WnJZe66VeLszg1XzBcNb5HgtvzGKBmnONclYTvGQzWyQaOZ+LOJhmblgGUbtgFb6uE7SUP7lTyqy2T8p4NNRxlNdgb3SxqNG9TJaB13NhzekALwV0qxGoOwd/XI47VWqylAJFHOT44ac9J++P+ycd21v1iC8cCSvbn3TCkS5PL3du74JC2Dc2L9WYnoOtE6k1yxaVpCGYmqQHem4+fkF0a8bdv6ZAwMz+p2uHpaddOBCxzxr79ZHFYGezKAk+mISKdxb9yebtJHuDClJQB1EAh/wr7BfYHAhYVZGWaL4AqhPOctwVaQrfrf4SgY9NaK8EMJFT9BjFazPC0gmv9V/Jijl1adLhpT+tbBlmbAQak6GXJpVvFArMDC94yOuQAd6DNyd6WxRHH1CEAUpBYzbvMeqJa4M7YDV5eALpDxJVdVEg8i3WEvdr9tbgyvjQBGdp1f/02ImZKwYje0fMohSEn/pcaVFjyjxVHtq+jfaYfJ8g5OWPc9ku3+YwOeqYPAkv1+c4njCDBWjqLacQ194Bk9fcQ15YUeg01b+gIaAeVyYJKLb95u2/AuCaTdOaYh98LfB3WydFgYFt8RzlEC7KYDDv4Mf8cHaDE7R8dOW78KZvhlZRb0wViUMKbH7pdMm3HMtRwtkmgGuzq8eIRwkXtUJn8dMwl1y/ZT/wk9e48MdUcPz3cVQ==", "X-Forefront-Antispam-Report": "\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7416014)(56012099003)(22082099003)(18002099003)(921020);DIR:OUT;SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n sAs3wfhJiRrSZpQSkjm2xQmN1Cb4gj65mVgji2yfGTOwHQ3gvsaemxGGxCPwYP9GmwVNLKtI8HMsIyVMBZjIbBrDLAhNgWOP67jzfZq0DL50u5pUu2AwhtvIi40Yj/Tz2JDw6+u7jorSkuPj5bcWf621djQpkZyfcMOx8yyhc4+pRyhgM3YB4GtnSpWx3Vs5TDgNzE37o5xqYlFfq4yM2xEhGjmhR7CAGuM3Si1TD6Da8RTAejm4QituVNlL3QoaO4Ei2xV1b1V//rBO/7vcVlW16H1VbV1PIgpdvYxO8RiNDfuwtuo36LUNFurnSL3LjaWBW+69c/WM/tEjYhTj25fUOqNICfHeoy6FS8sxG5brWOSYWZnBucncX738mi7CseVT/6BgiCCbgJb8YbagiGfIXqYBSfDXh0rHMgQcW3+4S+R5BW6dCJ4dS88vxnRcQCUsV0HfSJHm67IOX1nSa2AqJshs/wXPeWdghTqjqb68QpIyy+APGrYx5qOjT500QFlxtxLOQICgYiUXhPwB/CyRbBnBuztnR1jAe0i8B7tzPb03AK5ecJqhe6hpGu4BL6/4VIR9uK6XyRUG3PTdNLPGgvi8QmdNMSY/oje+V5Zt9jJclyojGdUiTmYDnfqgTpboX3O9xLCwt1ChWtecRS68ToF23vC70rvj32EhORDPpMsHkE0dObVKck9dhhQMkFv+bj0HmkFXEuIkBqViu/YzmEUHQURHZb3E2lh33cSeeXDBCaD4wzePHZZDTQ5ApyhLit4H7Hwf5GPgxKn1mB6kLpc79iHUYpsTpsmX48q9yoZRHuskOfSf658jadpEYwYNVOwv2q14ybxtijTxLWGg/XIvZ8Axse2LpNR755gGPIEENg0HS/YY3pMJ6EJKXgN6AifRK355SwLXgZOYBY1GF0hdJA6anRk8JefBVaiYrAgJWdRE5Wlb64Y5ZWzzauOOqxx23Q/rWOQyywNNMxvx/O11MZwRLSRVnJGvwKPmisVNjpbVfwQp3UUKcZbGrnlHt4SKBN1FvBL4YwABn3lD86hRt11TUhkLpzqKhWIW4yjDKglLZt+TibHFBhNQA7hsSDrTcXAZ8qiTj3MO+wnRgzjRwD9uuLzGogYFobhPe5f4wiTXSjcu8VKv3Cdp3fQBdAmH1YrRFQO/xTTXTJ0ti9ubdILwUJNagHbuxG/eLmWqo4UvE/n8KqqfiXb6owVPVystecUk6GSgeUI1bTiVRtz0YrT7NsJXXrGUMbKK0Yfuoh6JcPRaH/Tba5r2RFPuZRRfKpy22r3Y6LwkELyZT2UDTxYF0nijGRiBQcF6/PAGElD3EQWc+pe0pjaDiyMnpq2+1aROqL2u5TDDsDf+mnv+hJGFzjNclMNpUdhP8AoWMj3WsXkLdgKvGUWceGDETs7UcTv9MUmCTmJo33ift3ssAtqVnAZdFDUuAWvgY7O2xkvjpFHyiv+N8jd+Vozg90ZrvpcYIyzhK7lFGX6pm9vxJv0Qb+cOmhjjYX0DYB+tTYyEQrKoMy312C8QCGU4RPjEsgTkYgnJAfM2FU26+B2Lpeba6Sc04osUc/Na6mx4+WUSE1bCTiAm1gVHUPt6CEC3/Ak1J1C0ky1+QPrUp0b98bN91D7v/fpL/9QcqV9t5vIMluv5sQjexz5lZBAJTIjK+n/ptcaGMHdCexeaI3zZ8pBeX2gJrBpPoREiVb6sSotMp5PUATacbDPfF5bU6//MmS5bGRB/EE5Qx6R18gwzpWjxBJ2/mM2vXHKQkZJTjvXYnau4UE54OfTz", "X-OriginatorOrg": "valinux.co.jp", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e4d2aa31-0dae-4c22-bfa1-08de93f53203", "X-MS-Exchange-CrossTenant-AuthSource": "TY7P286MB7722.JPNP286.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Apr 2026 15:57:24.9065\n (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "7a57bee8-f73d-4c5f-a4f7-d72c91c8c111", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n g5q0P+9QMbq5idADw6GHfBQ/peep8jo/SJ5iisnuvaaMW6eT8m86N+djUzO50z/xqpEhqfEfJyxvLLeNntswvA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "TYYP286MB4187" }, "content": "Prepare pci-ep-msi for non-MSI doorbell backends.\n\nFactor MSI doorbell allocation into a helper and extend struct\npci_epf_doorbell_msg with:\n\n - irq_flags: required IRQ request flags (e.g. IRQF_SHARED for some\n backends)\n - type: doorbell backend type\n - bar/offset: pre-exposed doorbell target location, if any\n\nInitialize these fields for the existing MSI-backed doorbell\nimplementation.\n\nAlso add PCI_EPF_DOORBELL_EMBEDDED type, which is to be implemented in a\nfollow-up patch.\n\nNo functional changes.\n\nReviewed-by: Frank Li <Frank.Li@nxp.com>\nTested-by: Niklas Cassel <cassel@kernel.org>\nSigned-off-by: Koichiro Den <den@valinux.co.jp>\n---\n drivers/pci/endpoint/pci-ep-msi.c | 54 ++++++++++++++++++++++---------\n include/linux/pci-epf.h | 23 +++++++++++--\n 2 files changed, 60 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c\nindex 1395919571f8..85fe46103220 100644\n--- a/drivers/pci/endpoint/pci-ep-msi.c\n+++ b/drivers/pci/endpoint/pci-ep-msi.c\n@@ -8,6 +8,7 @@\n \n #include <linux/device.h>\n #include <linux/export.h>\n+#include <linux/interrupt.h>\n #include <linux/irqdomain.h>\n #include <linux/module.h>\n #include <linux/msi.h>\n@@ -35,23 +36,13 @@ static void pci_epf_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)\n \tpci_epc_put(epc);\n }\n \n-int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n+static int pci_epf_alloc_doorbell_msi(struct pci_epf *epf, u16 num_db)\n {\n-\tstruct pci_epc *epc = epf->epc;\n+\tstruct pci_epf_doorbell_msg *msg;\n \tstruct device *dev = &epf->dev;\n+\tstruct pci_epc *epc = epf->epc;\n \tstruct irq_domain *domain;\n-\tvoid *msg;\n-\tint ret;\n-\tint i;\n-\n-\t/* TODO: Multi-EPF support */\n-\tif (list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list) != epf) {\n-\t\tdev_err(dev, \"MSI doorbell doesn't support multiple EPF\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (epf->db_msg)\n-\t\treturn -EBUSY;\n+\tint ret, i;\n \n \tdomain = of_msi_map_get_device_domain(epc->dev.parent, 0,\n \t\t\t\t\t DOMAIN_BUS_PLATFORM_MSI);\n@@ -74,6 +65,12 @@ int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n \tif (!msg)\n \t\treturn -ENOMEM;\n \n+\tfor (i = 0; i < num_db; i++)\n+\t\tmsg[i] = (struct pci_epf_doorbell_msg) {\n+\t\t\t.type = PCI_EPF_DOORBELL_MSI,\n+\t\t\t.bar = NO_BAR,\n+\t\t};\n+\n \tepf->num_db = num_db;\n \tepf->db_msg = msg;\n \n@@ -90,13 +87,40 @@ int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n \tfor (i = 0; i < num_db; i++)\n \t\tepf->db_msg[i].virq = msi_get_virq(epc->dev.parent, i);\n \n+\treturn 0;\n+}\n+\n+int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db)\n+{\n+\tstruct pci_epc *epc = epf->epc;\n+\tstruct device *dev = &epf->dev;\n+\tint ret;\n+\n+\t/* TODO: Multi-EPF support */\n+\tif (list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list) != epf) {\n+\t\tdev_err(dev, \"Doorbell doesn't support multiple EPF\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (epf->db_msg)\n+\t\treturn -EBUSY;\n+\n+\tret = pci_epf_alloc_doorbell_msi(epf, num_db);\n+\tif (!ret)\n+\t\treturn 0;\n+\n+\tdev_err(dev, \"Failed to allocate doorbell: %d\\n\", ret);\n \treturn ret;\n }\n EXPORT_SYMBOL_GPL(pci_epf_alloc_doorbell);\n \n void pci_epf_free_doorbell(struct pci_epf *epf)\n {\n-\tplatform_device_msi_free_irqs_all(epf->epc->dev.parent);\n+\tif (!epf->db_msg)\n+\t\treturn;\n+\n+\tif (epf->db_msg[0].type == PCI_EPF_DOORBELL_MSI)\n+\t\tplatform_device_msi_free_irqs_all(epf->epc->dev.parent);\n \n \tkfree(epf->db_msg);\n \tepf->db_msg = NULL;\ndiff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h\nindex 7737a7c03260..cd747447a1ea 100644\n--- a/include/linux/pci-epf.h\n+++ b/include/linux/pci-epf.h\n@@ -152,14 +152,33 @@ struct pci_epf_bar {\n \tstruct pci_epf_bar_submap\t*submap;\n };\n \n+enum pci_epf_doorbell_type {\n+\tPCI_EPF_DOORBELL_MSI = 0,\n+\tPCI_EPF_DOORBELL_EMBEDDED,\n+};\n+\n /**\n * struct pci_epf_doorbell_msg - represents doorbell message\n- * @msg: MSI message\n- * @virq: IRQ number of this doorbell MSI message\n+ * @msg: Doorbell address/data pair to be mapped into BAR space.\n+ * For MSI-backed doorbells this is the MSI message, while for\n+ * \"embedded\" doorbells this represents an MMIO write that asserts\n+ * an interrupt on the EP side.\n+ * @virq: IRQ number of this doorbell message\n+ * @irq_flags: Required flags for request_irq()/request_threaded_irq().\n+ * Callers may OR-in additional flags (e.g. IRQF_ONESHOT).\n+ * @type: Doorbell type.\n+ * @bar: BAR number where the doorbell target is already exposed to the RC\n+ * (NO_BAR if not)\n+ * @offset: offset within @bar for the doorbell target (valid iff\n+ * @bar != NO_BAR)\n */\n struct pci_epf_doorbell_msg {\n \tstruct msi_msg msg;\n \tint virq;\n+\tunsigned long irq_flags;\n+\tenum pci_epf_doorbell_type type;\n+\tenum pci_barno bar;\n+\tresource_size_t offset;\n };\n \n /**\n", "prefixes": [ "v13", "4/7" ] }