Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220190/?format=api
{ "id": 2220190, "url": "http://patchwork.ozlabs.org/api/patches/2220190/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406112057.906685-4-jtornosm@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260406112057.906685-4-jtornosm@redhat.com>", "list_archive_url": null, "date": "2026-04-06T11:20:57", "name": "[net,3/3] iavf: drop netdev lock while waiting for MAC change completion", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "faf97b172e3535fb567bd442f444d38498d2ebc5", "submitter": { "id": 93070, "url": "http://patchwork.ozlabs.org/api/people/93070/?format=api", "name": "Jose Ignacio Tornos Martinez", "email": "jtornosm@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406112057.906685-4-jtornosm@redhat.com/mbox/", "series": [ { "id": 498871, "url": "http://patchwork.ozlabs.org/api/series/498871/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498871", "date": "2026-04-06T11:20:55", "name": "Fix i40e/iavf VF bonding after netdev lock changes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498871/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220190/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220190/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=iPROE4UO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqCbf3Qmmz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 01:16:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 1EF8880B53;\n\tMon, 6 Apr 2026 15:16:39 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id o4-7peP02p83; Mon, 6 Apr 2026 15:16:38 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 845ED80B4C;\n\tMon, 6 Apr 2026 15:16:38 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id A56141EB\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 11:21:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 8B8AA80EC8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 11:21:51 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id J3PFCwwLnorZ for <intel-wired-lan@lists.osuosl.org>;\n Mon, 6 Apr 2026 11:21:48 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 7841880D36\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 11:21:48 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-ACMuyeuWO_SqXKnXjyWWrA-1; Mon,\n 06 Apr 2026 07:21:44 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B65A619560A7; Mon, 6 Apr 2026 11:21:42 +0000 (UTC)", "from fedora.redhat.com (unknown [10.44.48.51])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9718A300019F; Mon, 6 Apr 2026 11:21:38 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 845ED80B4C", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7841880D36" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775488598;\n\tbh=cP5EVArCawQIz7cxWEYg9C3osdTcwWJT1kUDvk6U14I=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=iPROE4UOAaDSYm9ozZd69qhKCkdWK8hmrWnRu2JxMPzie3QUs2CDF4KJmOFc8b28d\n\t pd0F7T0ooN3ibPA1erx9tnnqEKPEAe6cYAiqLSbMrtQjVsj+Zc+YeqIoh9YSqqGDLh\n\t SKI/DlHH0xf7EaPM3GqEZDfBbu5JsgiT3/gi7UjBFXaiuodIqpIizkYAVtTERY/cJv\n\t F23flAFM+4/wmsQ4HpA4eGErsc63B+CzCwOHFwo5n5ajfuFmQn0CTHfyqyqPuWCyHi\n\t Wxn06P2vRA3BUny2r7KEVrTmGEZbzlZnx8jLD/GK7SNvSIU/DogG3ndmfeWMHvidj9\n\t ec2PWT3ZiPigA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=jtornosm@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7841880D36", "X-MC-Unique": "ACMuyeuWO_SqXKnXjyWWrA-1", "X-Mimecast-MFC-AGG-ID": "ACMuyeuWO_SqXKnXjyWWrA_1775474502", "From": "Jose Ignacio Tornos Martinez <jtornosm@redhat.com>", "To": "netdev@vger.kernel.org", "Cc": "intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,\n anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com,\n Jose Ignacio Tornos Martinez <jtornosm@redhat.com>, stable@vger.kernel.org", "Date": "Mon, 6 Apr 2026 13:20:57 +0200", "Message-ID": "<20260406112057.906685-4-jtornosm@redhat.com>", "In-Reply-To": "<20260406112057.906685-1-jtornosm@redhat.com>", "References": "<20260406112057.906685-1-jtornosm@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-MFC-PROC-ID": "vMf2nFuXvQ9Nb837DlrePCfIBJbkmepl3gd0dxluKqE_1775474502", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-Mailman-Approved-At": "Mon, 06 Apr 2026 15:16:35 +0000", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775474507;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=cP5EVArCawQIz7cxWEYg9C3osdTcwWJT1kUDvk6U14I=;\n b=DUh7jsWiZMJjWEExs2auBwt5iuSpPk0JivlCffpQ6brZWbbL9b7FnIPsxWBPKk5GEQEVAi\n 7T2yGFVC6Sg02MpWBKvdtSk39HtcDROvPon6VgrAjURMc5IIIPDIvM5DggDA4cM4tZ3yGu\n EKsXTYXXgwCzqI1uGrJsQ7DW+0A3Hgg=", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp1.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=DUh7jsWi" ], "Subject": "[Intel-wired-lan] [PATCH net 3/3] iavf: drop netdev lock while\n waiting for MAC change completion", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "After commit ad7c7b2172c3 (\"net: hold netdev instance lock during sysfs\noperations\"), iavf_set_mac() is called with the netdev instance lock\nalready held.\n\nThe function queues a MAC address change request and then waits for\ncompletion while holding this lock. However, the watchdog task that\nprocesses admin queue commands (including MAC changes) also needs to\nacquire the netdev lock to run.\n\nThis creates a lock contention scenario:\n1. iavf_set_mac() holds netdev lock and waits for MAC change\n2. Watchdog needs netdev lock to process the MAC change request\n3. Watchdog blocks waiting for lock\n4. MAC change times out after 2.5 seconds\n5. iavf_set_mac() returns -EAGAIN\n\nThis particularly affects VFs during initialization when enslaved to a\nbond. The first VF typically succeeds as it's already fully initialized,\nbut subsequent VFs fail as they're still progressing through their state\nmachine and need the watchdog to advance.\n\nFix by temporarily dropping the netdev lock before waiting for MAC change\ncompletion, allowing the watchdog to run and process the request, then\nre-acquiring the lock before returning.\n\nThis is safe because:\n- The MAC change request is already queued before we drop the lock\n- iavf_is_mac_set_handled() just checks filter state, doesn't modify it\n- We re-acquire the lock before checking results and returning\n\nFixes: ad7c7b2172c3 (\"net: hold netdev instance lock during sysfs operations\")\ncc: stable@vger.kernel.org\nSigned-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\nindex dad001abc908..6281858e6f3c 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n@@ -1068,10 +1068,14 @@ static int iavf_set_mac(struct net_device *netdev, void *p)\n \tif (ret)\n \t\treturn ret;\n \n+\tnetdev_unlock(netdev);\n+\n \tret = wait_event_interruptible_timeout(adapter->vc_waitqueue,\n \t\t\t\t\t iavf_is_mac_set_handled(netdev, addr->sa_data),\n \t\t\t\t\t msecs_to_jiffies(2500));\n \n+\tnetdev_lock(netdev);\n+\n \t/* If ret < 0 then it means wait was interrupted.\n \t * If ret == 0 then it means we got a timeout.\n \t * else it means we got response for set MAC from PF,\n", "prefixes": [ "net", "3/3" ] }