Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220163/?format=api
{ "id": 2220163, "url": "http://patchwork.ozlabs.org/api/patches/2220163/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260406145717.1882741-2-john.cabaj@canonical.com/", "project": { "id": 15, "url": "http://patchwork.ozlabs.org/api/projects/15/?format=api", "name": "Ubuntu Kernel", "link_name": "ubuntu-kernel", "list_id": "kernel-team.lists.ubuntu.com", "list_email": "kernel-team@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260406145717.1882741-2-john.cabaj@canonical.com>", "list_archive_url": null, "date": "2026-04-06T14:57:14", "name": "[SRU,Q:linux-azure,1/2] smb: client: fix in-place encryption corruption in SMB2_write()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2e959fecbff3383dc65adcbec334657a475af10a", "submitter": { "id": 85032, "url": "http://patchwork.ozlabs.org/api/people/85032/?format=api", "name": "John Cabaj", "email": "john.cabaj@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20260406145717.1882741-2-john.cabaj@canonical.com/mbox/", "series": [ { "id": 498864, "url": "http://patchwork.ozlabs.org/api/series/498864/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=498864", "date": "2026-04-06T14:57:15", "name": "Backporting critical SMB client fixes to affected Ubuntu distros", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498864/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220163/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220163/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<kernel-team-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=BXB/jqQm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqC9T2qlZz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 07 Apr 2026 00:57:32 +1000 (AEST)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1w9lOG-0006eu-OL; Mon, 06 Apr 2026 14:57:24 +0000", "from smtp-relay-internal-1.internal ([10.131.114.114]\n helo=smtp-relay-internal-1.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <john.cabaj@canonical.com>)\n id 1w9lOF-0006eC-DI\n for kernel-team@lists.ubuntu.com; Mon, 06 Apr 2026 14:57:23 +0000", "from mail-oo1-f71.google.com (mail-oo1-f71.google.com\n [209.85.161.71])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4BDD03F1E0\n for <kernel-team@lists.ubuntu.com>; Mon, 6 Apr 2026 14:57:23 +0000 (UTC)", "by mail-oo1-f71.google.com with SMTP id\n 006d021491bc7-683b4edaab1so4327522eaf.3\n for <kernel-team@lists.ubuntu.com>; Mon, 06 Apr 2026 07:57:23 -0700 (PDT)", "from smtp.gmail.com\n (h208-73-92-250.mdtnwi.broadband.dynamic.tds.net. [208.73.92.250])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-682991a4c09sm5727704eaf.12.2026.04.06.07.57.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 07:57:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1775487443;\n bh=nHHMwfJIm4C2+1dL9QP8L7v0CDkfyYek7MKHxpch3Gs=;\n h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n MIME-Version;\n b=BXB/jqQmGca4TMtP0DcscmDAJrJvW7a9596uOdxWZOGCFzZMjxptSwEP/Gc0Jd7+3\n lQrPWnClpm7WnZSJjKZ5CkaPkjBShJ8esgUVBbu5SpuESDRbRfG4Bn7xWYYfsYe0eS\n UevI8zlU+3Wk5m403c9eEJw1T6kUCJu2jhHLhJXmPzjCBriZvLpnwA1ty57JnEfmpC\n TYlSs9eC06N4DjobHLjKrePZMnz1KoFCZY3wvpv12dH1PLnEsUsyWhD0Qq47om6ORx\n qtJ/vQk/VJNn90LNAYuuj7DO4FxJIVSfMDBnpDL9wpmlpvSeTtRq7tmpAvRHYzCu0/\n 1NcrTyzCAfvlf9MXFdV2g/71IzBQDAK3phnHHEV71SQDcejgZPMN5PndaDGMLQKLOa\n 3HkXY/hFnQK7paX94mLZo/0MtZky2sTGTkJxLavbJhtUY9q5lTK6ov/UrLdW53+siG\n VuP9gJPtsQjAXV0zCJM5jAr5Xs80DaNr9brzaGchiZ5TbkqW/lnMX9joMocCCoqo9T\n wvi4xmj/4YshtBQl/W8TJ9yiqHHw7+OOEokFCMwVYcYCkY+oGg/kEka9jTWmFAwNJ6\n r7bZZOwvRKeGbbkgk02uOQsy0pKwGFC4D0FVAs9BakyDGcZmLAepo0/+s3cpA8nUYn\n 1n0apOWv/s5AcnGVJ/n4Sfuk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775487441; x=1776092241;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=nHHMwfJIm4C2+1dL9QP8L7v0CDkfyYek7MKHxpch3Gs=;\n b=pAIPa1P4iGA8UPBdjiilg3tt5UxZjmTLUIU4YUC9KVF2lD411E7qvnfkFkGqPrqbQM\n OPHIABJXRj4kQAdol4MlcU+BUzfJKXDDbJ0YirYiNcVK0uIWupLW8FgU7IfOeq5bm5r7\n 4SNsXyuLRc6T7xlmRKJ+3KJN6jNv9zv/11h1Ra9hySnGpjgNtlm/qgRq4ffhbxUvh9Uk\n LTV0uDzeEffzligpc6NtQQXbAdEjR1gvfuJ2mmsk3rz2ZG3AjJqAjytCWrCZpr6GtUBw\n fK1KOW2SdtcZ2UDq0FrZBIxUqLVlFlgRR8ZA4ks1ZClKsnlXWtvBLdesVuq2zu6N8/9W\n 94mw==", "X-Gm-Message-State": "AOJu0Yzd4KqYq4fG2QWcCqMiBZag4rf9DZk1yRNLVOIJJXvKrr1pzcy/\n ncqgSTLQ0hMa5AYfmWgyDPG3VmZVq6xh41B6OwSpidLFYgtDculKGXV0vueIgtcVG4/uA4Y2NIL\n Nginz9PzViL+nc50kcbEb6LZEX5LleeCTYKwgo1U9Ea51c2u4LcTO84WeHelb/F1oCxCenCiy2Z\n h8E+dGAPt60FX76g==", "X-Gm-Gg": "AeBDietLTlVKD+3+g/jpjGpzg0GKfScTgpt2j6QLc9/oqrgkVh6U/tcBJbY7LDxkXwj\n wCU0+WBwaxLdZGzmTa/X2TTmtulCBz9cN3Zb8uPesKwRPGGdw53+1inbQzFKzGM25hVJ2aYcTZP\n C8AXy21lUbVviDaLRicYk66kV9Tg2x+JDSC42AI/76Z3oSJuCnzeNVxFW4tiAEhO6mQ5qlRTyAq\n KUJ3WudvcdfsfYASm0tSk5szchVmL+dJzVTj+xhZjCr23eJDB4v82aHMxNB+7FufhOcTtYmm2nI\n JxMpG7QQFqLcbR+DKOd3u8+AO73M6z8jks7PJ+wSAxqFfAARN8aBg+U9zN9nPJ90ke8/LEW+R3j\n BoVZcnKohVf6hxL5FoVX/yrHkso/44OXrhJfTyN3G4kHWC+jBySXWsxogK0pJIuW/NnYpYXLTOl\n nSZtkcOFAXDg==", "X-Received": [ "by 2002:a05:6820:4de9:b0:67b:ab68:b5e2 with SMTP id\n 006d021491bc7-6821dd6fd09mr7543694eaf.18.1775487441174;\n Mon, 06 Apr 2026 07:57:21 -0700 (PDT)", "by 2002:a05:6820:4de9:b0:67b:ab68:b5e2 with SMTP id\n 006d021491bc7-6821dd6fd09mr7543685eaf.18.1775487440800;\n Mon, 06 Apr 2026 07:57:20 -0700 (PDT)" ], "From": "John Cabaj <john.cabaj@canonical.com>", "To": "kernel-team@lists.ubuntu.com", "Subject": "[SRU][Q:linux-azure][PATCH 1/2] smb: client: fix in-place encryption\n corruption in SMB2_write()", "Date": "Mon, 6 Apr 2026 09:57:14 -0500", "Message-ID": "<20260406145717.1882741-2-john.cabaj@canonical.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260406145717.1882741-1-john.cabaj@canonical.com>", "References": "<20260406145717.1882741-1-john.cabaj@canonical.com>", "MIME-Version": "1.0", "X-BeenThere": "kernel-team@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Kernel team discussions <kernel-team.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/kernel-team>", "List-Post": "<mailto:kernel-team@lists.ubuntu.com>", "List-Help": "<mailto:kernel-team-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "kernel-team-bounces@lists.ubuntu.com", "Sender": "\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>" }, "content": "From: Bharath SM <bharathsm@microsoft.com>\n\nBugLink: https://bugs.launchpad.net/bugs/2147347\n\nSMB2_write() places write payload in iov[1..n] as part of rq_iov.\nsmb3_init_transform_rq() pointer-shares rq_iov, so crypt_message()\nencrypts iov[1] in-place, replacing the original plaintext with\nciphertext. On a replayable error, the retry sends the same iov[1]\nwhich now contains ciphertext instead of the original data,\nresulting in corruption.\n\nThe corruption is most likely to be observed when connections are\nunstable, as reconnects trigger write retries that re-send the\nalready-encrypted data.\n\nThis affects SFU mknod, MF symlinks, etc. On kernels before\n6.10 (prior to the netfs conversion), sync writes also used\nthis path and were similarly affected. The async write path\nwasn't unaffected as it uses rq_iter which gets deep-copied.\n\nFix by moving the write payload into rq_iter via iov_iter_kvec(),\nso smb3_init_transform_rq() deep-copies it before encryption.\n\nCc: stable@vger.kernel.org #6.3+\nAcked-by: Henrique Carvalho <henrique.carvalho@suse.com>\nAcked-by: Shyam Prasad N <sprasad@microsoft.com>\nAcked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>\nSigned-off-by: Bharath SM <bharathsm@microsoft.com>\nSigned-off-by: Steve French <stfrench@microsoft.com>\n(cherry picked from commit d78840a6a38d312dc1a51a65317bb67e46f0b929)\nSigned-off-by: John Cabaj <john.cabaj@canonical.com>\n---\n fs/smb/client/smb2pdu.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c\nindex 64fe2de662ff..c8b7ada3c0eb 100644\n--- a/fs/smb/client/smb2pdu.c\n+++ b/fs/smb/client/smb2pdu.c\n@@ -5171,7 +5171,10 @@ SMB2_write(const unsigned int xid, struct cifs_io_parms *io_parms,\n \n \tmemset(&rqst, 0, sizeof(struct smb_rqst));\n \trqst.rq_iov = iov;\n-\trqst.rq_nvec = n_vec + 1;\n+\t/* iov[0] is the SMB header; move payload to rq_iter for encryption safety */\n+\trqst.rq_nvec = 1;\n+\tiov_iter_kvec(&rqst.rq_iter, ITER_SOURCE, &iov[1], n_vec,\n+\t\t io_parms->length);\n \n \tif (retries)\n \t\tsmb2_set_replay(server, &rqst);\n", "prefixes": [ "SRU", "Q:linux-azure", "1/2" ] }