Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220119/?format=api
{ "id": 2220119, "url": "http://patchwork.ozlabs.org/api/patches/2220119/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406115247.4879-3-armenon@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260406115247.4879-3-armenon@redhat.com>", "list_archive_url": null, "date": "2026-04-06T11:52:47", "name": "[2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate outbuf", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "12c3a1c0a90a3ac6fbcdbcbaec971e4d5cc6f58b", "submitter": { "id": 91136, "url": "http://patchwork.ozlabs.org/api/people/91136/?format=api", "name": "Arun Menon", "email": "armenon@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260406115247.4879-3-armenon@redhat.com/mbox/", "series": [ { "id": 498846, "url": "http://patchwork.ozlabs.org/api/series/498846/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498846", "date": "2026-04-06T11:52:45", "name": "migration/vmstate: Add VMState support to safely migrate GByteArray", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498846/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220119/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220119/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Ri8x/NGI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=WMcbI9vO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fq75S5PJdz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 06 Apr 2026 21:53:48 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9iVw-0002cz-Ly; Mon, 06 Apr 2026 07:53:08 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1w9iVv-0002Yp-9D\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 07:53:07 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1w9iVt-0002MN-Oe\n for qemu-devel@nongnu.org; Mon, 06 Apr 2026 07:53:07 -0400", "from mail-pf1-f200.google.com (mail-pf1-f200.google.com\n [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-308-ey_v-KgxNDKp73JAjLdtfQ-1; Mon, 06 Apr 2026 07:53:04 -0400", "by mail-pf1-f200.google.com with SMTP id\n d2e1a72fcca58-82c613194caso2406020b3a.1\n for <qemu-devel@nongnu.org>; Mon, 06 Apr 2026 04:53:03 -0700 (PDT)", "from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([152.59.100.215])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82d12218738sm11547849b3a.21.2026.04.06.04.52.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Apr 2026 04:53:01 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775476385;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=4xZ4atkg7nPuazSS+BRhIaW+e8ja5lz+OBs+fqAB4WM=;\n b=Ri8x/NGI9Qz5wSWxsoHfZVHm3jXRl1Ffn8NEqoIuGGIhGaGRtRpBfn1tWCKtNqTrpdZpxF\n HgQw/fETBHzAs3Bo5baiO+r86rVN/AZQg0cbZLnT6+lLbPHdFx4EmOZTe+BwA1AEizR2VE\n Pn30pCebmpxaiNH7wYuIsFNoY9pRU34=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775476383; x=1776081183; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4xZ4atkg7nPuazSS+BRhIaW+e8ja5lz+OBs+fqAB4WM=;\n b=WMcbI9vO+mJOmpGUrbjg26+v4U38W9FKvb99j4zOkoA+xmBDrD4ruHnCfEYfVw7kL4\n BixHumWuNzMgeiOxxSend1DNkkIdW/iu0Ep6BjLx+JOSnGknpwzx3HBXFdFuIkfFkbUR\n N8Hk5JGAU435axoHTbduGiDPWGAu73cqIO6V8wkU2CWDZPcro8VVP0qP7/HHA8JNs784\n Na96zv/tjp5NgKwoMnY2195Z2oLZPCXyG2iJHejLvpHTWPPVbrjVblLDk6Ku/YCGM6rJ\n 3AAbkh/ZEshH7RonclUw4k/A6E+6cIq65l4ly4ZLffsns8AMvDwvk9adYyZPx0fbb3mP\n 85SQ==" ], "X-MC-Unique": "ey_v-KgxNDKp73JAjLdtfQ-1", "X-Mimecast-MFC-AGG-ID": "ey_v-KgxNDKp73JAjLdtfQ_1775476383", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775476383; x=1776081183;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4xZ4atkg7nPuazSS+BRhIaW+e8ja5lz+OBs+fqAB4WM=;\n b=UeWHOF7FQl+kaf/KXcZ6jrjGGfxR+kBjmvtgk4wbGIMlHtxZfG+7l+M7OMlvRBA+st\n q82f4CcalaecQMuYSPCT6/QBpnDLleFh6NYEUE3e+qVCcZ0fGReoUKiFp2xnmkHlEGaW\n IItJVyJyRUarKvTqJFpmYAEBUPZY+DbsrCMKVDEdih3U/KzdFpt4kcoXdXhX0mhMtOJf\n AIzjXEhvsZfumnNvbHTiRrFGlEWv8k53CfToji3GYCIVxwBHHikRwogb3aYmSeYDuSi7\n LsDbBhyEoNj/uhapY6JSUYeF60REb1ITay9BfJaU9gAeEb3oZIof9SFHfghG9ObcQga6\n ANfQ==", "X-Gm-Message-State": "AOJu0YzNACweYkkcLYv8lVEs2+8PbsZSbJM9cG2KMABEaJ2IHl+WSIgh\n iL7rudNRtsQLvaX0ErnQ3/xv91KdrpRXs2MGjT/GUmmAtc84imvbto2yHoPZhi0srsHdA0yjZZi\n Hbp3wWmIrhrM06RS2PJKPhz4B33oFsc5lS99d1LZnfUyVFBlbGXddX+y6zYicqzigc4EPPJtbkQ\n i7aA9MRAUyhSCEGqqlq9dMqsHS6bPNgEXqcN2KB8s=", "X-Gm-Gg": "AeBDietJAJCd8zYql3L4WP9kBJyGSk9z2Il07To/Hqu5uvmwQR1SMzxvxk4On5Cf0Zu\n srcihRVm0Z0b0RvPdU+wQGzOBk0pW7DF8LqRdeKONIrtth61gahlHtI34+mZfHhNApvoUUBZt9q\n 16Xf/ENuhuSWQDpUTDU7TpFyuwsHJ75xd7TuDcK70jFFB3RDT6BZxSdqdszccXYDLvJFS8Xr5wf\n RpOyr3B4FCm/J4Wd8mxO0cLcZB3ThcHKd5KFvlRO2DiRFLOe5wmmbcj+a0StjbUhSoxqE0NTI1b\n 1uEh0ryUBmXfkn6ZJRiP4d1pOsl/ge0mg4fMV1v6pBpyQz++ntB47Z5L7nh3p+0pRQyOBdIxQik\n G+fuDZgCPlT5UXZrlTRvQpb24Y/GcKoyLBDz3LonZMnMNJatXRrbPhmDFe8TB9PDMnEmS", "X-Received": [ "by 2002:a05:6a00:4fc6:b0:82c:daa4:ce29 with SMTP id\n d2e1a72fcca58-82d0dbc51d3mr12286171b3a.47.1775476382608;\n Mon, 06 Apr 2026 04:53:02 -0700 (PDT)", "by 2002:a05:6a00:4fc6:b0:82c:daa4:ce29 with SMTP id\n d2e1a72fcca58-82d0dbc51d3mr12286135b3a.47.1775476381972;\n Mon, 06 Apr 2026 04:53:01 -0700 (PDT)" ], "From": "Arun Menon <armenon@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Arun Menon <armenon@redhat.com>", "Subject": "[PATCH 2/2] ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate\n outbuf", "Date": "Mon, 6 Apr 2026 17:22:47 +0530", "Message-ID": "<20260406115247.4879-3-armenon@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260406115247.4879-1-armenon@redhat.com>", "References": "<20260406115247.4879-1-armenon@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-25", "X-Spam_score": "-2.6", "X-Spam_bar": "--", "X-Spam_report": "(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Arun Menon <armenon@redhat.com>\n\nMigrating a GLib GByteArray is now possible directly using the newly\nintroduced VMSTATE_GBYTEARRAY. It uses the standard GLib API calls to\ncreate the array, or resize it.\n\nThis is safer than implementing a C struct and manually updating the\ndata and len fields. This commit uses the VMSTATE_GBYTEARRAY in vdaagent\nto store the outbuf variable.\n\nSigned-off-by: Arun Menon <armenon@redhat.com>\nFix-Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/vdagent.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)", "diff": "diff --git a/ui/vdagent.c b/ui/vdagent.c\nindex bb0c4aa14c..9206e47000 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -967,17 +967,6 @@ static const VMStateDescription vmstate_chunk = {\n }\n };\n \n-static const VMStateDescription vmstate_vdba = {\n- .name = \"vdagent/bytearray\",\n- .version_id = 0,\n- .minimum_version_id = 0,\n- .fields = (const VMStateField[]) {\n- VMSTATE_UINT32(len, GByteArray),\n- VMSTATE_VBUFFER_ALLOC_UINT32(data, GByteArray, 0, 0, len),\n- VMSTATE_END_OF_LIST()\n- }\n-};\n-\n struct CBInfoArray {\n uint32_t n;\n QemuClipboardInfo cbinfo[QEMU_CLIPBOARD_SELECTION__COUNT];\n@@ -1067,7 +1056,7 @@ static const VMStateDescription vmstate_vdagent = {\n VMSTATE_UINT32(xsize, VDAgentChardev),\n VMSTATE_UINT32(xoff, VDAgentChardev),\n VMSTATE_VBUFFER_ALLOC_UINT32(xbuf, VDAgentChardev, 0, 0, xsize),\n- VMSTATE_STRUCT_POINTER(outbuf, VDAgentChardev, vmstate_vdba, GByteArray),\n+ VMSTATE_GBYTEARRAY(outbuf, VDAgentChardev, 0),\n VMSTATE_UINT32(mouse_x, VDAgentChardev),\n VMSTATE_UINT32(mouse_y, VDAgentChardev),\n VMSTATE_UINT32(mouse_btn, VDAgentChardev),\n", "prefixes": [ "2/2" ] }