Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220088/?format=api
{ "id": 2220088, "url": "http://patchwork.ozlabs.org/api/patches/2220088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/a61c264c824d140a948db64b2e1036bc4229d163.1775466330.git.sayalip@linux.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<a61c264c824d140a948db64b2e1036bc4229d163.1775466330.git.sayalip@linux.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/a61c264c824d140a948db64b2e1036bc4229d163.1775466330.git.sayalip@linux.ibm.com/", "date": "2026-04-06T09:19:26", "name": "[v4,07/15] selftests/mm: free dynamically allocated PMD-sized buffers in split_huge_page_test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "232dd0061f21e2852b9e89bbdc0804ef8493ad43", "submitter": { "id": 92656, "url": "http://patchwork.ozlabs.org/api/people/92656/?format=api", "name": "Sayali Patil", "email": "sayalip@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/a61c264c824d140a948db64b2e1036bc4229d163.1775466330.git.sayalip@linux.ibm.com/mbox/", "series": [ { "id": 498833, "url": "http://patchwork.ozlabs.org/api/series/498833/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=498833", "date": "2026-04-06T09:19:22", "name": "selftests/mm: fix failures and robustness improvements", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498833/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220088/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220088/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-19403-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=R1qgUStS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19403-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5", "lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=R1qgUStS;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=sayalip@linux.ibm.com; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fq3pL2jy9z1yFt\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 06 Apr 2026 19:25:30 +1000 (AEST)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fq3pK4xyzz2yr4;\n\tMon, 06 Apr 2026 19:25:29 +1000 (AEST)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fq3pJ5wm1z2yr0\n\tfor <linuxppc-dev@lists.ozlabs.org>; Mon, 06 Apr 2026 19:25:28 +1000 (AEST)", "from pps.filterd (m0360072.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 635EQPZC2819363;\n\tMon, 6 Apr 2026 09:20:15 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dat9rdenx-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 06 Apr 2026 09:20:14 +0000 (GMT)", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 6365xCrv020514;\n\tMon, 6 Apr 2026 09:20:13 GMT", "from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dbdync2w9-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 06 Apr 2026 09:20:13 +0000", "from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 6369K90R24183080\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 6 Apr 2026 09:20:09 GMT", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2A1B620043;\n\tMon, 6 Apr 2026 09:20:09 +0000 (GMT)", "from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CFBC320040;\n\tMon, 6 Apr 2026 09:20:05 +0000 (GMT)", "from li-3f69264c-2ce6-11b2-a85c-c3f414d24014.bl1-in.ibm.com (unknown\n [9.123.3.209])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 6 Apr 2026 09:20:05 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775467529;\n\tcv=none;\n b=U0iyxSVXQqz7SON8mZmyWvQ/n8RLqMSMK9o5difi4l0drnPv099t9h8YboyC05eK2Ens6Mz/CtcC/toGWQBa2LhHJiQ86aIlY8qmfQvPB58fgWFD3x27JCPyNDmLKFpNCRe0lNjNCumSiXa9PBg/XN3JeGXr1DmWRsoyX6f3Ra1M5z5s39Vp9EL8THSAtLbFEn9e0lYntbPz2qHIIvObf0po4iFxb50H3E2c6J0wySv3/gVh3DKowtwPIe6nV2GIzley8ZDtRiGfXe1Gy97rSjwGcx9TxTD1vqmCPAnADWImIou+GDrnb3f0iaHr7M2+DlXd8farPgcj6/Hgk7WwRQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775467529; c=relaxed/relaxed;\n\tbh=CSvmaAj6V5ARHCiQk029wh6wu3HanW0BDVcs/Uzd7Cs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=SaDM/6dFwrhHfGJuoW49BhPhc6hfR8KLWErPRugY8MzJVmjBGO8nVr2y6GEtfs33DbacF1wf09BrcowFtqKEuJmtTaNcuNXuDBEAGgHiYQp04dCD8ZEtH5oshrHHyIMCOL+zamXu32mL5IRfjO72P9cJG/e9ykUz7ZYmolt9eW8OrspHzSZ2OmCjXAtYn8S+YHcT0ERrwjtPN0A/gH7G7n40zJlrCI/bNFHKLL1RV1L4NsP0qNZLO/DgfsPj2K6D+vsfl8KfYBGteACIVxHxP/+txgPO/8L4LIPfLEHRmht01OTK58ClmXXhWJJaH2GPSqpYH/yKKJOlBTDjkGxrxQ==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=R1qgUStS; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=sayalip@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=CSvmaAj6V5ARHCiQk\n\t029wh6wu3HanW0BDVcs/Uzd7Cs=; b=R1qgUStS8RZ/VnFx9mLUUtsH5+qq1crIO\n\tpCMadfppUhwV15dRgz/CWGWT4LzSc0Zt6pO2abE+WoBj0QZKpC6bWU0M22vkUcMf\n\tp+rydwoDZdi2P1TURTA4LMhNlgXSZ5RFe4l+5POR5ohQVfiH4hQd/IP5OjBi2Y3/\n\to45x6CLsiqEXRqh6Wd0fl6XfF28m4GKw3qFGkLjCTBLUDNCDIhwPkhw8fl+dkUvp\n\tYe5DwitGqJDQTusMKkyJ7yjOFIHa+AE00zbeop/DnzZ+6Ja7Y9vXSp6Z4IldWnZA\n\tRgm4F1HYAwC/cI9cVxALrFgEXjSjd1MgKOIvMmW5FORd+ETkpcEbA==", "From": "Sayali Patil <sayalip@linux.ibm.com>", "To": "Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>,\n linux-mm@kvack.org, linux-kernel@vger.kernel.org,\n linux-kselftest@vger.kernel.org,\n Ritesh Harjani <ritesh.list@gmail.com>", "Cc": "David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>,\n Michal Hocko <mhocko@kernel.org>, Oscar Salvador <osalvador@suse.de>,\n Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,\n Dev Jain <dev.jain@arm.com>, Liam.Howlett@oracle.com,\n linuxppc-dev@lists.ozlabs.org, Miaohe Lin <linmiaohe@huawei.com>,\n Venkat Rao Bagalkote <venkat88@linux.ibm.com>,\n Sayali Patil <sayalip@linux.ibm.com>", "Subject": "[PATCH v4 07/15] selftests/mm: free dynamically allocated PMD-sized\n buffers in split_huge_page_test", "Date": "Mon, 6 Apr 2026 14:49:26 +0530", "Message-ID": "\n <a61c264c824d140a948db64b2e1036bc4229d163.1775466330.git.sayalip@linux.ibm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<cover.1775466329.git.sayalip@linux.ibm.com>", "References": "<cover.1775466329.git.sayalip@linux.ibm.com>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-GUID": "F0fUoqfGsny2Ii1mqseYYZJuov0AU2po", "X-Proofpoint-ORIG-GUID": "-BTSCnmXb2KuszdYrQuMq8hlBjmqgjBL", "X-Authority-Analysis": "v=2.4 cv=bLYb4f+Z c=1 sm=1 tr=0 ts=69d37ace cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=-_7HawjV-lAcONoB0f4A:9", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDA2MDA5MCBTYWx0ZWRfX45R/R63BZB0M\n N4kN9iZYf2Wd+fJiNbYB/PkWr4elj9brr2+1sQtJQE005JXM9XEWNh8HrZd6/GH44+1HWXr+RFK\n yC8rrT2gu8plX5gpd9SW+M9otqvQbpsTuAtjVVjoE1O5exeMMw6PPN8ecQDE3ftUW4Ytx6dqcij\n xrsDCPeYndmpS0ridYE5GalFNlU84cARlDhF7hqh5SQRQpF6PSAMDM4XodRjXBtuYJ/VYFMC82i\n U+tmYte0KC5TJ8erW88J5uAuc2bOcZEqp9Bf6EwghwC9Wgo/DLc3QZfX1P95dqu79ug9c64lr61\n UeFrwgC6PpqsLmj4eCDoZbEO77AZKzAIhPr1FNKd/NW7N+29IsuQVtqJir2JPZca5IvldW0uTOl\n 5161Swyfhv8IxppT1By0JxBsyVsQazRa+3uOgJRiww4rH7nrsgKru+X2B2dYf8dX//RYjlc8YN/\n zkmcqyMJNs+0kqWw7Eg==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-06_02,2026-04-03_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n clxscore=1015 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0\n spamscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604060090", "X-Spam-Status": "No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Dynamically allocated buffers of PMD size for file-backed\nTHP operations (file_buf1 and file_buf2) were not freed on\nthe success path and some failure paths. Since the\nfunction is called repeatedly in a loop for each split order,\nthis can cause significant memory leaks.\n\nOn architectures with large PMD sizes, repeated leaks\ncould exhaust system memory and trigger the OOM killer\nduring test execution.\n\nEnsure all allocated buffers are freed to maintain\nstable repeated test runs.\n\nFixes: 035a112e5fd5 (\"selftests/mm: make file-backed THP split work by writing PMD size data\")\nSigned-off-by: Sayali Patil <sayalip@linux.ibm.com>\n---\n .../selftests/mm/split_huge_page_test.c | 22 ++++++++++++++-----\n 1 file changed, 16 insertions(+), 6 deletions(-)", "diff": "diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c\nindex 57e8a1c9647a..98319cfaf9a8 100644\n--- a/tools/testing/selftests/mm/split_huge_page_test.c\n+++ b/tools/testing/selftests/mm/split_huge_page_test.c\n@@ -487,12 +487,15 @@ static void split_file_backed_thp(int order)\n \tunsigned long size = 2 * pmd_pagesize;\n \tchar opts[64];\n \tssize_t num_written, num_read;\n-\tchar *file_buf1, *file_buf2;\n+\tchar *file_buf1 = NULL, *file_buf2 = NULL;\n \tuint64_t pgoff_start = 0, pgoff_end = 1024;\n \tint i;\n \n \tksft_print_msg(\"Please enable pr_debug in split_huge_pages_in_file() for more info.\\n\");\n \n+\tif (!tmpfs_loc)\n+\t\tksft_exit_fail_msg(\"mkdtemp failed\\n\");\n+\n \tfile_buf1 = (char *)malloc(pmd_pagesize);\n \tfile_buf2 = (char *)malloc(pmd_pagesize);\n \n@@ -508,8 +511,10 @@ static void split_file_backed_thp(int order)\n \tsnprintf(opts, sizeof(opts), \"huge=always,size=%lu\", size);\n \tstatus = mount(\"tmpfs\", tmpfs_loc, \"tmpfs\", 0, opts);\n \n-\tif (status)\n-\t\tksft_exit_fail_msg(\"Unable to create a tmpfs for testing\\n\");\n+\tif (status) {\n+\t\tksft_print_msg(\"Unable to create a tmpfs for testing\\n\");\n+\t\tgoto out;\n+\t}\n \n \tstatus = snprintf(testfile, INPUT_MAX, \"%s/thp_file\", tmpfs_loc);\n \tif (status >= INPUT_MAX) {\n@@ -561,10 +566,13 @@ static void split_file_backed_thp(int order)\n \n \tstatus = umount(tmpfs_loc);\n \tif (status) {\n-\t\trmdir(tmpfs_loc);\n-\t\tksft_exit_fail_msg(\"Unable to umount %s\\n\", tmpfs_loc);\n+\t\tksft_print_msg(\"Unable to umount %s\\n\", tmpfs_loc);\n+\t\tgoto out;\n \t}\n \n+\tfree(file_buf1);\n+\tfree(file_buf2);\n+\n \tstatus = rmdir(tmpfs_loc);\n \tif (status)\n \t\tksft_exit_fail_msg(\"cannot remove tmp dir: %s\\n\", strerror(errno));\n@@ -577,8 +585,10 @@ static void split_file_backed_thp(int order)\n \tclose(fd);\n cleanup:\n \tumount(tmpfs_loc);\n-\trmdir(tmpfs_loc);\n out:\n+\tfree(file_buf1);\n+\tfree(file_buf2);\n+\trmdir(tmpfs_loc);\n \tksft_exit_fail_msg(\"Error occurred\\n\");\n }\n \n", "prefixes": [ "v4", "07/15" ] }