Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2220038/?format=api
{ "id": 2220038, "url": "http://patchwork.ozlabs.org/api/patches/2220038/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406035130.2255713-1-tactii@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260406035130.2255713-1-tactii@gmail.com>", "list_archive_url": null, "date": "2026-04-06T03:51:30", "name": "[net] i40e: Cleanup PTP pins on probe failure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e67350cbb3c38ba3b5d992759ab6499b732e2a57", "submitter": { "id": 92679, "url": "http://patchwork.ozlabs.org/api/people/92679/?format=api", "name": "Matt Vollrath", "email": "tactii@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260406035130.2255713-1-tactii@gmail.com/mbox/", "series": [ { "id": 498819, "url": "http://patchwork.ozlabs.org/api/series/498819/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498819", "date": "2026-04-06T03:51:30", "name": "[net] i40e: Cleanup PTP pins on probe failure", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498819/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2220038/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2220038/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=7RZe+MQc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpwQ01LQWz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 06 Apr 2026 13:52:22 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3AF5B80EED;\n\tMon, 6 Apr 2026 03:52:19 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id LXVKzPezHEeZ; Mon, 6 Apr 2026 03:52:17 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id F2DB680EF1;\n\tMon, 6 Apr 2026 03:52:16 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 5FBCE1EB\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 03:52:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 45964401FC\n for <intel-wired-lan@lists.osuosl.org>; Mon, 6 Apr 2026 03:52:15 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id i6RSAfXXPVoB for <intel-wired-lan@lists.osuosl.org>;\n Mon, 6 Apr 2026 03:52:14 +0000 (UTC)", "from mail-dy1-x132e.google.com (mail-dy1-x132e.google.com\n [IPv6:2607:f8b0:4864:20::132e])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 771AA400EA\n for <intel-wired-lan@osuosl.org>; Mon, 6 Apr 2026 03:52:14 +0000 (UTC)", "by mail-dy1-x132e.google.com with SMTP id\n 5a478bee46e88-2bdd40d3c61so2975781eec.1\n for <intel-wired-lan@osuosl.org>; Sun, 05 Apr 2026 20:52:14 -0700 (PDT)", "from devobuntu.lan ([2600:6c5c:6b00:62b::23])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2cb92ea0ef1sm9810750eec.21.2026.04.05.20.52.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 05 Apr 2026 20:52:12 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org F2DB680EF1", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 771AA400EA" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775447537;\n\tbh=hmk9aicmTfvrHqX4hH39mm0lV7/QJSeEEdSeX0rcnVM=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=7RZe+MQcItUqfNLKpVFdgnvTfyDIOBjniOaut9QCxR8FZQVuoqKqqtN7gtSAE+vLx\n\t B6r3QrcC15mcZRZD1arhcSge/LxcJrgbVebbz7nTUUQxMQOA7b1mOSnhvmtC1uXtfj\n\t L54SGKQ7URc4mpVhGfdZT16yqbmB00bba53kbsE7y5oJqz5ihOmKaWaDekWAhq9lT6\n\t VxyEFmAndGMamNWfj5R48N5353w/nqAHyk4Icz/FpVYF/x0eFV4qzccefD/LsFwlN0\n\t 3yQZRZ1GU520d4pZ2tX22ea8iGzaeWCi0glBq9x4hmCJvzACLOuWJkKr6vZqcg63KS\n\t GVGPNyFieCbEg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::132e; helo=mail-dy1-x132e.google.com;\n envelope-from=tactii@gmail.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 771AA400EA", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775447533; x=1776052333;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hmk9aicmTfvrHqX4hH39mm0lV7/QJSeEEdSeX0rcnVM=;\n b=A6FV8kOturga9AM74yguJ8Xdb4n4PJW8jkJb6P3ax0JZhCB21D6EK/e88b3/OX7Y7x\n WUzx0SDKVdYoAM99zIifZSUeo8ImxJp5nKi+eOCombm16qbG4E4bsUmBccwMCc8Onv7e\n mCLADALCi5Kl3TLqLD1uVCgJoxSa7699v3o4ZebIszUfKx4yKy79IXPG2BfX6niB2o4k\n 6bhTPwh1D4ma7Fa52yVd4KHk4dmMsLAu6EetbYEXvQ9S1YSUZY/n2NPa5pJhfwBBC6U/\n /YPaNJidCtJ5nyMczCWO4yt6skX9duc75fqn/X9rA15PFfcp1GkJlXnQJ4UlFcI/0TH5\n VVGQ==", "X-Gm-Message-State": "AOJu0YxnRhdsRy7zvNTn/t8iT1zsir+bBPwnfdIT/q7DPWBPU3sLwrLZ\n 3+q6Rh4tkQy3umEFOxHQRPkf+Qpziku0UQ8tQzCQY36mdgxUUwY9jmheWEa/3Y4+", "X-Gm-Gg": "AeBDieu/IXTwQhrGGa5M04z48qh7yJgvntQgjBYbkzrPucip9gYaxlqUSODUkUnHeYr\n ls6G0JgKZ2U0m7eiE/6pkJgItf4c2XtDi1GDhH7sqhmqvx1mQqNOy9jd1Npv3/IZYb42zZBpf+X\n NpI9sdZhrLo/deEwCaRLcioNRZJ4PGWZcTUQRJTVu6sVMeqbxvZ8yUXarARP0syhhEerZRGv9VW\n ffokyevejvgMxwGTBa2c3MNG4Wscsl/oQT9E/C7wSUOMSL460pratJfgmwWT1zOY2C3zzCiT3Lg\n +Es0rrrU8IhZjXK8O6uw5ANyhYK87lcGMYufdJop0zutYOkGDAEGDHka7fUhVpgzmwC0VtkKtbV\n sNR//MSs3Iw3WyC1o4g3XXrLboMr/EDnFuLhaNOzfCNv9d9M+FofdwXeBZKWB/cqNq9F8PU6ncW\n /5NnI=", "X-Received": "by 2002:a05:693c:2c06:b0:2c8:7172:3b99 with SMTP id\n 5a478bee46e88-2cbfa5be574mr5450230eec.9.1775447532656;\n Sun, 05 Apr 2026 20:52:12 -0700 (PDT)", "From": "Matt Vollrath <tactii@gmail.com>", "To": "intel-wired-lan@osuosl.org", "Cc": "Matt Vollrath <tactii@gmail.com>,\n\tKohei Enju <kohei@enjuk.jp>", "Date": "Sun, 5 Apr 2026 23:51:30 -0400", "Message-ID": "<20260406035130.2255713-1-tactii@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775447533; x=1776052333; darn=osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=hmk9aicmTfvrHqX4hH39mm0lV7/QJSeEEdSeX0rcnVM=;\n b=gHihSWfjhOWaXXdw2sK74E0vxit/i1AKAKrt2ZH8n8rK8zTaAg5atzM3qe0liUa+xo\n LUkGXsamLyC771txE8TQwFSVnBZZ3HCh90MJj4xfFjM0CLichNzQgfBEXCRRTgZjxMxd\n ot3JEJ+5Qxmjdl+/DfQQUOstHibaaHf6MdsEIZVuutnU5leyLGHH5tMV1zXmkJAbI707\n Nj8n1POKjSWGWJcZGn586YFaGHpAJE/YQmgF7KpM9azRSTFLVEbfc8EVBbSIhUFo2CRj\n P3oEjFFcgoy+kUnt2+CaQarjsU5RblEqwbMySIhgZLffHfaSAR+nqIQzg+i+EG+Dsa/9\n u1oA==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gHihSWfj" ], "Subject": "[Intel-wired-lan] [PATCH net] i40e: Cleanup PTP pins on probe\n failure", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "PTP pin structs are allocated early in probe, but never cleaned up.\n\nFix this by calling i40e_ptp_free_pins in the error path.\n\nTo support this, i40e_ptp_free_pins was added to the header and made\nidempotent. The idempotency supports the condition of\npf->ptp_caps.pin_config not being allocated yet. pin_config is also\ncorrectly nullified after being freed.\n\nThis has been an issue since i40e_ptp_alloc_pins was introduced.\n\nFixes: 1050713026a08 (\"i40e: add support for PTP external synchronization clock\")\nReported-by: Kohei Enju <kohei@enjuk.jp>\nSigned-off-by: Matt Vollrath <tactii@gmail.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 1 +\n drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +\n drivers/net/ethernet/intel/i40e/i40e_ptp.c | 9 ++++++---\n 3 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex dcb50c2e1aa2..83e780919ac9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -1318,6 +1318,7 @@ void i40e_ptp_restore_hw_time(struct i40e_pf *pf);\n void i40e_ptp_init(struct i40e_pf *pf);\n void i40e_ptp_stop(struct i40e_pf *pf);\n int i40e_ptp_alloc_pins(struct i40e_pf *pf);\n+void i40e_ptp_free_pins(struct i40e_pf *pf);\n int i40e_update_adq_vsi_queues(struct i40e_vsi *vsi, int vsi_offset);\n int i40e_is_vsi_uplink_mode_veb(struct i40e_vsi *vsi);\n int i40e_get_partition_bw_setting(struct i40e_pf *pf);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 926d001b2150..c7062aa476dd 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -16112,6 +16112,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \ti40e_clear_interrupt_scheme(pf);\n \tkfree(pf->vsi);\n err_switch_setup:\n+\ti40e_ptp_free_pins(pf);\n \ti40e_reset_interrupt_capability(pf);\n \ttimer_shutdown_sync(&pf->service_timer);\n err_mac_addr:\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\nindex 404a716db8da..856c0f762644 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c\n@@ -940,12 +940,15 @@ int i40e_ptp_hwtstamp_get(struct net_device *netdev,\n *\n * Release memory allocated for PTP pins.\n **/\n-static void i40e_ptp_free_pins(struct i40e_pf *pf)\n+void i40e_ptp_free_pins(struct i40e_pf *pf)\n {\n \tif (i40e_is_ptp_pin_dev(&pf->hw)) {\n-\t\tkfree(pf->ptp_pins);\n-\t\tkfree(pf->ptp_caps.pin_config);\n+\t\tif (pf->ptp_pins)\n+\t\t\tkfree(pf->ptp_pins);\n+\t\tif (pf->ptp_caps.pin_config)\n+\t\t\tkfree(pf->ptp_caps.pin_config);\n \t\tpf->ptp_pins = NULL;\n+\t\tpf->ptp_caps.pin_config = NULL;\n \t}\n }\n \n", "prefixes": [ "net" ] }