Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219922/?format=api
{ "id": 2219922, "url": "http://patchwork.ozlabs.org/api/patches/2219922/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405112410.603223-1-alex.bennee@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260405112410.603223-1-alex.bennee@linaro.org>", "list_archive_url": null, "date": "2026-04-05T11:24:10", "name": "[v2] target/arm: fix fault_s1ns for stage 2 faults", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "47ecf520ddb7e8aaeccf7b70d4da8bfb7b99cb02", "submitter": { "id": 39532, "url": "http://patchwork.ozlabs.org/api/people/39532/?format=api", "name": "Alex Bennée", "email": "alex.bennee@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405112410.603223-1-alex.bennee@linaro.org/mbox/", "series": [ { "id": 498781, "url": "http://patchwork.ozlabs.org/api/series/498781/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498781", "date": "2026-04-05T11:24:10", "name": "[v2] target/arm: fix fault_s1ns for stage 2 faults", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498781/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219922/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=tgcu1Msx;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpXL219ppz1yFs\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 22:47:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9MsY-0007G0-W2; Sun, 05 Apr 2026 08:47:03 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1w9LaX-0007cX-Sr\n for qemu-devel@nongnu.org; Sun, 05 Apr 2026 07:24:21 -0400", "from mail-ed1-x533.google.com ([2a00:1450:4864:20::533])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1w9LaV-0007Ne-Ha\n for qemu-devel@nongnu.org; Sun, 05 Apr 2026 07:24:21 -0400", "by mail-ed1-x533.google.com with SMTP id\n 4fb4d7f45d1cf-66a33f61d80so5720742a12.0\n for <qemu-devel@nongnu.org>; Sun, 05 Apr 2026 04:24:19 -0700 (PDT)", "from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 4fb4d7f45d1cf-66e034c63ebsm2884164a12.26.2026.04.05.04.24.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 05 Apr 2026 04:24:16 -0700 (PDT)", "from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 370175F79F;\n Sun, 05 Apr 2026 12:24:15 +0100 (BST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775388258; x=1775993058; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=1v7R1AtFco+NkGTWs9tgqAhidfQ0/xG2e+uidBNqPEI=;\n b=tgcu1MsxMunqG9VImot8u8ZZIqTRh2ggU5d3q+Slek0ji9lIMwGHhdgDXLTTYw5nW/\n fCGSuSlisGRZfOA1aaYoeM+tmllLT5OvskjxF0mQGNfCoudYj+YmruAVUR3iB37SMlGI\n yPJ9w7xq2GoaPjxHXGfRO90aYzs0Q526n+ZQ/u9uHgkhtXIuFnCMlMV4TRFniI0ehd9L\n IuzD5rtu3vLwSYoVjWXssc3nUHgz6EOW5sltvHRi6DuTR69UeVH9MNOeBkyQMZWkU2zf\n TpouJNuefsvkUTAN7P7aDuvXc6LjY57IQRxHkqtYJ+LEcxKQTZobzTe53CMd4xx+aSX3\n 5Ufg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775388258; x=1775993058;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1v7R1AtFco+NkGTWs9tgqAhidfQ0/xG2e+uidBNqPEI=;\n b=nyIG13w0TakXvL1dMmEd7LZBl7Cr4b/PwdCKxhpnzFeLyIoNySeK8bx0AqP8UnohCW\n 0GoXJyMIOANral5fmqNJ53Y8ZrWOO3HL6u7kSq20stLUSR8/XYFoOTzq3GsW47qM12OH\n PDchzD9GuYlyhi6PbfhGY4ysWlZ4X/xibx/k1Z13Bjy10ymbSMpsw0XxznLkf/hkjX3s\n 5KgjeHWp9lXjFBBsXjvsG3Qxpzz+ZBxHeNSdL0qNvSiCS5E0MnwwrL1C1ULGgHqxseqY\n qyL4iWFOOSkLq07q+IXOwz9xtv7RFigfOR38T22u9WwRm6mgYcVp2lO7Tuj2xv3J3lXl\n kQvg==", "X-Gm-Message-State": "AOJu0YzNbGaDyrCEFAHUu3d2dDFJc4nfo4GGmK+US8Crl25C2Mt1jsyw\n UgM1jjCn1yXPBUex4ZdWN8XeOeBSriNEkWtknuow1wAZIExQi6KHZEJoYfIY56xFescfK1qlM/W\n u3ZuD15A=", "X-Gm-Gg": "AeBDiesgjttZP3Vy0nDyN4v4Zoe/DlGb/hC5XliyqBpsVVWy7ga77my1E9MCg/5DZAY\n Y4sq5fmrMcJmBmozkr9VXjKv3rkW2av0UrZgxbOSxTZNj47bUTwCuQ9vAJOZypGfcGSUOoT6uAL\n oSepLU2QsRp2byswN3iLH5QdJ+TEw8Us9wy2wKaBmbmByTNGv20NaRD1g7n5kOIHmsPuopLkwFv\n jhNa+jVudpHsSYMFShMygykQ49VRPTPPtV+rpYMtnK9oKVlcR72mR5dmDSX7ww2mc50Nx3tNk+M\n kJLodIsPEly/r8o7bGUt57Js5sYQwEcZdQlmIpYNnR88a30sgNCO4JLblH/sORxj/sNmC+gAfHY\n a/u/R0BksYGes5Nfniuz+9m55R7PaHz3uTBM1AzsM0EQibirwDgXV8IvK9z/qAFfgGXupDslvMg\n w6cH9RD2NRS6TtDtQfrYqgTCc=", "X-Received": "by 2002:a05:6402:5256:b0:66b:aa56:ee5b with SMTP id\n 4fb4d7f45d1cf-66e3f85414amr4403852a12.28.1775388257695;\n Sun, 05 Apr 2026 04:24:17 -0700 (PDT)", "From": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>,\n qemu-arm@nongnu.org (open list:ARM TCG CPUs)", "Subject": "[PATCH v2] target/arm: fix fault_s1ns for stage 2 faults", "Date": "Sun, 5 Apr 2026 12:24:10 +0100", "Message-ID": "<20260405112410.603223-1-alex.bennee@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::533;\n envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x533.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The computation of s1ns was simply wrong. For Stage 2 faults, it\nshould indicate whether the faulting IPA is in the Non-Secure IPA\nspace. Correct the logic to check for ARMSS_NonSecure and drop the\nextraneous s2_mmu_idx test. The actual writing of HPFAR_EL2.NS is\nalready gated by arm_is_secure_below_el3(env).\n\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/2568\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n\n---\nv2\n - simplified commit message\n - added r-b\n---\n target/arm/ptw.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/target/arm/ptw.c b/target/arm/ptw.c\nindex d5b2ed6c99c..57a413b468e 100644\n--- a/target/arm/ptw.c\n+++ b/target/arm/ptw.c\n@@ -631,12 +631,11 @@ static ARMSecuritySpace S2_security_space(ARMSecuritySpace s1_space,\n static bool fault_s1ns(ARMSecuritySpace space, ARMMMUIdx s2_mmu_idx)\n {\n /*\n- * For stage 2 faults in Secure EL22, S1NS indicates\n- * whether the faulting IPA is in the Secure or NonSecure\n- * IPA space. For all other kinds of fault, it is false.\n+ * For stage 2 faults, S1NS indicates whether the faulting IPA is\n+ * in the Non-Secure (true) or Secure (false) IPA space. For all\n+ * other kinds of fault, it is false.\n */\n- return space == ARMSS_Secure && regime_is_stage2(s2_mmu_idx)\n- && s2_mmu_idx == ARMMMUIdx_Stage2_S;\n+ return space == ARMSS_NonSecure && regime_is_stage2(s2_mmu_idx);\n }\n \n /* Translate a S1 pagetable walk through S2 if needed. */\n", "prefixes": [ "v2" ] }