Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219921/?format=api
{ "id": 2219921, "url": "http://patchwork.ozlabs.org/api/patches/2219921/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405094447.11347-1-viking4@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260405094447.11347-1-viking4@gmail.com>", "list_archive_url": null, "date": "2026-04-05T09:44:47", "name": "[v2] migration: validate page_size in mapped-ram header before use", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eab37cac1012aac36280c3ead42b8bff38c99a57", "submitter": { "id": 92831, "url": "http://patchwork.ozlabs.org/api/people/92831/?format=api", "name": "Trieu Huynh", "email": "vikingtc4@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260405094447.11347-1-viking4@gmail.com/mbox/", "series": [ { "id": 498780, "url": "http://patchwork.ozlabs.org/api/series/498780/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498780", "date": "2026-04-05T09:44:47", "name": "[v2] migration: validate page_size in mapped-ram header before use", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498780/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219921/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219921/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SSV1Ymt+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpXL21CLsz1yG0\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 22:47:36 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w9Msb-0007J4-WE; Sun, 05 Apr 2026 08:47:06 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1w9K2Y-0008FV-Jx\n for qemu-devel@nongnu.org; Sun, 05 Apr 2026 05:45:10 -0400", "from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1w9K2V-0004QH-0k\n for qemu-devel@nongnu.org; Sun, 05 Apr 2026 05:45:10 -0400", "by mail-pj1-x102a.google.com with SMTP id\n 98e67ed59e1d1-35da9692ec3so2812002a91.1\n for <qemu-devel@nongnu.org>; Sun, 05 Apr 2026 02:45:06 -0700 (PDT)", "from localhost.localdomain ([123.19.199.205])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dd367c142sm10565232a91.11.2026.04.05.02.45.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 05 Apr 2026 02:45:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775382305; x=1775987105; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=okzbMsYPMprqPyZYbFak0QDQb7u3TnkwG80rvryVJXY=;\n b=SSV1Ymt+zlTsIwQhbi4l8QTiFQ5tmoY6WfgfyIMrqn9FWzfQpYDdM/7iUr/JkKs9+p\n Nw/NkdxMBpsH/1ZCcBk/HZwKGClK/0BvOOZx7Aucb7Fy9v2GQfcSV6rnpQ+XXDmHz5MM\n ag5gA5GAX0toxlaRyGDRbBVs/CaNQu3M6gRhIciXabtPCrGog7WSHMs3iRWs+EBvkvc4\n 40ikjNAJNPjJ5lj2zzSCNCHDGa1ymIfiipkCTMw33sROBwukEdapmphc/pusNgr4Kx0F\n tAz24lpzQxPC6Am/kRy4seQ/vUyRpCOO7+6IA5m3LEVMUZGelrtkjSVCuoGVGjQsyoL6\n ppiA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775382305; x=1775987105;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=okzbMsYPMprqPyZYbFak0QDQb7u3TnkwG80rvryVJXY=;\n b=K40X0zWT5YULRw1DUmQu4sgahdv35vIoywvFd+UwKmNaU75lvNfJ5Eb3pHR4qsbqQI\n /FQvFA3xPAcHe6ERk9LEksa0qqe+ZhYjU4oxiHj85r5f5QGULzK/h+C8lU2xPZwmicHc\n oxACRWyz2nfRSkiYCMdj8fPpMqj3pdNmVMEIT0ft7TKO6DMotY8z/fwuv9ZExBeoWQXi\n tbfAshPTLd7dqGJ9Qp+DHuTS5BfZ857EKtIcRsvgHlDkXVzb1Y5XzlcHiwkX6tW9gJ63\n mMeMnhnFuhHRGnavgUm6MkAI4lkyII4NvR9x6vfdtcTEsIbmOM/uHipOZiEke/WOFcbK\n S1DQ==", "X-Gm-Message-State": "AOJu0Ywm74t9cXWEEljuvGui7+prXXgSuNauuyZPJ6nD5vDKThuOeQMD\n 3Vz2vHD1SE4fB2rvkFaA8h+gjkKgHwse4/9msEXd0v8do+p2/ujyepPbc+Tb8jIYjBaXVQ==", "X-Gm-Gg": "AeBDiev5AVlcyJ3sDiyrwZ0Rt/qS8sFm3G6w25v4584n1dgtgoTGq7EeqoQH6Czd9bj\n qe4Hx307TD5AaYLfl1aN33ZFyrY0cXRNXxHPS5Q90Q+ETb7GpXpp6R9CTM2Rsc9TAxIOyK4K+vZ\n ClZ8PTMt7v6aUyJPTfHSGlfGcpkhrVx7Kd7ebdcc5ETXUzhgWtZzKUGRuceaaP4HBCRO+4UMZbU\n +zgTtIfm6rKKr2UKPOPSgBo8gYwHAfNV6r9E/ygCqD2fncelF/iQd+UxMr58xHYZ8WuazlPMi2R\n j9ZMHfu2a9VBcCYim9VmFTH/Es5xq9TET4BRH+syZ+X7Rk5Oi54C+LvF+Hx3JDzAF44QBYFPbXH\n gwmMdRs0W1DvklKyTZIw1WoONs0aJGueit/FXa2+hjCAVpqZwCDCtZl2XIYCp401eHh9JJt1JBW\n BBc5zJILvf4jVkSac89B29IGn3gYrY2FSA7l7ei7TWpQ3xD5s=", "X-Received": "by 2002:a17:90b:3d8a:b0:35b:e4f8:7b2b with SMTP id\n 98e67ed59e1d1-35de68ebaf3mr9445875a91.18.1775382305260;\n Sun, 05 Apr 2026 02:45:05 -0700 (PDT)", "From": "Trieu Huynh <vikingtc4@gmail.com>", "X-Google-Original-From": "Trieu Huynh <viking4@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com, Trieu Huynh <vikingtc4@gmail.com>,\n Fabiano Rosas <farosas@suse.de>", "Subject": "[PATCH v2] migration: validate page_size in mapped-ram header before\n use", "Date": "Sun, 5 Apr 2026 16:44:47 +0700", "Message-ID": "<20260405094447.11347-1-viking4@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::102a;\n envelope-from=vikingtc4@gmail.com; helo=mail-pj1-x102a.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Trieu Huynh <vikingtc4@gmail.com>\n\nmapped_ram_read_header() reads page_size from the migration stream and\nstores it in MappedRamHeader, but does not validate that the value is\nnon-zero before it is later used in parse_ramblock_mapped_ram():\n\nnum_pages = length / header.page_size;\n\nIf a corrupted or malformed migration stream provides invalid, guest\nresumes either with corrupted memory or crashes unexpectedly (eg.\npage_size = 0)\n\nAdd validation in mapped_ram_read_header() to reject invalid page_size\nvalues early and return an error instead of continuing with an invalid\nheader.\n\nSteps to reproduce:\n\nCreate a migration snapshot with mapped-ram enabled:\n(qemu) migrate_set_capability mapped-ram on\n(qemu) migrate file:/tmp/qemu-snapshots/snapshot.bin\nModify the snapshot so that MappedRamHeader.page_size becomes diff with\ntarget psize. (0/512/8192/1GB).\nRestore the snapshot:\n(qemu) migrate_set_capability mapped-ram on\n(qemu) migrate_incoming file:/tmp/qemu-snapshots/snapshot.bin\n\nAs-is:\n* [0]: Floating point exception (core dumped)\n* [512/8192]: Silent corruption\n* [1GB]: \"post load hook failed for: kvm-tpr-opt\" (EPERM)\nTo-be:\n* All: qemu-system-x86_64: Migration mapped-ram header has invalid\n page_size [val] (expected 4096)\n\nSigned-off-by: Trieu Huynh <vikingtc4@gmail.com>\n---\nv2:\n- Replace == 0 check with != TARGET_PAGE_SIZE, which also catches\n non-zero wrong values and matches the actual invariant of the\n mapped-ram feature (suggested by Peter Xu)\n- Include actual and expected values in the error message\n\n migration/ram.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/migration/ram.c b/migration/ram.c\nindex 979751f61b..2046f16caa 100644\n--- a/migration/ram.c\n+++ b/migration/ram.c\n@@ -3088,6 +3088,12 @@ static bool mapped_ram_read_header(QEMUFile *file, MappedRamHeader *header,\n }\n \n header->page_size = be64_to_cpu(header->page_size);\n+ if (header->page_size != TARGET_PAGE_SIZE) {\n+ error_setg(errp, \"Migration mapped-ram header has invalid \"\n+ \"page_size %\" PRIu64 \" (expected %d)\",\n+ header->page_size, TARGET_PAGE_SIZE);\n+ return false;\n+ }\n header->bitmap_offset = be64_to_cpu(header->bitmap_offset);\n header->pages_offset = be64_to_cpu(header->pages_offset);\n \n", "prefixes": [ "v2" ] }