Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219845/?format=api
{ "id": 2219845, "url": "http://patchwork.ozlabs.org/api/patches/2219845/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260404194338.21168-1-ebiggers@kernel.org/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260404194338.21168-1-ebiggers@kernel.org>", "list_archive_url": null, "date": "2026-04-04T19:43:38", "name": "ksmbd: Remove unnecessary selection of CRYPTO_ECB", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ef4d54345233245dbcb526688ca171ae5fa0689b", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260404194338.21168-1-ebiggers@kernel.org/mbox/", "series": [ { "id": 498749, "url": "http://patchwork.ozlabs.org/api/series/498749/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=498749", "date": "2026-04-04T19:43:38", "name": "ksmbd: Remove unnecessary selection of CRYPTO_ECB", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498749/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219845/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-cifs+bounces-10666-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=eF+YrLnj;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10666-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"eF+YrLnj\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fp5fZ6R55z1yG2\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 05:45:26 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 1D93A3004425\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 4 Apr 2026 19:45:25 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A1F6D29AAEA;\n\tSat, 4 Apr 2026 19:45:23 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F2C723C39A;\n\tSat, 4 Apr 2026 19:45:23 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id E7F91C19421;\n\tSat, 4 Apr 2026 19:45:22 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775331923; cv=none;\n b=LnT/fc1uOs+4FU2vaRiJfw/5TnvKbudTPLLtAuBLXtmgPkteilODw1bToDu8lWlmym6qId19s5cM7cFPUahsoAFx8BFlPGu+RZMCUrWS+rSjfPH6r8Xh0nOp/Vca3kNzfSkQHlmsruwNg4tN7Av2f4vKjl/mHtmhqu8sHnRQUSc=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775331923; c=relaxed/simple;\n\tbh=7JSG5D3JGF+7GTzodGjPk3bDws1pIPBcqi4HIsjesSY=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=FPichcIuXQdfL2KJjr7/YRfKlKC+gK1Ka9d9gpIGsmcMI94tue46PgxXADpWQQCOahCjfWTN5cmyL7kfhRgHaBhWGfc/8GvZZwu2w53aC2lpnswFY9j9f8VF+VzMYfAcMh9bXGITkd8Bk7D6sFNRSS6xrL9AM1cUpJ1X1FevxKk=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=eF+YrLnj; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775331923;\n\tbh=7JSG5D3JGF+7GTzodGjPk3bDws1pIPBcqi4HIsjesSY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=eF+YrLnj1+a0diqXTUPtLiR429KJqMbhfSTKTOAvlEa+dCmqw0KKEsk5AtydU3swI\n\t B2C4bU2pQtnOtqezNUD1ML7A4sWJxuLLPKpnfnao7lmO+4YXdO061d81OJMpcPV0re\n\t 166xMJsSExkMLj/47bUWxu4uhNhmnIAWqoAYoQHipvbHl+J8LnN5/8FiuxpgVDsRIH\n\t Q/GsRMYZobgDoCd7Agsrqw4tjITnAWsUPaMJ90gcvM0iBmz67+e6lRzK5e11H0jNUE\n\t hiP3Vw62ax9+s1eoiiH59wyb10H3qGkVJank3GG64qr9khXYXTp8arpaIrCt/pmJEz\n\t 9lvbpR7sMR1Qw==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-cifs@vger.kernel.org,\n\tNamjae Jeon <linkinjeon@kernel.org>,\n\tSteve French <smfrench@gmail.com>", "Cc": "Sergey Senozhatsky <senozhatsky@chromium.org>,\n\tTom Talpey <tom@talpey.com>,\n\tlinux-kernel@vger.kernel.org,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH] ksmbd: Remove unnecessary selection of CRYPTO_ECB", "Date": "Sat, 4 Apr 2026 12:43:38 -0700", "Message-ID": "<20260404194338.21168-1-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Since the SMB server never uses any ecb(...) algorithm from the\ncrypto_skcipher API, selecting CRYPTO_ECB is unnecessary.\n\nRemove it along with the unused CRYPTO_BLK_* constants.\n\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n\nThis patch is targeting the ksmbd tree.\n\n fs/smb/server/Kconfig | 1 -\n fs/smb/server/crypto_ctx.h | 5 -----\n fs/smb/server/server.c | 1 -\n 3 files changed, 7 deletions(-)\n\n\nbase-commit: 2febe6e6ee6e34c7754eff3c4d81aa7b0dcb7979", "diff": "diff --git a/fs/smb/server/Kconfig b/fs/smb/server/Kconfig\nindex 5c77c5552ed8a..37387410e5bb3 100644\n--- a/fs/smb/server/Kconfig\n+++ b/fs/smb/server/Kconfig\n@@ -5,11 +5,10 @@ config SMB_SERVER\n \tdepends on FILE_LOCKING\n \tselect NLS\n \tselect NLS_UTF8\n \tselect NLS_UCS2_UTILS\n \tselect CRYPTO\n-\tselect CRYPTO_ECB\n \tselect CRYPTO_LIB_ARC4\n \tselect CRYPTO_LIB_DES\n \tselect CRYPTO_LIB_MD5\n \tselect CRYPTO_LIB_SHA256\n \tselect CRYPTO_LIB_SHA512\ndiff --git a/fs/smb/server/crypto_ctx.h b/fs/smb/server/crypto_ctx.h\nindex b9476ed520ae4..27fd553d10aab 100644\n--- a/fs/smb/server/crypto_ctx.h\n+++ b/fs/smb/server/crypto_ctx.h\n@@ -18,15 +18,10 @@ enum {\n \tCRYPTO_AEAD_AES_GCM = 16,\n \tCRYPTO_AEAD_AES_CCM,\n \tCRYPTO_AEAD_MAX,\n };\n \n-enum {\n-\tCRYPTO_BLK_ECBDES\t= 32,\n-\tCRYPTO_BLK_MAX,\n-};\n-\n struct ksmbd_crypto_ctx {\n \tstruct list_head\t\tlist;\n \n \tstruct shash_desc\t\t*desc[CRYPTO_SHASH_MAX];\n \tstruct crypto_aead\t\t*ccmaes[CRYPTO_AEAD_MAX];\ndiff --git a/fs/smb/server/server.c b/fs/smb/server/server.c\nindex 422d9d9782859..d8893079abdb5 100644\n--- a/fs/smb/server/server.c\n+++ b/fs/smb/server/server.c\n@@ -627,11 +627,10 @@ static void __exit ksmbd_server_exit(void)\n }\n \n MODULE_AUTHOR(\"Namjae Jeon <linkinjeon@kernel.org>\");\n MODULE_DESCRIPTION(\"Linux kernel CIFS/SMB SERVER\");\n MODULE_LICENSE(\"GPL\");\n-MODULE_SOFTDEP(\"pre: ecb\");\n MODULE_SOFTDEP(\"pre: nls\");\n MODULE_SOFTDEP(\"pre: aes\");\n MODULE_SOFTDEP(\"pre: cmac\");\n MODULE_SOFTDEP(\"pre: aead2\");\n MODULE_SOFTDEP(\"pre: ccm\");\n", "prefixes": [] }