Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219826/?format=api
{ "id": 2219826, "url": "http://patchwork.ozlabs.org/api/patches/2219826/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260404152736.30190-1-viking4@gmail.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260404152736.30190-1-viking4@gmail.com>", "list_archive_url": null, "date": "2026-04-04T15:27:36", "name": "migration: add optional capabilities field to migrate and migrate-incoming", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7bfb36416277a59777f012050f67d5a944391b6a", "submitter": { "id": 92831, "url": "http://patchwork.ozlabs.org/api/people/92831/?format=api", "name": "Trieu Huynh", "email": "vikingtc4@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260404152736.30190-1-viking4@gmail.com/mbox/", "series": [ { "id": 498736, "url": "http://patchwork.ozlabs.org/api/series/498736/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498736", "date": "2026-04-04T15:27:36", "name": "migration: add optional capabilities field to migrate and migrate-incoming", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498736/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219826/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=GoPI8NOn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnzyL1bzGz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 02:28:42 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w92ui-0002xF-UN; Sat, 04 Apr 2026 11:27:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1w92uh-0002x4-H6\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 11:27:55 -0400", "from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <vikingtc4@gmail.com>)\n id 1w92ud-0004dW-FS\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 11:27:53 -0400", "by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2ab077e3f32so11102475ad.3\n for <qemu-devel@nongnu.org>; Sat, 04 Apr 2026 08:27:50 -0700 (PDT)", "from localhost.localdomain ([123.19.199.205])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c6475ae9sm8010120a12.2.2026.04.04.08.27.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 04 Apr 2026 08:27:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775316469; x=1775921269; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=VpOPu3N88OLYcGF2nSpup4up/DQqoLUQd3kVQiqld5Q=;\n b=GoPI8NOnSJtbtrfUNw0djthuXTLTiszglM1mnI2s+MpAZEuKs5s2kL0CErPD5/66g9\n 55RK/HiDzeYYCvoyXpxe8FVmubcM5YdzrvWMW9wkn5nzRvw9gICM42/32X6xjLFJ0aP+\n kLSnquH0kBe+7fDYuWlqogKjXnvWxHs/KavP+NFxW0DP/txFOe2Hj56pLyPb7INgLrWe\n DQSlNWazXvokBt3uIOrUCHmnYCif1Zhpw63pMyjuWK2s8HbvYqCjwaM98fed3HlJfTzm\n uVohTw0+V2s/fui2Zg05Gzn9/KRMeAJgAcEeNXTW46v/De/yb3stkIRh8GQeK3dD8vui\n vg1w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775316469; x=1775921269;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VpOPu3N88OLYcGF2nSpup4up/DQqoLUQd3kVQiqld5Q=;\n b=kGtLEgZdxLjJ+n+vSvZBmS8alWWACbgVF97vvc5HrQBrHuIFCe5ycKqTuY37yzlwlA\n jUtlasc/cDqdF3JburkqrCXD+UdOVpqeSjWdDFpwrSLVihf/MW1SUW+7WN+L1e4dDEi5\n pNA0gyr2iNDjxVb53kcOBl7wk1cbI4TQwiZXapUmztsb9B87A8SGj/S8WKyiKEb0JrEy\n yzLuUmF1QrHbJsRK+HkVMvyO7XW9bOm2S3tBXET/76p8FfWlqClAw2KLebRWS9zzyXv+\n y4KUqPHbxTnxjKDTBZfLnH5X6IKkGmLx/VnyNZQedBSeeK8Cd47BXr/GT7QjYhkeDTuc\n Gktg==", "X-Gm-Message-State": "AOJu0YwzTvhrMdsrvnBaGpaRB4bKZq6ewtZllwcoY8LU6uM8XJ2jYmaG\n dDkpMDk3XKbOn7E+3CDaeOhQLPM82l2esrPrNIAzNxJR6CmUzUndRwk1iVJ+FjwZE2QksQ==", "X-Gm-Gg": "AeBDiesTVZomR4ncxpgH37xflLiGnRy+tUrkcP5/Vglg5xzo5AWwhSSKf08h6m9OGIf\n jO7oUMeC4ZoeUAsjkJEwgEYWFZj4EX9Hw8OH5iokWEkSzV8fCRGJr/UFTWseV3whUTld8oULdsY\n cPOyrNkv/HmhexNlb/EcEG5j+bxarLqK7b5Vs5iPvhfA+6wU3m4SxxStCMip0Kf5xZCgZ/9IXWs\n S4FYHiKH6tDPAj1WorFncsLnGf7qDIGPZqxFZo1LtmlNfZC762aZzwldZCbE02RqXPt3v9Lu6uN\n fPYnwdgOIAjg7dyggLxP3WNHyxS7gGKzLJwd9uDZHo/HayGkpFaYMynDrfSnF3u0W8WSXb5hKZU\n fNINbiscxWsEc233LbY+yuX145n/h1U/HRDX8JhmnCVoGhNQ/sC4UPR3nByvdJAAZjou/Nd65Ph\n qixXtB9gheXv22IKWdh+2+VvoSnOAmIyCvrcqrBrIOR0ujI4ElYT+mqGM/yw==", "X-Received": "by 2002:a17:903:183:b0:2b0:5626:f75d with SMTP id\n d9443c01a7336-2b28176974bmr69306335ad.26.1775316469329;\n Sat, 04 Apr 2026 08:27:49 -0700 (PDT)", "From": "Trieu Huynh <vikingtc4@gmail.com>", "X-Google-Original-From": "Trieu Huynh <viking4@gmail.com>", "To": "qemu-devel@nongnu.org", "Cc": "Trieu Huynh <vikingtc4@gmail.com>, Peter Xu <peterx@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, Eric Blake <eblake@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH] migration: add optional capabilities field to migrate and\n migrate-incoming", "Date": "Sat, 4 Apr 2026 22:27:36 +0700", "Message-ID": "<20260404152736.30190-1-viking4@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::636;\n envelope-from=vikingtc4@gmail.com; helo=mail-pl1-x636.google.com", "X-Spam_score_int": "-17", "X-Spam_score": "-1.8", "X-Spam_bar": "-", "X-Spam_report": "(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Trieu Huynh <vikingtc4@gmail.com>\n\nWhen invoking migration, user must call migrate-set-capabilities as a\nseparate QMP command before calling migrate or migrate-incoming.\n\nAdd an optional 'capabilities' field to both commands. When provided,\nthe capabilities are applied before the migration starts, in the same\norder as a migrate-set-capabilities call would apply them. Existing\ncallers that do not pass the field are unaffected.\n\nThis is particularly useful, eg. for snapshot-load workflows where a\nsingle migrate-incoming call should express the full migration\nconfiguration:\n\n { \"execute\": \"migrate-incoming\",\n \"arguments\": {\n \"uri\": \"file:/tmp/snapshot\",\n \"capabilities\": [{\"capability\": \"mapped-ram\", \"state\": true}]\n }}\n\nInternal callers (HMP migrate-incoming, vl.c -incoming) pass\nhas_capabilities=false so their behaviour is unchanged.\n\nRelated-to: https://wiki.qemu.org/ToDo/LiveMigration#Allow_QMP_command_%22migrate[_incoming]%22_to_take_capabilities_and_parameters\n\nSigned-off-by: Trieu Huynh <vikingtc4@gmail.com>\n---\n migration/migration-hmp-cmds.c | 4 ++--\n migration/migration.c | 19 +++++++++++++++++++\n qapi/migration.json | 12 ++++++++++++\n system/vl.c | 3 ++-\n 4 files changed, 35 insertions(+), 3 deletions(-)", "diff": "diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c\nindex 0a193b8f54..32c338103d 100644\n--- a/migration/migration-hmp-cmds.c\n+++ b/migration/migration-hmp-cmds.c\n@@ -522,7 +522,7 @@ void hmp_migrate_incoming(Monitor *mon, const QDict *qdict)\n }\n QAPI_LIST_PREPEND(caps, g_steal_pointer(&channel));\n \n- qmp_migrate_incoming(NULL, true, caps, true, false, &err);\n+ qmp_migrate_incoming(NULL, true, caps, false, NULL, true, false, &err);\n qapi_free_MigrationChannelList(caps);\n \n end:\n@@ -829,7 +829,7 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)\n }\n QAPI_LIST_PREPEND(caps, g_steal_pointer(&channel));\n \n- qmp_migrate(NULL, true, caps, true, resume, &err);\n+ qmp_migrate(NULL, true, caps, false, NULL, true, resume, &err);\n if (hmp_handle_error(mon, err)) {\n return;\n }\ndiff --git a/migration/migration.c b/migration/migration.c\nindex 5c9aaa6e58..eb1a734dd9 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -1752,6 +1752,8 @@ void migrate_del_blocker(Error **reasonp)\n \n void qmp_migrate_incoming(const char *uri, bool has_channels,\n MigrationChannelList *channels,\n+ bool has_capabilities,\n+ MigrationCapabilityStatusList *capabilities,\n bool has_exit_on_error, bool exit_on_error,\n Error **errp)\n {\n@@ -1772,6 +1774,14 @@ void qmp_migrate_incoming(const char *uri, bool has_channels,\n return;\n }\n \n+ if (has_capabilities) {\n+ qmp_migrate_set_capabilities(capabilities, errp);\n+ if (*errp) {\n+ yank_unregister_instance(MIGRATION_YANK_INSTANCE);\n+ return;\n+ }\n+ }\n+\n mis->exit_on_error =\n has_exit_on_error ? exit_on_error : INMIGRATE_DEFAULT_EXIT_ON_ERROR;\n \n@@ -2020,6 +2030,8 @@ static gboolean migration_connect_outgoing_cb(QIOChannel *channel,\n \n void qmp_migrate(const char *uri, bool has_channels,\n MigrationChannelList *channels,\n+ bool has_capabilities,\n+ MigrationCapabilityStatusList *capabilities,\n bool has_resume, bool resume, Error **errp)\n {\n MigrationState *s = migrate_get_current();\n@@ -2036,6 +2048,13 @@ void qmp_migrate(const char *uri, bool has_channels,\n return;\n }\n \n+ if (has_capabilities) {\n+ qmp_migrate_set_capabilities(capabilities, errp);\n+ if (*errp) {\n+ return;\n+ }\n+ }\n+\n if (!migrate_prepare(s, has_resume && resume, errp)) {\n /* Error detected, put into errp */\n return;\ndiff --git a/qapi/migration.json b/qapi/migration.json\nindex 7134d4ce47..58d934f8fe 100644\n--- a/qapi/migration.json\n+++ b/qapi/migration.json\n@@ -1388,6 +1388,11 @@\n # @channels: list of migration stream channels with each stream in the\n # list connected to a destination interface endpoint.\n #\n+# @capabilities: list of migration capabilities to set before\n+# starting the migration. Equivalent to calling\n+# `migrate-set-capabilities` before `migrate`, but more\n+# convenient.\n+#\n # @resume: when set, use the new uri/channels specified to resume\n # paused postcopy migration. This flag should only be used if\n # the previous postcopy migration was interrupted. The command\n@@ -1453,6 +1458,7 @@\n { 'command': 'migrate',\n 'data': {'*uri': 'str',\n '*channels': [ 'MigrationChannel' ],\n+ '*capabilities': ['MigrationCapabilityStatus'],\n '*resume': 'bool' } }\n \n ##\n@@ -1467,6 +1473,11 @@\n # @channels: list of migration stream channels with each stream in the\n # list connected to a destination interface endpoint.\n #\n+# @capabilities: list of migration capabilities to set before\n+# starting the migration. Equivalent to calling\n+# `migrate-set-capabilities` before `migrate-incoming`, but more\n+# convenient.\n+#\n # @exit-on-error: Exit on incoming migration failure. Default true.\n # When set to false, the failure triggers a\n # :qapi:event:`MIGRATION` event, and error details could be\n@@ -1525,6 +1536,7 @@\n { 'command': 'migrate-incoming',\n 'data': {'*uri': 'str',\n '*channels': [ 'MigrationChannel' ],\n+ '*capabilities': ['MigrationCapabilityStatus'],\n '*exit-on-error': 'bool' } }\n \n ##\ndiff --git a/system/vl.c b/system/vl.c\nindex 246623b319..ed569d75e7 100644\n--- a/system/vl.c\n+++ b/system/vl.c\n@@ -2826,7 +2826,8 @@ void qmp_x_exit_preconfig(Error **errp)\n g_new0(MigrationChannelList, 1);\n \n channels->value = incoming_channels[MIGRATION_CHANNEL_TYPE_MAIN];\n- qmp_migrate_incoming(NULL, true, channels, true, true, &local_err);\n+ qmp_migrate_incoming(NULL, true, channels, false, NULL, true,\n+ true, &local_err);\n if (local_err) {\n error_reportf_err(local_err, \"-incoming %s: \", incoming);\n exit(1);\n", "prefixes": [] }