Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219672/?format=api
{ "id": 2219672, "url": "http://patchwork.ozlabs.org/api/patches/2219672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403163751.1303250-2-dmantipov@yandex.ru/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403163751.1303250-2-dmantipov@yandex.ru>", "list_archive_url": null, "date": "2026-04-03T16:37:51", "name": "[v2,2/2] ubifs: use strscpy() and kmemdup_nul() where appropriate", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2a062d5d6d3c053ffb0e7a53338e8cd1db023651", "submitter": { "id": 87610, "url": "http://patchwork.ozlabs.org/api/people/87610/?format=api", "name": "Dmitry Antipov", "email": "dmantipov@yandex.ru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403163751.1303250-2-dmantipov@yandex.ru/mbox/", "series": [ { "id": 498656, "url": "http://patchwork.ozlabs.org/api/series/498656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=498656", "date": "2026-04-03T16:37:51", "name": null, "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498656/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219672/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kRDq2pp9;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256\n header.s=mail header.b=cT8rQkYH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)", "\n mail-nwsmtp-smtp-production-main-92.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnPZP4dgNz1yDH\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 03:39:21 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8hY4-00000002L49-3cPZ;\n\tFri, 03 Apr 2026 16:39:08 +0000", "from forward102a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:d102])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8hXz-00000002L1f-3QCF\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 03 Apr 2026 16:39:06 +0000", "from mail-nwsmtp-smtp-production-main-92.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-92.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c1f:251b:0:640:cb7f:0])\n\tby forward102a.mail.yandex.net (Yandex) with ESMTPS id A1029C0063;\n\tFri, 03 Apr 2026 19:38:53 +0300 (MSK)", "by mail-nwsmtp-smtp-production-main-92.vla.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id pcg2buER9mI0-ePC8Qvkh;\n\tFri, 03 Apr 2026 19:38:53 +0300" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=U7TCwkyjBLvZr8z+dthrHvLOf+P8KWSkZPeJCznnfNw=; b=kRDq2pp9/XTC6H\n\tc1vHtltU1s1wdNsg9++NMCZLuCP0XGs3E2Ut9EfInjim/CMoroUs/l8PjL/1RTuIuwFhfqOs8PfOG\n\thMK77NfrN6IvcQbykE78+RMyHp2wD284awPuqc4N0jJCwrz0GtBJOCT4qQqi9jCgUFtdVzHwNCfwQ\n\tVbd7P7WfdtW/r5BOY1xPNkEGnCmr6cFrg4edYCaG4ok9tMJQ6KjfehpQKtBmSdArXfXXhBJuuIvGi\n\tGjSqS5rb7f5Wjy4w52maRfYtNK1QNfnYdWpzecTr0EeS89UvbX4C1k+A95GysdkyTitk0S8dFtNn7\n\t9/Cy5CHBztgqu+wl7YDw==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n\tt=1775234333; bh=XVWgAv6XvNduTtlZO3tPzBIGWEjQ9P6aF2g0hzg8ZN0=;\n\th=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n\tb=cT8rQkYHSThM2SEM/HiGpOJK/kyTXjY0UqM2e8UyP+pqQuympRUWIGFIrkC7OLcc2\n\t 9KFVb47KXE/57xayCZurkxzx7i2Wgd5By4h4sxUnaknVZ8qP5KcqjYUTw4eL8/lvjq\n\t VF8kFI+mIT1hrxvalxzDegZ1tkNcnm7iRHG238s4=" ], "X-Yandex-Fwd": "1", "From": "Dmitry Antipov <dmantipov@yandex.ru>", "To": "Zhihao Cheng <chengzhihao1@huawei.com>", "Cc": "Richard Weinberger <richard@nod.at>,\n\tlinux-mtd@lists.infradead.org,\n\tDmitry Antipov <dmantipov@yandex.ru>", "Subject": "[PATCH v2 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate", "Date": "Fri, 3 Apr 2026 19:37:51 +0300", "Message-ID": "<20260403163751.1303250-2-dmantipov@yandex.ru>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260403163751.1303250-1-dmantipov@yandex.ru>", "References": "<67df08d1-6bbf-560c-de40-9cf1e88c406a@huawei.com>\n <20260403163751.1303250-1-dmantipov@yandex.ru>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260403_093904_400446_C43A3F81 ", "X-CRM114-Status": "GOOD ( 11.18 )", "X-Spam-Score": "-2.8 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Go closer to the modern kernel API and use 'strscpy()' and\n 'kmemdup_nul()' over an ad-hoc ensure-to-have-'\\0' quirks where\n appropriate.\n Signed-off-by: Dmitry Antipov --- v2: initial version to join the series\n --- fs/ubifs/journal.c | 18 ++++++ fs/ubifs/replay.c | 3 +--\n fs/ubifs/super.c\n | 8 ++------ 3 files changed, 9 ins [...]\n Content analysis details: (-2.8 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low\n trust\n [2a02:6b8:c0e:500:1:45:d181:d102 listed in]\n [list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [dmantipov(at)yandex.ru]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Go closer to the modern kernel API and use 'strscpy()' and 'kmemdup_nul()'\nover an ad-hoc ensure-to-have-'\\0' quirks where appropriate.\n\nSigned-off-by: Dmitry Antipov <dmantipov@yandex.ru>\n---\nv2: initial version to join the series\n---\n fs/ubifs/journal.c | 18 ++++++------------\n fs/ubifs/replay.c | 3 +--\n fs/ubifs/super.c | 8 ++------\n 3 files changed, 9 insertions(+), 20 deletions(-)", "diff": "diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c\nindex e28ab4395e5c..fa13e988e8b2 100644\n--- a/fs/ubifs/journal.c\n+++ b/fs/ubifs/journal.c\n@@ -729,8 +729,7 @@ int ubifs_jnl_update(struct ubifs_info *c, const struct inode *dir,\n \tdent->inum = deletion ? 0 : cpu_to_le64(inode->i_ino);\n \tdent->type = get_dent_type(inode->i_mode);\n \tdent->nlen = cpu_to_le16(fname_len(nm));\n-\tmemcpy(dent->name, fname_name(nm), fname_len(nm));\n-\tdent->name[fname_len(nm)] = '\\0';\n+\tstrscpy(dent->name, fname_name(nm), fname_len(nm));\n \tset_dent_cookie(c, dent);\n \n \tzero_dent_node_unused(dent);\n@@ -1232,8 +1231,7 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,\n \tdent1->inum = cpu_to_le64(fst_inode->i_ino);\n \tdent1->type = get_dent_type(fst_inode->i_mode);\n \tdent1->nlen = cpu_to_le16(fname_len(snd_nm));\n-\tmemcpy(dent1->name, fname_name(snd_nm), fname_len(snd_nm));\n-\tdent1->name[fname_len(snd_nm)] = '\\0';\n+\tstrscpy(dent1->name, fname_name(snd_nm), fname_len(snd_nm));\n \tset_dent_cookie(c, dent1);\n \tzero_dent_node_unused(dent1);\n \tubifs_prep_grp_node(c, dent1, dlen1, 0);\n@@ -1248,8 +1246,7 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,\n \tdent2->inum = cpu_to_le64(snd_inode->i_ino);\n \tdent2->type = get_dent_type(snd_inode->i_mode);\n \tdent2->nlen = cpu_to_le16(fname_len(fst_nm));\n-\tmemcpy(dent2->name, fname_name(fst_nm), fname_len(fst_nm));\n-\tdent2->name[fname_len(fst_nm)] = '\\0';\n+\tstrscpy(dent2->name, fname_name(fst_nm), fname_len(fst_nm));\n \tset_dent_cookie(c, dent2);\n \tzero_dent_node_unused(dent2);\n \tubifs_prep_grp_node(c, dent2, dlen2, 0);\n@@ -1424,8 +1421,7 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir,\n \tdent->inum = cpu_to_le64(old_inode->i_ino);\n \tdent->type = get_dent_type(old_inode->i_mode);\n \tdent->nlen = cpu_to_le16(fname_len(new_nm));\n-\tmemcpy(dent->name, fname_name(new_nm), fname_len(new_nm));\n-\tdent->name[fname_len(new_nm)] = '\\0';\n+\tstrscpy(dent->name, fname_name(new_nm), fname_len(new_nm));\n \tset_dent_cookie(c, dent);\n \tzero_dent_node_unused(dent);\n \tubifs_prep_grp_node(c, dent, dlen1, 0);\n@@ -1446,8 +1442,7 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir,\n \t\tdent2->type = DT_UNKNOWN;\n \t}\n \tdent2->nlen = cpu_to_le16(fname_len(old_nm));\n-\tmemcpy(dent2->name, fname_name(old_nm), fname_len(old_nm));\n-\tdent2->name[fname_len(old_nm)] = '\\0';\n+\tstrscpy(dent2->name, fname_name(old_nm), fname_len(old_nm));\n \tset_dent_cookie(c, dent2);\n \tzero_dent_node_unused(dent2);\n \tubifs_prep_grp_node(c, dent2, dlen2, 0);\n@@ -1897,8 +1892,7 @@ int ubifs_jnl_delete_xattr(struct ubifs_info *c, const struct inode *host,\n \txent->inum = 0;\n \txent->type = get_dent_type(inode->i_mode);\n \txent->nlen = cpu_to_le16(fname_len(nm));\n-\tmemcpy(xent->name, fname_name(nm), fname_len(nm));\n-\txent->name[fname_len(nm)] = '\\0';\n+\tstrscpy(xent->name, fname_name(nm), fname_len(nm));\n \tzero_dent_node_unused(xent);\n \tubifs_prep_grp_node(c, xent, xlen, 0);\n \ndiff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c\nindex a9a568f4a868..cb1c3fafa5c5 100644\n--- a/fs/ubifs/replay.c\n+++ b/fs/ubifs/replay.c\n@@ -463,8 +463,7 @@ static int insert_dent(struct ubifs_info *c, int lnum, int offs, int len,\n \tr->sqnum = sqnum;\n \tkey_copy(c, key, &r->key);\n \tfname_len(&r->nm) = nlen;\n-\tmemcpy(nbuf, name, nlen);\n-\tnbuf[nlen] = '\\0';\n+\tstrscpy(nbuf, name, nlen);\n \tfname_name(&r->nm) = nbuf;\n \n \tlist_add_tail(&r->list, &c->replay_list);\ndiff --git a/fs/ubifs/super.c b/fs/ubifs/super.c\nindex 03bf924756ca..da2f1067f054 100644\n--- a/fs/ubifs/super.c\n+++ b/fs/ubifs/super.c\n@@ -168,13 +168,11 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)\n \t\tinode->i_op = &ubifs_file_inode_operations;\n \t\tinode->i_fop = &ubifs_file_operations;\n \t\tif (ui->xattr) {\n-\t\t\tui->data = kmalloc(ui->data_len + 1, GFP_NOFS);\n+\t\t\tui->data = kmemdup_nul(ino->data, ui->data_len, GFP_NOFS);\n \t\t\tif (!ui->data) {\n \t\t\t\terr = -ENOMEM;\n \t\t\t\tgoto out_ino;\n \t\t\t}\n-\t\t\tmemcpy(ui->data, ino->data, ui->data_len);\n-\t\t\t((char *)ui->data)[ui->data_len] = '\\0';\n \t\t} else if (ui->data_len != 0) {\n \t\t\terr = 10;\n \t\t\tgoto out_invalid;\n@@ -194,13 +192,11 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)\n \t\t\terr = 12;\n \t\t\tgoto out_invalid;\n \t\t}\n-\t\tui->data = kmalloc(ui->data_len + 1, GFP_NOFS);\n+\t\tui->data = kmemdup_nul(ino->data, ui->data_len, GFP_NOFS);\n \t\tif (!ui->data) {\n \t\t\terr = -ENOMEM;\n \t\t\tgoto out_ino;\n \t\t}\n-\t\tmemcpy(ui->data, ino->data, ui->data_len);\n-\t\t((char *)ui->data)[ui->data_len] = '\\0';\n \t\tbreak;\n \tcase S_IFBLK:\n \tcase S_IFCHR:\n", "prefixes": [ "v2", "2/2" ] }