Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219660/?format=api
{ "id": 2219660, "url": "http://patchwork.ozlabs.org/api/patches/2219660/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20260403-add-mcu-fan-khadas-vim4-v2-5-70536b22439a@aliel.fr/", "project": { "id": 35, "url": "http://patchwork.ozlabs.org/api/projects/35/?format=api", "name": "Linux I2C development", "link_name": "linux-i2c", "list_id": "linux-i2c.vger.kernel.org", "list_email": "linux-i2c@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403-add-mcu-fan-khadas-vim4-v2-5-70536b22439a@aliel.fr>", "list_archive_url": null, "date": "2026-04-03T16:08:38", "name": "[v2,5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "82f04c25e7ca0c540321fe12f94666f7a90bd0e7", "submitter": { "id": 93040, "url": "http://patchwork.ozlabs.org/api/people/93040/?format=api", "name": "Ronald Claveau", "email": "linux-kernel-dev@aliel.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-i2c/patch/20260403-add-mcu-fan-khadas-vim4-v2-5-70536b22439a@aliel.fr/mbox/", "series": [ { "id": 498653, "url": "http://patchwork.ozlabs.org/api/series/498653/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-i2c/list/?series=498653", "date": "2026-04-03T16:08:34", "name": "Add VIM4 MCU/FAN support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498653/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219660/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-i2c+bounces-16954-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-i2c@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n secure) header.d=aliel.fr header.i=@aliel.fr header.a=rsa-sha256\n header.s=courrier-s1 header.b=EUSknzW6;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16954-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr\n header.b=\"EUSknzW6\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=65.21.61.41", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=aliel.fr", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=aliel.fr" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnP4p3CHhz1yDH\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 03:17:14 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 87A7D31262C1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 3 Apr 2026 16:10:10 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CE2C53CCA1F;\n\tFri, 3 Apr 2026 16:09:29 +0000 (UTC)", "from courrier.aliel.fr (courrier.aliel.fr [65.21.61.41])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 57CEF3CEB84;\n\tFri, 3 Apr 2026 16:09:27 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775232569; cv=none;\n b=UAaOH4olFdiMgdwDrVZCMlhEcEUhZn09DjLHmLwciTGhmXF7z8v1GYP0MhLxlbF6Uk6lc8Vnq9e0+gsmW+tVNRwOEghEjTw/8CEomQJ9CCxj6nf9z/0+xVxEoLlPmkl1fxvwJZgbRRG2aI7hu8pF0GIC+GpxdNDfbpQWe3zLFTQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775232569; c=relaxed/simple;\n\tbh=J2SoalosCyxImvGFu5R4J5FtFH7pMqPC3RBWKZVsADo=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=O86LkqPCvB65w3/IJ2X3MSgsuFugBr4e4GSFjOmdkjGknkXItlJ2rCcLf4ZGlmyE4+dVt0Xgvmt+XZ4YOLGUrHPp0jf6L8zQcJJk+xUVepT/22fCsi3vw2p8Puq+D6wFXTfZ1AS1Z04F9Hrq2RCT4Va5o/UrOdoSww5COJW/8Ls=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=aliel.fr;\n spf=pass smtp.mailfrom=aliel.fr;\n dkim=pass (1024-bit key) header.d=aliel.fr header.i=@aliel.fr\n header.b=EUSknzW6; arc=none smtp.client-ip=65.21.61.41", "From": "Ronald Claveau <linux-kernel-dev@aliel.fr>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr;\n\ts=courrier-s1; t=1775232560;\n\tbh=J2SoalosCyxImvGFu5R4J5FtFH7pMqPC3RBWKZVsADo=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc;\n\tb=EUSknzW6QXDFBYi2M6ZqAl4SVbok284Y2Y48z/7aUBxPgf4Wpt3v5SPa+HbN7rpAL\n\t WLGiXGrBZ6X60yVoUYMxcDSv7r2UdRJMBp69j74ROe1H5U2LKzKOLdGzrlQcwXe0DL\n\t c+A9m97tM5uv7aU3VCXXjAr06SfFnq444i9f2uco=", "Date": "Fri, 03 Apr 2026 18:08:38 +0200", "Subject": "[PATCH v2 5/8] thermal: khadas-mcu-fan: Add fan config from\n platform data Add regulator support", "Precedence": "bulk", "X-Mailing-List": "linux-i2c@vger.kernel.org", "List-Id": "<linux-i2c.vger.kernel.org>", "List-Subscribe": "<mailto:linux-i2c+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-i2c+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260403-add-mcu-fan-khadas-vim4-v2-5-70536b22439a@aliel.fr>", "References": "<20260403-add-mcu-fan-khadas-vim4-v2-0-70536b22439a@aliel.fr>", "In-Reply-To": "<20260403-add-mcu-fan-khadas-vim4-v2-0-70536b22439a@aliel.fr>", "To": "Neil Armstrong <neil.armstrong@linaro.org>, Lee Jones <lee@kernel.org>,\n Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,\n Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>,\n Martin Blumenstingl <martin.blumenstingl@googlemail.com>,\n Beniamino Galvani <b.galvani@gmail.com>,\n \"Rafael J. Wysocki\" <rafael@kernel.org>,\n Daniel Lezcano <daniel.lezcano@kernel.org>, Zhang Rui <rui.zhang@intel.com>,\n Lukasz Luba <lukasz.luba@arm.com>, Liam Girdwood <lgirdwood@gmail.com>,\n Mark Brown <broonie@kernel.org>", "Cc": "linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,\n Ronald Claveau <linux-kernel-dev@aliel.fr>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openssh-sha256; t=1775232552; l=3477;\n i=linux-kernel-dev@aliel.fr; s=id_ed25519; h=from:subject:message-id;\n bh=J2SoalosCyxImvGFu5R4J5FtFH7pMqPC3RBWKZVsADo=;\n b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgMGec55oxeeisqykQiUedekMYyOnR9\n BG9E/7rDWyqdNoAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA\n QEFj0nfFG83jnBBd60nayCy9VVofB4EIdNwOIGL1JZxdO4sU2taPxbmzNMnLl+Iy7VzNGFGRYEq\n v3kniuehwGQI=", "X-Developer-Key": "i=linux-kernel-dev@aliel.fr; a=openssh;\n fpr=SHA256:kch4osYZ6A1BrPps5AUs6KnfdE2wm4ocMtyTc8TmZMs" }, "content": "Replace the hardcoded MAX_LEVEL constant and fan register\nwith values read from platform_data (fan_reg, max_level),\nas new MCUs need different values.\n\nOptionally acquire and enable a \"fan\" regulator supply\nat probe time and on resume,\nso boards that gate fan power through a regulator are handled.\n\nSigned-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>\n---\n drivers/thermal/khadas_mcu_fan.c | 49 +++++++++++++++++++++++++++++++++++-----\n 1 file changed, 43 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c\nindex d35e5313bea41..24559bf65de46 100644\n--- a/drivers/thermal/khadas_mcu_fan.c\n+++ b/drivers/thermal/khadas_mcu_fan.c\n@@ -13,13 +13,15 @@\n #include <linux/regmap.h>\n #include <linux/sysfs.h>\n #include <linux/thermal.h>\n-\n-#define MAX_LEVEL 3\n+#include <linux/regulator/consumer.h>\n \n struct khadas_mcu_fan_ctx {\n \tstruct khadas_mcu *mcu;\n+\tunsigned int fan_reg;\n \tunsigned int level;\n+\tunsigned int max_level;\n \tstruct thermal_cooling_device *cdev;\n+\tstruct regulator *power;\n };\n \n static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n@@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n {\n \tint ret;\n \n-\tret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n-\t\t\t level);\n+\tret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level);\n \tif (ret)\n \t\treturn ret;\n \n@@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev,\n \t\t\t\t\tunsigned long *state)\n {\n-\t*state = MAX_LEVEL;\n+\tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n+\n+\t*state = ctx->max_level;\n \n \treturn 0;\n }\n@@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev,\n {\n \tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n \n-\tif (state > MAX_LEVEL)\n+\tif (state > ctx->max_level)\n \t\treturn -EINVAL;\n \n \tif (state == ctx->level)\n@@ -83,11 +86,32 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)\n \tstruct device *dev = &pdev->dev;\n \tstruct khadas_mcu_fan_ctx *ctx;\n \tint ret;\n+\tconst struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev);\n \n \tctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);\n \tif (!ctx)\n \t\treturn -ENOMEM;\n+\n \tctx->mcu = mcu;\n+\tctx->fan_reg = pdata->fan_reg;\n+\tctx->max_level = pdata->max_level;\n+\n+\tctx->power = devm_regulator_get_optional(dev->parent, \"fan\");\n+\tif (IS_ERR(ctx->power)) {\n+\t\tif (PTR_ERR(ctx->power) == -ENODEV)\n+\t\t\tctx->power = NULL;\n+\t\telse\n+\t\t\treturn PTR_ERR(ctx->power);\n+\t}\n+\n+\tif (ctx->power) {\n+\t\tret = regulator_enable(ctx->power);\n+\t\tif (ret) {\n+\t\t\tdev_err(dev, \"Failed to enable fan power supply: %d\\n\", ret);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n \tplatform_set_drvdata(pdev, ctx);\n \n \tcdev = devm_thermal_of_cooling_device_register(dev->parent,\n@@ -124,12 +148,25 @@ static int khadas_mcu_fan_suspend(struct device *dev)\n \n \tctx->level = level_save;\n \n+\tif (ctx->power) {\n+\t\tret = regulator_disable(ctx->power);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n \treturn 0;\n }\n \n static int khadas_mcu_fan_resume(struct device *dev)\n {\n \tstruct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev);\n+\tint ret;\n+\n+\tif (ctx->power) {\n+\t\tret = regulator_enable(ctx->power);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n \n \treturn khadas_mcu_fan_set_level(ctx, ctx->level);\n }\n", "prefixes": [ "v2", "5/8" ] }