Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219656/?format=api
{ "id": 2219656, "url": "http://patchwork.ozlabs.org/api/patches/2219656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403-winbond-v6-18-rc1-spi-nor-swp-v4-25-833dab5e7288@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403-winbond-v6-18-rc1-spi-nor-swp-v4-25-833dab5e7288@bootlin.com>", "list_archive_url": null, "date": "2026-04-03T16:09:43", "name": "[v4,25/27] mtd: spi-nor: winbond: Add W25H01NWxxIQ CMP locking support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70ebfa544f6b747dc20a055fb05e22de0223405b", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403-winbond-v6-18-rc1-spi-nor-swp-v4-25-833dab5e7288@bootlin.com/mbox/", "series": [ { "id": 498652, "url": "http://patchwork.ozlabs.org/api/series/498652/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=498652", "date": "2026-04-03T16:09:18", "name": "mtd: spi-nor: Enhance software protection", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498652/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219656/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=h5qhAmOk;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=TJsY1hAL;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnP4d4mTDz1yCt\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 03:17:05 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8hCd-00000002J9W-2ips;\n\tFri, 03 Apr 2026 16:16:59 +0000", "from smtpout-03.galae.net ([185.246.85.4])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8hCb-00000002J8q-0vON\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 03 Apr 2026 16:16:58 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 27B934E428D5;\n\tFri, 3 Apr 2026 16:10:37 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id EC8FF603C1;\n\tFri, 3 Apr 2026 16:10:36 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 421B01045010E;\n\tFri, 3 Apr 2026 18:10:34 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=a2ni/MMFNezY1qKtvmYrRsDXrfvWeA0YFKH1o6PFV7o=; b=h5qhAmOkCJrsxy\n\t/SvUzywjXt4hoQU/FGI7o+PrKly/Pi9zhqj35cvkIx8wvd682Waz/BV1r+R5TZX7rMpAKC/jtIlY3\n\tCtQGAOs4vG5bNU4JzUaJXtRp06xc+HHgaIcxsU3GPaZUWXrNTKWeSXVJBwiEq3jbBxSo0spZkF19u\n\t8hNB6DDz7Tc4qlOzoOuX5ehqGHnldKno/kQAn9SR6vBeYCkD7DzN5AxK8q9VnwrOC90H7TU+TJr5N\n\tfZzWRFN4ltg2tyCMGgffUBv7lMlEGEJux28h6T4BKr0l81KAqJfxYs4YHffEoJKfQGrF/XOxorvwT\n\trCI/6hKFZWv8yUdsgPAA==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1775232636; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=9HHkcU7E3iEbQwyhNOO8botbJmQi1btZtCu9+8skmvc=;\n\tb=TJsY1hAL7ofvIcIJ2LUkiEhNoAvzsbVG8CEQwEPdYi5nzHikDIFhIC3YIWsJI2teL7OXze\n\ty4trR8m570ofgB5OVWhj2FvqOqV9FAbE9TcQdCk5zaHBiHUQ20wCJZKkooU17gfHeHYjQW\n\tDtXxK0hAM2YwO0PM/aBi1w2FCF5kgaykBa9jilkipvekLYubiCWY4b2MIBWwekajOBG+KJ\n\tAyvnjUTAmSMSxRI8fV/SxEteQYu7mCT0yGrPaxAqT2Ezq9xGZ83qvVNau2Ko6yF6ED59Ry\n\tZ56AMSzcDSBnm/amoI2dz4+sNXOfa+U5lbP6ruIAiQyXpwPWYZBddjQqhJXylg==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Fri, 03 Apr 2026 18:09:43 +0200", "Subject": "[PATCH v4 25/27] mtd: spi-nor: winbond: Add W25H01NWxxIQ CMP\n locking support", "MIME-Version": "1.0", "Message-Id": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-25-833dab5e7288@bootlin.com>", "References": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-0-833dab5e7288@bootlin.com>", "In-Reply-To": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-0-833dab5e7288@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260403_091657_406521_D8D9DC52 ", "X-CRM114-Status": "GOOD ( 12.96 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: This chip has support for the locking complement (CMP)\n feature.\n Add the relevant bit to enable it. Unfortunately,\n this chip also comes with\n an incorrect BFPT table,\n indicating the Control Register cannot be read back.\n This is wrong, reading back the register works and has no (observed) side\n effect. [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in bl.score.senderscore.com]\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "This chip has support for the locking complement (CMP) feature. Add\nthe relevant bit to enable it.\n\nUnfortunately, this chip also comes with an incorrect BFPT table,\nindicating the Control Register cannot be read back. This is wrong,\nreading back the register works and has no (observed) side effect. The\ndatasheet clearly indicates supporting the 35h command and all bits from\nthe CR are marked readable. QE and CMP bits are inside, and can be\nproperly read back.\n\nAdd a fixup for this, otherwise it would defeat the use of the CMP\nfeature.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\nTest run with W25H01NWxxIQ:\n$ flash_lock -u /dev/mtd0\n$ flash_lock -l /dev/mtd0 $bs $all_but_one # all but the first\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0000ffff | unlocked | 1\n 00010000-07ffffff | locked | 2047\n$ flash_lock -u /dev/mtd0 $bs 1 # all but the two first\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0001ffff | unlocked | 2\n 00020000-07ffffff | locked | 2046\n$ flash_lock -u /dev/mtd0\n$ flash_lock -l /dev/mtd0 0 $all_but_one # same from the other side\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-07feffff | locked | 2047\n 07ff0000-07ffffff | unlocked | 1\n$ flash_lock -u /dev/mtd0 $(($size - (2 * $bs))) 1 # alll but two\n$ show_sectors\nlocked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-07fdffff | locked | 2046\n 07fe0000-07ffffff | unlocked | 2\n---\n drivers/mtd/spi-nor/winbond.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c\nindex 959fd4f46eb5..373c0af9daa2 100644\n--- a/drivers/mtd/spi-nor/winbond.c\n+++ b/drivers/mtd/spi-nor/winbond.c\n@@ -366,7 +366,9 @@ static const struct flash_info winbond_nor_parts[] = {\n \t}, {\n \t\t/* W25Q01NWxxIQ */\n \t\t.id = SNOR_ID(0xef, 0x60, 0x21),\n-\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_NOR_4BIT_BP,\n+\t\t.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 |\n+\t\t\t SPI_NOR_4BIT_BP | SPI_NOR_HAS_CMP,\n+\t\t.fixups = &winbond_rdcr_fixup,\n \t}, {\n \t\t/* W25Q01NWxxIM */\n \t\t.id = SNOR_ID(0xef, 0x80, 0x21),\n", "prefixes": [ "v4", "25/27" ] }