Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219647/?format=api
{ "id": 2219647, "url": "http://patchwork.ozlabs.org/api/patches/2219647/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403-winbond-v6-18-rc1-spi-nor-swp-v4-21-833dab5e7288@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403-winbond-v6-18-rc1-spi-nor-swp-v4-21-833dab5e7288@bootlin.com>", "list_archive_url": null, "date": "2026-04-03T16:09:39", "name": "[v4,21/27] mtd: spi-nor: Add steps for testing locking with CMP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5d3bb3bc31e8b68d4899589d8dc43c0fdc268782", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403-winbond-v6-18-rc1-spi-nor-swp-v4-21-833dab5e7288@bootlin.com/mbox/", "series": [ { "id": 498652, "url": "http://patchwork.ozlabs.org/api/series/498652/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=498652", "date": "2026-04-03T16:09:18", "name": "mtd: spi-nor: Enhance software protection", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498652/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219647/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MjJNQ6Vc;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=TRMXvvAl;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=0JRh3nd7;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnNxR2Glnz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 03:10:51 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8h6Z-00000002Hxh-0CQA;\n\tFri, 03 Apr 2026 16:10:43 +0000", "from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8h6U-00000002HpX-1YXE\n\tfor linux-mtd@bombadil.infradead.org;\n\tFri, 03 Apr 2026 16:10:38 +0000", "from smtpout-03.galae.net ([185.246.85.4])\n\tby desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8h6L-00000004OXg-1OUG\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 03 Apr 2026 16:10:36 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-03.galae.net (Postfix) with ESMTPS id 107BB4E428D7;\n\tFri, 3 Apr 2026 16:10:27 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id DAF21603C1;\n\tFri, 3 Apr 2026 16:10:26 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 4FA44104500F6;\n\tFri, 3 Apr 2026 18:10:24 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=QOIGUzjJ/5AsCkog9LxPjPl4NKIjOIotQPqnAXN3xvM=; b=MjJNQ6VckG7W/A\n\tkRBKJzMS+Uz9MKI+N+26ymTTCTcJBfsMpAgurleQscSMCt2scd0LPcP6suWlUakuxUzAPxTarBLm2\n\tT29zV8JQYEVywf14pGHzHROwwA0M+/CO0QMJ1uo4QX7cJDJY2qXi9dSILO9yGrNsYF/C7wvm9qIRk\n\t9BP+03bWmSUGz7i0agn7fCe0zOpkykvo8nEDZuQT27VlqavJYz3g7aDeMWTo/18OQClCf6FO76mOJ\n\tL9VdHmAkCt2QvsF5uOs/BlowKcJPGJyErbkAQU2P430kM4zH48417LcHTLVH37dFxYHKgwnrIxxwg\n\tdre+ihgVMTQ4vGBXXf3A==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References:\n\tMessage-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:\n\tFrom:Sender:Reply-To:Content-ID:Content-Description;\n\tbh=3IYxtkzdeu6bnBo9MR5hdgZZXX41AGqFyUgLNr5QV1k=; b=TRMXvvAl30Vw3DR8D/xAHRFta8\n\tPdS/3sTnFApIDrHXIFmN/P+Nj1mOvUTDZbQB0608K9wOFVsc8YnX+zL7lb7V25e13u2RCr6GFi78G\n\tNA5BA1Yx3kSmOHsu9kJkXnxEu9SBZPxPkvlF24UBavXopng4E5wEDWmCZewydQ+4uHhXH8fr8NylZ\n\tWDGuvKeDj7PhQsfYn3y28CXXC8G52toh23BGs9zeNVCZMCBhFB37KQP5gIlNpnwt8LdBhm2BKKSld\n\trABm0+m4Q8oQ1zmaiFGZPD0AOpPUBPQ/SJjnoHrQ3HUnh/W6yTMh+WyJvIBlZnByJOrivWH/uWr7c\n\tQsqgDVWg==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1775232626; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=3IYxtkzdeu6bnBo9MR5hdgZZXX41AGqFyUgLNr5QV1k=;\n\tb=0JRh3nd7uPxKBQjr0gpuMTv+uGoVpzl/OUHmv+NgwRBOaQgZ5jaETyEddbJfKTMamPPG8g\n\tkTEWoBYiMLLrxigSWWfHxTLD/V6IDDf0isVqztHjtkuDNIZ/cafXTLkevGhK+LVhkB9tQY\n\tkQd/dv88B34HM+du4N8Geh+3zS6OhEaoj7mibc1Kkq1r8aadPavB5LQ/nqiWjBJdai761H\n\t6bCwHr7gCJq7ROek8qettAe3OPt1zqzOPqVtzyrhQIH68yDeIzyHjFxayEYkwZiRrZ+pSJ\n\ttSLbsLFNjBp+lWz80aqj6pbOjsllVmF21R1LJL5nXer/SSE7TtulLj1Z19ChIA==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Fri, 03 Apr 2026 18:09:39 +0200", "Subject": "[PATCH v4 21/27] mtd: spi-nor: Add steps for testing locking with\n CMP", "MIME-Version": "1.0", "Message-Id": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-21-833dab5e7288@bootlin.com>", "References": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-0-833dab5e7288@bootlin.com>", "In-Reply-To": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-0-833dab5e7288@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260403_171031_236742_5D26BC53 ", "X-CRM114-Status": "GOOD ( 10.32 )", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Extend the test coverage by giving guidelines to verify the\n CMP bit acts according to our expectations. Signed-off-by: Miquel Raynal\n <miquel.raynal@bootlin.com> --- The instructions listed in this file target\n people adding support for new chips,\n however here are below extra steps that\n I also ran with th [...]\n Content analysis details: (-0.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.246.85.4 listed in bl.score.senderscore.com]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Extend the test coverage by giving guidelines to verify the CMP bit acts\naccording to our expectations.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\nThe instructions listed in this file target people adding support for\nnew chips, however here are below extra steps that I also ran with the\nsame W25H512NWxxAM chip. They are here to prove core correctness.\n\n $ flash_lock -u /dev/mtd0\n $ flash_lock -l /dev/mtd0 0 1008\n $ show_sectors\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03efffff | locked | 1008\n 03f00000-03ffffff | unlocked | 16\n $ flash_lock -l /dev/mtd0 0 1009\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03efffff | locked | 1008\n 03f00000-03ffffff | unlocked | 16\n $ flash_lock -l /dev/mtd0 0 1015\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03efffff | locked | 1008\n 03f00000-03ffffff | unlocked | 16\n $ flash_lock -l /dev/mtd0 0 1016\n $ show_sectors # should cover more\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03f7ffff | locked | 1016\n 03f80000-03ffffff | unlocked | 8\n $ flash_lock -u /dev/mtd0 $((1015 * $bs)) 1\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03f7ffff | locked | 1016\n 03f80000-03ffffff | unlocked | 8\n $ flash_lock -u /dev/mtd0 $((1009 * $bs)) 7\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03f7ffff | locked | 1016\n 03f80000-03ffffff | unlocked | 8\n $ flash_lock -u /dev/mtd0 $((1008 * $bs)) 8\n $ show_sectors # range should reduce down to initial value\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-03efffff | locked | 1008\n 03f00000-03ffffff | unlocked | 16\n\n [Similar situations, on the other side of the device]\n\n $ flash_lock -u /dev/mtd0\n $ flash_lock -l /dev/mtd0 $((16 * $bs)) 1008\n $ show_sectors\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-000fffff | unlocked | 16\n 00100000-03ffffff | locked | 1008\n $ flash_lock -l /dev/mtd0 $((15 * $bs)) 1009\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-000fffff | unlocked | 16\n 00100000-03ffffff | locked | 1008\n $ flash_lock -l /dev/mtd0 $((9 * $bs)) 1015\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-000fffff | unlocked | 16\n 00100000-03ffffff | locked | 1008\n $ flash_lock -l /dev/mtd0 $((8 * $bs)) 1016\n $ show_sectors # should cover more\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0007ffff | unlocked | 8\n 00080000-03ffffff | locked | 1016\n $ flash_lock -u /dev/mtd0 $((8 * $bs)) 1\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0007ffff | unlocked | 8\n 00080000-03ffffff | locked | 1016\n $ flash_lock -u /dev/mtd0 $((8 * $bs)) 7\n $ show_sectors # should not change\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-0007ffff | unlocked | 8\n 00080000-03ffffff | locked | 1016\n $ flash_lock -u /dev/mtd0 $((8 * $bs)) 8\n $ show_sectors # range should reduce down to initial value\n software locked sectors\n region (in hex) | status | #blocks\n ------------------+----------+--------\n 00000000-000fffff | unlocked | 16\n 00100000-03ffffff | locked | 1008\n---\n Documentation/driver-api/mtd/spi-nor.rst | 36 ++++++++++++++++++++++++++++++++\n 1 file changed, 36 insertions(+)", "diff": "diff --git a/Documentation/driver-api/mtd/spi-nor.rst b/Documentation/driver-api/mtd/spi-nor.rst\nindex 4755eb75fe5e..ec46bba8297a 100644\n--- a/Documentation/driver-api/mtd/spi-nor.rst\n+++ b/Documentation/driver-api/mtd/spi-nor.rst\n@@ -331,3 +331,39 @@ section, after the ``---`` marker.\n ------------------+----------+--------\n 00000000-0000ffff | locked | 1\n 00010000-03ffffff | unlocked | 1023\n+\n+ If the flash features a Complement (CMP) bit, we can protect with\n+ more granularity above half of the capacity. Let's lock all but one\n+ block, then unlock one more block::\n+\n+ root@1:~# all_but_one=$((($size / $bs) - 1))\n+ root@1:~# flash_lock -u /dev/mtd0\n+ root@1:~# flash_lock -l /dev/mtd0 $bs $all_but_one # all but the first\n+ root@1:~# show_sectors\n+ software locked sectors\n+ region (in hex) | status | #blocks\n+ ------------------+----------+--------\n+ 00000000-0000ffff | unlocked | 1\n+ 00010000-03ffffff | locked | 1023\n+ root@1:~# flash_lock -u /dev/mtd0 $bs 1 # all but the two first\n+ root@1:~# show_sectors\n+ software locked sectors\n+ region (in hex) | status | #blocks\n+ ------------------+----------+--------\n+ 00000000-0001ffff | unlocked | 2\n+ 00020000-03ffffff | locked | 1022\n+ root@1:~# flash_lock -u /dev/mtd0\n+ root@1:~# flash_lock -l /dev/mtd0 0 $all_but_one # same from the other side\n+ root@1:~# show_sectors\n+ software locked sectors\n+ region (in hex) | status | #blocks\n+ ------------------+----------+--------\n+ 00000000-03feffff | locked | 1023\n+ 03ff0000-03ffffff | unlocked | 1\n+ root@1:~# flash_lock -u /dev/mtd0 $(($size - (2 * $bs))) 1 # all but two\n+ root@1:~# show_sectors\n+ software locked sectors\n+ region (in hex) | status | #blocks\n+ ------------------+----------+--------\n+ 00000000-03fdffff | locked | 1022\n+ 03fe0000-03ffffff | unlocked | 2\n", "prefixes": [ "v4", "21/27" ] }