Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219636/?format=api
{ "id": 2219636, "url": "http://patchwork.ozlabs.org/api/patches/2219636/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403-winbond-v6-18-rc1-spi-nor-swp-v4-10-833dab5e7288@bootlin.com/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403-winbond-v6-18-rc1-spi-nor-swp-v4-10-833dab5e7288@bootlin.com>", "list_archive_url": null, "date": "2026-04-03T16:09:28", "name": "[v4,10/27] mtd: spi-nor: swp: Create a helper that writes SR, CR and checks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5a7e9f1b088cca0d12407148045471ae42f97e95", "submitter": { "id": 73368, "url": "http://patchwork.ozlabs.org/api/people/73368/?format=api", "name": "Miquel Raynal", "email": "miquel.raynal@bootlin.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20260403-winbond-v6-18-rc1-spi-nor-swp-v4-10-833dab5e7288@bootlin.com/mbox/", "series": [ { "id": 498652, "url": "http://patchwork.ozlabs.org/api/series/498652/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=498652", "date": "2026-04-03T16:09:18", "name": "mtd: spi-nor: Enhance software protection", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498652/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219636/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219636/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kacFYU6v;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=dqu5qaT4;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=xT/WFOe3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnNwl4SQFz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 03:10:15 +1100 (AEDT)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8h61-00000002HAU-1XnW;\n\tFri, 03 Apr 2026 16:10:09 +0000", "from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8h5y-00000002H4I-0Pvg\n\tfor linux-mtd@bombadil.infradead.org;\n\tFri, 03 Apr 2026 16:10:06 +0000", "from smtpout-04.galae.net ([185.171.202.116])\n\tby desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w8h5t-00000004OMx-2vO2\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 03 Apr 2026 16:10:04 +0000", "from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-04.galae.net (Postfix) with ESMTPS id 99ABAC59F66;\n\tFri, 3 Apr 2026 16:10:32 +0000 (UTC)", "from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 9D860603C1;\n\tFri, 3 Apr 2026 16:10:00 +0000 (UTC)", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 9157610450106;\n\tFri, 3 Apr 2026 18:09:57 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id\n\t:MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=AM3dbWxBPWoUOca+wSMMtaP4Upg39+5Nxfj+0kxmSdI=; b=kacFYU6v2ArlrW\n\tSyPQD1oidKL3Ofj53Y/3LklHbRE1IYqPdNBXPmNDMNI2GQl0lxS9opI5SgIzbicA2O/ddZU/v3Xc8\n\tPTbierSmGE29hDQ8CPSglyPq6WHiSyFkYkH4QZq98I2/tPoGcsJamRP0Hean1Wa0dz2Du73wnZ2wH\n\tkKJpRSd93SF/aInx4BdtWx9kUuSZwYbhq8e6SoJftQtPRGuPbUo7wkVfbfSC6tf1qB2mDuKrAwTe3\n\tInM54xZul0IYaLiStTQ2qzvpw7/Zuv1pe1D+Dxavs2D0jYVxncShzPL/mr2/YsQ9AreMdsjPuifxT\n\tTPdyJscwwALGHCVjugoA==;", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References:\n\tMessage-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:\n\tFrom:Sender:Reply-To:Content-ID:Content-Description;\n\tbh=/AjRw+s7RE2lXtZjyitxYQ9NqjIQGCFOfS5T/3HA2Ck=; b=dqu5qaT4jax7h9OkKaktSRQWRa\n\tVFojuSh9hih6X1InafgfCybANTPaBYFPu2Rs9wTJQSEVC28MtL/hWLVjfQvEjo6U/IPQg1EfroAnU\n\tKpMkiF1L9Ti9IkKF/49ZID/auxy8AoQ21sx2JsKGR1kSkDvSNWqFiPOcpVQwMcgsiBlP6WteM558k\n\ttVFEOyVsWwGszCE+BrrZNOu1xGfjV/XyQH0mU/u2kbnhw6aAx/dBsXLNJfW241RgRAvSM9AuGLv+D\n\tbvZ5ykZMPorFBBHyuP7dvVNIRWvt4Pae5Wv4XCfGttY52cUYWeNT+viBEKaomIT16GkHnsEiBlm2G\n\tab3xMGuQ==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1775232599; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=/AjRw+s7RE2lXtZjyitxYQ9NqjIQGCFOfS5T/3HA2Ck=;\n\tb=xT/WFOe3l8zZQDPt/91FNOSFmxTy9zE138aqQnyeziRT4BScLjL2og9sQQwT6tG7naD1Sc\n\tt5VUHMCfjdQmaqG6mcZhvOFO61A5t/TGghstbiIj+komOyd3PNnMvh3Puv1lBxDj/Z9k3q\n\tvciH/9UdrgbTMkkeVCnJ/beZNxX/DcFTA5h9AUFLZzLIIZ09bk53hJtkh3/1SYA2/NhNoa\n\twRO8hbVsOJewYHHHfdhbVXwjm+dEUoX0wx/m6GCpR0/n/AdNuR3up9F+En107CwlvUH+bb\n\tHDgStTNFsN9/yQfEy1uDyS9yDN0df+zXmPFcDBk9jxkl9gLG3Se6Af/9pxZ6FA==" ], "From": "Miquel Raynal <miquel.raynal@bootlin.com>", "Date": "Fri, 03 Apr 2026 18:09:28 +0200", "Subject": "[PATCH v4 10/27] mtd: spi-nor: swp: Create a helper that writes\n SR, CR and checks", "MIME-Version": "1.0", "Message-Id": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-10-833dab5e7288@bootlin.com>", "References": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-0-833dab5e7288@bootlin.com>", "In-Reply-To": "\n <20260403-winbond-v6-18-rc1-spi-nor-swp-v4-0-833dab5e7288@bootlin.com>", "To": "Pratyush Yadav <pratyush@kernel.org>, Michael Walle <mwalle@kernel.org>,\n Takahiro Kuwano <takahiro.kuwano@infineon.com>,\n Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>,\n Jonathan Corbet <corbet@lwn.net>", "Cc": "Sean Anderson <sean.anderson@linux.dev>,\n Thomas Petazzoni <thomas.petazzoni@bootlin.com>,\n Steam Lin <STLin2@winbond.com>, linux-mtd@lists.infradead.org,\n linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,\n Miquel Raynal <miquel.raynal@bootlin.com>", "X-Mailer": "b4 0.14.3", "X-Last-TLS-Session-Version": "TLSv1.3", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260403_171001_929437_A0A090EC ", "X-CRM114-Status": "GOOD ( 13.91 )", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: There are many helpers already to either read and/or write\n SR and/or CR, as well as sometimes check the returned values. In order to\n be able to switch from a 1 byte status register to a 2 bytes status [...] \n Content analysis details: (-0.2 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n bl.score.senderscore.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-trusted.bondedsender.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "There are many helpers already to either read and/or write SR and/or CR,\nas well as sometimes check the returned values. In order to be able to\nswitch from a 1 byte status register to a 2 bytes status register while\nkeeping the same level of verification, let's introduce a new helper\nthat writes them both (atomically) and then reads them back (separated)\nto compare the values.\n\nIn case 2 bytes registers are not supported, we still have the usual\nfallback available in the helper being exported to the rest of the core.\n\nSigned-off-by: Miquel Raynal <miquel.raynal@bootlin.com>\n---\n drivers/mtd/spi-nor/core.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++\n drivers/mtd/spi-nor/core.h | 1 +\n 2 files changed, 66 insertions(+)", "diff": "diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c\nindex 1eee519c01e5..f007bd6b389a 100644\n--- a/drivers/mtd/spi-nor/core.c\n+++ b/drivers/mtd/spi-nor/core.c\n@@ -976,6 +976,54 @@ int spi_nor_write_16bit_cr_and_check(struct spi_nor *nor, u8 cr)\n \treturn 0;\n }\n \n+/**\n+ * spi_nor_write_16bit_sr_cr_and_check() - Write the Status Register 1 and the\n+ * Configuration Register in one shot. Ensure that the bytes written in both\n+ * registers match the received value.\n+ * @nor:\tpointer to a 'struct spi_nor'.\n+ * @regs:\ttwo-byte array with values to be written to the status and\n+ *\t\tconfiguration registers.\n+ *\n+ * Return: 0 on success, -errno otherwise.\n+ */\n+static int spi_nor_write_16bit_sr_cr_and_check(struct spi_nor *nor, const u8 *regs)\n+{\n+\tu8 written_regs[2];\n+\tint ret;\n+\n+\twritten_regs[0] = regs[0];\n+\twritten_regs[1] = regs[1];\n+\tnor->bouncebuf[0] = regs[0];\n+\tnor->bouncebuf[1] = regs[1];\n+\n+\tret = spi_nor_write_sr(nor, nor->bouncebuf, 2);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = spi_nor_read_sr(nor, &nor->bouncebuf[0]);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (written_regs[0] != nor->bouncebuf[0]) {\n+\t\tdev_dbg(nor->dev, \"SR: Read back test failed\\n\");\n+\t\treturn -EIO;\n+\t}\n+\n+\tif (nor->flags & SNOR_F_NO_READ_CR)\n+\t\treturn 0;\n+\n+\tret = spi_nor_read_cr(nor, &nor->bouncebuf[1]);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (written_regs[1] != nor->bouncebuf[1]) {\n+\t\tdev_dbg(nor->dev, \"CR: read back test failed\\n\");\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * spi_nor_write_sr_and_check() - Write the Status Register 1 and ensure that\n * the byte written match the received value without affecting other bits in the\n@@ -993,6 +1041,23 @@ int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 sr1)\n \treturn spi_nor_write_sr1_and_check(nor, sr1);\n }\n \n+/**\n+ * spi_nor_write_sr_cr_and_check() - Write the Status Register 1 and ensure that\n+ * the byte written match the received value. Same for the Control Register if\n+ * available.\n+ * @nor:\tpointer to a 'struct spi_nor'.\n+ * @regs:\tbyte array to be written to the registers.\n+ *\n+ * Return: 0 on success, -errno otherwise.\n+ */\n+int spi_nor_write_sr_cr_and_check(struct spi_nor *nor, const u8 *regs)\n+{\n+\tif (nor->flags & SNOR_F_HAS_16BIT_SR)\n+\t\treturn spi_nor_write_16bit_sr_cr_and_check(nor, regs);\n+\n+\treturn spi_nor_write_sr1_and_check(nor, regs[0]);\n+}\n+\n /**\n * spi_nor_write_sr2() - Write the Status Register 2 using the\n * SPINOR_OP_WRSR2 (3eh) command.\ndiff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h\nindex 16b382d4f04f..3dc9ba3bc6da 100644\n--- a/drivers/mtd/spi-nor/core.h\n+++ b/drivers/mtd/spi-nor/core.h\n@@ -632,6 +632,7 @@ int spi_nor_read_cr(struct spi_nor *nor, u8 *cr);\n int spi_nor_write_sr(struct spi_nor *nor, const u8 *sr, size_t len);\n int spi_nor_write_sr_and_check(struct spi_nor *nor, u8 sr1);\n int spi_nor_write_16bit_cr_and_check(struct spi_nor *nor, u8 cr);\n+int spi_nor_write_sr_cr_and_check(struct spi_nor *nor, const u8 *regs);\n \n ssize_t spi_nor_read_data(struct spi_nor *nor, loff_t from, size_t len,\n \t\t\t u8 *buf);\n", "prefixes": [ "v4", "10/27" ] }