Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219576/?format=api
{ "id": 2219576, "url": "http://patchwork.ozlabs.org/api/patches/2219576/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260403135205.26979-2-ansuelsmth@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403135205.26979-2-ansuelsmth@gmail.com>", "list_archive_url": null, "date": "2026-04-03T13:51:58", "name": "[v5,1/6] misc: fs_loader: fix ubifs not unmounted on dev_get_priv error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c99bec27a90482e924d42db81ef097a24e0a1ef0", "submitter": { "id": 71108, "url": "http://patchwork.ozlabs.org/api/people/71108/?format=api", "name": "Christian Marangi", "email": "ansuelsmth@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260403135205.26979-2-ansuelsmth@gmail.com/mbox/", "series": [ { "id": 498633, "url": "http://patchwork.ozlabs.org/api/series/498633/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498633", "date": "2026-04-03T13:51:57", "name": "misc: fs_loader: reorg and split to FS and FW loader + FIP loader", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/498633/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219576/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219576/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gMBMS2Ml;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"gMBMS2Ml\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=ansuelsmth@gmail.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnKsm4f5dz1yCs\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 04 Apr 2026 00:52:28 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 981F5840AB;\n\tFri, 3 Apr 2026 15:52:21 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 00A33840AB; Fri, 3 Apr 2026 15:52:20 +0200 (CEST)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n [IPv6:2a00:1450:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C8C0983642\n for <u-boot@lists.denx.de>; Fri, 3 Apr 2026 15:52:17 +0200 (CEST)", "by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-48557c8ad47so15561055e9.0\n for <u-boot@lists.denx.de>; Fri, 03 Apr 2026 06:52:17 -0700 (PDT)", "from Ansuel-XPS24 ([217.202.87.54])\n by smtp.googlemail.com with ESMTPSA id\n 5b1f17b1804b1-4888a7162cesm196732895e9.13.2026.04.03.06.52.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Apr 2026 06:52:16 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775224337; x=1775829137; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=ncf5CGqxvO5twq8XmgDTVmMycW8ixnJNHA/TGHwyw7Q=;\n b=gMBMS2Mlo9IJhi25spn93pYfO2HsrRjQYK8KHa9XFe46fShqAk/rrr5p3ggJKJssG4\n At5DAPEblx6xX3my34oZpK64P/5gLyJwgvyIh1hTncjROhqEWDbwgJdQED2EyezIDuKh\n ItG/WXAHmHWbQbtkz2ycreNV/QWFMghu6S09Ydyy8pmlBZDs8Wd1iQSAfQO+I2QlHxsI\n v8LenTaUASqGQvtzVQoB//6gAKyAal5ILUmJmd2cOggskXWrkynFczWhvIoDh+aZuZIK\n nQZjZ5HZEmManZgxJrK+ho/2jevwgbU9pmKbfE4Lmy+ZofjOUQ/Bs2pHR9R1DcFiiyJz\n qJpg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775224337; x=1775829137;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=ncf5CGqxvO5twq8XmgDTVmMycW8ixnJNHA/TGHwyw7Q=;\n b=TCM83qDfLKjFv8naszU83dChfzv6dZTX63QnGECT4sb8fcN+GW4foXmUpA39Wj9Z6I\n GP1jL6oo/KvL26GZjZXdNRAnu0EOAzDtiSw5VsvTKKFNJneYM7lDmIW+GmlO+eFsz7kb\n gmVgSmTkRMk2h5nU1X2dUw5Ug7QCfJgY2YTZVmYaC8MbxDb7snGEZklhD2w4FSActY6j\n Vx1SDYcQj1ciqqwofQgIBqHfTAKSZruH5MhnM+Pyaq3IE+3usQUbUPnWe321vqenHLM2\n 5rvnYT7G9Hc47XF0i/zPlxDvQylyy7ph8fuo65X0jD0qqWUfOji/BULNCkSXK3bLPLf2\n Cj3Q==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVx0ClPgxlZLKsuVHNt6B5TKo5eVRVmVbXKNj9LJMDNRhMGLQjA+nZuJxmCFgVxPzP+UcC+nRg=@lists.denx.de", "X-Gm-Message-State": "AOJu0YyA+pYsR3XJbscxYVEDU9Aj3sFJaYsngmTXwmCkN1YuBsai5wXU\n 9aXvRrpRshUf9hs0b1gc1+EXwtvWD1/94HxsKCEDMkWsykDzwGc0O0WX", "X-Gm-Gg": "ATEYQzz1inixKVqaob9nLE/n+Be7Q/phSZofWFejplZ9LXqUsZ2TJToTl4GXqbrB0SW\n /wM1Bl+MxNTDQS49qOPPul5Pf/FOG0lE0qv4CDBTAY0wXMatzjyaeiN+E+Fmox0nspUgcBgjJpe\n VfT0H8C93u7GZtjtgsIkl6fV5hFk7tlX64im00/D18xcWMCP/nKTALtMmaKJfsD1WI4Du+e/Jbh\n M3GR1W3jBTt3mIL2mjqLTLuEAG5MZuz561S58vau/begj2kprlBMcDUvnNPP4UGiSmgY3duoJZE\n 5VuO3LkoUh26qebICA9j9ipdHQcoSmXEyCRyg1fiCesgzahyrfDe/UJIQP2IYxz1zZGN947/bza\n gkUC0lVABXX3Mekg4DGbvy33u+9G06vx2BXDJDcfnXfzZWUS8HApd7T4iJkSU8hNoJh99kNsRh9\n rKDSN+TieM/IW/owlv54XNyeg=", "X-Received": "by 2002:a05:600c:1381:b0:487:1108:48af with SMTP id\n 5b1f17b1804b1-488996a351bmr47496555e9.4.1775224337114;\n Fri, 03 Apr 2026 06:52:17 -0700 (PDT)", "From": "Christian Marangi <ansuelsmth@gmail.com>", "To": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Christian Marangi <ansuelsmth@gmail.com>,\n Casey Connolly <casey.connolly@linaro.org>,\n Quentin Schulz <quentin.schulz@cherry.de>, Peng Fan <peng.fan@nxp.com>,\n Justin Klaassen <justin@tidylabs.net>,\n Neha Malcom Francis <n-francis@ti.com>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Jamie Gibbons <jamie.gibbons@microchip.com>,\n Leo Yu-Chi Liang <ycliang@andestech.com>, Harsha Vardhan V M <h-vm@ti.com>,\n Weijie Gao <weijie.gao@mediatek.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Patrice Chotard <patrice.chotard@foss.st.com>, Yao Zi <me@ziyao.cc>,\n Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,\n \"Lucien.Jheng\" <lucienzx159@gmail.com>, u-boot@lists.denx.de", "Subject": "[PATCH v5 1/6] misc: fs_loader: fix ubifs not unmounted on\n dev_get_priv error", "Date": "Fri, 3 Apr 2026 15:51:58 +0200", "Message-ID": "<20260403135205.26979-2-ansuelsmth@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260403135205.26979-1-ansuelsmth@gmail.com>", "References": "<20260403135205.26979-1-ansuelsmth@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "When dev_get_priv errors out, the ubifs is not umounted (if used).\n\nCorrectly handle this handle condition and while at it also return -EINVAL\ninstead of -ENOMEM as a better error since no memory is allocated but is\nactually an invalid scenario for fw_get_filesystem_firmware().\n\nSigned-off-by: Christian Marangi <ansuelsmth@gmail.com>\nReviewed-by: Simon Glass <sjg@chromium.org>\nReviewed-by: Neha Malcom Francis <n-francis@ti.com>\n---\n drivers/misc/fs_loader.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c\nindex 6af4c7f15e7b..cd4695b08eea 100644\n--- a/drivers/misc/fs_loader.c\n+++ b/drivers/misc/fs_loader.c\n@@ -175,8 +175,10 @@ static int fw_get_filesystem_firmware(struct udevice *dev)\n \n \tstruct firmware *firmwarep = dev_get_priv(dev);\n \n-\tif (!firmwarep)\n-\t\treturn -ENOMEM;\n+\tif (!firmwarep) {\n+\t\tret = -EINVAL;\n+\t\tgoto out;\n+\t}\n \n \tret = fs_read(firmwarep->name, (ulong)map_to_sysmem(firmwarep->data),\n \t\t\tfirmwarep->offset, firmwarep->size, &actread);\n", "prefixes": [ "v5", "1/6" ] }