Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219510/?format=api
{ "id": 2219510, "url": "http://patchwork.ozlabs.org/api/patches/2219510/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260403075528.1150196-2-paul.henrys_ext@softathome.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403075528.1150196-2-paul.henrys_ext@softathome.com>", "list_archive_url": null, "date": "2026-04-03T07:55:27", "name": "[v4,2/3] binman: Generate preload header and sign data only once", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0fddace1f7bc395e5ff1c538706e31fe793c0135", "submitter": { "id": 83555, "url": "http://patchwork.ozlabs.org/api/people/83555/?format=api", "name": "Paul HENRYS", "email": "paul.henrys_ext@softathome.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260403075528.1150196-2-paul.henrys_ext@softathome.com/mbox/", "series": [ { "id": 498598, "url": "http://patchwork.ozlabs.org/api/series/498598/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498598", "date": "2026-04-03T07:55:27", "name": "[v4,1/3] tools: binman: Test signing an encrypted FIT with a preload header", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/498598/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219510/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=ga7kjDXg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"ga7kjDXg\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=paul.henrys_ext@softathome.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn9yG0c8Dz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 18:55:49 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4990183DC9;\n\tFri, 3 Apr 2026 09:55:47 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 6F13583CF5; Fri, 3 Apr 2026 09:55:45 +0200 (CEST)", "from PA5P264CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170100000.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 812A58407E\n for <u-boot+nodisclaimer@lists.denx.de>;\n Fri, 3 Apr 2026 09:55:43 +0200 (CEST)", "from PA7P264CA0194.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:376::12)\n by MR0P264MB5289.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:4e::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Fri, 3 Apr\n 2026 07:55:39 +0000", "from PA2PEPF00019231.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:376:cafe::fd) by PA7P264CA0194.outlook.office365.com\n (2603:10a6:102:376::12) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.21 via Frontend Transport; Fri,\n 3 Apr 2026 07:55:39 +0000", "from proxy.softathome.com (149.6.166.170) by\n PA2PEPF00019231.mail.protection.outlook.com (10.167.242.37) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.17\n via Frontend Transport; Fri, 3 Apr 2026 07:55:39 +0000", "from sah2lpt245.. (unknown [192.168.72.220])\n by proxy.softathome.com (Postfix) with ESMTPSA id E165220934;\n Fri, 3 Apr 2026 09:55:38 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,\n SUSPICIOUS_RECIPS autolearn=no autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Am+zLpv7NeRT/rM4qyZDBkvt3O0pVs9r46WE9ngdA2g5P4xT4adzvdT81oxe/qHr7xFMXIiHBqc2sk4Z1RKSCIm86v24bDtsQB3L0s773uqsokiVIBozKcgaGAKQ3daocRQLzVWX9eBRcUALOgvXdsxouJTL+K1Up5pYBqf0MvwqxGOEwx2nf/VUGPED1hj1uUkUkOPqof+SeYdnisvJJHsLfhu9Vu3HS8S3BEtSD2j7Si6skNtmImMfc6Fg/Km9hG31BX5gwEL6uhA59wvVC9uo2d6qbeBxlrq+qXg97YHzLzsA2/MJlmu+uDdQeYJvoZiueNHjWzgFrBsnR6lHVQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Gm2e7s+7T0r/ZWT69ioPQlR+Nwq3/U8b/LtU4t+3lQ0=;\n b=TN/vofDXhKInju+y2F3cgIRuyaMBj+KZX8pUJlZQPyOE8rrav+XwbefYDc0KhsCXq4k2URKmWKSdpYLbLa4GvnB8aZ8y8mrGKTS5VCsFLPMqn/Z0+wbmQLxwKF3ZggfJQ6sNfrpGxg/S3zbq8wvPacjg9IIzPWznkXCE0QNEUaJ1mQA8G/XsspPM2jeSnp63E/d+NNjMRGvbTShoHJZGDe1JM9yQzZOooTod5Prq/35wb1AjqzFJQ5R0MVGt04R54gBe3U6xaJ+CEPv5jLoymboEHgx30lHv5fsdyGIXi4jHfHYeN9wST4IuuYYKap1B4X2C2onChxPrrT89jUHaGg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=chromium.org smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Gm2e7s+7T0r/ZWT69ioPQlR+Nwq3/U8b/LtU4t+3lQ0=;\n b=ga7kjDXgw/iCK3ozlUF4h+OgzjiU9E8Gw/PBspEWCZpcrwHhg2Pk8oaZdB96aolzvnuOHKT4yBCZLiXIArPQYXSCYFdt9LOQfrg+CmP+7A+LzBlpJoq+JltfLuAjTxTIO5p9gPC0PXvnKjDTjtfwTINd81Sy5KGnZjSSN/43e59M3yqNPQxGtPfbYVsz6mt7yiFshSa32GIHBl9PoM6LLQq6c3Iw03J6o4J+GbDD7NkAjIGYyeNJqDROBT387w9FAeku1JvutHYAJ6I80628JQnXrg4x66KsX32W7iWh/bTUiwgYIq5biBxh5SMnl158edwfTCR4QXUIXsAj6q4efg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;", "Received-SPF": "Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C", "From": "Paul HENRYS <paul.henrys_ext@softathome.com>", "To": "u-boot+nodisclaimer@lists.denx.de", "Cc": "sjg+nodisclaimer@chromium.org, trini+nodisclaimer@konsulko.com,\n alpernebiyasak+nodisclaimer@gmail.com,\n philippe.reynes+nodisclaimer@softathome.com,\n Paul HENRYS <paul.henrys_ext@softathome.com>", "Subject": "[PATCH v4 2/3] binman: Generate preload header and sign data only\n once", "Date": "Fri, 3 Apr 2026 09:55:27 +0200", "Message-ID": "<20260403075528.1150196-2-paul.henrys_ext@softathome.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260403075528.1150196-1-paul.henrys_ext@softathome.com>", "References": "<20260403073251.1051533-1-paul.henrys_ext@softathome.com>\n <20260403075528.1150196-1-paul.henrys_ext@softathome.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PA2PEPF00019231:EE_|MR0P264MB5289:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "4b8a074b-5253-4e17-dfc6-08de915665be", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|1800799024|376014|82310400026|36860700016|22082099003|18002099003|56012099003;", "X-Microsoft-Antispam-Message-Info": "\n Se3odE8z+Bul1cfwgeNvneQ3x1J+M0n1O6J3w31bxTIIG3AmDB2Vc1MHt02v+IteVPdav62kZuBlH/erGVpl73Mmlvo5byi84IvS7tNunwgQHGe4mXC2JXAnAh+mnUNzhlAtaXzIQYDGGaFW8p1UMqSH9CVE422N+gNt0GLUP4HN0turvBglrF/9/vWWz88tfXRftvMS8SPlzlhgxK8IUdwExmU3pKhmSExYAa9DWSopKGCRgX9XPdyF9XW1plSlfsh8cewMQ2hGOmEwZDZ3vhqSwZCY4xgpba+qN10e9B29Ecr1i82ob3sTIWwWz3gM+R8kgmnPn6WDoXKqKTjlU1w52FqLqW0PwRupswY+aBNTxi5Xg+vGHTcGMqPXexJW3XSEwwlIIjqnR4GGqvk+k6YdRE2lsKzQfJ1+CTvcfh6LqRS0M9D36iXOmv1Mzs0oxYJyJquDGWkRJphfZwSRSa5eU9FuAry6Neyt7uBdZWxxs9GJpPTW58Q/Ac861VFfHEO2BPTWVnVrcUv3bajdrY6NByp5omOtttKC1ST+PUccNtCaVVXcYC5CsgyOXTk4SL/Oy2Su6DYfDXFYBZDRtdZW4M9d/ACa2SizBxMmErjrpiTBQDE//RmjeIa9pvq3deQboW/v0xYXyMS4Kj35tttxYKN0Op+tIlC2S16LlrP/6H7AB0Y+wfnbboQBp8AS3MBiRlx88KDjKhF8qJU6OZbX2jLFxwtm0DwzmYqP0SO7mY5Rx6SVJMbrDvwXqcgSAtXPUrhmlOdRuM/Xi1Bh9g==", "X-Forefront-Antispam-Report": "CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(82310400026)(36860700016)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 1h6c2Y7S1kbzb5+hDaafgg0M6xM7UGRl3OUWzLT2Tjw7DYSOwqFE7o3vazv3ziH/+hct7AsTVCaObTKtuIwxO1D+ayxAMruaF3UFYWdT5sz9pj+UbCayZod97DomAHeEAWu8MJfDLV7IYAY5ae4XepKC4b8rYMILyX+cJpF76o8Y3uuAgNodt/BS1u9+qkwlf2l/kaJ25Gq1wQlFTMr/BRecvyxhljRZ/FpCAt5McAWUIbOmIsbxmQSkZM57Ii6pw+TdLs5RFcTqvtHnztdo6KlgNrQ3RTA0SuPTyKct9FSk210ZKUjqGU1vUqKqmT4nNBNyrYWEeu9aKwtm71O4gTG3nreZcs7h4S92I0SsrbgLd8vwP9SMKz0QM/DyIsATDN1e8K7mJbKVjUvCY2MUFv48diunefFnJZB2uNCrfW37N/OiZfbsbDgMjycl32XD", "X-OriginatorOrg": "softathome.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Apr 2026 07:55:39.2941 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4b8a074b-5253-4e17-dfc6-08de915665be", "X-MS-Exchange-CrossTenant-Id": "aa10e044-e405-4c10-8353-36b4d0cce511", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]", "X-MS-Exchange-CrossTenant-AuthSource": "PA2PEPF00019231.FRAP264.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MR0P264MB5289", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "To optimize preload generation, generate the header and signatures only\nafter all data has been collected. This avoids signing the data multiple\ntimes.\n\nSince header_size is known upfront (from __init__), set the preload\nheader size in `ObtainContents()` to avoid an extra packing pass when\nProcessContentsUpdate() detects the size changed from 0 to header_size.\n\nThis reduces unnecessary repacking and signing operations.\n\nSigned-off-by: Paul HENRYS <paul.henrys_ext@softathome.com>\n---\nChanges for v4:\n- No change\n\n tools/binman/etype/pre_load.py | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/tools/binman/etype/pre_load.py b/tools/binman/etype/pre_load.py\nindex 00f1a896767..34a7bc1b985 100644\n--- a/tools/binman/etype/pre_load.py\n+++ b/tools/binman/etype/pre_load.py\n@@ -152,14 +152,14 @@ class Entry_pre_load(Entry_collection):\n return data + pad\n \n def ObtainContents(self):\n- \"\"\"Obtain a placeholder for the header contents\"\"\"\n- # wait that the image is available\n- self.image = self.GetContents(False)\n- if self.image is None:\n- return False\n- self.SetContents(self._CreateHeader())\n+ \"\"\"Only set the known size of the preload header. The data will be\n+ generated later on in ProcessContents() when the data from every entries\n+ can be retrieved.\n+ \"\"\"\n+ self.contents_size = self.header_size\n return True\n \n def ProcessContents(self):\n+ self.image = self.GetContents(True)\n data = self._CreateHeader()\n return self.ProcessContentsUpdate(data)\n", "prefixes": [ "v4", "2/3" ] }