Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219496/?format=api
{ "id": 2219496, "url": "http://patchwork.ozlabs.org/api/patches/2219496/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260403054029.3789616-7-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260403054029.3789616-7-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-04-03T05:40:24", "name": "[iwl-net,6/10] ice: check PHY autoneg capability before rejecting ethtool autoneg setting", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7cb9d6f528c00552b1d03852205767c46ab5c244", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260403054029.3789616-7-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 498590, "url": "http://patchwork.ozlabs.org/api/series/498590/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=498590", "date": "2026-04-03T05:40:19", "name": "ice: bug fixes -- no link, tc-flower, VF rate", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498590/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219496/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=oa/CkmCi;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn6yg3FqVz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 16:40:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D41CB40F90;\n\tFri, 3 Apr 2026 05:40:42 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Dtq-n-tvoenV; Fri, 3 Apr 2026 05:40:42 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 3E81040F33;\n\tFri, 3 Apr 2026 05:40:42 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 1CE102CC\n for <intel-wired-lan@lists.osuosl.org>; Fri, 3 Apr 2026 05:40:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 02ACD4008E\n for <intel-wired-lan@lists.osuosl.org>; Fri, 3 Apr 2026 05:40:41 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Le1sfjgdmwix for <intel-wired-lan@lists.osuosl.org>;\n Fri, 3 Apr 2026 05:40:40 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.20])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 00E8940071\n for <intel-wired-lan@lists.osuosl.org>; Fri, 3 Apr 2026 05:40:39 +0000 (UTC)", "from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Apr 2026 22:40:40 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa007.fm.intel.com with ESMTP; 02 Apr 2026 22:40:38 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3E81040F33", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 00E8940071" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775194842;\n\tbh=DpemvsT70sAaGYlYNkZG+Jcy/8NyoMr2kgA29TuiAz4=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=oa/CkmCiYjxS/tfAFrlSXm69xheZyDjY/g4t3GwpZwLThGuy9yUtlW5mlhdWA/jyG\n\t vz7prtJI4FeXH/5ae2fur2BLkFTIQ2I54swrfMPl7i0qM74FqrD6a37bxOXmCzTTqi\n\t 1WvPHdbXtTJcwyJQG9WU3EIJSFSLJrK5wQDfVQvX7QzUU4OPucR9J5aAUtbRsIsdS+\n\t WBglh4w0OY2H36N19xBUQUFnT15G36Xfy+8/wF84WG+K0N6E6l6ZNihGZzmOnJTBtY\n\t buF3gu1Irh/8X43xA1s+zSOE7sQqiRuAxuNkvc1G+ljQkb1yfQcSHlQBnaIBUNdDpV\n\t Ka4dm+VWi8kaA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.20;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 00E8940071", "X-CSE-ConnectionGUID": [ "h3ZeczMxSn2eKYLI5X+e1w==", "2HBAAWu1T9GmzwNZScerbQ==" ], "X-CSE-MsgGUID": [ "UqoT2SCTR5CJU/EHGGXu5g==", "e+GfxgQrTcmdfKlqDKVJug==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11747\"; a=\"75981749\"", "E=Sophos;i=\"6.23,157,1770624000\"; d=\"scan'208\";a=\"75981749\"", "E=Sophos;i=\"6.23,157,1770624000\"; d=\"scan'208\";a=\"223904939\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org,\n\tJan Glaza <jan.glaza@intel.com>", "Date": "Fri, 3 Apr 2026 07:40:24 +0200", "Message-ID": "<20260403054029.3789616-7-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260403054029.3789616-1-aleksandr.loktionov@intel.com>", "References": "<20260403054029.3789616-1-aleksandr.loktionov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775194840; x=1806730840;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=jK3wjtpXszUhk9dYiDSEL6WygtA0YLoAGsaq2N23/UE=;\n b=V/kKrThwPaavvtanlMOPFGyiSdKjSZcrZP32slYXN+/AqrZ5ARwv1Jbg\n XtPkzUtG4qO54Tesyioh7Y04KNXGSN/zXDHBM6+Ud46H8VjtWTnyF/Sy7\n f0MwHaE6zsMcOar4ixRpmj5G1DptQl9MK3QxlKf/5ls+TxIfOGZO1w40l\n LSnhiz/GLNJuqAdDqX+UY4Lq5KKRzgY1nHYMXLg5bhUgbo+NboZSTfHgA\n vQ0NxCTwUlyHNBBC7AZUslOaxon+lw2dOSdeiX5msaaDGiij1YvHJW7Bj\n j+lcJBA9LEw9hOUQ8Vcv5E7VMIz1HaBx+8aWuYolOSN02sGsvLgF/GExd\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=V/kKrThw" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 6/10] ice: check PHY autoneg\n capability before rejecting ethtool autoneg setting", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ice_set_link_ksettings() rejects autoneg requests by comparing\nuser settings against safe_ks which is populated by\nice_phy_type_to_ethtool(). The Autoneg bit in safe_ks is set\nonly if the current PHY configuration reports it supported,\nbut this misses PHYs that support autoneg and have it available\nthrough PHY capabilities. Pull the autoneg flag from the actual\nPHY capabilities (already fetched earlier in the function) to\nensure the user can toggle autoneg on any capable PHY.\n\nFixes: 5cd349c349d6 (\"ice: report supported and advertised autoneg using PHY capabilities\")\nCc: stable@vger.kernel.org\nSigned-off-by: Jan Glaza <jan.glaza@intel.com>\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 49b9376..44483bc 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -2654,6 +2654,14 @@ ice_set_link_ksettings(struct net_device *netdev,\n \t/* Get link modes supported by hardware.*/\n \tice_phy_type_to_ethtool(netdev, &safe_ks);\n \n+\t/* Pull the value of autoneg from phy caps to ensure we allow\n+\t * toggling it on all PHYs that support it.\n+\t */\n+\tif (ice_is_phy_caps_an_enabled(phy_caps)) {\n+\t\tethtool_link_ksettings_add_link_mode(&safe_ks, supported, Autoneg);\n+\t\tset_bit(ETHTOOL_LINK_MODE_FEC_NONE_BIT, safe_ks.link_modes.supported);\n+\t}\n+\n \t/* and check against modes requested by user.\n \t * Return an error if unsupported mode was set.\n \t */\n", "prefixes": [ "iwl-net", "6/10" ] }