Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219298/?format=api
{ "id": 2219298, "url": "http://patchwork.ozlabs.org/api/patches/2219298/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260402192431.2421155-1-yan.wang@softathome.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260402192431.2421155-1-yan.wang@softathome.com>", "list_archive_url": null, "date": "2026-04-02T19:24:29", "name": "[v2,1/3] tools: binman: Test signing an encrypted FIT with a preload header", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "62cf6149f959a007746b96cad9012cb2f6a912f2", "submitter": { "id": 90652, "url": "http://patchwork.ozlabs.org/api/people/90652/?format=api", "name": "yan wang", "email": "yan.wang@softathome.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260402192431.2421155-1-yan.wang@softathome.com/mbox/", "series": [ { "id": 498545, "url": "http://patchwork.ozlabs.org/api/series/498545/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498545", "date": "2026-04-02T19:24:29", "name": "[v2,1/3] tools: binman: Test signing an encrypted FIT with a preload header", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498545/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219298/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219298/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=n4cR9iP7;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"n4cR9iP7\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=yan.wang@softathome.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmsHm0kBbz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 06:24:52 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7F43F84099;\n\tThu, 2 Apr 2026 21:24:48 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 201D784020; Thu, 2 Apr 2026 21:24:47 +0200 (CEST)", "from PA5P264CU001.outbound.protection.outlook.com\n (mail-francecentralazlp170100000.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1B9DA83D8A\n for <u-boot+nodisclaimer@lists.denx.de>;\n Thu, 2 Apr 2026 21:24:45 +0200 (CEST)", "from MR1P264CA0203.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:57::18)\n by PAZP264MB2622.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1f3::13) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.18; Thu, 2 Apr\n 2026 19:24:42 +0000", "from MR1PEPF00000D5A.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:501:57:cafe::89) by MR1P264CA0203.outlook.office365.com\n (2603:10a6:501:57::18) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.20 via Frontend Transport; Thu,\n 2 Apr 2026 19:24:42 +0000", "from proxy.softathome.com (149.6.166.170) by\n MR1PEPF00000D5A.mail.protection.outlook.com (10.167.241.7) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.17\n via Frontend Transport; Thu, 2 Apr 2026 19:24:42 +0000", "from sah1lpt719.softathome.com (unknown [192.168.72.213])\n by proxy.softathome.com (Postfix) with ESMTPSA id 1EA76201BB;\n Thu, 2 Apr 2026 21:24:42 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,\n SUSPICIOUS_RECIPS autolearn=no autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=m7/O05zYsCgOgFOF88vhnRb5dvGIGhdMWRCF/0a3Ocut8/JgSWRums5zTxL1A6DdieE/BhIylOzeczQcMXvbznYER3ySwngZAHGI6zE/UWlN1R5HqwSX95+9TFnJN3je8CsXmnNFJuo2FtsLrOwcUAxp+2j6Ur472Np7p3xrvHdFAI/vbY3u4hK48sO44IjsP6l0lTNy8ETOd5O1HHKCENRhmIO3XkwB1sJFRo84jvue7NZhb9l3GvWQK7AQJUX+ieP197KvKgIBMYmft7B2TWcvu5EPL/7blNC8V4Sl+0HNRr9gZrQu6Hb+jRiDaBKMmcfw8eq5ZMG19Z0dDDSdwQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ZYN8SUxj4goAvAF+oZmk6SVmOTyRYRIhpX+29IyP3vs=;\n b=aoY2Q+RNAfGI9CQlDZ4mf62fNbiX/Lnh2CGprRocuSBjcGEHIUTEtXpTOgautWr3XyxO/hBeUnFxZWzAr/zDmnocbok7q+LCXnqYPkyDYKPybhAKyQiCkclUyAKrSvot2vjZCfJSsJaIt89MD1hQEDUA8q6NL0WoYVPI30ndJtHuwItY8E9eoKyNTUfzdny/TFMWYhqYyZkX00Cwp4a9aqZ3Rutdv5LNW7MzU8J+BENpKizj+9Hw4X3JdJLnS/zZ+NjSGRW6VJw53zr4Ffe6G2ocgRc3yBWYK/XKKV4tqRVLWxEsjO9hbwkOgWPXkamjOyvGNKpFXTI007PsnL7HDQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=chromium.org smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZYN8SUxj4goAvAF+oZmk6SVmOTyRYRIhpX+29IyP3vs=;\n b=n4cR9iP7nKotMBw2MN8HL1Ph+J0wytHf4/8hXubZC2nExNRKP4+KlpEdIQXTiU/t5p0DjHpUfnk0o4ba4Hty4mrpSFx7M/kUjcDm2j4d0xlTaS6/JOESrWT5RPvCPXhHTeTKhjXbWgb6d8KfeZMQmU+PrpyfyOarauyGzBYCB9z+WL8uMNClZ4G4Yv5yMNB1O9QWtbtuR8kWRM0vO4hdyPLRztPmW/F65pLx5a9it6ThSo6CmZti8uevtoey9ROgNptqnLo4eHdPJeW0HlAw4UAEVAt+AV8jSwfjaT1sU2z99PLWki7xZy8AAIVn5pwQyOv35XmjUx41TceoTMdzUQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;", "Received-SPF": "Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C", "From": "yan wang <yan.wang@softathome.com>", "To": "trini+nodisclaimer@konsulko.com, sjg+nodisclaimer@chromium.org,\n alpernebiyasak+nodisclaimer@gmail.com", "Cc": "philippe.reynes+nodisclaimer@softathome.com,\n paul.henrys_ext+nodisclaimer@softathome.com,\n u-boot+nodisclaimer@lists.denx.de,\n Paul HENRYS <paul.henrys_ext@softathome.com>", "Subject": "[PATCH v2 1/3] tools: binman: Test signing an encrypted FIT with a\n preload header", "Date": "Thu, 2 Apr 2026 21:24:29 +0200", "Message-Id": "<20260402192431.2421155-1-yan.wang@softathome.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MR1PEPF00000D5A:EE_|PAZP264MB2622:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "cff2c83b-98e4-4c4a-18e3-08de90ed7dbe", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|376014|36860700016|1800799024|82310400026|18002099003|56012099003;", "X-Microsoft-Antispam-Message-Info": "\n ZyAAIW4ez5/vD+fEsAnKsibR35epmvNoyebjPzWMwGKUVUFmEP8SGLk/LRVxYy7k3Q+gMVhsfBLqj7+TyKQZyjcHw915N4WPun6xjOqe5aJvObF9YnhySQNHJQAMxQ/FQ7q1n/gveUZ8M5VpTXkRcFS2N9lyj4zHZwJJxEYDfJ3sjkVZwQoZW32D8zZ/RFZc3oxXfHtyybEDeInQs8iomwXPjNrWG+Z5XK/Df88ViiCeM1Wr1RjybuDDUfVDAOoETvR3WTXH9FtWKJcmeuouYciUX7tre5mLpWfwntNwHCN4UZnp7u6g68AsRC4ALFjWB/4JLd001+TrM+5Ra+nQLzZjfa7HjZs4ZFR5pK/S2pgd+Yhs+QFfROR7KSSbEEZHTd9zBD3OUf+Z6ICa1QDpMx7VS6sraeAmks8rlGDfOU7+6bQwfvlefvU8L+gS2xA4omfC+0qawKcgyAxgb44FcWSuANUOJ2Z9zUZFo+5vjRLeTZ+DrncjPInbJCxUKK23LCU72vx8SsacUiXo9hCzmSb4sBp8X05gEqzBgIAh6JnFZwSC24v4NZTl+hfoqX9dYTT3KTP5aBqaNYzvzfMfbO3AK4szrSvYkloDqNzTkdcoVhVAYdk770j+Y6TXOqxcWjLKEtv8kTo/W9FASJsNgzIx4WBbG1yal7gqA4sblpbKFodrjvqYSkxOINa94yUS9s4T2r49fxqSebNJ9HVxKo5S59CgitkqFHapEB081CmfJwFjrm/GvFwWWPN01h/EfBLDrqYjB/98AcLNBig46w==", "X-Forefront-Antispam-Report": "CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(376014)(36860700016)(1800799024)(82310400026)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n vW0ba8dROnsZ5gBGEc13dMFMU/zSNmiFdzbma0H5R3EnnaMUkX0JbCt9alGH3pdnK5Od+YwSEEa3nHnP1W9FvciWY4QjmokrmSyUw05Bg0GowBD41+vtUEZG1d/HJ0bxEzMZf8B8+8SyrXxvp5VjrD8vzOcK4+TWKskpB5GTFGCBXjUc72FVfXOODQX9qcx24kXeGE4l5ku1yyOEKMBDi4WeB8smGFMB4BqiUso1MzeEf3RwUVOBAmKJiuaDCYzXxSWDfj9RR69x3huRRcQI92nLNG7qRzekRk1n+DloZfM78WcyX/EpdKvCAsrGdV5NqLDrPAD0y4AEpHZVk0VVN4npxUTslF1T6IT/DdkVQ4BX4LUzhim4k78yVOMB7Dg6hEJ5L/IkC9E0iVlSJgq0L+5fanTgAbZAHttcoXQwhGbimwjtnx/1kcZe57UOQZID", "X-OriginatorOrg": "softathome.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Apr 2026 19:24:42.3794 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n cff2c83b-98e4-4c4a-18e3-08de90ed7dbe", "X-MS-Exchange-CrossTenant-Id": "aa10e044-e405-4c10-8353-36b4d0cce511", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]", "X-MS-Exchange-CrossTenant-AuthSource": "MR1PEPF00000D5A.FRAP264.PROD.OUTLOOK.COM", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PAZP264MB2622", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: Paul HENRYS <paul.henrys_ext@softathome.com>\n\nAdd a test to verify the preload header correctly signs an encrypted\nFIT. This test exercises the case where encryption uses random IVs that\nwould change between mkimage calls.\n\nSigned-off-by: Paul HENRYS <paul.henrys_ext@softathome.com>\n---\nChanges for v2:\n- Rename test file as 351_pre_load_fit_encrypted.dts\n- Update the commit message according to the remarks made\n\n tools/binman/ftest.py | 17 +++++\n .../test/351_pre_load_fit_encrypted.dts | 63 +++++++++++++++++++\n 2 files changed, 80 insertions(+)\n create mode 100644 tools/binman/test/351_pre_load_fit_encrypted.dts", "diff": "diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py\nindex a53e37f31b3..dcfe97f0444 100644\n--- a/tools/binman/ftest.py\n+++ b/tools/binman/ftest.py\n@@ -5894,6 +5894,23 @@ fdt fdtmap Extract the devicetree blob from the fdtmap\n data = self._DoReadFileDtb('236_pre_load_invalid_key.dts',\n entry_args=entry_args)\n \n+ def testPreLoadEncryptedFit(self):\n+ \"\"\"Test an encrypted FIT image with a pre-load header\"\"\"\n+ entry_args = {\n+ 'pre-load-key-path': os.path.join(self._binman_dir, 'test'),\n+ }\n+ data = self._DoReadFileDtb(\n+ '351_pre_load_fit_encrypted.dts', entry_args=entry_args,\n+ extra_indirs=[os.path.join(self._binman_dir, 'test')])[0]\n+\n+ image_fname = tools.get_output_filename('image.bin')\n+ is_signed = self._CheckPreload(image_fname, self.TestFile(\"dev.key\"))\n+\n+ self.assertEqual(PRE_LOAD_MAGIC, data[:len(PRE_LOAD_MAGIC)])\n+ self.assertEqual(PRE_LOAD_VERSION, data[4:4 + len(PRE_LOAD_VERSION)])\n+ self.assertEqual(PRE_LOAD_HDR_SIZE, data[8:8 + len(PRE_LOAD_HDR_SIZE)])\n+ self.assertEqual(is_signed, True)\n+\n def _CheckSafeUniqueNames(self, *images):\n \"\"\"Check all entries of given images for unsafe unique names\"\"\"\n for image in images:\ndiff --git a/tools/binman/test/351_pre_load_fit_encrypted.dts b/tools/binman/test/351_pre_load_fit_encrypted.dts\nnew file mode 100644\nindex 00000000000..f5e9bf9426c\n--- /dev/null\n+++ b/tools/binman/test/351_pre_load_fit_encrypted.dts\n@@ -0,0 +1,63 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+\n+/dts-v1/;\n+\n+/ {\n+\t#address-cells = <1>;\n+\t#size-cells = <1>;\n+\n+\tbinman {\n+\t\tpre-load {\n+\t\t\tcontent = <&image>;\n+\t\t\talgo-name = \"sha256,rsa2048\";\n+\t\t\tkey-name = \"dev.key\";\n+\t\t\theader-size = <4096>;\n+\t\t\tversion = <0x11223344>;\n+\t\t};\n+\n+\t\timage: fit {\n+\t\t\tfit,encrypt;\n+\t\t\tdescription = \"Test a FIT with encrypted data and signed with a preload\";\n+\t\t\t#address-cells = <1>;\n+\n+\t\t\timages {\n+\t\t\t\tu-boot {\n+\t\t\t\t\tdescription = \"U-Boot\";\n+\t\t\t\t\ttype = \"firmware\";\n+\t\t\t\t\tarch = \"arm64\";\n+\t\t\t\t\tos = \"U-Boot\";\n+\t\t\t\t\tcompression = \"none\";\n+\t\t\t\t\tload = <00000000>;\n+\t\t\t\t\tentry = <00000000>;\n+\t\t\t\t\tcipher {\n+\t\t\t\t\t\talgo = \"aes256\";\n+\t\t\t\t\t\tkey-name-hint = \"aes256\";\n+\t\t\t\t\t};\n+\t\t\t\t\tu-boot-nodtb {\n+\t\t\t\t\t};\n+\t\t\t\t};\n+\t\t\t\tfdt-1 {\n+\t\t\t\t\tdescription = \"Flattened Device Tree blob\";\n+\t\t\t\t\ttype = \"flat_dt\";\n+\t\t\t\t\tarch = \"arm64\";\n+\t\t\t\t\tcompression = \"none\";\n+\t\t\t\t\tcipher {\n+\t\t\t\t\t\talgo = \"aes256\";\n+\t\t\t\t\t\tkey-name-hint = \"aes256\";\n+\t\t\t\t\t};\n+\t\t\t\t\tu-boot-dtb {\n+\t\t\t\t\t};\n+\t\t\t\t};\n+\t\t\t};\n+\n+\t\t\tconfigurations {\n+\t\t\t\tdefault = \"conf-1\";\n+\t\t\t\tconf-1 {\n+\t\t\t\t\tdescription = \"Boot U-Boot with FDT blob\";\n+\t\t\t\t\tfirmware = \"u-boot\";\n+\t\t\t\t\tfdt = \"fdt-1\";\n+\t\t\t\t};\n+\t\t\t};\n+\t\t};\n+\t};\n+};\n", "prefixes": [ "v2", "1/3" ] }