Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219131/?format=api
{ "id": 2219131, "url": "http://patchwork.ozlabs.org/api/patches/2219131/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/patch/5b4521e3-eb6b-4fca-aab8-caeb3e24a691@gmail.com/", "project": { "id": 13, "url": "http://patchwork.ozlabs.org/api/projects/13/?format=api", "name": "Linux IDE development", "link_name": "linux-ide", "list_id": "linux-ide.vger.kernel.org", "list_email": "linux-ide@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<5b4521e3-eb6b-4fca-aab8-caeb3e24a691@gmail.com>", "list_archive_url": null, "date": "2026-04-02T13:30:48", "name": "[v2,3/5] ata: libata-transport: use static struct ata_transport_internal to simplify match functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2abeceaeecb5ce6fc7fb1d7f2416f94e287b9b06", "submitter": { "id": 65365, "url": "http://patchwork.ozlabs.org/api/people/65365/?format=api", "name": "Heiner Kallweit", "email": "hkallweit1@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ide/patch/5b4521e3-eb6b-4fca-aab8-caeb3e24a691@gmail.com/mbox/", "series": [ { "id": 498482, "url": "http://patchwork.ozlabs.org/api/series/498482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/list/?series=498482", "date": "2026-04-02T13:30:05", "name": "ata: libata-transport: series with further refactorings", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498482/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219131/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-ide+bounces-5425-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ide@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=imT2v12z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ide+bounces-5425-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"imT2v12z\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.47", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmjf43sDDz1yCs\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 00:40:12 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id ECDBA30AAD3D\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Apr 2026 13:30:56 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B22982EBB84;\n\tThu, 2 Apr 2026 13:30:53 +0000 (UTC)", "from mail-wr1-f47.google.com (mail-wr1-f47.google.com\n [209.85.221.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 25A832BF3F3\n\tfor <linux-ide@vger.kernel.org>; Thu, 2 Apr 2026 13:30:52 +0000 (UTC)", "by mail-wr1-f47.google.com with SMTP id\n ffacd0b85a97d-43b949bf4easo1407638f8f.0\n for <linux-ide@vger.kernel.org>; Thu, 02 Apr 2026 06:30:51 -0700 (PDT)", "from ?IPV6:2003:ea:8f19:9500:c168:ad27:2fdd:9334?\n (p200300ea8f199500c168ad272fdd9334.dip0.t-ipconnect.de.\n [2003:ea:8f19:9500:c168:ad27:2fdd:9334])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e2a6f5bsm7579923f8f.7.2026.04.02.06.30.49\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 02 Apr 2026 06:30:49 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775136653; cv=none;\n b=UD47zlFvNMHDNUb3GppB8nxlMTJ5mUPR0JUm9mtmsjdwLXxeIPMRoLBkoveQdFItXcDKvfu8BMRfHBOyUJ2zPYs5asS9Mtnzd/rLkyrBTV11XA32sFSjvCpENXwPB+cvkLF4EuwBEz1oGSQeANKljbZtdCUAUGvyXYJeuFTvxI0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775136653; c=relaxed/simple;\n\tbh=oeQfoSM+oSuOWrNP1refR0lQ1BTs8wy0S3lbTh5owWc=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=Lu06VHZf6iNhKb3MyBSuqDAeIAo/0CpNFdLj5qyyKM/ACIf9/SXpMh8jxT/wZbDpPEwD2nTnGl5vZ7on2daUgiwtjjJsmjq1QdzVyeQ1tYmIIszxjr37DeBJQDiBcSG5eAUhBrElqn/EKqEgXTgJcyGtQmyUJ7GD3neErZo6diI=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=imT2v12z; arc=none smtp.client-ip=209.85.221.47", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775136650; x=1775741450;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=6dTns50KEXcCjmIgDZ6H3vL8B1rqJ1369P+2wfbLKhs=;\n b=imT2v12ztnBg3eKRPjcLhRXPIfhCb+K49RekX/ydNw1n54x1fllG8p/u71/Cyj8nXq\n kJhWEZnh1hY06Y2/S1wm/sBEVpsdl1MQDrj8CxhsBTwg/wCwSXFyJvrGPI9J9wp8c9pC\n 3UvqeFIPiqJCeWwUF1DySEelAnhU9p3Rg/s96h+4phAI2NOByQVS83r0o5mQKmyihm/I\n nJqXYZtk3ecgGIY8RWEmLNUbUHq6vMoG/iCI+PoJzTrQ5f8TsUfXhehgO4MKqWmKLjY7\n EZqGjTNY8On1VYKPDp3rq/zzXKMi54WA05GqsbqWhyZFLshAa3GO6G4KuYvyq7wbcx3n\n hH6w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775136650; x=1775741450;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=6dTns50KEXcCjmIgDZ6H3vL8B1rqJ1369P+2wfbLKhs=;\n b=tFiWw+bK4wWYZf2kZs6UBpIluoH3fQEuB+h0S/nKpZpujeCoGWRucd3HKG8dduUvjP\n vxEMVyWbBSCFXTSH+cIel0KvdQaQ73JBRXJuhWtksL1ex7DmnM41m8t170M6O642OyF/\n BECk3eSCT6QdTdhWR9UsABjoV6DIlSN+yU5cKRvT6mJaI97sMYpInGIumFAwiWZgNurI\n STNSkAGiITpzow+FtBwPaSUjAzW+i0w69SbA0YKURDC4gb/kwHb0CMZ/aAgHz/3HEzoF\n 7oFNBqZZ9P14Vdk9zEWc884iFzv4PBqnuhF3xZsFQT+mEZVXNSd8uka4agQApYy8QE4c\n eyCg==", "X-Gm-Message-State": "AOJu0YwUGjROmCanFW1Arvna0ikxQO5TviGQfdnPL6OLq+7Bmb3Sge0f\n\t+utpwF/vJlziYHvpLpzt+lrJBx+x8GmnMABUGqRKzHthVzxxKTLb7t73", "X-Gm-Gg": "AeBDiesxfvSfER6ZymdMGp0gYfzMerG5Mp5u9aRrRPbIVJlNv18Z2iFJBsqIUyCjIKZ\n\t/S45Wmc2V8UEQrOaS+sOVDSb42laBAOrWLpiQcwVJMXTHVSAX7shc2oa6GJHZDR2u9grpk4Vf64\n\tbDf8uEcp9NkHbCfi49QUQ+6uO6pUZZHAqXhN4GzWF1FtrEMp29bXievtlhsDmZsYfgJwn0jsbKy\n\torVm9pb2hZjfp8QwwgC6UIA4f4En/hjIt0f5O7/pElYqvxRR6VpEv54/L8CHxmfpUdGFlmNqQ7I\n\thkrhohjJBzWxyUxkwRM2TSbn7lXXfPYOa84LVyzPytnjBzHQ5roju/iYg2QwomgC3jj1n9mlnHt\n\tAmXchMGuxFiFNPU7m0+IOwYHPmLEufnOyJ1UmfJzr5Ra83Zr4bZaMefMSaVvtz6ZWQTL1M3ZxcP\n\tKMPV2xtYQ6xr0JhhzyPRJIQRVXEZMe2ZmT6sAKYS48BkCwLgDRnItKakzA+6/95wo0kHZxQe2V2\n\tcSCADfazxRfzGp/9nCAkd4YmlYd2pbcRjNJH2dCmMPYExaECvV4mGnEv4ppx+iXnA==", "X-Received": "by 2002:a05:6000:420a:b0:43d:167a:b5a with SMTP id\n ffacd0b85a97d-43d210ca81dmr4569643f8f.0.1775136650276;\n Thu, 02 Apr 2026 06:30:50 -0700 (PDT)", "Message-ID": "<5b4521e3-eb6b-4fca-aab8-caeb3e24a691@gmail.com>", "Date": "Thu, 2 Apr 2026 15:30:48 +0200", "Precedence": "bulk", "X-Mailing-List": "linux-ide@vger.kernel.org", "List-Id": "<linux-ide.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "User-Agent": "Mozilla Thunderbird", "Subject": "[PATCH v2 3/5] ata: libata-transport: use static struct\n ata_transport_internal to simplify match functions", "From": "Heiner Kallweit <hkallweit1@gmail.com>", "To": "Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>", "Cc": "linux-ide@vger.kernel.org", "References": "<93fc6c62-ed8c-4953-ad7b-522031bb7ed9@gmail.com>", "Content-Language": "en-US", "In-Reply-To": "<93fc6c62-ed8c-4953-ad7b-522031bb7ed9@gmail.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "7bit" }, "content": "Both matching functions can make use of static struct\nata_transport_internal. This eliminates the dependency on static\nvariable ata_scsi_transport_template, and it allows to remove helper\nto_ata_internal(). Small drawback is that a forward declaration of\nboth functions is needed.\n\nReviewed-by: Damien Le Moal <dlemoal@kernel.org>\nSigned-off-by: Heiner Kallweit <hkallweit1@gmail.com>\n---\n drivers/ata/libata-transport.c | 44 ++++++++++++++++++----------------\n 1 file changed, 23 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c\nindex 9d594562c..68ae57a89 100644\n--- a/drivers/ata/libata-transport.c\n+++ b/drivers/ata/libata-transport.c\n@@ -46,7 +46,11 @@ struct ata_internal {\n \tstruct transport_container link_attr_cont;\n \tstruct transport_container dev_attr_cont;\n };\n-#define to_ata_internal(tmpl)\tcontainer_of(tmpl, struct ata_internal, t)\n+\n+static int ata_tlink_match(struct attribute_container *cont,\n+\t\t\t struct device *dev);\n+static int ata_tdev_match(struct attribute_container *cont,\n+\t\t\t struct device *dev);\n \n #define tdev_to_device(d)\t\t\t\t\t\\\n \tcontainer_of((d), struct ata_device, tdev)\n@@ -519,16 +523,6 @@ static bool ata_is_ata_dev(const struct device *dev)\n \treturn dev->release == ata_tdev_release;\n }\n \n-static int ata_tdev_match(struct attribute_container *cont,\n-\t\t\t struct device *dev)\n-{\n-\tstruct ata_internal *i = to_ata_internal(ata_scsi_transport_template);\n-\n-\tif (!ata_is_ata_dev(dev))\n-\t\treturn 0;\n-\treturn &i->dev_attr_cont.ac == cont;\n-}\n-\n /**\n * ata_tdev_free -- free an ATA transport device\n * @dev:\tstruct ata_device owning the transport device to free\n@@ -660,16 +654,6 @@ static bool ata_is_link(const struct device *dev)\n \treturn dev->release == ata_tlink_release;\n }\n \n-static int ata_tlink_match(struct attribute_container *cont,\n-\t\t\t struct device *dev)\n-{\n-\tstruct ata_internal *i = to_ata_internal(ata_scsi_transport_template);\n-\n-\tif (!ata_is_link(dev))\n-\t\treturn 0;\n-\treturn &i->link_attr_cont.ac == cont;\n-}\n-\n /**\n * ata_tlink_delete -- remove an ATA link transport device\n * @link:\tstruct ata_link owning the link transport device to remove\n@@ -762,6 +746,24 @@ static struct ata_internal ata_transport_internal = {\n \t.dev_attr_cont.ac.match\t= ata_tdev_match,\n };\n \n+static int ata_tlink_match(struct attribute_container *cont,\n+\t\t\t struct device *dev)\n+{\n+\tif (!ata_is_link(dev))\n+\t\treturn 0;\n+\n+\treturn &ata_transport_internal.link_attr_cont.ac == cont;\n+}\n+\n+static int ata_tdev_match(struct attribute_container *cont,\n+\t\t\t struct device *dev)\n+{\n+\tif (!ata_is_ata_dev(dev))\n+\t\treturn 0;\n+\n+\treturn &ata_transport_internal.dev_attr_cont.ac == cont;\n+}\n+\n /*\n * Setup / Teardown code\n */\n", "prefixes": [ "v2", "3/5" ] }