Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219128/?format=api
{ "id": 2219128, "url": "http://patchwork.ozlabs.org/api/patches/2219128/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/patch/d74731b0-525e-45c2-a166-d56c5766dc00@gmail.com/", "project": { "id": 13, "url": "http://patchwork.ozlabs.org/api/projects/13/?format=api", "name": "Linux IDE development", "link_name": "linux-ide", "list_id": "linux-ide.vger.kernel.org", "list_email": "linux-ide@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<d74731b0-525e-45c2-a166-d56c5766dc00@gmail.com>", "list_archive_url": null, "date": "2026-04-02T13:32:13", "name": "[v2,5/5] ata: libata-transport: remove static variable ata_scsi_transport_template", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5c8f6881d3ec67e4bd36fc3cae48fb421dd9ea2e", "submitter": { "id": 65365, "url": "http://patchwork.ozlabs.org/api/people/65365/?format=api", "name": "Heiner Kallweit", "email": "hkallweit1@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ide/patch/d74731b0-525e-45c2-a166-d56c5766dc00@gmail.com/mbox/", "series": [ { "id": 498482, "url": "http://patchwork.ozlabs.org/api/series/498482/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/list/?series=498482", "date": "2026-04-02T13:30:05", "name": "ata: libata-transport: series with further refactorings", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498482/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219128/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219128/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-ide+bounces-5427-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ide@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=dL4otU+B;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ide+bounces-5427-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"dL4otU+B\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.50", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmjTx2Jmfz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 03 Apr 2026 00:33:09 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 00BBC306D0F2\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Apr 2026 13:32:32 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0A6CF2ECE9B;\n\tThu, 2 Apr 2026 13:32:18 +0000 (UTC)", "from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n [209.85.128.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D1631F98B\n\tfor <linux-ide@vger.kernel.org>; Thu, 2 Apr 2026 13:32:16 +0000 (UTC)", "by mail-wm1-f50.google.com with SMTP id\n 5b1f17b1804b1-48558d6ef83so8797035e9.3\n for <linux-ide@vger.kernel.org>; Thu, 02 Apr 2026 06:32:16 -0700 (PDT)", "from ?IPV6:2003:ea:8f19:9500:c168:ad27:2fdd:9334?\n (p200300ea8f199500c168ad272fdd9334.dip0.t-ipconnect.de.\n [2003:ea:8f19:9500:c168:ad27:2fdd:9334])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e2c637asm7682833f8f.14.2026.04.02.06.32.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 02 Apr 2026 06:32:14 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775136737; cv=none;\n b=PVd2h+w6VPQt9ZTcbdVn66WLJBgOcFTY6jcnfVJIf338eaE3vCBcw65vymSRvKVlrBkT1lLZlB8KoNMW5WCGkINGTYrY8vyCWuQoTEYmbEeGaNJDT6lP2fZtDI6U26sHsJeRyDDZM1VNmh4UD3OO2yR/XsYpoN6pTagu2wnTZtE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775136737; c=relaxed/simple;\n\tbh=rD0iHIvZVh5bnT5Ghfn2LMMag9AYPFQf1yu2E6LMoD8=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=BRRWm5GXQlyUi+d/RXIw1aPJMYQNoBHwYU2cvfdMnFHIELbJvfJ6otVBP3KDfXTaJ29Tn8+ZMP+Xpep7cWdSpcYhsZDaaREts2lbQgQabjgJqHwpXiSkC6eeFyBokBD4c84PwIkJuCK+AUxy9H457S0R3js/Pqiaq0QAN5NzTHA=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=dL4otU+B; arc=none smtp.client-ip=209.85.128.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775136735; x=1775741535;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=7BnqSNQqqXt1XTO7uhbxBJAVp0tAa89VSH6tk08p79Q=;\n b=dL4otU+BxzC6RL+DBMncAYeRWWschDnDL2Yd/dVP+Li3UjIfsosNAPyIJiVdPrKlba\n WDO++38QatNpo8srCSgIehrQ6BLn5P6add6kZ9TZ4fIz85ZLjm3/qwWkd2A+eYTRWOD/\n 8AbIgzF8TwEgx0cGP/xcG8T8hh6JkaYACcvEDBKrobV5pTt9JdGn6fww2vR+bnDddOih\n FQpRfb+cIX3Uv2ZgkUvMYwfLSf1vnDsaOctIulY7Iu9XcMLlhOX3RixzRL2m87RDUFwk\n TcFL71rJkSGqFypSRJtfIZSmside0PN9lB7IIfiFP4jfxkCN4T100Zedv+1mSMfI8ryF\n qk1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775136735; x=1775741535;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=7BnqSNQqqXt1XTO7uhbxBJAVp0tAa89VSH6tk08p79Q=;\n b=gqW2uRFSp9m68pwDrhx6jECYRYDNg/EPVviePdENC8FiRdwIio2dSAQY4ZcYGbM3nX\n oG3biwW06wLVoo360MW8RTyeENZ9Mvye5sXNCxdnxJ+s2CHQXQbtaD7VzSm2hj/kJGOA\n rVm7h0dIDyCrpIa9gYDkMx53hvAdRPjwk/DistMZhL0ZrsZda6bnn0JgYbbxf5LlLR+v\n grMrxSmDeNRWeDtwhhrMxfFEEtUTyEJ57Jw2Xq0xtCjMLpmv01tHocnYGGnES0EVKY0B\n QqyHEv0H3GR1qWxi8qXQLGcGQ8VZdrrrO9v0mDzVI/DcW1n3AGLoglProqeXZeMVLTc5\n 9ltQ==", "X-Gm-Message-State": "AOJu0Yw5DyEucTi06/t3G26rUyIApVEkfMkxsbm9msiHmka9sjiypG9p\n\tx83rMNfLhtroomQy6kiP//RB7xauh+N/WI+WxIoWZPTiW3UmOQKGdKRl3rRhnQ==", "X-Gm-Gg": "ATEYQzxLS7Jz1QvqFi20VNzQoy2uPLMbJI7+wble+Rzm3+nWRdyOlDazcj0MEUBFO/X\n\t6v9BFQ2xVhU/YRkIlHMcY7Ge1UWcucZCkprBLqN/rSpttRhuTfU4u/N7PRgFNQcpknFWYMh874S\n\tC5RMR9GR7av7+0lp5VFCIxzeoxDfk3PBe7pBl8fX+FSjIDIn73tFHGs4NsXxbXgksoW1sI0KU6d\n\tp8Dif5RC+5SxwruCHoe0HLJfUxXAkF3EyN6Psq/ShBYFcpjgr/bqiMsnCTvvYLp4CZL5kpV2eNf\n\tL4Oc97R18KKq/UyoYapavi+gHqcYBhobEotIA6yZNLzoBEn8yTnUmhquqNYJE2lLn3Is1yyMwK5\n\tlqpmvxWprZIghYt95DnGeOZZODb7fBO5xPMMOjB6Xo9HlG/N0+wwFbxpxLV0F0z/MPKCri6ZhR8\n\txsiVTCUdOInZxAPZDOyTBHlgHOXpLT+ZrFAazXJDDoPItIpFBuVgNwtwOfa+D+MxttcpJp8UYXN\n\tSKlXrytMfSdSRUzud4FiWH8l/Cb1IzIvCHbdWveTZqfMuNLG2tIcqFyEhKbLUtSoA==", "X-Received": "by 2002:a05:600c:8488:b0:487:1fbf:e0a1 with SMTP id\n 5b1f17b1804b1-48883569e15mr126831235e9.4.1775136734895;\n Thu, 02 Apr 2026 06:32:14 -0700 (PDT)", "Message-ID": "<d74731b0-525e-45c2-a166-d56c5766dc00@gmail.com>", "Date": "Thu, 2 Apr 2026 15:32:13 +0200", "Precedence": "bulk", "X-Mailing-List": "linux-ide@vger.kernel.org", "List-Id": "<linux-ide.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "User-Agent": "Mozilla Thunderbird", "Subject": "[PATCH v2 5/5] ata: libata-transport: remove static variable\n ata_scsi_transport_template", "From": "Heiner Kallweit <hkallweit1@gmail.com>", "To": "Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>", "Cc": "linux-ide@vger.kernel.org", "References": "<93fc6c62-ed8c-4953-ad7b-522031bb7ed9@gmail.com>", "Content-Language": "en-US", "In-Reply-To": "<93fc6c62-ed8c-4953-ad7b-522031bb7ed9@gmail.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "7bit" }, "content": "Simplify the code by making struct ata_scsi_transportt public, instead\nof using separate variable ata_scsi_transport_template.\n\nReviewed-by: Damien Le Moal <dlemoal@kernel.org>\nSigned-off-by: Heiner Kallweit <hkallweit1@gmail.com>\n---\n drivers/ata/libata-scsi.c | 2 +-\n drivers/ata/libata-transport.c | 9 ++-------\n drivers/ata/libata-transport.h | 2 +-\n 3 files changed, 4 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\nindex 06f3a243f..b15830bed 100644\n--- a/drivers/ata/libata-scsi.c\n+++ b/drivers/ata/libata-scsi.c\n@@ -4624,7 +4624,7 @@ int ata_scsi_add_hosts(struct ata_host *host, const struct scsi_host_template *s\n \t\t*(struct ata_port **)&shost->hostdata[0] = ap;\n \t\tap->scsi_host = shost;\n \n-\t\tshost->transportt = ata_scsi_transport_template;\n+\t\tshost->transportt = &ata_scsi_transportt;\n \t\tshost->unique_id = ap->print_id;\n \t\tshost->max_id = 16;\n \t\tshost->max_lun = 1;\ndiff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c\nindex 538743e88..adf38e4bb 100644\n--- a/drivers/ata/libata-transport.c\n+++ b/drivers/ata/libata-transport.c\n@@ -37,9 +37,6 @@\n #include \"libata.h\"\n #include \"libata-transport.h\"\n \n-struct scsi_transport_template;\n-struct scsi_transport_template *ata_scsi_transport_template;\n-\n static int ata_tlink_match(struct attribute_container *cont,\n \t\t\t struct device *dev);\n static int ata_tdev_match(struct attribute_container *cont,\n@@ -224,7 +221,7 @@ static int ata_tport_match(struct attribute_container *cont,\n {\n \tif (!ata_is_port(dev))\n \t\treturn 0;\n-\treturn &ata_scsi_transport_template->host_attrs.ac == cont;\n+\treturn &ata_scsi_transportt.host_attrs.ac == cont;\n }\n \n /**\n@@ -722,7 +719,7 @@ int ata_tlink_add(struct ata_link *link)\n \treturn error;\n }\n \n-static struct scsi_transport_template ata_scsi_transportt = {\n+struct scsi_transport_template ata_scsi_transportt = {\n \t.eh_strategy_handler\t= ata_scsi_error,\n \t.user_scan\t\t= ata_scsi_user_scan,\n \n@@ -783,8 +780,6 @@ __init int libata_transport_init(void)\n \ttransport_container_register(&ata_link_attr_cont);\n \ttransport_container_register(&ata_dev_attr_cont);\n \n-\tata_scsi_transport_template = &ata_scsi_transportt;\n-\n \treturn 0;\n \n out_unregister_port:\ndiff --git a/drivers/ata/libata-transport.h b/drivers/ata/libata-transport.h\nindex fe5ca66fc..629ac843a 100644\n--- a/drivers/ata/libata-transport.h\n+++ b/drivers/ata/libata-transport.h\n@@ -3,7 +3,7 @@\n #define _LIBATA_TRANSPORT_H\n \n \n-extern struct scsi_transport_template *ata_scsi_transport_template;\n+extern struct scsi_transport_template ata_scsi_transportt;\n \n int ata_tlink_add(struct ata_link *link);\n void ata_tlink_delete(struct ata_link *link);\n", "prefixes": [ "v2", "5/5" ] }