Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2219003/?format=api
{ "id": 2219003, "url": "http://patchwork.ozlabs.org/api/patches/2219003/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402095132.29245-9-thuth@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260402095132.29245-9-thuth@redhat.com>", "list_archive_url": null, "date": "2026-04-02T09:51:30", "name": "[08/10] hw/i386/isapc: Adjust the check for valid CPUs in the isapc machine", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "be07d9a8ebe1dae3220dacbb9dcbdc4ec180859a", "submitter": { "id": 66152, "url": "http://patchwork.ozlabs.org/api/people/66152/?format=api", "name": "Thomas Huth", "email": "thuth@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402095132.29245-9-thuth@redhat.com/mbox/", "series": [ { "id": 498459, "url": "http://patchwork.ozlabs.org/api/series/498459/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498459", "date": "2026-04-02T09:51:22", "name": "Deprecate the qemu-system-i386 binary", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498459/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2219003/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2219003/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MNK30biT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmcbj2nlBz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 20:52:49 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w8Eiw-00079C-En; Thu, 02 Apr 2026 05:52:26 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1w8Eiu-00078j-6d\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 05:52:24 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <thuth@redhat.com>) id 1w8Eis-0008T0-4y\n for qemu-devel@nongnu.org; Thu, 02 Apr 2026 05:52:23 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-1vhEy7nAPBuHaAth0OIBwQ-1; Thu,\n 02 Apr 2026 05:52:12 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A4325195609E; Thu, 2 Apr 2026 09:52:11 +0000 (UTC)", "from thuth-p1g4.redhat.com (unknown [10.44.34.44])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C847819373D8; Thu, 2 Apr 2026 09:52:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775123536;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=sPFlzk9ZLlZHPOcJhaP/VkTFHtoZ9xuGlVYtWm9rC1k=;\n b=MNK30biTDm96fwJ578FEh6uuymQ3y0mKKphVd/ne+oEx/YzOR5l1W/7UkR1yc58hXB32wD\n TpzKdwJX5FLY/aJz1iqVdZJmKJlg4AJl4IpGF/H5ouhC9nYhr0JCasBWz9/5Sho1AOPgAf\n b1itlgAt1IE8Z5jtC7TO/K7H/hq1/FM=", "X-MC-Unique": "1vhEy7nAPBuHaAth0OIBwQ-1", "X-Mimecast-MFC-AGG-ID": "1vhEy7nAPBuHaAth0OIBwQ_1775123531", "From": "Thomas Huth <thuth@redhat.com>", "To": "Paolo Bonzini <pbonzini@redhat.com>,\n\tqemu-devel@nongnu.org", "Cc": "Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n \"Michael S. Tsirkin\" <mst@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= <philmd@linaro.org>, Zhao Liu <zhao1.liu@intel.com>,\n Thomas Huth <thuth@redhat.com>", "Subject": "[PATCH 08/10] hw/i386/isapc: Adjust the check for valid CPUs in the\n isapc machine", "Date": "Thu, 2 Apr 2026 11:51:30 +0200", "Message-ID": "<20260402095132.29245-9-thuth@redhat.com>", "In-Reply-To": "<20260402095132.29245-1-thuth@redhat.com>", "References": "<20260402095132.29245-1-thuth@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "27", "X-Spam_score": "2.7", "X-Spam_bar": "++", "X-Spam_report": "(2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Thomas Huth <thuth@redhat.com>\n\nNow that we can run in both, x86_64 and i386 mode with one binary,\nwe must not hard-code the suffix of the CPU names here anymore.\n\nSigned-off-by: Thomas Huth <thuth@redhat.com>\n---\n target/i386/cpu.h | 1 +\n hw/i386/isapc.c | 18 ++++++++++--------\n target/i386/cpu.c | 2 +-\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/target/i386/cpu.h b/target/i386/cpu.h\nindex 38309773ea8..78f2dadc2e3 100644\n--- a/target/i386/cpu.h\n+++ b/target/i386/cpu.h\n@@ -2722,6 +2722,7 @@ void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask,\n const char *verbose_prefix);\n void mark_forced_on_features(X86CPU *cpu, FeatureWord w, uint64_t mask,\n const char *verbose_prefix);\n+char *x86_cpu_type_name(const char *model_name);\n \n static inline bool x86_has_cpuid_0x1f(X86CPU *cpu)\n {\ndiff --git a/hw/i386/isapc.c b/hw/i386/isapc.c\nindex 1ba9ae22cc3..c772b7f533a 100644\n--- a/hw/i386/isapc.c\n+++ b/hw/i386/isapc.c\n@@ -43,13 +43,13 @@ static void pc_init_isa(MachineState *machine)\n \n bool valid_cpu_type = false;\n static const char * const valid_cpu_types[] = {\n- X86_CPU_TYPE_NAME(\"486\"),\n- X86_CPU_TYPE_NAME(\"athlon\"),\n- X86_CPU_TYPE_NAME(\"kvm32\"),\n- X86_CPU_TYPE_NAME(\"pentium\"),\n- X86_CPU_TYPE_NAME(\"pentium2\"),\n- X86_CPU_TYPE_NAME(\"pentium3\"),\n- X86_CPU_TYPE_NAME(\"qemu32\"),\n+ \"486\",\n+ \"athlon\",\n+ \"kvm32\",\n+ \"pentium\",\n+ \"pentium2\",\n+ \"pentium3\",\n+ \"qemu32\",\n };\n \n /*\n@@ -59,8 +59,10 @@ static void pc_init_isa(MachineState *machine)\n * a warning if anyone tries to use a deprecated CPU.\n */\n for (i = 0; i < ARRAY_SIZE(valid_cpu_types); i++) {\n- if (!strcmp(machine->cpu_type, valid_cpu_types[i])) {\n+ g_autofree char *valid_cpu = x86_cpu_type_name(valid_cpu_types[i]);\n+ if (!strcmp(machine->cpu_type, valid_cpu)) {\n valid_cpu_type = true;\n+ break;\n }\n }\n \ndiff --git a/target/i386/cpu.c b/target/i386/cpu.c\nindex 98e03cb9a88..a8ff1b29f33 100644\n--- a/target/i386/cpu.c\n+++ b/target/i386/cpu.c\n@@ -2274,7 +2274,7 @@ void host_cpuid(uint32_t function, uint32_t count,\n /* Return type name for a given CPU model name\n * Caller is responsible for freeing the returned string.\n */\n-static char *x86_cpu_type_name(const char *model_name)\n+char *x86_cpu_type_name(const char *model_name)\n {\n if (target_i386()) {\n return g_strdup_printf(\"%s\" I386_CPU_TYPE_SUFFIX, model_name);\n", "prefixes": [ "08/10" ] }