Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218984/?format=api
{ "id": 2218984, "url": "http://patchwork.ozlabs.org/api/patches/2218984/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260402085545.284457-1-a-garg7@ti.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260402085545.284457-1-a-garg7@ti.com>", "list_archive_url": null, "date": "2026-04-02T08:55:45", "name": "PCI: cadence: Use cdns_pcie_read_sz() for byte or word read access", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1fe0c21cabc1cc9c9f62d049821a25c57fbe1257", "submitter": { "id": 92467, "url": "http://patchwork.ozlabs.org/api/people/92467/?format=api", "name": "Aksh Garg", "email": "a-garg7@ti.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260402085545.284457-1-a-garg7@ti.com/mbox/", "series": [ { "id": 498453, "url": "http://patchwork.ozlabs.org/api/series/498453/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=498453", "date": "2026-04-02T08:55:45", "name": "PCI: cadence: Use cdns_pcie_read_sz() for byte or word read access", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498453/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218984/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-51714-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=UkPtKQjU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51714-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=\"UkPtKQjU\"", "smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.62.59", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=ti.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmbV358mMz1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 20:02:51 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5927030A8ACE\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Apr 2026 08:55:57 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B86623793CD;\n\tThu, 2 Apr 2026 08:55:56 +0000 (UTC)", "from DM5PR21CU001.outbound.protection.outlook.com\n (mail-centralusazon11011059.outbound.protection.outlook.com [52.101.62.59])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B1CA51B4F1F;\n\tThu, 2 Apr 2026 08:55:54 +0000 (UTC)", "from BY3PR05CA0006.namprd05.prod.outlook.com (2603:10b6:a03:254::11)\n by SJ0PR10MB6424.namprd10.prod.outlook.com (2603:10b6:a03:44e::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Thu, 2 Apr\n 2026 08:55:52 +0000", "from SJ5PEPF0000020A.namprd05.prod.outlook.com\n (2603:10b6:a03:254:cafe::7e) by BY3PR05CA0006.outlook.office365.com\n (2603:10b6:a03:254::11) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.16 via Frontend Transport; Thu,\n 2 Apr 2026 08:55:52 +0000", "from flwvzet201.ext.ti.com (198.47.21.195) by\n SJ5PEPF0000020A.mail.protection.outlook.com (10.167.244.43) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Thu, 2 Apr 2026 08:55:50 +0000", "from DFLE205.ent.ti.com (10.64.6.63) by flwvzet201.ext.ti.com\n (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 03:55:49 -0500", "from DFLE208.ent.ti.com (10.64.6.66) by DFLE205.ent.ti.com\n (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 03:55:49 -0500", "from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE208.ent.ti.com\n (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Thu, 2 Apr 2026 03:55:49 -0500", "from a0507033-hp.dhcp.ti.com (a0507033-hp.dhcp.ti.com\n [172.24.231.225])\n\tby lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 6328tjUs2171747;\n\tThu, 2 Apr 2026 03:55:46 -0500" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775120156; cv=fail;\n b=TvTfZejQoWrro3ZFCf1es3vPa3U2aqiB1KDiCTPSWOHyLBMrRRLe4B7G0/Phg8oLHDxh9jnKEGWmuPsh0EAkJcMfAhvwiZRl31VCRw8zVS71bYYTGjE8ET1z8BsQhBcNqDZen9BIFne4SEaGhJyNvJhnsomUSZIcR4xqQe+3Dx0=", "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=ocbdVwlUCjqcKXwhJzL2P9gpAYli2Te4kgSRqkr7jfgaWFClG1P5fqkSgfEPhw3KcalT7IPgVQdMwKnp26ekNNJPLgVOk9z0sbC/1Dls2QGvd/2voe+hKY98Kme/4jnPRcOsGmw+sUQyw241vZ3y4rPQIUQjBRmnZPVqFLX8Nc05A0xwLs/UtNGzWi9pZz9ylxLsBv7arPHZaPxJkwWIf+8gcP9f8dJSzKASjFaT64u67Bh4iR5lkmIc10EJ7OwOJSTnShcJYK4W6t6VR7WeR80C2PoRqlELXGW2O/z4uWHGnZ98rBGMZiRjhbfDNNyQjU9wxDbfUXTQcb1/t0AzYA==" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775120156; c=relaxed/simple;\n\tbh=AooOAT7AVA4fY0/XfFgOibDviIy7i3sroXvIPIO9Qvk=;\n\th=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type;\n b=hpUi246ot1kR77onCuKC1XyUl2l5PPFVHPRWUCxxBqcwfiDfFy93NogceVbF3aeqS+fVw4j4yNrbcEBQ9WaOPTE2LFRa7H7a+AO/QdJ2oi6CcQcL7MKNQXz2QzKfyQbQvqQMt9id0pWqTsCZcZ48ldBIXEm45ohMVQFLFui6Oy8=", "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=OigpvRnq8Az+RJBJRmOjabUCVoeUyUSdDJvllJ3AJns=;\n b=zVA1wvZw7PJ+CG+RtDDM5dw58g2gv9GweEeJuLeR6q1CuWpv9GUvq8+QwptJJGPD12GmT5VZRSD0IcFp3TswfDCllpT7E0Jlb5+e5pja3dnFGtRQxUdbMtxPF5Kp7BUBaVwh5KQ0fU8jsD+gNH3A15AY6uS/jDK7pJHelzbCeI0rsabYiaHyfVEHeie/UkAnCssEdRiE2shFWU4LuZtJr7Ou14vapgFEkrJwWeohw7O7tuEInsiZT2WB7m8HMdP4qirk0vE8BWsz4oSXNoCYJgC55Vn5bn0TXOOM+JrBq2CkK2hpzhq+GYhUTYnTo2Gnf3NUtXETfRhrDv9PTFecvw==" ], "ARC-Authentication-Results": [ "i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com;\n spf=pass smtp.mailfrom=ti.com;\n dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=UkPtKQjU;\n arc=fail smtp.client-ip=52.101.62.59", "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.21.195) smtp.rcpttodomain=outlook.com smtp.mailfrom=ti.com; dmarc=pass\n (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none\n (message not signed); arc=none (0)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=OigpvRnq8Az+RJBJRmOjabUCVoeUyUSdDJvllJ3AJns=;\n b=UkPtKQjULQ9NsLl/Kd56rzQinnMPsvgs0iMdpzuKbaF1J0anLt5sQnXPjmKzHv3sbzVRy52BMmsjQKG36C858FGbKBQED27Y6TbPF9yl96WqWAePbiSxVehk5aovbXzBW3xJMMFYMpExwMU44qKFfbhif9QBY0oYdTyPkl3GePo=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 198.47.21.195)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass\n action=none header.from=ti.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ti.com designates\n 198.47.21.195 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C", "From": "Aksh Garg <a-garg7@ti.com>", "To": "<linux-pci@vger.kernel.org>, <lpieralisi@kernel.org>, <mani@kernel.org>,\n\t<kwilczynski@kernel.org>, <bhelgaas@google.com>, <18255117159@163.com>", "CC": "<linux-kernel@vger.kernel.org>, <robh@kernel.org>, <mpillai@cadence.com>,\n\t<unicorn_wang@outlook.com>, <s-vadapalli@ti.com>, <danishanwar@ti.com>,\n\t<a-garg7@ti.com>", "Subject": "[PATCH] PCI: cadence: Use cdns_pcie_read_sz() for byte or word read\n access", "Date": "Thu, 2 Apr 2026 14:25:45 +0530", "Message-ID": "<20260402085545.284457-1-a-garg7@ti.com>", "X-Mailer": "git-send-email 2.34.1", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ5PEPF0000020A:EE_|SJ0PR10MB6424:EE_", "X-MS-Office365-Filtering-Correlation-Id": "4535416b-7a36-4f25-6f87-08de9095a3cf", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "\n\tBCL:0;ARA:13230040|32650700020|36860700016|376014|1800799024|7416014|82310400026|18002099003|56012099003;", "X-Microsoft-Antispam-Message-Info": "\n\txn4KuBQDpXQM6LAha8b7qk0hAkqCIExIbY1YUcVl1PJqvqHexFxPEQq838I4ai16O7Impg6EuvnQ4vdixmX016O/HL2L49+bdTlAGluFonDFQN1Jv5JI5ySCDfq4kRFE8zb1LxfWVpuLBsdbPVbzp08brl0j6NvNeCA9zDqBtF0csKzS+q6GwVz3yQ3SF6D2o7b7PbAkvaJijxZ6kUj6ewjNRqHe3ChFBdZ94TiHhQpVaD9h/kpk6OOY0LnL46Fl7YYIuyXJwmDxABAvx0A0oKyn7i1cR2miFSPXLv0OXZ1G4k2MQ4zjYf2cPpzRqI84JNN5xqsy7l82IB1mV4WI9indl513juBKFwGexYwJgMfeFGA+waIH17J0y41ZJbh1Hfwm/S3QWCX+6oRwyplGZJGlR8ue2j7q5HimVJDrjK99DRARgZNVIxAFWYXOEzad8658aek2Knwjy9EoWJFl63wOrMB7PNEl8t1VrQ7Y5SNBKaRjNI/3NCC/yykcQTkrq/QMFp/lOGcpBNeaKP+kdwBfbO0MliolkPHJ6Wr5m0bALc3KOM2xgJ3l24upiOVvh9QpESEysEz1gstcIUyKrjzHayJzoBrO0Sxp586ojcp2hukVnWW2Um21IgPHPRs5hb/AmOdhxKAd8jzSF87W5bszoWG/3DqLHr1XIv576ibGvxbsjl5rbki0aK9lFD3gvBSUN2kym8TGRE97+n+vIrhBGGlt4Z+qoGxg9hyLi/eV+KenWfW2/MUITamv0P06Q+7iPSGAAsMtdVwiM89h2A==", "X-Forefront-Antispam-Report": "\n\tCIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(32650700020)(36860700016)(376014)(1800799024)(7416014)(82310400026)(18002099003)(56012099003);DIR:OUT;SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n\tt2Gz0pNFOmgjnrGUB49U2cSWzyPoJQ0Ml/jD6zE9XVFlXXWd1jg690FBa6WDeSz1CXevOBqKHV44iXVdLWSxTXWmNV9aBWY472rG9jgDN3xgrwmvi3BRtYkzLLdkQHAsfcN/k60GH6OLmv0pkdBNXietcSf5GOCd4eoB3eRtWr2DaMNMCYpRaos5lkhl9xzCC38o63Dout6pX7BJ7Ld1UVeQ7uNRNINIVGUzkGqbnOgMfau0uwVmnVLgNijTHyO5HwED8u/sUFyDshJoJIgXP5+fnJ0DEN2YneQOuLWbyKamOTYje38LKrYrpTmDrjycFtM/xaGD2jf9ra6G+HddacRNP2HZX/N5Jpy86ekgmZZ3MPT9KC5Zx1w3LGg03mGXS06Y+WCzBH2lEmc7yBDTZSgcAGCD1+JLleGQibxjluwprv/i4a0ZE8T1CwMKFtO8", "X-OriginatorOrg": "ti.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Apr 2026 08:55:50.4737\n (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4535416b-7a36-4f25-6f87-08de9095a3cf", "X-MS-Exchange-CrossTenant-Id": "e5b49634-450b-4709-8abb-1e2b19b982b7", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n\tSJ5PEPF0000020A.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR10MB6424" }, "content": "The commit 18ac51ae9df9 (\"PCI: cadence: Implement capability search\nusing PCI core APIs\") assumes all the platforms using Cadence PCIe\ncontroller support byte and word register accesses. This is not true\nfor all platforms (e.g., TI J721E SoC, which only supports dword\nregister accesses).\n\nThis causes capability searches via cdns_pcie_find_capability() to fail\non such platforms.\n\nFix this by using cdns_pcie_read_sz() for config read functions, which\nproperly handles size-aligned accesses. Remove the now-unused byte and\nword read wrapper functions (cdns_pcie_readw and cdns_pcie_readb).\n\nFixes: 18ac51ae9df9 (\"PCI: cadence: Implement capability search using PCI core APIs\")\nSigned-off-by: Aksh Garg <a-garg7@ti.com>\nCc: stable@vger.kernel.org\n---\n drivers/pci/controller/cadence/pcie-cadence.h | 56 +++++++++----------\n 1 file changed, 25 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h\nindex 443033c607d7..277f3706a4f4 100644\n--- a/drivers/pci/controller/cadence/pcie-cadence.h\n+++ b/drivers/pci/controller/cadence/pcie-cadence.h\n@@ -249,37 +249,6 @@ static inline u32 cdns_pcie_hpa_readl(struct cdns_pcie *pcie,\n \treturn readl(pcie->reg_base + reg);\n }\n \n-static inline u16 cdns_pcie_readw(struct cdns_pcie *pcie, u32 reg)\n-{\n-\treturn readw(pcie->reg_base + reg);\n-}\n-\n-static inline u8 cdns_pcie_readb(struct cdns_pcie *pcie, u32 reg)\n-{\n-\treturn readb(pcie->reg_base + reg);\n-}\n-\n-static inline int cdns_pcie_read_cfg_byte(struct cdns_pcie *pcie, int where,\n-\t\t\t\t\t u8 *val)\n-{\n-\t*val = cdns_pcie_readb(pcie, where);\n-\treturn PCIBIOS_SUCCESSFUL;\n-}\n-\n-static inline int cdns_pcie_read_cfg_word(struct cdns_pcie *pcie, int where,\n-\t\t\t\t\t u16 *val)\n-{\n-\t*val = cdns_pcie_readw(pcie, where);\n-\treturn PCIBIOS_SUCCESSFUL;\n-}\n-\n-static inline int cdns_pcie_read_cfg_dword(struct cdns_pcie *pcie, int where,\n-\t\t\t\t\t u32 *val)\n-{\n-\t*val = cdns_pcie_readl(pcie, where);\n-\treturn PCIBIOS_SUCCESSFUL;\n-}\n-\n static inline u32 cdns_pcie_read_sz(void __iomem *addr, int size)\n {\n \tvoid __iomem *aligned_addr = PTR_ALIGN_DOWN(addr, 0x4);\n@@ -320,6 +289,31 @@ static inline void cdns_pcie_write_sz(void __iomem *addr, int size, u32 value)\n \twritel(val, aligned_addr);\n }\n \n+static inline int cdns_pcie_read_cfg_byte(struct cdns_pcie *pcie, int where,\n+\t\t\t\t\t u8 *val)\n+{\n+\tvoid __iomem *addr = pcie->reg_base + where;\n+\n+\t*val = cdns_pcie_read_sz(addr, 0x1);\n+\treturn PCIBIOS_SUCCESSFUL;\n+}\n+\n+static inline int cdns_pcie_read_cfg_word(struct cdns_pcie *pcie, int where,\n+\t\t\t\t\t u16 *val)\n+{\n+\tvoid __iomem *addr = pcie->reg_base + where;\n+\n+\t*val = cdns_pcie_read_sz(addr, 0x2);\n+\treturn PCIBIOS_SUCCESSFUL;\n+}\n+\n+static inline int cdns_pcie_read_cfg_dword(struct cdns_pcie *pcie, int where,\n+\t\t\t\t\t u32 *val)\n+{\n+\t*val = cdns_pcie_readl(pcie, where);\n+\treturn PCIBIOS_SUCCESSFUL;\n+}\n+\n /* Root Port register access */\n static inline void cdns_pcie_rp_writeb(struct cdns_pcie *pcie,\n \t\t\t\t u32 reg, u8 value)\n", "prefixes": [] }