Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218980/?format=api
{ "id": 2218980, "url": "http://patchwork.ozlabs.org/api/patches/2218980/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20260402082510.1417440-6-amusil@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260402082510.1417440-6-amusil@redhat.com>", "list_archive_url": null, "date": "2026-04-02T08:25:09", "name": "[ovs-dev,5/6] tests: Add basic test for route notifier.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "18e1e8e6e81d74f666cd68ddc3222bbb67821cdc", "submitter": { "id": 83634, "url": "http://patchwork.ozlabs.org/api/people/83634/?format=api", "name": "Ales Musil", "email": "amusil@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20260402082510.1417440-6-amusil@redhat.com/mbox/", "series": [ { "id": 498451, "url": "http://patchwork.ozlabs.org/api/series/498451/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=498451", "date": "2026-04-02T08:25:04", "name": "Netlink notifier consolidation and nexthop table support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498451/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218980/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2218980/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=g+GeZ8zn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp3.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=g+GeZ8zn", "smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp4.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=g+GeZ8zn" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmZgC2mYQz1yCs\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 19:25:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id EC32B60F9C;\n\tThu, 2 Apr 2026 08:25:41 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id e176SyjcXABf; Thu, 2 Apr 2026 08:25:41 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 0AC8E60F0C;\n\tThu, 2 Apr 2026 08:25:41 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id F2DD3C0070;\n\tThu, 2 Apr 2026 08:25:40 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 177E0C0070\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 129EC40E15\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:29 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id X-dL1C_U4Jm6 for <dev@openvswitch.org>;\n Thu, 2 Apr 2026 08:25:27 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 2397F40DAE\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:25 +0000 (UTC)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-ETTd1eJbPU6ohCMTccn9wg-1; Thu,\n 02 Apr 2026 04:25:23 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E33C91956072\n for <dev@openvswitch.org>; Thu, 2 Apr 2026 08:25:21 +0000 (UTC)", "from amusil.brq.redhat.com (unknown [10.43.17.233])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id DE1F130030D6; Thu, 2 Apr 2026 08:25:20 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0AC8E60F0C", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2397F40DAE" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=amusil@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2397F40DAE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775118325;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=TRWQUUVt6ylk4IdnaACqOIYwyLV5i6dwCq+jZgGAhbM=;\n b=g+GeZ8znk+a4tBTEPZaXky2XHjAPkBvHM70J7Qi0my53NdQRvhSD93ylg+9YOWiXxCpuZj\n weLgGxF/R9w7uKT2GcJ5rsZzc4G6CqFNpHpqLKCtdVEyiuJ/VO/90kGbHChVqpTypmZL4A\n O7i/2CEKlq4yGzfMO2bde3YHoRNPOfs=", "X-MC-Unique": "ETTd1eJbPU6ohCMTccn9wg-1", "X-Mimecast-MFC-AGG-ID": "ETTd1eJbPU6ohCMTccn9wg_1775118322", "To": "dev@openvswitch.org", "Date": "Thu, 2 Apr 2026 10:25:09 +0200", "Message-ID": "<20260402082510.1417440-6-amusil@redhat.com>", "In-Reply-To": "<20260402082510.1417440-1-amusil@redhat.com>", "References": "<20260402082510.1417440-1-amusil@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "CEtzOs_GjXYzstO-K2HQnaGwZ5ooNBFeUCR4zbrY05Q_1775118322", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH ovn 5/6] tests: Add basic test for route notifier.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "From": "Ales Musil via dev <ovs-dev@openvswitch.org>", "Reply-To": "Ales Musil <amusil@redhat.com>", "Cc": "dceara@redhat.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Add basic test for route notifier in very similar fashion to what\nwe already have for neighbor notifications.\n\nAssisted-by: Claude, with model: claude-opus-4-6\nSigned-off-by: Ales Musil <amusil@redhat.com>\n---\n tests/system-common-macros.at | 3 +++\n tests/system-ovn-netlink.at | 42 +++++++++++++++++++++++++++++++++++\n tests/test-ovn-netlink.c | 31 ++++++++++++++++++++++++++\n 3 files changed, 76 insertions(+)", "diff": "diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at\nindex 5062f02b0..5243b3f1b 100644\n--- a/tests/system-common-macros.at\n+++ b/tests/system-common-macros.at\n@@ -400,6 +400,9 @@ m4_define([VRF_RESERVE],\n ]\n )\n \n+# RTPROT_OVN - the routing protocol number used by OVN.\n+m4_define([RTPROT_OVN], [84])\n+\n # OVN_ROUTE_EQUAL([vrf], [string to compare])\n #\n # Will dump all v4 routes in the mentioned vrf. Trailing spaces will be removed\ndiff --git a/tests/system-ovn-netlink.at b/tests/system-ovn-netlink.at\nindex 8bf1055d1..26382f087 100644\n--- a/tests/system-ovn-netlink.at\n+++ b/tests/system-ovn-netlink.at\n@@ -495,3 +495,45 @@ blackhole fd20:100::/64 dev lo proto ovn metric 1024 pref medium\n fe80::/64 dev lo-test proto kernel metric 256 pref medium])\n \n AT_CLEANUP\n+\n+AT_SETUP([sync netlink routes - table notify])\n+AT_KEYWORDS([netlink-routes])\n+CHECK_VRF()\n+\n+table_id=100\n+\n+check ip link add vrf-$table_id type vrf table $table_id\n+on_exit 'ip link del vrf-$table_id'\n+check ip link set dev vrf-$table_id up\n+\n+check ip link add lo-test type dummy\n+on_exit 'ip link del lo-test'\n+check ip link set lo-test master vrf-$table_id\n+check ip link set lo-test address 00:00:00:00:00:10\n+check ip addr add 20.0.0.10/24 dev lo-test\n+check ip addr add fd20::10/64 dev lo-test\n+check ip link set up lo-test\n+\n+dnl Should notify if an IPv4 route is added to a table monitored by OVN.\n+AT_CHECK_UNQUOTED([ovstest test-ovn-netlink route-table-notify \\\n+ \"ip route add 10.10.10.0/24 via 20.0.0.1 vrf vrf-$table_id\"], [0], [dnl\n+Notification v4 table_id=$table_id\n+])\n+\n+dnl Should notify if an IPv6 route is added to a table monitored by OVN.\n+AT_CHECK_UNQUOTED([ovstest test-ovn-netlink route-table-notify \\\n+ \"ip -6 route add fd10::/64 via fd20::1 vrf vrf-$table_id\"], [0], [dnl\n+Notification v6 table_id=$table_id\n+])\n+\n+dnl Should NOT notify if a route with proto ovn is added.\n+AT_CHECK_UNQUOTED([ovstest test-ovn-netlink route-table-notify \\\n+ \"ip route add 10.10.20.0/24 via 20.0.0.1 vrf vrf-$table_id proto RTPROT_OVN\"], [0], [dnl\n+])\n+\n+dnl Should NOT notify if an IPv6 route with proto ovn is added.\n+AT_CHECK_UNQUOTED([ovstest test-ovn-netlink route-table-notify \\\n+ \"ip -6 route add fd20:200::/64 via fd20::1 vrf vrf-$table_id proto RTPROT_OVN\"], [0], [dnl\n+])\n+\n+AT_CLEANUP\ndiff --git a/tests/test-ovn-netlink.c b/tests/test-ovn-netlink.c\nindex efc3c9e5e..555b2df99 100644\n--- a/tests/test-ovn-netlink.c\n+++ b/tests/test-ovn-netlink.c\n@@ -250,6 +250,35 @@ done:\n ds_destroy(&msg);\n }\n \n+static void\n+test_route_table_notify(struct ovs_cmdl_context *ctx)\n+{\n+ unsigned int shift = 1;\n+\n+ const char *cmd = test_read_value(ctx, shift++, \"shell_command\");\n+ if (!cmd) {\n+ return;\n+ }\n+\n+ ovn_netlink_update_notifier(OVN_NL_NOTIFIER_ROUTE_V4, true);\n+ ovn_netlink_update_notifier(OVN_NL_NOTIFIER_ROUTE_V6, true);\n+ run_command_under_notifier(cmd);\n+\n+ uint32_t table_id;\n+\n+ struct vector *msgs = ovn_netlink_get_msgs(OVN_NL_NOTIFIER_ROUTE_V4);\n+ VECTOR_FOR_EACH (msgs, table_id) {\n+ printf(\"Notification v4 table_id=%\"PRIu32\"\\n\", table_id);\n+ }\n+\n+ msgs = ovn_netlink_get_msgs(OVN_NL_NOTIFIER_ROUTE_V6);\n+ VECTOR_FOR_EACH (msgs, table_id) {\n+ printf(\"Notification v6 table_id=%\"PRIu32\"\\n\", table_id);\n+ }\n+\n+ ovn_netlink_notifiers_destroy();\n+}\n+\n static void\n test_ovn_netlink(int argc, char *argv[])\n {\n@@ -260,6 +289,8 @@ test_ovn_netlink(int argc, char *argv[])\n test_neighbor_table_notify, OVS_RO},\n {\"host-if-monitor\", NULL, 2, 3, test_host_if_monitor, OVS_RO},\n {\"route-sync\", NULL, 1, INT_MAX, test_route_sync, OVS_RO},\n+ {\"route-table-notify\", NULL, 1, 1,\n+ test_route_table_notify, OVS_RO},\n {NULL, NULL, 0, 0, NULL, OVS_RO},\n };\n struct ovs_cmdl_context ctx;\n", "prefixes": [ "ovs-dev", "5/6" ] }