Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218909/?format=api
{ "id": 2218909, "url": "http://patchwork.ozlabs.org/api/patches/2218909/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402022921.298818-8-kshk@linux.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260402022921.298818-8-kshk@linux.ibm.com>", "list_archive_url": null, "date": "2026-04-02T02:29:13", "name": "[07/15] s390x/pci: Move/rename enabled from S390PCIIOMMU to S390PCIBusDevice", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a24b96a6f44c4b99184fada66d389c15a7bdb236", "submitter": { "id": 90249, "url": "http://patchwork.ozlabs.org/api/people/90249/?format=api", "name": "Konstantin Shkolnyy", "email": "kshk@linux.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260402022921.298818-8-kshk@linux.ibm.com/mbox/", "series": [ { "id": 498419, "url": "http://patchwork.ozlabs.org/api/series/498419/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=498419", "date": "2026-04-02T02:29:08", "name": "s390x/pci: Implement migration for emulated devices", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498419/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218909/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=hln5y3Zl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmQqh5c7lz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 13:32:32 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w87pW-0004ln-LC; Wed, 01 Apr 2026 22:30:46 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kshk@linux.ibm.com>)\n id 1w87oq-0004De-W5; Wed, 01 Apr 2026 22:30:05 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kshk@linux.ibm.com>)\n id 1w87oo-0001lR-S2; Wed, 01 Apr 2026 22:30:04 -0400", "from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 631LKewY330917; Thu, 2 Apr 2026 02:29:59 GMT", "from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d64dgtajs-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:58 +0000 (GMT)", "from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 631Mjbab021665;\n Thu, 2 Apr 2026 02:29:58 GMT", "from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72])\n by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6sasrgdq-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 02:29:57 +0000", "from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 6322TubQ17367740\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 02:29:56 GMT", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 46040580F4;\n Thu, 2 Apr 2026 02:29:56 +0000 (GMT)", "from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id B13EA580F6;\n Thu, 2 Apr 2026 02:29:55 +0000 (GMT)", "from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.247.119])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 02:29:55 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=G+mRZ7G+wFrg4KfVX\n 4SGQUu69NmYqkiVfXmLRl4uDEw=; b=hln5y3Zl0U1LuLxc7TueZcAYUWNIMG8xk\n wHAZS28vY83e3sKpkgYUx9l0QEkkFKsxUB0Xrr93GWKoFSuyPvVOtJGPdASQ+xGo\n JyQRaCbHmWmZnrcVOlhRZNIJ58FlYpzGwnyQGNc/2785G7x4XQ63yyfhWWnLz8Zo\n m9l3aDkOGtlvct1KC7BfC7yZSJzEcVcHDdLmuZEbkXUQT82+OnXSic5J4fDkUJ7T\n Elxnw4/hbUNIwcWSaTi+xxf82SF49XWvuV7gpb22c0uFHZtZArB+1LECS1f9ENXB\n y0XSYSiI0OMcqICJQ092PrVZNjOgRe576JZ54HQWb4FXJjpC+PRxw==", "From": "Konstantin Shkolnyy <kshk@linux.ibm.com>", "To": "mjrosato@linux.ibm.com", "Cc": "alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy <kshk@linux.ibm.com>", "Subject": "[PATCH 07/15] s390x/pci: Move/rename enabled from S390PCIIOMMU to\n S390PCIBusDevice", "Date": "Wed, 1 Apr 2026 21:29:13 -0500", "Message-Id": "<20260402022921.298818-8-kshk@linux.ibm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260402022921.298818-1-kshk@linux.ibm.com>", "References": "<20260402022921.298818-1-kshk@linux.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDAyMDAxOSBTYWx0ZWRfX+09NyZINEwI4\n yR4GPXmMfLfp3QHnltrFvIe2/uzz30Vzh/Ic+vx20KIBjidnCkPvngoQZMqn/Jipe61Fe4zVtJA\n kY3tWoVOy7rl8DNy1wEwZ1PjKS3mVRYqDDcv+2TL7AKo8MW1QrldN3j2J1JrcR769IcENSPODQ9\n mopubQ8j36d90ZK/09HsM4RkAOAC/Hy4QUSGNkCWCNTOmVGuxiX/Z4GJPdno/VdnyB5/DI0dpKG\n H2ZhYDZprFUeC/MHNrk8w89BRQTZ4FdkjecFRA4VXxmPrLacll/wENDv3DT5mlpRqRZNIXU9tRg\n YyF2NAPRokhZE0LXyw3y8TSPoXFotsEMP+PLkULCAXnUb4yfNuPpFtgioFa9arH7oAxX+d94JSJ\n OAJk0vUUHgo75dVl5XdNYxL7XcaEaELckXsAW7Q1daqUWqcm6unmCvxVO2v2Bt6oX7f/IeMe7In\n 7u5cSHk3sIeYWTMa1UA==", "X-Authority-Analysis": "v=2.4 cv=QKZlhwLL c=1 sm=1 tr=0 ts=69cdd4a6 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=i0DCopz73FH-yKe2uwYA:9", "X-Proofpoint-GUID": "--D4BzZmrQcKj0KxfOxBmoVFJ_h7ofUl", "X-Proofpoint-ORIG-GUID": "--D4BzZmrQcKj0KxfOxBmoVFJ_h7ofUl", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-01_05,2026-04-01_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1015\n spamscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020019", "Received-SPF": "pass client-ip=148.163.158.5; envelope-from=kshk@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com", "X-Spam_score_int": "-6", "X-Spam_score": "-0.7", "X-Spam_bar": "/", "X-Spam_report": "(-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "This field is only used when S390PCIBusDevice exists, so it can be moved\nthere to simplify S390PCIIOMMU which purpose is just to store the \"root\"\nAddressSpace.\n\nThis also allows to save/restore this field during migration.\n\nSigned-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>\n---\n hw/s390x/s390-pci-bus.c | 14 +++++++-------\n hw/s390x/s390-pci-inst.c | 8 ++++----\n include/hw/s390x/s390-pci-bus.h | 2 +-\n 3 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex 83e9ca99f3..27ba3c801c 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -205,7 +205,7 @@ void s390_pci_sclp_deconfigure(SCCB *sccb)\n } else if (pbdev->summary_ind) {\n pci_dereg_irqs(pbdev);\n }\n- if (pbdev->iommu->enabled) {\n+ if (pbdev->iommu_enabled) {\n pci_dereg_ioat(pbdev);\n }\n pbdev->state = ZPCI_FS_STANDBY;\n@@ -554,7 +554,7 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,\n switch (pbdev->state) {\n case ZPCI_FS_ENABLED:\n case ZPCI_FS_BLOCKED:\n- if (!iommu->enabled) {\n+ if (!pbdev->iommu_enabled) {\n return ret;\n }\n break;\n@@ -771,7 +771,7 @@ void s390_pci_iommu_enable(S390PCIBusDevice *pbdev)\n memory_region_init_iommu(&pbdev->iommu_mr, sizeof(pbdev->iommu_mr),\n TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),\n name, iommu->pal + 1);\n- iommu->enabled = true;\n+ pbdev->iommu_enabled = true;\n memory_region_add_subregion(&iommu->mr, 0, MEMORY_REGION(&pbdev->iommu_mr));\n g_free(name);\n }\n@@ -794,7 +794,7 @@ void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev)\n memory_region_init_alias(pbdev->dm_mr, OBJECT(&iommu->mr), name,\n get_system_memory(), 0,\n s390_get_memory_limit(s390ms));\n- iommu->enabled = true;\n+ pbdev->iommu_enabled = true;\n memory_region_add_subregion(&iommu->mr, pbdev->zpci_fn.sdma,\n pbdev->dm_mr);\n }\n@@ -802,7 +802,7 @@ void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev)\n void s390_pci_iommu_disable(S390PCIBusDevice *pbdev)\n {\n S390PCIIOMMU *iommu = pbdev->iommu;\n- iommu->enabled = false;\n+ pbdev->iommu_enabled = false;\n g_hash_table_remove_all(pbdev->iotlb);\n if (pbdev->dm_mr) {\n memory_region_del_subregion(&iommu->mr, pbdev->dm_mr);\n@@ -1411,7 +1411,7 @@ static void s390_pcihost_reset(DeviceState *dev)\n } else if (pbdev->summary_ind) {\n pci_dereg_irqs(pbdev);\n }\n- if (pbdev->iommu->enabled) {\n+ if (pbdev->iommu_enabled) {\n pci_dereg_ioat(pbdev);\n }\n pbdev->state = ZPCI_FS_STANDBY;\n@@ -1552,7 +1552,7 @@ static void s390_pci_device_reset(DeviceState *dev)\n } else if (pbdev->summary_ind) {\n pci_dereg_irqs(pbdev);\n }\n- if (pbdev->iommu->enabled) {\n+ if (pbdev->iommu_enabled) {\n pci_dereg_ioat(pbdev);\n }\n \ndiff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex 8349b44dd4..4458eae681 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -1251,7 +1251,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,\n if (dmaas != 0) {\n cc = ZPCI_PCI_LS_ERR;\n s390_set_status_code(env, r1, ZPCI_MOD_ST_DMAAS_INVAL);\n- } else if (pbdev->iommu->enabled) {\n+ } else if (pbdev->iommu_enabled) {\n cc = ZPCI_PCI_LS_ERR;\n s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);\n } else if (reg_ioat(env, pbdev, fib, ra)) {\n@@ -1263,7 +1263,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,\n if (dmaas != 0) {\n cc = ZPCI_PCI_LS_ERR;\n s390_set_status_code(env, r1, ZPCI_MOD_ST_DMAAS_INVAL);\n- } else if (!pbdev->iommu->enabled) {\n+ } else if (!pbdev->iommu_enabled) {\n cc = ZPCI_PCI_LS_ERR;\n s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);\n } else {\n@@ -1274,7 +1274,7 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,\n if (dmaas != 0) {\n cc = ZPCI_PCI_LS_ERR;\n s390_set_status_code(env, r1, ZPCI_MOD_ST_DMAAS_INVAL);\n- } else if (!pbdev->iommu->enabled) {\n+ } else if (!pbdev->iommu_enabled) {\n cc = ZPCI_PCI_LS_ERR;\n s390_set_status_code(env, r1, ZPCI_MOD_ST_SEQUENCE);\n } else {\n@@ -1404,7 +1404,7 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,\n /* fallthrough */\n case ZPCI_FS_ENABLED:\n fib.fc |= 0x80;\n- if (pbdev->iommu->enabled) {\n+ if (pbdev->iommu_enabled) {\n fib.fc |= 0x10;\n }\n if (!(fh & FH_MASK_ENABLE)) {\ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex fcaaf19512..24f6e60786 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -275,7 +275,6 @@ struct S390PCIIOMMU {\n Object parent_obj;\n AddressSpace as;\n MemoryRegion mr;\n- bool enabled;\n uint64_t g_iota;\n uint64_t pba;\n uint64_t pal;\n@@ -350,6 +349,7 @@ struct S390PCIBusDevice {\n S390MsixInfo msix;\n AdapterRoutes routes;\n S390PCIIOMMU *iommu;\n+ bool iommu_enabled;\n IOMMUMemoryRegion iommu_mr;\n MemoryRegion *dm_mr;\n GHashTable *iotlb;\n", "prefixes": [ "07/15" ] }