Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2218763/?format=api
{ "id": 2218763, "url": "http://patchwork.ozlabs.org/api/patches/2218763/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260401212057.773357-1-xmei5@asu.edu/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260401212057.773357-1-xmei5@asu.edu>", "list_archive_url": null, "date": "2026-04-01T21:20:57", "name": "[net,v2] netfilter: nfnetlink_log: initialize nfgenmsg in NLMSG_DONE terminator", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "08738672a02fac60adfa9ae86689d8472df0fb57", "submitter": { "id": 93033, "url": "http://patchwork.ozlabs.org/api/people/93033/?format=api", "name": "Xiang Mei", "email": "xmei5@asu.edu" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260401212057.773357-1-xmei5@asu.edu/mbox/", "series": [ { "id": 498394, "url": "http://patchwork.ozlabs.org/api/series/498394/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=498394", "date": "2026-04-01T21:20:57", "name": "[net,v2] netfilter: nfnetlink_log: initialize nfgenmsg in NLMSG_DONE terminator", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/498394/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2218763/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2218763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <netfilter-devel+bounces-11579-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=asu.edu header.i=@asu.edu header.a=rsa-sha256\n header.s=google header.b=Mg6TteOv;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11579-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu\n header.b=\"Mg6TteOv\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.176", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=asu.edu", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=asu.edu" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmHxj2tTFz1yFv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 08:22:17 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id CB65330378E8\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 1 Apr 2026 21:21:23 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8E6673803F2;\n\tWed, 1 Apr 2026 21:21:19 +0000 (UTC)", "from mail-dy1-f176.google.com (mail-dy1-f176.google.com\n [74.125.82.176])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 06F002C08D0\n\tfor <netfilter-devel@vger.kernel.org>; Wed, 1 Apr 2026 21:21:17 +0000 (UTC)", "by mail-dy1-f176.google.com with SMTP id\n 5a478bee46e88-2c1632faeb9so493924eec.0\n for <netfilter-devel@vger.kernel.org>;\n Wed, 01 Apr 2026 14:21:17 -0700 (PDT)", "from p1.scai.dhcp.asu.edu (209-147-138-15.nat.asu.edu.\n [209.147.138.15])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ca7c7f268esm690144eec.20.2026.04.01.14.21.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 01 Apr 2026 14:21:16 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775078479; cv=none;\n b=uQQfr9FbcxAw7eoRaNiXNFFQYvemYerjoAyP8LgW3CGLHwcwRS467KcFxnqMS9heN2+NbGPaFqH4qYBMpKFFj+efZzJXm3aixzgRlULhY8RjobtakUMzXGO0wmnKxsTw+3nbfL5M3PNUqPc0xNzyURego7SkHNeL3xX4g1qw8qg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775078479; c=relaxed/simple;\n\tbh=ceiUWFuE6/YmjPbAR+dTCdL3AyF7U/F+ps+er5MNyl8=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=IprWVw7hHLuOVvXOzKy3R10F1YvZgPJrccIiD7repqU03pb+qZvkS0guGwKtShY7x5qLlTCA5P1GCK4g/SXrJiAeQYSdJAwffVs6y3YzqcaiyuGjJ2O05d3H/n0MSHMaapb1VSLYlfTkowhNgdP4qX32yKVf9AfJ4U50lbrutWc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=asu.edu;\n spf=pass smtp.mailfrom=asu.edu;\n dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu\n header.b=Mg6TteOv; arc=none smtp.client-ip=74.125.82.176", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=asu.edu; s=google; t=1775078477; x=1775683277; darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Mj7P4G0mBP6nG/9FnTYA1QuSPTWr/jns+CKVmZY9R/U=;\n b=Mg6TteOvkj/yTagOYA70ENvVsvilvyE7knDqiG1cIrghyWKkqo5OlZiQdyuWHYAMMr\n un+Hob1rh4BU7UikzHeZJLLOlvvi08Djf2GXm2RfWPTm1Gz+3242ylGJGaqKxfKAqSma\n 4gxSL4oDipPv/X1guF/LTqdzjrwN9FUCrMhMhDErXjcTQqGXxfQ1lIj6NHfpfXIN2ivc\n QLMqvK6zdQn6s7sjw46wEfPP4CTVHDSDNxUPonEF/doMlCJJZMkqvRJdy28W0gfjPEp0\n PGMTwyNAvBaWY2W+2uRXu17t5e7KXcjWPn7zJmMAnnJ02Xe8eNgLBH7pstHX4OChcM86\n A1sQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775078477; x=1775683277;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Mj7P4G0mBP6nG/9FnTYA1QuSPTWr/jns+CKVmZY9R/U=;\n b=sTpuv3tbQTivOu9vUw5sZFUVZUVAbMxKlNInuCCOfIbX///qv4Wtj9yIt8AgBRycvJ\n YdFggPcmsP7nbTZBYp0059l4IpsxMW3xygnBpKaROLB69yATIv6Go68y8iZEvamtgpNt\n z6nKRVuA9GEfTmnhuX0Rww8gk7xOQGntFG0/iEAYeMSoTrr2m6nhqbQhTEbUbs/C2Rw1\n ginNGiEXcAv0dmv+0vsXHtTvC37q1XhEBd34nwGbixjp7/w6+SJPZv78mqpsPew5MStT\n 3+xF3saDJHTN89jJThloZH/LbZJHDcVxWpqPZbkrvMWXDxj2MwkS2epF+qhEkj6TXzAR\n Fqvw==", "X-Gm-Message-State": "AOJu0YzkOcnH9u8Ki+/75iGjnLb5C0b5koM2Vdcn0nuFKk8fTu/7679z\n\tz0S/qV6qLTf9dzU7h5xJVWP9o43uLJDO3eLvq5VtiaWSzVN62LRiKldej5H25vQirfpyrnfa11L\n\tJzNo6nrEf", "X-Gm-Gg": "ATEYQzwEt1J8Ma/YSC9sRh0mqVSBxZA1GprESCW5eX1t0rhA7d30wtgMo2kfrLQ23A6\n\tIld0vkLQ9dm+5aaWiqNrYmClWp+uh722p5OHEmPBS8W04LGMVbK7scjan12DCO6IFP9zPC4Tnvn\n\tWSKs48ljk2ec9CsLfP7N27aINKXae/2sRxI+CY754/z9iamDNiWHurW4UhnJfzFXN+iV4mxBGx7\n\tEm3KIHMhAOq+MBtNni3LQJE77r44C7pHd57b2RqqGETv3+ldTu2N1LluaOSVE03ahJCRuZJA7Em\n\tUJTUQgGSbb3e4vGj2+D7oIIf2KHXMdkw34gGBSCggUIzPwoyY5OSD1BL/970UpDf1afACszfjaT\n\tOTKnteFTEAD9JBiNWN1wnhDIccvYCqIMqiiHtk9FtTMiBzswq9LyBdWX75J8u94vyoDp4ttirji\n\tF+b+LIePCYchKIlUEB7+h6bpMy/607dWAa5C4x+ocmdyzzsnnEqrupOg==", "X-Received": "by 2002:a05:7301:4188:b0:2c5:347:e642 with SMTP id\n 5a478bee46e88-2c932eae777mr3121226eec.33.1775078476962;\n Wed, 01 Apr 2026 14:21:16 -0700 (PDT)", "From": "Xiang Mei <xmei5@asu.edu>", "To": "netfilter-devel@vger.kernel.org", "Cc": "pablo@netfilter.org,\n\tfw@strlen.de,\n\tphil@nwl.cc,\n\tdavem@davemloft.net,\n\teric@inl.fr,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tbestswngs@gmail.com,\n\tXiang Mei <xmei5@asu.edu>", "Subject": "[PATCH net v2] netfilter: nfnetlink_log: initialize nfgenmsg in\n NLMSG_DONE terminator", "Date": "Wed, 1 Apr 2026 14:20:57 -0700", "Message-ID": "<20260401212057.773357-1-xmei5@asu.edu>", "X-Mailer": "git-send-email 2.43.0", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "When batching multiple NFLOG messages (inst->qlen > 1), __nfulnl_send()\nappends an NLMSG_DONE terminator with sizeof(struct nfgenmsg) payload via\nnlmsg_put(), but never initializes the nfgenmsg bytes. The nlmsg_put()\nhelper only zeroes alignment padding after the payload, not the payload\nitself, so four bytes of stale kernel heap data are leaked to userspace\nin the NLMSG_DONE message body.\n\nUse nfnl_msg_put() to build the NLMSG_DONE terminator, which initializes\nthe nfgenmsg payload via nfnl_fill_hdr(), consistent with how\n__build_packet_message() already constructs NFULNL_MSG_PACKET headers.\n\nFixes: 29c5d4afba51 (\"[NETFILTER]: nfnetlink_log: fix sending of multipart messages\")\nReported-by: Weiming Shi <bestswngs@gmail.com>\nSigned-off-by: Xiang Mei <xmei5@asu.edu>\n---\nv2: use nfnl_msg_put to init\n\n net/netfilter/nfnetlink_log.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c\nindex fcbe54940b2e..66ff23c444a6 100644\n--- a/net/netfilter/nfnetlink_log.c\n+++ b/net/netfilter/nfnetlink_log.c\n@@ -361,10 +361,10 @@ static void\n __nfulnl_send(struct nfulnl_instance *inst)\n {\n \tif (inst->qlen > 1) {\n-\t\tstruct nlmsghdr *nlh = nlmsg_put(inst->skb, 0, 0,\n-\t\t\t\t\t\t NLMSG_DONE,\n-\t\t\t\t\t\t sizeof(struct nfgenmsg),\n-\t\t\t\t\t\t 0);\n+\t\tstruct nlmsghdr *nlh = nfnl_msg_put(inst->skb, 0, 0,\n+\t\t\t\t\t\t NLMSG_DONE, 0,\n+\t\t\t\t\t\t AF_UNSPEC, NFNETLINK_V0,\n+\t\t\t\t\t\t htons(inst->group_num));\n \t\tif (WARN_ONCE(!nlh, \"bad nlskb size: %u, tailroom %d\\n\",\n \t\t\t inst->skb->len, skb_tailroom(inst->skb))) {\n \t\t\tkfree_skb(inst->skb);\n", "prefixes": [ "net", "v2" ] }